Message-ID: <c19d2596-c525-1405-fe14-73bed9af6bde@enterprisedb.com>
Date: Mon, 20 Dec 2021 21:57:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: BUG #17339: Assert failed on attempt to detach a sequence
 concurrently
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com,
 pgsql-bugs@lists.postgresql.org
References: <17339-a9e09aaf38a3457a@postgresql.org>
 <YcB5K6/Mrh9X82lG@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <YcB5K6/Mrh9X82lG@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/c19d2596-c525-1405-fe14-73bed9af6bde%40enterprisedb.com>
Precedence: bulk


On 20.12.21 13:38, Michael Paquier wrote:
> On Sun, Dec 19, 2021 at 06:00:02AM +0000, PG Bug reporting form wrote:
>> CREATE SEQUENCE seq;
>> CREATE TABLE range_parted(a int) PARTITION BY RANGE(a);
>> ALTER TABLE range_parted DETACH PARTITION seq CONCURRENTLY;
> 
> The same error happens additionally for views or materialized views.
> Looking at the code, I think that we should just apply
> ATSimplePermissions() on (ATT_TABLE | ATT_FOREIGN_TABLE) when
> executing the detach command to check for the supported relkinds.
> That would make the logic consistent with the attach code path that
> does the same check on the partition attached, while generating an
> error message already generic enough for this purpose.
> 
> Attached is a patch, with some regression tests.

Is it possible for child tables in partitioned tables to have different 
ownerships?  Then this change would introduce a new failure mode.