MIME-Version: 1.0
Date: Sat, 17 Sep 2022 15:12:03 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: pgsql-bugs@lists.postgresql.org
Subject: Bug in pg_upgrade live check right after starting the old server on
 Windows
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <c578ccfcf0691d87cae3aef86ec81e2b@postgrespro.ru>
Organization: Postgres Professional
Content-Type: multipart/mixed;
 boundary="=_8b7c542a272b20896d6257d1a065e528"
Archived-At: 
 <https://www.postgresql.org/message-id/c578ccfcf0691d87cae3aef86ec81e2b%40postgrespro.ru>
Precedence: bulk

--=_8b7c542a272b20896d6257d1a065e528
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Hello!

I got a problem on a Windows machine on master [1] when running 
pg_upgrade live check right after starting the old server (note that 
instead of the expected banner 'Performing Consistency Checks on Old 
Live Server' there's a banner 'Performing Consistency Checks'):

> bin\initdb.exe -D data_old
> bin\initdb.exe -D data_new
> bin\pg_ctl.exe -D data_old -l logfile_old start && bin\pg_upgrade.exe 
> -d C:\postgrespro\inst\data_old -D C:\postgrespro\inst\data_new -b 
> C:\postgrespro\inst\bin -B C:\postgrespro\inst\bin -p 5432 --check 
> --retain && bin\pg_ctl.exe -D data_old stop
waiting for server to start.... done
server started
Performing Consistency Checks
-----------------------------
Checking cluster versions                                   ok
...
*Clusters are compatible*
pg_ctl: PID file "data_old/postmaster.pid" does not exist
Is server running?

 From pg_upgrade_server_start.log with debug output (see 
diff_debug_pg_ctl_start.patch):

command: "C:/postgrespro/inst/bin/pg_ctl" -w -l 
"C:/postgrespro/inst/data_new/pg_upgrade_output.d/20220917T044300.887/log/pg_upgrade_server.log" 
-D "C:/postgrespro/inst/data_old" -o "-p 5432 -b " start >> 
"C:/postgrespro/inst/data_new/pg_upgrade_output.d/20220917T044300.887/log/pg_upgrade_server_start.log" 
2>&1
pg_ctl: another server might be running; trying to start server anyway
pg_ctl: do_start old_pid 6100
waiting for server to start...pg_ctl: wait_for_postmaster_start pmpid 
6100
pg_ctl: wait_for_postmaster_start pmstart 1663414980
pg_ctl: wait_for_postmaster_start start_time 1663414982
  done
server started

And adding a sufficient pause between the old server start and 
pg_upgrade solves the problem:

> bin\pg_ctl.exe -D data_old -l logfile_old start && sleep 2 && 
> bin\pg_upgrade.exe -d C:\postgrespro\inst\data_old -D 
> C:\postgrespro\inst\data_new -b C:\postgrespro\inst\bin -B 
> C:\postgrespro\inst\bin -p 5432 --check --retain && bin\pg_ctl.exe -D 
> data_old stop
waiting for server to start.... done
server started
Performing Consistency Checks on Old Live Server
------------------------------------------------
Checking cluster versions                                   ok
...
*Clusters are compatible*
waiting for server to shut down.... done
server stopped

The patch to check the previous postmaster pid when running pg_ctl start 
[2] works for me, but it was reverted [3]...

[1] 
https://github.com/postgres/postgres/commit/fdd8937c071e85e2b7606939fb28284f008e15d1
[2] 
https://github.com/postgres/postgres/commit/6a5084eed49552bfc8859c438c8d74ad09fc5d3f
[3] 
https://github.com/postgres/postgres/commit/f38291e927fa8c04eb772e6a17a3dd44da2b69e8

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--=_8b7c542a272b20896d6257d1a065e528
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=diff_debug_pg_ctl_start.patch
Content-Disposition: attachment;
 filename=diff_debug_pg_ctl_start.patch;
 size=937

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfY3RsL3BnX2N0bC5jIGIvc3JjL2Jpbi9wZ19jdGwvcGdf
Y3RsLmMKaW5kZXggOTI5MWM2MWQwMDBmZWViMjQ0M2I0OWY4NzM5ODA5YTQzM2E3NzgxZC4uNTU0
ZGZiZDJmODQ3YzgzMGViM2NhNmZjNjY3N2I5NTcxMWYzMmVmOSAxMDA2NDQKLS0tIGEvc3JjL2Jp
bi9wZ19jdGwvcGdfY3RsLmMKKysrIGIvc3JjL2Jpbi9wZ19jdGwvcGdfY3RsLmMKQEAgLTYyMiw2
ICs2MjIsMTEgQEAgd2FpdF9mb3JfcG9zdG1hc3Rlcl9zdGFydChwZ3BpZF90IHBtX3BpZCwgYm9v
bCBkb19jaGVja3BvaW50KQogCQkJICovCiAJCQlwbXBpZCA9IGF0b2wob3B0bGluZXNbTE9DS19G
SUxFX0xJTkVfUElEIC0gMV0pOwogCQkJcG1zdGFydCA9IGF0b2wob3B0bGluZXNbTE9DS19GSUxF
X0xJTkVfU1RBUlRfVElNRSAtIDFdKTsKKworCQkJcGdfbG9nX2luZm8oIndhaXRfZm9yX3Bvc3Rt
YXN0ZXJfc3RhcnQgcG1waWQgJWxkIiwgcG1waWQpOworCQkJcGdfbG9nX2luZm8oIndhaXRfZm9y
X3Bvc3RtYXN0ZXJfc3RhcnQgcG1zdGFydCAlbHUiLCBwbXN0YXJ0KTsKKwkJCXBnX2xvZ19pbmZv
KCJ3YWl0X2Zvcl9wb3N0bWFzdGVyX3N0YXJ0IHN0YXJ0X3RpbWUgJWx1Iiwgc3RhcnRfdGltZSk7
CisKIAkJCWlmIChwbXN0YXJ0ID49IHN0YXJ0X3RpbWUgLSAyICYmCiAjaWZuZGVmIFdJTjMyCiAJ
CQkJcG1waWQgPT0gcG1fcGlkCkBAIC05MzYsNiArOTQxLDcgQEAgZG9fc3RhcnQodm9pZCkKIAkJ
CXdyaXRlX3N0ZGVycihfKCIlczogYW5vdGhlciBzZXJ2ZXIgbWlnaHQgYmUgcnVubmluZzsgIgog
CQkJCQkJICAgInRyeWluZyB0byBzdGFydCBzZXJ2ZXIgYW55d2F5XG4iKSwKIAkJCQkJCSBwcm9n
bmFtZSk7CisJCXBnX2xvZ19pbmZvKCJkb19zdGFydCBvbGRfcGlkICVsZCIsIG9sZF9waWQpOwog
CX0KIAogCXJlYWRfcG9zdF9vcHRzKCk7Cg==
--=_8b7c542a272b20896d6257d1a065e528--