Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLeop-0001TT-Go for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2020 03:22:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jLeon-0007Hv-6f for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2020 03:22:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLeon-0007B7-0P; Tue, 07 Apr 2020 03:22:29 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLeoi-0006Ti-N6; Tue, 07 Apr 2020 03:22:26 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id 00937602FB; Tue, 7 Apr 2020 12:22:20 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: Don't try fetching future segment of a TLI. To: Kyotaro Horiguchi Cc: psuderevsky@gmail.com, david@pgmasters.net, pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org References: <8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net> <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> <20200407.102909.709448322643210522.horikyota.ntt@gmail.com> From: Fujii Masao Message-ID: Date: Tue, 7 Apr 2020 12:22:20 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200407.102909.709448322643210522.horikyota.ntt@gmail.com> Content-Type: multipart/mixed; boundary="------------081B1AA7C6C0C40F25C7B93F" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------081B1AA7C6C0C40F25C7B93F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2020/04/07 10:29, Kyotaro Horiguchi wrote: > Thank you for picking this up. > > At Tue, 7 Apr 2020 02:43:02 +0900, Fujii Masao wrote in >> On 2020/03/19 22:22, Pavel Suderevsky wrote: >>> Hi, >>> I've tested patch provided by Kyotaro and do confirm it fixes the >>> issue. >> >> The patch looks good to me. Attached is the updated version of the >> patch. >> I updated only comments. > > + * The logfile segment that doesn't belong to the timeline is > + * older or newer than the segment that the timeline started or > + * eneded at, respectively. It's sufficient to check only the > > s/eneded/ended/ ? Yes! Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------081B1AA7C6C0C40F25C7B93F Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="v3-0001-Don-t-try-fetching-out-of-timeline-segments.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="v3-0001-Don-t-try-fetching-out-of-timeline-segments.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYyBiL3NyYy9i YWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYwppbmRleCBhYmY5NTRiYTM5Li5lYzU1ZDY4 ZDI3IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMKKysr IGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZy5jCkBAIC0zNzc2LDExICszNzc2 LDM2IEBAIFhMb2dGaWxlUmVhZEFueVRMSShYTG9nU2VnTm8gc2Vnbm8sIGludCBlbW9kZSwg WExvZ1NvdXJjZSBzb3VyY2UpCiAKIAlmb3JlYWNoKGNlbGwsIHRsZXMpCiAJewotCQlUaW1l TGluZUlECXRsaSA9ICgoVGltZUxpbmVIaXN0b3J5RW50cnkgKikgbGZpcnN0KGNlbGwpKS0+ dGxpOworCQlUaW1lTGluZUhpc3RvcnlFbnRyeSAqaGVudCA9IChUaW1lTGluZUhpc3RvcnlF bnRyeSAqKSBsZmlyc3QoY2VsbCk7CisJCVRpbWVMaW5lSUQJdGxpID0gaGVudC0+dGxpOwog CiAJCWlmICh0bGkgPCBjdXJGaWxlVExJKQogCQkJYnJlYWs7CQkJCS8qIGRvbid0IGJvdGhl ciBsb29raW5nIGF0IHRvby1vbGQgVExJcyAqLwogCisJCS8qCisJCSAqIFNraXAgc2Nhbm5p bmcgdGhlIHRpbWVsaW5lIElEIHRoYXQgdGhlIGxvZ2ZpbGUgc2VnbWVudCB0byByZWFkCisJ CSAqIGRvZXNuJ3QgYmVsb25nIHRvCisJCSAqLworCQlpZiAoaGVudC0+YmVnaW4gIT0gSW52 YWxpZFhMb2dSZWNQdHIpCisJCXsKKwkJCVhMb2dTZWdObwliZWdpbnNlZyA9IDA7CisKKwkJ CVhMQnl0ZVRvU2VnKGhlbnQtPmJlZ2luLCBiZWdpbnNlZywgd2FsX3NlZ21lbnRfc2l6ZSk7 CisKKwkJCS8qCisJCQkgKiBUaGUgbG9nZmlsZSBzZWdtZW50IHRoYXQgZG9lc24ndCBiZWxv bmcgdG8gdGhlIHRpbWVsaW5lIGlzCisJCQkgKiBvbGRlciBvciBuZXdlciB0aGFuIHRoZSBz ZWdtZW50IHRoYXQgdGhlIHRpbWVsaW5lIHN0YXJ0ZWQgb3IKKwkJCSAqIGVuZGVkIGF0LCBy ZXNwZWN0aXZlbHkuIEl0J3Mgc3VmZmljaWVudCB0byBjaGVjayBvbmx5IHRoZQorCQkJICog c3RhcnRpbmcgc2VnbWVudCBvZiB0aGUgdGltZWxpbmUgaGVyZS4gU2luY2UgdGhlIHRpbWVs aW5lcyBhcmUKKwkJCSAqIHNjYW5uZWQgaW4gZGVzY2VuZGluZyBvcmRlciBpbiB0aGlzIGxv b3AsIGFueSBzZWdtZW50cyBuZXdlcgorCQkJICogdGhhbiB0aGUgZW5kaW5nIHNlZ21lbnQg c2hvdWxkIGJlbG9uZyB0byBuZXdlciB0aW1lbGluZSBhbmQKKwkJCSAqIGhhdmUgYWxyZWFk eSBiZWVuIHJlYWQgYmVmb3JlLiBTbyBpdCdzIG5vdCBuZWNlc3NhcnkgdG8gY2hlY2sKKwkJ CSAqIHRoZSBlbmRpbmcgc2VnbWVudCBvZiB0aGUgdGltZWxpbmUgaGVyZS4KKwkJCSAqLwor CQkJaWYgKHNlZ25vIDwgYmVnaW5zZWcpCisJCQkJY29udGludWU7CisJCX0KKwogCQlpZiAo c291cmNlID09IFhMT0dfRlJPTV9BTlkgfHwgc291cmNlID09IFhMT0dfRlJPTV9BUkNISVZF KQogCQl7CiAJCQlmZCA9IFhMb2dGaWxlUmVhZChzZWdubywgZW1vZGUsIHRsaSwK --------------081B1AA7C6C0C40F25C7B93F--