Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3Jbm-00359E-Iv for pgsql-bugs@arkaria.postgresql.org; Wed, 15 Nov 2023 17:23:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r3Jbk-000zYB-Il for pgsql-bugs@arkaria.postgresql.org; Wed, 15 Nov 2023 17:23:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3Jbk-000zY3-5V for pgsql-bugs@lists.postgresql.org; Wed, 15 Nov 2023 17:23:20 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r3Jbc-005j6P-Nq for pgsql-bugs@lists.postgresql.org; Wed, 15 Nov 2023 17:23:18 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507b9408c61so9611670e87.0 for ; Wed, 15 Nov 2023 09:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20230601.gappssmtp.com; s=20230601; t=1700068990; x=1700673790; darn=lists.postgresql.org; h=mime-version:user-agent:references:in-reply-to:date:to:from:subject :message-id:from:to:cc:subject:date:message-id:reply-to; bh=II1dVOeQbz6IVU3BT5N9KVjjwnb4yPRyHd9UqQw1Vnw=; b=EFggG3BDlAZ04hKW5FqUYTcK5MVRQxAFsLOBgvDtE/YUp3AkQG77h6JDnnEJsA4puC WCWSiQ3HIMOZBITInpfeNNCXSKLL+YDYeuR0FMqc0l8EdcTPP1CR/fYJTq7LmjUXV1O0 izBb/K7sHx6VPoddC4EUgq0Q7LEo7pqKQ+jPlB2LGCG/hkyBLpJGwSsruV3kBtqAiAef cidhR6GC4xg8yRKVqwscsRXfW+H6ThG/zfPQEbO74pQUx5Ojk17nASSBnvGVXV8V3+UB EAc7sDjysnd5GcQx6UQyRSNqiTRE+NkBKNoyWdpDtywwimH1KXLPeJJYRePIEaLDmbkK JtWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700068990; x=1700673790; h=mime-version:user-agent:references:in-reply-to:date:to:from:subject :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=II1dVOeQbz6IVU3BT5N9KVjjwnb4yPRyHd9UqQw1Vnw=; b=NzNXLYUhV96OGifNzoND236vslSj3pKdSgk0G1ouaVpIAWcXLEtYnqW7KfN2aI2Kf2 YzCNZmenEHp6fAGILtPO+XyX06qoKA57YDwWyshEUy5OCRH2NDD0qlRJDtDhTOi+8ZhE zo3I03POBu2LRrHNFBrE84Tnp7ljG3kiM3cSSa38DewZXrxhaMHxXkf7sauNyVwxiwD3 D+j59nvU3v0iEIyev0bwmVT1G908jHfOTCtq7SyVe9lf3khUYG1ePpbLxuUBv6CtmFsn 8is8R3cQXviovO7fXKqIjZ+B8tucBrN3xLS0QSqjWXo10vXf/0bghmZdUdtYAUHTHbTc haEQ== X-Gm-Message-State: AOJu0Yz/kQdaireM1P0LmJufyIJA3WOEDaL/Tcl/Phua3H3gduoTnGHz sbSGQ1rLeVyMIX2TkCaqkxRKW2RgEB1nQD2kg1g= X-Google-Smtp-Source: AGHT+IEYBc/M6LBnf9wyKAil+fF/0Q0tc1jAHP7UlOUfoxhkD+hUkT/B3XJTQQXqHKcIFTY3VoWqOA== X-Received: by 2002:a05:6512:3ca9:b0:509:1033:c544 with SMTP id h41-20020a0565123ca900b005091033c544mr13439128lfv.50.1700068989978; Wed, 15 Nov 2023 09:23:09 -0800 (PST) Received: from localhost.localdomain (p50992f7c.dip0.t-ipconnect.de. [80.153.47.124]) by smtp.gmail.com with ESMTPSA id i7-20020adffc07000000b0032dcb08bf94sm11116419wrr.60.2023.11.15.09.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 09:23:09 -0800 (PST) Message-ID: Subject: Re: BUG #18200: Undefined behaviour in interval_div From: Laurenz Albe To: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Date: Wed, 15 Nov 2023 18:23:08 +0100 In-Reply-To: <18200-5ea288c7b2d504b1@postgresql.org> References: <18200-5ea288c7b2d504b1@postgresql.org> Content-Type: multipart/mixed; boundary="=-ZKDKbv7dAsoVGbxxjPxe" User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-ZKDKbv7dAsoVGbxxjPxe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2023-11-15 at 13:00 +0000, PG Bug reporting form wrote: > The following query: > SELECT interval '12000000 months' / 0.001; >=20 > triggers an ubsan-detected error: > timestamp.c:3408:18: runtime error: 1.2e+10 is outside the range of > representable values of type 'int' >=20 > Without ubsan the result is: > -178956970 years -8 mons -2562047788:00:54.775808 How about the attached fix? Yours, Laurenz Albe --=-ZKDKbv7dAsoVGbxxjPxe Content-Disposition: attachment; filename="0001-Check-for-overflow-in-interval-division.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Check-for-overflow-in-interval-division.patch"; charset="UTF-8" RnJvbSAyNzQ4YzAxYTNlMzQzMDAxZDM2Njg1NTRmZGI3ZWU4OTRmZWZiZGYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h dD4KRGF0ZTogV2VkLCAxNSBOb3YgMjAyMyAxODoyMTo0MiArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IENoZWNrIGZvciBvdmVyZmxvdyBpbiBpbnRlcnZhbCBkaXZpc2lvbgoKRGl2aWRpbmcgYSBsYXJn ZSBpbnRlcnZhbCBieSBhIHNtYWxsIGZsb2F0aW5nIHBvaW50IG51bWJlcgpjYW4gbGVhZCB0byBp bnRlZ2VyIG92ZXJmbG93LCB3aGljaCByZXN1bHRzIGluIGJvZ3VzIHZhbHVlcy4KUmVwb3J0IGJ5 IEFsZXhhbmRlciBMYWtoaW4uCgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tLzE4MjAw LTVlYTI4OGM3YjJkNTA0YjFAcG9zdGdyZXNxbC5vcmcKLS0tCiBzcmMvYmFja2VuZC91dGlscy9h ZHQvdGltZXN0YW1wLmMgfCA5ICsrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC90aW1lc3RhbXAuYyBiL3Ny Yy9iYWNrZW5kL3V0aWxzL2FkdC90aW1lc3RhbXAuYwppbmRleCA2NDdiOTdhY2E2Li5iMjFlZmVi ODk3IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hZHQvdGltZXN0YW1wLmMKKysrIGIv c3JjL2JhY2tlbmQvdXRpbHMvYWR0L3RpbWVzdGFtcC5jCkBAIC0zNDIyLDYgKzM0MjIsMTUgQEAg aW50ZXJ2YWxfZGl2KFBHX0ZVTkNUSU9OX0FSR1MpCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9ESVZJ U0lPTl9CWV9aRVJPKSwKIAkJCQkgZXJybXNnKCJkaXZpc2lvbiBieSB6ZXJvIikpKTsKIAorCS8q IGNoZWNrIGZvciBvdmVyZmxvdyAqLworCWlmIChzcGFuLT5tb250aCAvIGZhY3RvciA+IFBHX0lO VDMyX01BWCB8fAorCQlzcGFuLT5tb250aCAvIGZhY3RvciA8IFBHX0lOVDMyX01JTiB8fAorCQlz cGFuLT5kYXkgLyBmYWN0b3IgPiBQR19JTlQzMl9NQVggfHwKKwkJc3Bhbi0+ZGF5IC8gZmFjdG9y IDwgUEdfSU5UMzJfTUlOKQorCWVyZXBvcnQoRVJST1IsCisJCQllcnJjb2RlKEVSUkNPREVfREFU RVRJTUVfVkFMVUVfT1VUX09GX1JBTkdFKSwKKwkJCWVycm1zZygiaW50ZXJ2YWwgb3V0IG9mIHJh bmdlIikpOworCiAJcmVzdWx0LT5tb250aCA9IChpbnQzMikgKHNwYW4tPm1vbnRoIC8gZmFjdG9y KTsKIAlyZXN1bHQtPmRheSA9IChpbnQzMikgKHNwYW4tPmRheSAvIGZhY3Rvcik7CiAKLS0gCjIu NDEuMAoK --=-ZKDKbv7dAsoVGbxxjPxe--