Message-ID: <ca3f78bc-9775-4c12-97b5-5e03282df3ea@postgrespro.ru>
Date: Thu, 28 Sep 2023 13:32:25 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: EXPLAIN Verbose issue - custom_scan_tlist can directly refer CTE
 and Subquery
Content-Language: en-US
To: Richard Guo <guofenglinux@gmail.com>,
 Lepikhov Andrei <lepikhov@fastmail.com>
Cc: pgsql-bugs@lists.postgresql.org, tgl@sss.pgh.pa.us,
 =?UTF-8?B?0JDQu9C10L3QsCDQoNGL0LHQsNC60LjQvdCw?=
 <a.rybakina@postgrespro.ru>, =?UTF-8?B?0JTQsNC80LjRgCDQkdC10LvRj9C70L7Qsg==?=
 <d.belyalov@postgrespro.ru>
References: <dfe47e78-f9c3-4f59-a345-591f7fd3ceec@app.fastmail.com>
 <CAMbWs49A1VegrUX08on3WdH7b7t7FUE15JT4qk_vsQ_qfHMGhQ@mail.gmail.com>
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: 
 <CAMbWs49A1VegrUX08on3WdH7b7t7FUE15JT4qk_vsQ_qfHMGhQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ca3f78bc-9775-4c12-97b5-5e03282df3ea%40postgrespro.ru>
Precedence: bulk

On 11/9/2023 13:28, Richard Guo wrote:
> So it seems that we need to assign a proper INNER referent for
> CustomScan node in set_deparse_plan().  I tried 'trick.diff' in [1]
> which uses linitial(dpns->subplans), it fixes the query there but would
> crash the query below.
> 
> explain (verbose, costs off)
> select (rr).column2 from
>    (select r from (values(1,2),(3,4)) r) s join
>    (select rr from (values(1,7),(3,8)) rr limit 2) ss
>    on (r).column1 = (rr).column1;
> server closed the connection unexpectedly
> 
> Maybe we can use the first plan in CustomScan->custom_plans as the INNER
> referent?  I'm not sure.

Looking into this issue more, I figured out that we can't be sure from 
which side the current varno of custom_scan_tlist was produced: from 
inner, outer or one of the custom subplans. In one of my previous R&D 
projects, I remember that the CustomScan node received tuples from the 
network, gathering them from other pg-instances.
So, as we already have an optional ExplainCustomScan routine, maybe add 
one more for the show_plan_tlist routine? It can print a target list or 
ignore it as the Append node does.

-- 
regards,
Andrey Lepikhov
Postgres Professional