Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
References: <20170621020210.eqf44aoqjcu3qtma@alvherre.pgsql>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Message-ID: <cd372b5a-bda9-6d9e-8310-e60e77ef0ee3@lab.ntt.co.jp>
Date: Wed, 21 Jun 2017 11:12:51 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170621020210.eqf44aoqjcu3qtma@alvherre.pgsql>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Bruno Wolff III <bruno@wolff.to>, pgsql-bugs@postgresql.org
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On 2017/06/21 11:02, Alvaro Herrera wrote:
> Bruno Wolff III wrote:
>> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
>> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
> 
> You're absolutely right, and this is a bug in the parser -- I probably
> misplaced the IF NOT EXISTS clause while playing with Tomas' parser
> changes.  Here's the fix.  I'm a bit troubled that this change doesn't
> seem to affect any tests, so I'll add some before pushing.

I posted the same patch but with a test:

https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp

Forgot to cc you or Tomas.

Thanks,
Amit


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs