Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIDGR-0003T3-DN for pgsql-bugs@arkaria.postgresql.org; Fri, 05 Mar 2021 16:25:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lIDGP-0001Zb-DF for pgsql-bugs@arkaria.postgresql.org; Fri, 05 Mar 2021 16:25:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIDGP-0001ZU-7G for pgsql-bugs@lists.postgresql.org; Fri, 05 Mar 2021 16:25:17 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIDGN-0001kb-BD for pgsql-bugs@lists.postgresql.org; Fri, 05 Mar 2021 16:25:16 +0000 Received: from desktop.home.thelabyrinth.net (c-73-39-102-148.hsd1.md.comcast.net [73.39.102.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 783DF5466B; Fri, 5 Mar 2021 16:25:13 +0000 (UTC) Subject: Re: posgres 12 bug (partitioned table) To: Amit Langote , Pavel Biryukov <79166341370@yandex.ru> Cc: Andres Freund , Tom Lane , PostgreSQL mailing lists References: <141051591267657@mail.yandex.ru> <1251598.1591289850@sss.pgh.pa.us> <20200811180231.fcssvhelqpnydnx7@alap3.anarazel.de> <81885.1597205290@sss.pgh.pa.us> <20200812162718.ycxrktzoe6rpdy5k@alap3.anarazel.de> <407111603806900@mail.yandex.ru> From: David Steele Message-ID: Date: Fri, 5 Mar 2021 11:25:12 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 10/28/20 10:01 AM, Amit Langote wrote: > On Tue, Oct 27, 2020 at 10:55 PM Pavel Biryukov <79166341370@yandex.ru> wrote: >> Hi! >> >> What's the state with this issue? > I think that the patch that Andres Freund posted earlier on this > thread [1] would be fine as a workaround at least for stable releases > v12 and v13. I have attached with this email a rebased version of > that patch, although I also made a few changes. The idea of the patch > is to allocate and use a partition-specific *non-virtual* slot, one > that is capable of providing system columns when the RETURNING > projection needs them. Andres' patch would allocate such a slot even > if RETURNING contained no system columns, whereas I changed the slot > creation code stanza to also check that RETURNING indeed contains > system columns. I've attached 2 patch files: one for HEAD and another > for v12 and v13 branches. > > That said, the discussion on what to do going forward to *cleanly* > support accessing system columns through partitioned tables is > pending, but maybe the "workaround" fix will be enough in the meantime > (at least v12 and v13 can only get a workaround fix). > stgresql.org/message-id/20200811180629.zx57llliqcmcgfyr%40alap3.anarazel.de This thread has been quiet for while. Does everyone agree with Amit's proposal to use this patch as a workaround? Also, is there a CF entry for this issue? If so I am unable to find it. Regards, -- -David david@pgmasters.net