Message-ID: <ce071503fee88334aa70f360e6e4ea14d48305ee.camel@j-davis.com>
Subject: pg_dump assertion failure with "-n pg_catalog"
From: Jeff Davis <pgsql@j-davis.com>
To: pgsql-bugs@postgresql.org
Date: Wed, 07 Jun 2023 10:36:29 -0700
Content-Type: multipart/mixed; boundary="=-tf+Jpaq7riVQt7bRVurX"
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com>
Precedence: bulk

--=-tf+Jpaq7riVQt7bRVurX
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


On version 15 or later:

  pg_dump -n pg_catalog postgres > /dev/null
  pg_dump: pg_dump.c:13291: dumpCollation: Assertion `collcollate !=3D
((void *)0)' failed.

Patch attached.

I tried adding a test, but dumping pg_catalog seems to only be
supported for research purposes, so it's not clear what the test should
be testing.

If we went almost two release cycles without anyone noticing, then
perhaps we should just get rid of the ability to dump pg_catalog. But I
think the attached patch clarifies things regardless.


--=20
Jeff Davis
PostgreSQL Contributor Team - AWS


--=-tf+Jpaq7riVQt7bRVurX
Content-Disposition: attachment;
	filename*0=0001-Fix-pg_dump-assertion-failure-when-dumping-pg_catalo.pat;
	filename*1=ch
Content-Type: text/x-patch;
	name="0001-Fix-pg_dump-assertion-failure-when-dumping-pg_catalo.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSAyMzU5ZjMyNDRjYzMwYmJjMzM1M2I4NjQ0ZTI1ODc5ZDhhZTg3YzIwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBX
ZWQsIDcgSnVuIDIwMjMgMTA6MzI6NTIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXggcGdfZHVt
cCBhc3NlcnRpb24gZmFpbHVyZSB3aGVuIGR1bXBpbmcgcGdfY2F0YWxvZy4KCi0tLQogc3JjL2Jp
bi9wZ19kdW1wL3BnX2R1bXAuYyB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t
LQogMSBmaWxlIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZm
IC0tZ2l0IGEvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXAuYyBiL3NyYy9iaW4vcGdfZHVtcC9wZ19k
dW1wLmMKaW5kZXggNWRhYjFiYTllYS4uMmE2YTMyMTYwOSAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9w
Z19kdW1wL3BnX2R1bXAuYworKysgYi9zcmMvYmluL3BnX2R1bXAvcGdfZHVtcC5jCkBAIC0xMzQ0
NiwxMyArMTM0NDYsMzQgQEAgZHVtcENvbGxhdGlvbihBcmNoaXZlICpmb3V0LCBjb25zdCBDb2xs
SW5mbyAqY29sbGluZm8pCiAJaWYgKHN0cmNtcChQUWdldHZhbHVlKHJlcywgMCwgaV9jb2xsaXNk
ZXRlcm1pbmlzdGljKSwgImYiKSA9PSAwKQogCQlhcHBlbmRQUUV4cEJ1ZmZlclN0cihxLCAiLCBk
ZXRlcm1pbmlzdGljID0gZmFsc2UiKTsKIAotCWlmIChjb2xsaWN1bG9jYWxlICE9IE5VTEwpCisJ
aWYgKGNvbGxwcm92aWRlclswXSA9PSAnZCcpCiAJeworCQlBc3NlcnQoY29sbGljdWxvY2FsZSA9
PSBOVUxMKTsKKwkJQXNzZXJ0KGNvbGxpY3VydWxlcyA9PSBOVUxMKTsKKwkJQXNzZXJ0KGNvbGxj
b2xsYXRlID09IE5VTEwpOworCQlBc3NlcnQoY29sbGN0eXBlID09IE5VTEwpOworCisJCS8qIG5v
IGxvY2FsZSAtLSB0aGUgZGVmYXVsdCBjb2xsYXRpb24gY2Fubm90IGJlIHJlbG9hZGVkIGFueXdh
eSAqLworCX0KKwllbHNlIGlmIChjb2xscHJvdmlkZXJbMF0gPT0gJ2knKQorCXsKKwkJQXNzZXJ0
KGNvbGxpY3Vsb2NhbGUgIT0gTlVMTCk7CisJCUFzc2VydChjb2xsY29sbGF0ZSA9PSBOVUxMKTsK
KwkJQXNzZXJ0KGNvbGxjdHlwZSA9PSBOVUxMKTsKKwogCQlhcHBlbmRQUUV4cEJ1ZmZlclN0cihx
LCAiLCBsb2NhbGUgPSAiKTsKIAkJYXBwZW5kU3RyaW5nTGl0ZXJhbEFIKHEsIGNvbGxpY3Vsb2Nh
bGUsIGZvdXQpOworCisJCWlmIChjb2xsaWN1cnVsZXMpCisJCXsKKwkJCWFwcGVuZFBRRXhwQnVm
ZmVyU3RyKHEsICIsIHJ1bGVzID0gIik7CisJCQlhcHBlbmRTdHJpbmdMaXRlcmFsQUgocSwgY29s
bGljdXJ1bGVzLCBmb3V0KTsKKwkJfQogCX0KLQllbHNlCisJZWxzZSBpZiAoY29sbHByb3ZpZGVy
WzBdID09ICdjJykKIAl7CisJCUFzc2VydChjb2xsaWN1bG9jYWxlID09IE5VTEwpOworCQlBc3Nl
cnQoY29sbGljdXJ1bGVzID09IE5VTEwpOwogCQlBc3NlcnQoY29sbGNvbGxhdGUgIT0gTlVMTCk7
CiAJCUFzc2VydChjb2xsY3R5cGUgIT0gTlVMTCk7CiAKQEAgLTEzNDY5LDEyICsxMzQ5MCw4IEBA
IGR1bXBDb2xsYXRpb24oQXJjaGl2ZSAqZm91dCwgY29uc3QgQ29sbEluZm8gKmNvbGxpbmZvKQog
CQkJYXBwZW5kU3RyaW5nTGl0ZXJhbEFIKHEsIGNvbGxjdHlwZSwgZm91dCk7CiAJCX0KIAl9Ci0K
LQlpZiAoY29sbGljdXJ1bGVzKQotCXsKLQkJYXBwZW5kUFFFeHBCdWZmZXJTdHIocSwgIiwgcnVs
ZXMgPSAiKTsKLQkJYXBwZW5kU3RyaW5nTGl0ZXJhbEFIKHEsIGNvbGxpY3VydWxlcywgZm91dCk7
Ci0JfQorCWVsc2UKKwkJcGdfZmF0YWwoInVucmVjb2duaXplZCBjb2xsYXRpb24gcHJvdmlkZXIg
JyVjJyIsIGNvbGxwcm92aWRlclswXSk7CiAKIAkvKgogCSAqIEZvciBiaW5hcnkgdXBncmFkZSwg
Y2Fycnkgb3ZlciB0aGUgY29sbGF0aW9uIHZlcnNpb24uICBGb3Igbm9ybWFsCi0tIAoyLjM0LjEK
Cg==


--=-tf+Jpaq7riVQt7bRVurX--