Message-ID: <ce4165ffeac66281faa05cd9fc5ceabebe210af0.camel@cybertec.at>
Subject: Re: BUG #18244: Corruption in indexes involving whole-row
 expressions
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, nik@postgres.ai,
	pgsql-bugs@lists.postgresql.org
Date: Thu, 14 Dec 2023 06:43:26 +0100
In-Reply-To: <2528430.1702440277@sss.pgh.pa.us>
References: <18244-8a7897de2acd5a08@postgresql.org>
	 <f577abdc489e75a0b62f0648829d633d75ff8d95.camel@cybertec.at>
	 <CA+hUKGJPxjaD3d_qYrHPxHLS_=ktVMFK7O-+9RgTBzQUTB9q6A@mail.gmail.com>
	 <c37d4184c476a15ad4c488d272bdc95ea7b0ff49.camel@cybertec.at>
	 <2528430.1702440277@sss.pgh.pa.us>
Autocrypt: addr=laurenz.albe@cybertec.at; prefer-encrypt=mutual;
 keydata=mQINBGGDwAQBEADgbWy5cKXQld3N2mF+DFyiNFbi2oBl2T+XgxpPF8wTRw2D/u4bBKXP0SYSE/lA86jIVNWWU0gf1KODIkVvgJm2w4vH2VBV1b7ddVViGl1Iu+9zaRnv9wulhnH42KefepXnoean6UT1EzLM0opF/Ik0j+40TxdRtobkBprkQUyHDXWlHc2ffPs3SipyFEP9AVLf7ejRC46CXWDnsqjOBSMEW8Z4HiK/8RrPZBsKLts8dJxKF4pygOdJb0CWk8k/X1jbcfdxo+zOLjOMvJcSJ2pFdJmQHU+JufB3rePziqQ2S9Ur6sccr9XnTC1GVBWN4Lf5VHq+vf+bFJjVwg+2hrySZnAVfcOrxoqFLErr7ug1zN2nM1kcpgA4VWn4gxlJtYNYYq+9WxX5dtvnNANlG3ZCrRKQzl8lxtzoF6Zo7LUhEqPaHDwn7Rvs+IdbOn41lF5UDTJGqmC4gS/bZydW2Fy3YWm4aSaN9fgFf8D+PVkrlKAZB7gBLz1TyHjbcRf85cYF+GKKrDld5SzMB/V60VX3oP/Eo8ikFpyWaqiz1f9X7MBot3/PjJkY+wDzp3nmb19QEcOBuQiSQ4xds2r0HewbuHTAR68u8jNNMGmpm2j4x+g09Jd/WQDjqlTBZ/jEltH41fYCCPWMfljXTOOXu2eLNGdfi7ETZogtwjM9oTtSPQARAQABtCdMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5hdD6JAk4EEwEIADgWIQR0CqhbZGGABqoaSbdi8bhXA2EdmAUCYYPABAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBi8bhXA2EdmM/6EADK232JCwmBzhlj8h7U9CjG6kx0JHP3uJGv+XfsHtHAlmY/RCwF1BHMEsRlk
 bT5UrLvJ2jb99bA9QARzhFaxzyn0F/BUKzuIjRGNs/n6d5dNUFA0kOt8sX+TacmC
 GEyjEBCrVCm4ranBiUyePn9NhHNWnaex7pJyqvMLLdwW9BEMJx0Fqo+DN8ukbXmYRsmhEtd3ue+x/luYmOmJnaGtzInaY5aOJYbW9XqoRIZkZvOCgbi1FfvNmoqWa+3oVxTOgw9RafjJDyW0lTHzKGjbGI5ofMU98l+/hKJFYJqWUF6VpFJY5YIcN/1lf4ZICMwDl+MPIVo/tpq8L10seJL28nLlvw3K+cI+TVW8IW/qL/LyVoDofI3USeOORuYmhpWRhik8JXX6xf3v6GrRilJIPWNFIJbxm1ZblQiQnOw3IOW7T+8nAmPin1HKqM3VrOrJQ2VtShsefNBibNAsr1oFaqcDBkn3yGG8i6CTW+FyO4PZ+/EwNxMVgktxbYdy5AT1/lpXr5tB+phhLIyVfiBvrWs5EThxYMQ/L8Y85c3GMsAy1l/x4h3jqySIYy3SCU9+jc5UVuNnXljbvkEzJ+NLWJ6C1rACFWrMszgPdh5tCrlRY9PpmYll4JbCgb8BtxEIUmR+xr50/ZElEK5iml7Q00KUekCcDt+36PsyGFTXBzNOrkCDQRhg8AEARAAzOZ2tLHlI4rrhG411h6cdCFjBZxuljaFCxFyHn3m6wbGLqwBUWC5k8UrRqjHMz88KcTSaNO7XGAmCqPdWd2SeflPZRnNTbjsVpw7mLdffsBm4JX7kki2Pvk5h0NtYeidXT1PSpc2ri4DutYXuT9uD8RAm1wUDCE5HQNUihT/WH6opt+hskHW21uHao0+y822tG0QQcGMqdQR5Vxdxj89wiEPdqW+HpU/oOZIhrf2E7prduAppxixjHy/o1rcnoznnJvc8D3+YgI9O0LrBMij89dM55pRGbLovTR1oGR3U74sX774+0xmSzeIKwZfiMUz7Atlvfk5SHOsRUFPN2Ux9kaXiiBibQpHFxt7b
 lDrT4wxdLJ/XCdbPPAyl+lZtOLsaHEEZvYNyTXwZc35dVf3R4/oz20HoG6s7ct8e1
 AQygj43XAERzty9SkWgxs8+grp1PrGx6FHVSYRqBM8dS/ZR6yRVwOwJXPyaSSqfIF21DkE4j1y4n+ItSewPGoRp8K/yWCikt6qlkVkO2ASNIiX04fAbtzwVOaNn8ZMRNqyvLc1fED4sr49onE4cAIcBLjcC3KL+w9DUGRQCdziROj5H2Yl/sXGPdMciUHo/Uz2rggc+2th3bQiMhrHWSsBpUkDQp0yWewemstPpPgBL3h2fHKaX8B9oH5Qu/H1IgrOuX8AEQEAAYkCNgQYAQgAIBYhBHQKqFtkYYAGqhpJt2LxuFcDYR2YBQJhg8AEAhsMAAoJEGLxuFcDYR2YuPwQAMkpGtR80pQ1gVsONhdkqj0H2eU66efP/gO3CoyaoIcvrpKYj7C2HipVSmkt1gpByL0X4AMQ/vKuknUz3wd28Ba+G1dCfbVs/Xiusq+SmpUj5rTwmYqdSjWMuCo1R6oS5hdJMdUUJYGMT0QkVlm1KnW8jkmCTl9GzjDxOAsN9O6/6lPzaGFtk9XF+34Bry/N4HKiJkqpC4+UTd0AprPfzJ2jdT64e1F0+W88X8y1bTTgNrHwK4mDiLnlE4SKRuEm54lNhJz//ar86Or5BErzNpM6TL7lk44QS06hwsMrEdKIy8J/SYJPjfzR8tIUnKscclVpOgjKaBqC+0iFiVaRqAgfOlIEiezX6kMh5Q2FIUfqs46qWhhXjRrdKOEoStYAaikdLu5ZXr7vfb0ZaDh+ZwTQtbSMFolyOkecwI81MCdbMfT/1TqIGTOdAj5as9fAakk0jb2pXgUYQ8X1DVTR8ahSDVEaw9VTmWiSvTxvguVJ1Mb7gG4Gmh6aviDTJhfXtH4rPUNXhDLqrTH8JkJjyKROOMakIF68Hjse5vUfUxreBEOtb5r1Coa2Fe7ncJayaSE7ryrDbFqpZ
 36UMAx4ulWMyqJajLNGY0DdG8qIsR5nxRhrnK/mrCidZ8F9/D3bWAl4rjtHlsztN59
 +AnW5l0HsQcY9ntFL/zEBOaonjdJf
Content-Type: multipart/mixed; boundary="=-LJx2e0LzAtruvMxAm0Nc"
User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/ce4165ffeac66281faa05cd9fc5ceabebe210af0.camel%40cybertec.at>
Precedence: bulk

--=-LJx2e0LzAtruvMxAm0Nc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2023-12-12 at 23:04 -0500, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > Should we forbid composite types in index declarations?  Sounds posssib=
le,
> > but very restrictive.
>=20
> That would make a lot of people very sad, I fear.
>=20
> I think a minimum answer could be to document that you might need to
> REINDEX such indexes after a change in the composite type.  We could
> perhaps try to be more proactive, say by marking such indexes invalid.
> I think though that that would have deadlock problems as well as race
> conditions.  Perhaps best to leave it at "reindex when necessary",
> especially in view of the tiny number of reports to date.

I agree.  How about the attached documentation patch?

Yours,
Laurenz Albe

--=-LJx2e0LzAtruvMxAm0Nc
Content-Disposition: attachment;
	filename="0001-Document-the-dangers-of-composite-type-columns.patch"
Content-Type: text/x-patch;
	name="0001-Document-the-dangers-of-composite-type-columns.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSAyMzk5YjcxMjAzMTY4Zjk5MDUyMzYzODAzNzllZDNjYWRkNmQzZjRjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogVGh1LCAxNCBEZWMgMjAyMyAwNjo0MToxOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd
IERvY3VtZW50IHRoZSBkYW5nZXJzIG9mIGNvbXBvc2l0ZSB0eXBlIGNvbHVtbnMKClRhYmxlIGNv
bHVtbnMgb2YgYSBjb21wb3NpdGUgdHlwZSBhcmUgdXN1YWxseSBub3QgYSBnb29kIGlkZWEsCmFz
IHRoZXkgdmlvbGF0ZSB0aGUgZmlyc3Qgbm9ybWFsIGZvcm0uCk1vcmVvdmVyLCBpZiB5b3UgY3Jl
YXRlIGFuIGluZGV4IG9uIGEgY29tcG9zaXRlIHR5cGUgYW5kIGxhdGVyCnVzZSBBTFRFUiBUWVBF
IHRvIG1vZGlmeSB0aGUgdHlwZSwgdGhlIGluZGV4IGNhbiBnZXQgY29ycnVwdGVkLgoKQXV0aG9y
OiBMYXVyZW56IEFsYmUKRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS8xODI0NC04YTc4
OTdkZTJhY2Q1YTA4JTQwcG9zdGdyZXNxbC5vcmcKLS0tCiBkb2Mvc3JjL3NnbWwvcm93dHlwZXMu
c2dtbCB8IDEwICsrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCgpk
aWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3Jvd3R5cGVzLnNnbWwgYi9kb2Mvc3JjL3NnbWwvcm93
dHlwZXMuc2dtbAppbmRleCA0ZDg2Zjk3YzAzLi42YTNiZWFmN2QwIDEwMDY0NAotLS0gYS9kb2Mv
c3JjL3NnbWwvcm93dHlwZXMuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvcm93dHlwZXMuc2dtbApA
QCAtNjcsNiArNjcsMTYgQEAgU0VMRUNUIHByaWNlX2V4dGVuc2lvbihpdGVtLCAxMCkgRlJPTSBv
bl9oYW5kOwogCiAgPC9wYXJhPgogCisgPG5vdGU+CisgIDxwYXJhPgorICAgV2hpbGUgeW91IGNh
biB1c2UgY29tcG9zaXRlIHR5cGVzIGluIGNvbHVtbiBkZWZpbml0aW9ucywgdGhlcmUgaXMgdXN1
YWxseSBubworICAgYmVuZWZpdCBpbiBkb2luZyBzby4gIEFsc28sIGlmIHlvdSBjcmVhdGUgaW5k
ZXhlcyBvbiBjb21wb3NpdGUgdHlwZSBjb2x1bW5zLAorICAgYmV3YXJlIG9mIHVzaW5nIDxjb21t
YW5kPkFMVEVSIFRZUEU8L2NvbW1hbmQ+IHRvIG1vZGlmeSB0aGUgdHlwZSBkZWZpbml0aW9uOgor
ICAgZG9pbmcgdGhhdCBjb3VsZCBicmVhayB0aGUgcmVxdWlyZW1lbnQgdGhhdCBpbmRleCBleHBy
ZXNzaW9ucyBtdXN0IGJlCisgICBpbW11dGFibGUgYW5kIG1pZ2h0IHJlbmRlciB0aGUgaW5kZXgg
Y29ycnVwdGVkLgorICA8L3BhcmE+CisgPC9ub3RlPgorCiAgPHBhcmE+CiAgIFdoZW5ldmVyIHlv
dSBjcmVhdGUgYSB0YWJsZSwgYSBjb21wb3NpdGUgdHlwZSBpcyBhbHNvIGF1dG9tYXRpY2FsbHkK
ICAgY3JlYXRlZCwgd2l0aCB0aGUgc2FtZSBuYW1lIGFzIHRoZSB0YWJsZSwgdG8gcmVwcmVzZW50
IHRoZSB0YWJsZSdzCi0tIAoyLjQzLjAKCg==


--=-LJx2e0LzAtruvMxAm0Nc--