Content-Type: multipart/mixed; boundary="------------cOsTK4bKWYzNi3e9tfgwckEg"
Message-ID: <cfd3d974-d3e7-4adf-9574-0094044e91a4@technowledgy.de>
Date: Sun, 31 Mar 2024 15:34:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: walther@technowledgy.de
Subject: Re: Building with musl in CI and the build farm
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
References: <4093813.1710899588@sss.pgh.pa.us>
 <CA+hUKGKNK5V8XwwJJZm36s3EUy8V51xu4XiE8=26n=Wq3OGd4A@mail.gmail.com>
 <4095435.1710900216@sss.pgh.pa.us>
 <CA+hUKGK2cSx3dveMqBD+E9N=zJ0WawBcbk_jnPqmdWBM0DT_3Q@mail.gmail.com>
 <477fa513-6bf0-456d-8d24-1e22a19df671@technowledgy.de>
 <ZfrmN4WHuJgD95fw@momjian.us>
 <CA+hUKGJzC4rr2Yr=QZyx9W83Wv=TVJHndKF1anjNLNXVUM7TqQ@mail.gmail.com>
 <f98cd8de-1c66-491a-8409-e62c09932080@technowledgy.de>
 <20240322001948.atp2eetusylgjyw2@awork3.anarazel.de>
 <40543180-a0a2-495b-8d34-23b46c28f533@technowledgy.de>
 <20240326001447.wcatfvx45tkmizji@awork3.anarazel.de>
 <0a48d551-50e1-4bd3-8d46-8421e3b1b724@technowledgy.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
In-Reply-To: <0a48d551-50e1-4bd3-8d46-8421e3b1b724@technowledgy.de>
Archived-At: 
 <https://www.postgresql.org/message-id/cfd3d974-d3e7-4adf-9574-0094044e91a4%40technowledgy.de>
Precedence: bulk

This is a multi-part message in MIME format.
--------------cOsTK4bKWYzNi3e9tfgwckEg
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

About building one of the CI tasks with musl:

Andres Freund:
> I'd rather adapt one of the existing tasks, to avoid increasing CI costs unduly.

I looked into this and I think the only task that could be changed is 
the SanityCheck. This is because this builds without any additional 
features enabled. I guess that makes sense, because otherwise those 
dependencies would first have to be built with musl-gcc as well.


> FWIW, except for one small issue, building postgres against musl works on debian and the tests pass if I install first.

After the fix for LD_LIBRARY_PATH this now works as expected without 
installing first. I confirmed it works on debian with CC=musl-gcc.


> The small problem mentioned above is that on debian linux/fs.h isn't available
> when building with musl, which in turn causes src/bin/pg_upgrade/file.c to
> fail to compile.

According to [1], this can be worked around by linking some folders:

ln -s /usr/include/linux /usr/include/x86_64-linux-musl/
ln -s /usr/include/asm-generic /usr/include/x86_64-linux-musl/
ln -s /usr/include/x86_64-linux-gnu/asm /usr/include/x86_64-linux-musl/

Please find a patch to use musl-gcc in SanityCheck attached. Logs from 
the CI run are in [2]. It has this in the configure phase:

[13:19:52.712] Using 'CC' from environment with value: 'ccache musl-gcc'
[13:19:52.712] C compiler for the host machine: ccache musl-gcc (gcc 
10.2.1 "cc (Debian 10.2.1-6) 10.2.1 20210110")
[13:19:52.712] C linker for the host machine: musl-gcc ld.bfd 2.35.2
[13:19:52.712] Using 'CC' from environment with value: 'ccache musl-gcc'

So meson picks up musl-gcc properly. I also double checked that without 
the links above, the build does indeed fail with the linux/fs.h error.

I assume the installation of musl-tools should be done in the 
pg-vm-images repo instead of the additional script here?

Best,

Wolfgang

[1]: 
https://debian-bugs-dist.debian.narkive.com/VlFkLigg/bug-789789-musl-fails-to-compile-stuff-that-depends-on-kernel-headers
[2]: https://cirrus-ci.com/task/5741892590108672
--------------cOsTK4bKWYzNi3e9tfgwckEg
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Build-SanityCheck-against-musl.patch"
Content-Disposition: attachment;
 filename="0001-Build-SanityCheck-against-musl.patch"
Content-Transfer-Encoding: base64

RnJvbSA0YTY5ZDk4NTFlN2JiZDdjZDUyMWQyMzY4NDdhZjllYmY1ZTYyNTNiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBXb2xmZ2FuZyBXYWx0aGVyIDx3YWx0aGVyQHRlY2hu
b3dsZWRneS5kZT4KRGF0ZTogU3VuLCAzMSBNYXIgMjAyNCAxNToxNzo0MyArMDIwMApTdWJq
ZWN0OiBbUEFUQ0hdIEJ1aWxkIFNhbml0eUNoZWNrIGFnYWluc3QgbXVzbAoKLS0tCiAuY2ly
cnVzLnRhc2tzLnltbCB8IDkgKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRp
b25zKCspCgpkaWZmIC0tZ2l0IGEvLmNpcnJ1cy50YXNrcy55bWwgYi8uY2lycnVzLnRhc2tz
LnltbAppbmRleCA3MmY1NTNlNjlmNC4uNTgxNWM1MWFiYmUgMTAwNjQ0Ci0tLSBhLy5jaXJy
dXMudGFza3MueW1sCisrKyBiLy5jaXJydXMudGFza3MueW1sCkBAIC02OSw2ICs2OSw3IEBA
IHRhc2s6CiAgICAgQ0NBQ0hFX0RJUjogJHtDSVJSVVNfV09SS0lOR19ESVJ9L2NjYWNoZV9k
aXIKICAgICAjIG5vIG9wdGlvbnMgZW5hYmxlZCwgc2hvdWxkIGJlIHNtYWxsCiAgICAgQ0NB
Q0hFX01BWFNJWkU6ICIxNTBNIgorICAgIENDOiBjY2FjaGUgbXVzbC1nY2MKIAogICAjIFdo
aWxlIGNvbnRhaW5lcnMgd291bGQgc3RhcnQgdXAgYSBiaXQgcXVpY2tlciwgYnVpbGRpbmcg
aXMgYSBiaXQKICAgIyBzbG93ZXIuIFRoaXMgd2F5IHdlIGRvbid0IGhhdmUgdG8gbWFpbnRh
aW4gYSBjb250YWluZXIgaW1hZ2UuCkBAIC03Nyw2ICs3OCwxNCBAQCB0YXNrOgogICBjY2Fj
aGVfY2FjaGU6CiAgICAgZm9sZGVyOiAkQ0NBQ0hFX0RJUgogCisgIHNldHVwX2FkZGl0aW9u
YWxfcGFja2FnZXNfc2NyaXB0OiB8CisgICAgYXB0LWdldCB1cGRhdGUKKyAgICBERUJJQU5f
RlJPTlRFTkQ9bm9uaW50ZXJhY3RpdmUgYXB0LWdldCAteSBpbnN0YWxsIG11c2wtdG9vbHMK
KyAgICBsbiAtcyAtdCAvdXNyL2luY2x1ZGUveDg2XzY0LWxpbnV4LW11c2wvIFwKKyAgICAg
IC91c3IvaW5jbHVkZS9saW51eCBcCisgICAgICAvdXNyL2luY2x1ZGUvYXNtLWdlbmVyaWMg
XAorICAgICAgL3Vzci9pbmNsdWRlL3g4Nl82NC1saW51eC1nbnUvYXNtCisKICAgY3JlYXRl
X3VzZXJfc2NyaXB0OiB8CiAgICAgdXNlcmFkZCAtbSBwb3N0Z3JlcwogICAgIGNob3duIC1S
IHBvc3RncmVzOnBvc3RncmVzIC4KLS0gCjIuNDQuMAoK

--------------cOsTK4bKWYzNi3e9tfgwckEg--