Message-ID: <d374b6fc-4217-48a9-8639-2c9b4d3a92d0@deepbluecap.com>
Date: Thu, 12 Sep 2024 10:27:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-bugs@lists.postgresql.org
From: Duncan Sands <duncan.sands@deepbluecap.com>
Subject: pg_restore with --disable-triggers discards ENABLE ALWAYS
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d374b6fc-4217-48a9-8639-2c9b4d3a92d0%40deepbluecap.com>
Precedence: bulk

This is with postgresql version 16.4.  You can reproduce as follows:

CREATE TABLE test_table(x int);
CREATE FUNCTION test_function() RETURNS trigger AS $$ BEGIN RETURN NULL; END; $$ 
LANGUAGE plpgsql;
CREATE TRIGGER test_trigger AFTER UPDATE ON test_table FOR EACH ROW EXECUTE 
FUNCTION test_function();
ALTER TABLE test_table ENABLE ALWAYS TRIGGER test_trigger;

Checking the table:

duncan=> \d test_table
              Table "public.test_table"
  Column |  Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
  x      | integer |           |          |
Triggers firing always:
     test_trigger AFTER UPDATE ON test_table FOR EACH ROW EXECUTE FUNCTION 
test_function()

^ Observe "Triggers firing always".


Now for the dump + restore:

pg_dump -f dump.custom -Fc --table test_table
pg_restore --data-only --disable-triggers --dbname duncan dump.custom

Checking the table:

duncan=> \d test_table
              Table "public.test_table"
  Column |  Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
  x      | integer |           |          |
Triggers:
     test_trigger AFTER UPDATE ON test_table FOR EACH ROW EXECUTE FUNCTION 
test_function()

^ Observe that "Triggers firing always" has disappeared.

Best wishes, Duncan.