Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1txU1R-00A34w-A2 for pgsql-bugs@arkaria.postgresql.org; Wed, 26 Mar 2025 16:54:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1txU1P-006qs7-Qc for pgsql-bugs@arkaria.postgresql.org; Wed, 26 Mar 2025 16:54:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1txU1O-006qrz-Qh for pgsql-bugs@lists.postgresql.org; Wed, 26 Mar 2025 16:54:31 +0000 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1txU1M-001H1A-1t for pgsql-bugs@lists.postgresql.org; Wed, 26 Mar 2025 16:54:29 +0000 Received: from phl-compute-13.internal (phl-compute-13.phl.internal [10.202.2.53]) by mailfout.phl.internal (Postfix) with ESMTP id 40EA01383A2D; Wed, 26 Mar 2025 12:54:27 -0400 (EDT) Received: from phl-imap-09 ([10.202.2.99]) by phl-compute-13.internal (MEProxy); Wed, 26 Mar 2025 12:54:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1743008067; x=1743094467; bh=3MzYgm/2zr GFJrzovZm23+PETC/TNM+UxEJJPJTQqIg=; b=bE07vT/hcKuXwoyxsCQLn69Om8 Vo9ls3GP4QVUI5WzwfPug11UjyQFXwY5Xje68iX7Kl83q7U9Vq8yMV6isHu/87UB mkHXn0R1Fn5AHA9ln6B3SHH46LgJhQlqGYxLf8HU97ZzeNgWFvt1ZQ5TIqrUk7Rz KdXxSmMN+kJXiXDs0sy4goot8q+fkeosni1JRT6usEQuE4upoHyuTavgAnTqNFa9 GUdU8qK+Mzn+zZgH+73olc79dkePa1Gqd8Fq+z7i26oIvKzfG36rZKDY60UT4kWM Gd4gRra27xInJnnuaJpcRSpdyk5VPj/Bf0/3clr2ZcL+piTuuwQCUzLQJXtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1743008067; x=1743094467; bh=3MzYgm/2zrGFJrzovZm23+PETC/TNM+UxEJ JPJTQqIg=; b=WG//OdDjoHYGpiDa7IdUNIyFQn4aP/QUXIP9KAay5rkNKaSPKcp ZWtgph8Niy3QdLkpPq9bKJRjaDzyMBBOXGg+hYoGf6EpUhjIL302jkmisuNP7j/2 HsLYmvplhyUxiDX99owEdgnjyuDqXG6660V/mlZg7QdpTie/XeKr5Ng/GeJNDjgu 4lfMqf4lkhqXGEFuUczd3pmzTF/F907283ghmhSNwVBVJzCpq3ZLGZZchK8ApL0d XZUD7BG4eQJeJsbghQ+IXvNG26XSmzaFDDa+vtl8n2aW5kT65055fervMOFVFBaf gdf1eXhqMy59fRQu+cdpJvnIwUJwNx/io1g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduieeitdeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgesrgdtreerredt tdenucfhrhhomhepfdfguhhlvghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvg hrthhordgtohhmqeenucggtffrrghtthgvrhhnpeekheetvefggedtudevjeehjeffteeu vdfhfedtvdfgleektdfgfeektdfhheekvdenucffohhmrghinhepvghnthgvrhhprhhish gvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepvghulhgvrhesvghulhgvrhhtohdrtghomhdpnhgspghrtghpthhtohephedpmh houggvpehsmhhtphhouhhtpdhrtghpthhtohepthhhrghrrghkrghnsehgmhgrihhlrdgt ohhmpdhrtghpthhtohepthhnughrfigrnhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtoh ephhhlihhnnhgrkhgrsehikhhirdhfihdprhgtphhtthhopehpghhsqhhlqdgsuhhgshes lhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepthhglhesshhssh drphhghhdrphgrrdhush X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 065E7780068; Wed, 26 Mar 2025 12:54:27 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: T19f6e68f6dea2943 Date: Wed, 26 Mar 2025 13:51:51 -0300 From: "Euler Taveira" To: "Tom Lane" Cc: "Tender Wang" , tharakan@gmail.com, pgsql-bugs@lists.postgresql.org, "Heikki Linnakangas" Message-Id: In-Reply-To: <1618267.1743004859@sss.pgh.pa.us> References: <18866-d68926d0f1c72d44@postgresql.org> <1280897.1742920635@sss.pgh.pa.us> <1618267.1743004859@sss.pgh.pa.us> Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort Content-Type: multipart/alternative; boundary=0369cddb1d3948a88ae9f4449d79e5ec List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0369cddb1d3948a88ae9f4449d79e5ec Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Mar 26, 2025, at 1:00 PM, Tom Lane wrote: > "Euler Taveira" writes: > > Your patch needs some adjustments. There is no need to include pg_class.h. I > > don't like the proposed error message. I prefer saying the relation cannot be > > opened because that's what will happen if it reaches this code path. > > I don't care for that proposal either: we just did open the relation ;-) Fair point. > relcache.c: > elog(ERROR, "relation \"%s\" does not have storage", > RelationGetRelationName(relation)); > > So the previous proposal was evidently modeled on the first two of > these precedents. Personally I prefer messages that say *why* > something failed, so I'd go with something more like "relation \"%s\" > does not have storage". Use of errdetail_relkind_not_supported is > fine though. I thought about saying "no storage" but don't know why was convinced by that proposal. Your suggestion works for me. -- Euler Taveira EDB https://www.enterprisedb.com/ --0369cddb1d3948a88ae9f4449d79e5ec Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Wed, Mar 26,= 2025, at 1:00 PM, Tom Lane wrote:
"Euler Taveira" <euler@eulerto.com> writes:
> Your patch= needs some adjustments. There is no need to include pg_class.h. I
> don't like the proposed error message. I prefer saying the= relation cannot be
> opened because that's what will h= appen if it reaches this code path.

I don't= care for that proposal either: we just did open the relation ;-)

Fair point.

relcache.c:
        elog(ERROR, "relation \"%s\= " does not have storage",
     &n= bsp;       RelationGetRelationName(relatio= n));

So the previous proposal was evidently= modeled on the first two of
these precedents.  Perso= nally I prefer messages that say *why*
something failed, s= o I'd go with something more like "relation \"%s\"
does no= t have storage".  Use of errdetail_relkind_not_supported is
fine though.

I thought = about saying "no storage" but don't know why was convinced by that
proposal. Your suggestion works for me.


--
Eul= er Taveira
EDB   https://www.enterprisedb.com/

--0369cddb1d3948a88ae9f4449d79e5ec--