Content-Type: multipart/mixed; boundary="------------4qAb0T1bFG55FQ7NEykYge2N"
Message-ID: <d959bd09-3bce-6a5e-7ae0-dff761f8ad81@gmail.com>
Date: Mon, 10 Jun 2024 11:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #18483: Segmentation fault in tests modules
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, a.kozhemyakin@postgrespro.ru,
 pgsql-bugs@lists.postgresql.org
References: <18483-30bfff42de238000@postgresql.org>
 <Zl5GS6SHBXRAkl_c@paquier.xyz> <219049.1717792376@sss.pgh.pa.us>
 <ZmOJ3jfeltZQnN_M@paquier.xyz>
 <439c9310-1d71-f2c6-b213-a9a2ea732ba9@gmail.com>
 <336833.1717859243@sss.pgh.pa.us>
 <250a21e5-d677-6b2a-2692-cd4233785e37@gmail.com>
 <ZmaUKZOmjv-L9EvK@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <ZmaUKZOmjv-L9EvK@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/d959bd09-3bce-6a5e-7ae0-dff761f8ad81%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------4qAb0T1bFG55FQ7NEykYge2N
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello Michael,

10.06.2024 08:50, Michael Paquier wrote:
> On Sun, Jun 09, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote:
>> 2)
>> echo "
>> select test_enc_conversion('\x8bc68bcf8b', 'gb18030', 'gb18030', false);
>> " >> src/test/regress/sql/conversion.sql
>> TESTS="conversion" make -s check-tests
>>
>> produces (under Valgrind):
>> ==00:00:00:05.947 3320530== Invalid read of size 1
>> ==00:00:00:05.947 3320530==    at 0x6F21E5: pg_gb18030_mblen (wchar.c:1000)
>> ==00:00:00:05.947 3320530==    by 0x6F2BA0: pg_encoding_mblen (wchar.c:2072)
>> ==00:00:00:05.947 3320530==    by 0x6B4EAF: report_invalid_encoding (mbutils.c:1700)
>> ==00:00:00:05.947 3320530==    by 0x4867D3F: test_enc_conversion (regress.c:1154)
>> ==00:00:00:05.947 3320530==    by 0x3B9796: ExecInterpExpr (execExprInterp.c:764)
>>
>> If I understand correctly, the defect is inside test_enc_conversion(), not
>> in the core code.
> Interesting, I cannot see this one, did you use a specific option with
> valgrind?

Thanks for your interest to it!

My Valgrind-testing procedure is:
git apply .../install-vrunner.patch # use the attached
CPPFLAGS="-Og -DUSE_VALGRIND" ./configure -q && make -j8 -s

echo "
select test_enc_conversion('\x8bc68bcf8b', 'gb18030', 'gb18030', false);
" >> src/test/regress/sql/conversion.sql
TESTS="conversion" make -s check-tests

not ok 1     - conversion                               3189 ms
# (test process exited with exit code 2)

Best regards,
Alexander
--------------4qAb0T1bFG55FQ7NEykYge2N
Content-Type: text/x-patch; charset=UTF-8; name="install-vrunner.patch"
Content-Disposition: attachment; filename="install-vrunner.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2luc3RhbGwtdnJ1bm5lci5zaCBiL2luc3RhbGwtdnJ1bm5lci5zaApu
ZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMC4uMjE4ODFkNGM3MjkKLS0t
IC9kZXYvbnVsbAorKysgYi9pbnN0YWxsLXZydW5uZXIuc2gKQEAgLTAsMCArMSwzMSBAQAor
IyEvYmluL2Jhc2gKK3NldCAtZQorCitTUkNESVI9JDEKK1BHQklOPSQyCisKK2NkICRQR0JJ
TgorY3AgJFNSQ0RJUi9zcmMvdG9vbHMvdmFsZ3JpbmQuc3VwcCAuLworCitlY2hvICIiCitj
YXQgPDwgJ0VPRicgPiB2cnVubmVyCisjIS9iaW4vYmFzaAorc2V0IC1lCitCRD0iJCggY2Qg
IiQoIGRpcm5hbWUgIiR7QkFTSF9TT1VSQ0VbMF19IiApIiAmJiBwd2QgKSIKK1NOPSIkKGJh
c2VuYW1lICIke0JBU0hfU09VUkNFWzBdfSIpIgorT0JJTj0iXyRTTiIKK1tbICRMRF9QUkVM
T0FEID0gKiJ2YWxncmluZCIqIF1dICYmIGV4ZWMgJEJELyRPQklOICIkQCIKKworZXhlYyB2
YWxncmluZCAtLXF1aWV0ICAtLWV4aXQtb24tZmlyc3QtZXJyb3I9eWVzIC0tdHJhY2stb3Jp
Z2lucz1ubyAtLWVycm9yLWV4aXRjb2RlPTEgLS1sZWFrLWNoZWNrPW5vIC0tdGltZS1zdGFt
cD15ZXMgXAorIC0tZ2VuLXN1cHByZXNzaW9ucz1hbGwgLS1zdXBwcmVzc2lvbnM9JEJEL3Zh
bGdyaW5kLnN1cHAgXAorIC0tdHJhY2UtY2hpbGRyZW49eWVzIC0tdHJhY2UtY2hpbGRyZW4t
c2tpcD0iL2Jpbi8qLC91c3IvYmluLyoiIFwKKyAkQkQvJE9CSU4gIiRAIgorRU9GCitjaG1v
ZCBhK3ggdnJ1bm5lcgorCitmb3IgZiBpbiAqOyBkbworICAgIGlmIFsgIiRmIiA9ICJ2cnVu
bmVyIiBdIHx8IFsgISAteCAiJGYiIF07IHRoZW4gY29udGludWU7IGZpCisgICAgbXYgIiRm
IiAiXyRmIgorICAgIGxuIC1zIHZydW5uZXIgIiRmIgorICAgIGNobW9kIGEreCAiJGYiCitk
b25lCmRpZmYgLS1naXQgYS9zcmMvTWFrZWZpbGUuZ2xvYmFsLmluIGIvc3JjL01ha2VmaWxl
Lmdsb2JhbC5pbgppbmRleCA4ODRkNjY5MjBiNi4uODdhZjdmZDlhYjggMTAwNjQ0Ci0tLSBh
L3NyYy9NYWtlZmlsZS5nbG9iYWwuaW4KKysrIGIvc3JjL01ha2VmaWxlLmdsb2JhbC5pbgpA
QCAtNDExLDIgKzQxMSwzIEBAIGlmZXEgKCQoTUFLRUxFVkVMKSwwKQogCSQoTUFLRSkgLWox
ICQoaWYgJChDSEVDS1BSRVBfVE9QKSwtQyAkKENIRUNLUFJFUF9UT1ApLCkgY2hlY2twcmVw
ID4+JyQoYWJzX3RvcF9idWlsZGRpciknL3RtcF9pbnN0YWxsL2xvZy9pbnN0YWxsLmxvZyAy
PiYxCisJJyQoYWJzX3RvcF9idWlsZGRpciknL2luc3RhbGwtdnJ1bm5lci5zaCAnJChhYnNf
dG9wX2J1aWxkZGlyKScgJyQoYWJzX3RvcF9idWlsZGRpcikvdG1wX2luc3RhbGwkKGJpbmRp
ciknCiAKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfY3RsL3BnX2N0bC5jIGIvc3JjL2Jpbi9w
Z19jdGwvcGdfY3RsLmMKaW5kZXggN2Y0MjdlN2Q2MGUuLmU2MTE1ODgxZjZiIDEwMDY0NAot
LS0gYS9zcmMvYmluL3BnX2N0bC9wZ19jdGwuYworKysgYi9zcmMvYmluL3BnX2N0bC9wZ19j
dGwuYwpAQCAtNjIwLDEyICs2MjAsNyBAQCB3YWl0X2Zvcl9wb3N0bWFzdGVyKHBncGlkX3Qg
cG1fcGlkLCBib29sIGRvX2NoZWNrcG9pbnQpCiAJCQlwbXBpZCA9IGF0b2wob3B0bGluZXNb
TE9DS19GSUxFX0xJTkVfUElEIC0gMV0pOwogCQkJcG1zdGFydCA9IGF0b2wob3B0bGluZXNb
TE9DS19GSUxFX0xJTkVfU1RBUlRfVElNRSAtIDFdKTsKIAkJCWlmIChwbXN0YXJ0ID49IHN0
YXJ0X3RpbWUgLSAyICYmCi0jaWZuZGVmIFdJTjMyCi0JCQkJcG1waWQgPT0gcG1fcGlkCi0j
ZWxzZQotCQkJLyogV2luZG93cyBjYW4gb25seSByZWplY3Qgc3RhbmRhbG9uZS1iYWNrZW5k
IFBJRHMgKi8KLQkJCQlwbXBpZCA+IDAKLSNlbmRpZgorCQkJCXBtcGlkID09IHBtX3BpZCAg
JiYga2lsbChwbXBpZCwgMCkgPT0gMAogCQkJCSkKIAkJCXsKIAkJCQkvKgo=

--------------4qAb0T1bFG55FQ7NEykYge2N--