Content-Type: multipart/mixed; boundary="------------ZW41uSs0HHmEXaP0VbN8aPGd"
Message-ID: <d9e1c765-7f83-4015-ade3-16506854d0b1@postgrespro.ru>
Date: Thu, 22 May 2025 16:29:37 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Standby server with cascade logical replication could not be
 properly stopped under load
To: shveta malik <shveta.malik@gmail.com>,
 "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
 Ajin Cherian <itsajin@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
References: <52138028-7246-421c-9161-4fa108b88070@postgrespro.ru>
 <CAJpy0uA9kw9WLWETPg+upwzBu145vMB7sPZwBuR_vDrbazeuag@mail.gmail.com>
Content-Language: en-US
From: Alexey Makhmutov <a.makhmutov@postgrespro.ru>
In-Reply-To: 
 <CAJpy0uA9kw9WLWETPg+upwzBu145vMB7sPZwBuR_vDrbazeuag@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/d9e1c765-7f83-4015-ade3-16506854d0b1%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------ZW41uSs0HHmEXaP0VbN8aPGd
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ajin and Shveta, thank you for looking at this issue.

On 5/22/25 12:48, Ajin Cherian wrote:

> Just a small comment: can you explicitly mention in the comments that
> "for logical replication we can only send records that have already
> been replayed else we might get stuck in shutdown" or something to
> that effect as that distinction is important for future developers in
> this area.

Thank you. I've expanded the comment to make it more verbose to clarify 
expected logic in this case.
Updated patch is attached as 
'0001-Use-only-replayed-position-as-target-flush-point-2.patch'.

Thanks,
Alexey

--------------ZW41uSs0HHmEXaP0VbN8aPGd
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Use-only-replayed-position-as-target-flush-point-2.patch"
Content-Disposition: attachment;
 filename*0="0001-Use-only-replayed-position-as-target-flush-point-2.patc";
 filename*1="h"
Content-Transfer-Encoding: base64

RnJvbSAxMmY5OGFhZGI1YTQyM2IxN2I0MWU2NWQzNmM4MDM1NWJlMWJlYjYxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4ZXkgTWFraG11dG92IDxhLm1ha2htdXRvdkBw
b3N0Z3Jlc3Byby5ydT4KRGF0ZTogVGh1LCAyMiBNYXkgMjAyNSAwNDowMjo1MCArMDMwMApT
dWJqZWN0OiBbUEFUQ0hdIFVzZSBvbmx5IHJlcGxheWVkIHBvc2l0aW9uIGFzIHRhcmdldCBm
bHVzaCBwb2ludCBmb3IgbG9naWNhbAogcmVwbGljYXRpb24KCkZvciBwaHlzaWNhbCB3YWxz
ZW5kZXIgdGhlIEdldFN0YW5kYnlGbHVzaFJlY1B0ciBmdW5jdGlvbiByZXR1cm5zIHBvc2l0
aW9uCm9mIHRoZSBsYXRlc3Qgc3RvcmVkIFdBTCByZWNvcmQsIGFzIHdlIGNhbiBzdHJlYW0g
ZGF0YSB0byBkb3duc3RyZWFtIGluc3RhbmNlCndpdGhvdXQgd2FpdGluZyBmb3IgaXQgYmVp
bmcgbG9jYWxseSBhcHBsaWVkLiBIb3dldmVyLCBmb3IgbG9naWNhbCByZXBsaWNhdGlvbgp3
ZSBjYW4gc2VudCBkYXRhIHRvIGRvd25zdHJlYW0gY2xpZW50IG9ubHkgdXAgdG8gdGhlIGxv
Y2FsbHkgYXBwbGllZCBwb3NpdGlvbi4KVGhpcyBkaXN0aW5jdGlvbiBpcyBpbXBvcnRhbnQg
d2hlbiB3ZSBkZWNpZGUgd2hldGhlciB3YWxzZW5kZXIgaGFzIHNlbnQgYWxsIHRoZQphdmFp
bGFibGUgZGF0YSB0byBjbGllbnQgKCdjYXVnaHQgdXAnKS4gRHVyaW5nIHRoZSBzaHV0ZG93
biBwcm9jZXNzIHdhbHNlbmRlcgpiYWNrZW5kcyBhcmUgYWxsb3dlZCB0byB3b3JrIHVudGls
IHRoZXkgcmVhY2ggdGhlICdjYXVnaHQgdXAnIHN0YXRlLCB3aGlsZQpyZWNvdmVyeSBwcm9j
ZXNzIGlzIGFscmVhZHkgZGVhY3RpdmF0ZWQsIHNvIHRoZSBhcHBsaWVkIHBvc2l0aW9uIHdv
bid0IGJlCm1vdmluZy4gSW4gdGhpcyBjYXNlIHdhbHNlbmRlciBmb3IgbG9naWNhbCByZXBs
aWNhdGlvbiBzaG91bGQgd29yayBvbmx5IHVudGlsCml0IGNhdWdodCB1cCB3aXRoIHRoZSBs
YXRlc3QgYXBwbGllZCByZWNvcmQsIG90aGVyd2lzZSBpdCB3aWxsIHN0dWNrIGluIHRoZQpp
bmZpbml0ZSBsb29wIGFuZCBpbmhpYml0IGluc3RhbmNlIHNodXRkb3duLgotLS0KIHNyYy9i
YWNrZW5kL3JlcGxpY2F0aW9uL3dhbHNlbmRlci5jIHwgMzYgKysrKysrKysrKysrKysrKysr
LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNCBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxzZW5k
ZXIuYyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHNlbmRlci5jCmluZGV4IDlmYThi
ZWI2MTAzLi4zYzQ4MGQwMjM5MyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcmVwbGljYXRp
b24vd2Fsc2VuZGVyLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vd2Fsc2VuZGVy
LmMKQEAgLTM1MzIsMjkgKzM1MzIsMzcgQEAgV2FsU25kRG9uZShXYWxTbmRTZW5kRGF0YUNh
bGxiYWNrIHNlbmRfZGF0YSkKIFhMb2dSZWNQdHIKIEdldFN0YW5kYnlGbHVzaFJlY1B0cihU
aW1lTGluZUlEICp0bGkpCiB7Ci0JWExvZ1JlY1B0cglyZXBsYXlQdHI7CiAJVGltZUxpbmVJ
RAlyZXBsYXlUTEk7Ci0JWExvZ1JlY1B0cglyZWNlaXZlUHRyOwotCVRpbWVMaW5lSUQJcmVj
ZWl2ZVRMSTsKIAlYTG9nUmVjUHRyCXJlc3VsdDsKIAogCUFzc2VydChhbV9jYXNjYWRpbmdf
d2Fsc2VuZGVyIHx8IElzU3luY2luZ1JlcGxpY2F0aW9uU2xvdHMoKSk7CiAKLQkvKgotCSAq
IFdlIGNhbiBzYWZlbHkgc2VuZCB3aGF0J3MgYWxyZWFkeSBiZWVuIHJlcGxheWVkLiBBbHNv
LCBpZiB3YWxyZWNlaXZlcgotCSAqIGlzIHN0cmVhbWluZyBXQUwgZnJvbSB0aGUgc2FtZSB0
aW1lbGluZSwgd2UgY2FuIHNlbmQgYW55dGhpbmcgdGhhdCBpdAotCSAqIGhhcyBzdHJlYW1l
ZCwgYnV0IGhhc24ndCBiZWVuIHJlcGxheWVkIHlldC4KLQkgKi8KLQotCXJlY2VpdmVQdHIg
PSBHZXRXYWxSY3ZGbHVzaFJlY1B0cihOVUxMLCAmcmVjZWl2ZVRMSSk7Ci0JcmVwbGF5UHRy
ID0gR2V0WExvZ1JlcGxheVJlY1B0cigmcmVwbGF5VExJKTsKKwlyZXN1bHQgPSBHZXRYTG9n
UmVwbGF5UmVjUHRyKCZyZXBsYXlUTEkpOwogCiAJaWYgKHRsaSkKIAkJKnRsaSA9IHJlcGxh
eVRMSTsKIAotCXJlc3VsdCA9IHJlcGxheVB0cjsKLQlpZiAocmVjZWl2ZVRMSSA9PSByZXBs
YXlUTEkgJiYgcmVjZWl2ZVB0ciA+IHJlcGxheVB0cikKLQkJcmVzdWx0ID0gcmVjZWl2ZVB0
cjsKKwkvKgorCSAqIEZvciBwaHlzaWNhbCByZXBsaWNhdGlvbiB3ZSBjYW4gc2VuZCBkb3du
c3RyZWFtIGFueXRoaW5nIHRoYXQgaGFzCisJICogYWxyZWFkeSBiZWVuIHJlY2VpdmVkIGlm
IHdhbHJlY2VpdmVyIGlzIHN0cmVhbWluZyBXQUwgZnJvbSB0aGUgc2FtZQorCSAqIHRpbWVs
aW5lLiBUaGlzIGlzIGFsc28gdHJ1ZSBpZiB0aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCBmcm9t
IHNsb3QKKwkgKiBzeW5jaHJvbml6YXRpb24gcm91dGluZXMgKE15V2FsU25kIGlzIE5VTEwg
aW4gc3VjaCBjYXNlKSwgc2luY2UgdGhleQorCSAqIGFsc28gb25seSB0cmFjayB0aGUgcGh5
c2ljYWxseSBmbHVzaGVkIHBvc2l0aW9uLiBIb3dldmVyLCBmb3IgbG9naWNhbAorCSAqIHJl
cGxpY2F0aW9uIHRoZSBzaXR1YXRpb24gaXMgZGlmZmVyZW50IGFuZCB3ZSBjYW4gb25seSBk
ZWNvZGUgYW5kIHNlbmQKKwkgKiBkb3duc3RyZWFtIGRhdGEgdGhhdCBoYXMgYWxyZWFkeSBi
ZWVuIGFwcGxpZWQgdG8gdGhlIGN1cnJlbnQgaW5zdGFuY2UuCisJICogVGhpcyBkaXN0aW5j
dGlvbiBpcyBlc3BlY2lhbGx5IGltcG9ydGFudCBkdXJpbmcgc2h1dGRvd24sIGFzIHdhbHNl
bmRlcgorCSAqIGlzIGFsbG93ZWQgdG8gY29udGludWUgaXRzIHdvcmsgdW50aWwgZGF0YSBp
cyBzZW50IHRvIHRoZSBjbGllbnQgdXAgdG8KKwkgKiB0aGUgZmx1c2ggcG9pbnQsIHNvIGl0
IGNhbiBnZXQgc3R1Y2sgaWYgd2UgcmV0dXJuIHN0b3JlZCByYXRoZXIgdGhhbgorCSAqIHJl
cGxheWVkIGRhdGEgcG9zaXRpb24uCisJICovCisJaWYgKCFNeVdhbFNuZCB8fCBNeVdhbFNu
ZC0+a2luZCA9PSBSRVBMSUNBVElPTl9LSU5EX1BIWVNJQ0FMKQorCXsKKwkJVGltZUxpbmVJ
RAlyZWNlaXZlVExJOworCQlYTG9nUmVjUHRyCXJlY2VpdmVQdHIgPSBHZXRXYWxSY3ZGbHVz
aFJlY1B0cihOVUxMLCAmcmVjZWl2ZVRMSSk7CisKKwkJaWYgKHJlY2VpdmVUTEkgPT0gcmVw
bGF5VExJICYmIHJlY2VpdmVQdHIgPiByZXN1bHQpCisJCQlyZXN1bHQgPSByZWNlaXZlUHRy
OworCX0KIAogCXJldHVybiByZXN1bHQ7CiB9Ci0tIAoyLjQ5LjAKCg==

--------------ZW41uSs0HHmEXaP0VbN8aPGd--