Message-ID: <dac9094eac03d8eaff9e310aba336ec01fa3cf47.camel@j-davis.com>
Subject: Re: Error when setting default_text_search_config
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Erik Wienhold <ewie@ewie.name>
Cc: Murat =?UTF-8?Q?Efendio=C4=9Flu?= <mrtdmrts001@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Date: Sun, 06 Oct 2024 14:51:17 -0700
In-Reply-To: <1381066.1728239990@sss.pgh.pa.us>
References: 
	<CACbCzujQ4zS8MM1bx-==+tr+D3Hk5G1cjN4XkUQ+Q=cEpwhzqg@mail.gmail.com>
	 <26c28873-85ca-4360-a5e9-1cc691a05451@ewie.name>
	 <9c480df9-720b-4419-85c6-09113f5d6f0a@ewie.name>
	 <1381066.1728239990@sss.pgh.pa.us>
Content-Type: multipart/mixed; boundary="=-JOcYR3QE2Omcu11YJX72"
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/dac9094eac03d8eaff9e310aba336ec01fa3cf47.camel%40j-davis.com>
Precedence: bulk

--=-JOcYR3QE2Omcu11YJX72
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2024-10-06 at 14:39 -0400, Tom Lane wrote:
> I suppose we could just move the InitializeSearchPath call up
> a bit (the comments in postinit.c are misleading about what it
> actually does), but I wonder whether the cache-is-valid assumptions
> in namespace.c ought to be rethought.=C2=A0 It seems unduly fragile
> as-is.

I attached a patch which fixes the observed problem and is hopefully
more robust to similar issues.

The test for use_cache in check_search_path() is also somewhat
indirect. The goal there is to avoid calling GetUserId() before
CurrentUserId is valid, but that could probably be solved other ways or
commented better. I will look into it.

Regards,
	Jeff Davis


--=-JOcYR3QE2Omcu11YJX72
Content-Disposition: attachment;
 filename="v1-0001-Fix-search_path-cache-approach-2.patch"
Content-Type: text/x-patch;
 name="v1-0001-Fix-search_path-cache-approach-2.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSBkZjQxNTE0NTQwOGY5ODM1NDYxOGZlOTUwZTQyZWIwM2EzZTA1NTIzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBT
dW4sIDYgT2N0IDIwMjQgMTM6NDA6MzEgLTA3MDAKU3ViamVjdDogW1BBVENIIHYxXSBGaXggc2Vh
cmNoX3BhdGggY2FjaGUgYXBwcm9hY2ggMi4KCi0tLQogc3JjL2JhY2tlbmQvY2F0YWxvZy9uYW1l
c3BhY2UuYyB8IDMwICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5n
ZWQsIDIwIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9i
YWNrZW5kL2NhdGFsb2cvbmFtZXNwYWNlLmMgYi9zcmMvYmFja2VuZC9jYXRhbG9nL25hbWVzcGFj
ZS5jCmluZGV4IDQzYjcwNzY5OWQuLmNlZWQ3ZWI3MGMgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5k
L2NhdGFsb2cvbmFtZXNwYWNlLmMKKysrIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9uYW1lc3BhY2Uu
YwpAQCAtMzA1LDE3ICszMDUsMzIgQEAgc3RhdGljIFNlYXJjaFBhdGhDYWNoZUVudHJ5ICpMYXN0
U2VhcmNoUGF0aENhY2hlRW50cnkgPSBOVUxMOwogc3RhdGljIHZvaWQKIHNwY2FjaGVfaW5pdCh2
b2lkKQogewotCUFzc2VydChTZWFyY2hQYXRoQ2FjaGVDb250ZXh0KTsKLQotCWlmIChTZWFyY2hQ
YXRoQ2FjaGUgJiYgc2VhcmNoUGF0aENhY2hlVmFsaWQgJiYKKwlpZiAoc2VhcmNoUGF0aENhY2hl
VmFsaWQgJiYKIAkJU2VhcmNoUGF0aENhY2hlLT5tZW1iZXJzIDwgU1BDQUNIRV9SRVNFVF9USFJF
U0hPTEQpCiAJCXJldHVybjsKIAotCS8qIG1ha2Ugc3VyZSB3ZSBkb24ndCBsZWF2ZSBkYW5nbGlu
ZyBwb2ludGVycyBpZiBuc3BoYXNoX2NyZWF0ZSBmYWlscyAqLworCXNlYXJjaFBhdGhDYWNoZVZh
bGlkID0gZmFsc2U7CisJYmFzZVNlYXJjaFBhdGhWYWxpZCA9IGZhbHNlOworCisJLyoKKwkgKiBN
YWtlIHN1cmUgd2UgZG9uJ3QgbGVhdmUgZGFuZ2xpbmcgcG9pbnRlcnMgaWYgYSBmYWlsdXJlIGhh
cHBlbnMgZHVyaW5nCisJICogaW5pdGlhbGl6YXRpb24uCisJICovCiAJU2VhcmNoUGF0aENhY2hl
ID0gTlVMTDsKIAlMYXN0U2VhcmNoUGF0aENhY2hlRW50cnkgPSBOVUxMOwogCi0JTWVtb3J5Q29u
dGV4dFJlc2V0KFNlYXJjaFBhdGhDYWNoZUNvbnRleHQpOworCWlmIChTZWFyY2hQYXRoQ2FjaGVD
b250ZXh0ID09IE5VTEwpCisJeworCQkvKiBNYWtlIHRoZSBjb250ZXh0IHdlJ2xsIGtlZXAgc2Vh
cmNoIHBhdGggY2FjaGUgaGFzaHRhYmxlIGluICovCisJCVNlYXJjaFBhdGhDYWNoZUNvbnRleHQg
PSBBbGxvY1NldENvbnRleHRDcmVhdGUoVG9wTWVtb3J5Q29udGV4dCwKKwkJCQkJCQkJCQkJCQkg
ICAic2VhcmNoX3BhdGggcHJvY2Vzc2luZyBjYWNoZSIsCisJCQkJCQkJCQkJCQkJICAgQUxMT0NT
RVRfREVGQVVMVF9TSVpFUyk7CisJfQorCWVsc2UKKwl7CisJCU1lbW9yeUNvbnRleHRSZXNldChT
ZWFyY2hQYXRoQ2FjaGVDb250ZXh0KTsKKwl9CisKIAkvKiBhcmJpdHJhcnkgaW5pdGlhbCBzdGFy
dGluZyBzaXplIG9mIDE2IGVsZW1lbnRzICovCiAJU2VhcmNoUGF0aENhY2hlID0gbnNwaGFzaF9j
cmVhdGUoU2VhcmNoUGF0aENhY2hlQ29udGV4dCwgMTYsIE5VTEwpOwogCXNlYXJjaFBhdGhDYWNo
ZVZhbGlkID0gdHJ1ZTsKQEAgLTQ3NDIsMTEgKzQ3NTcsNiBAQCBJbml0aWFsaXplU2VhcmNoUGF0
aCh2b2lkKQogCX0KIAllbHNlCiAJewotCQkvKiBNYWtlIHRoZSBjb250ZXh0IHdlJ2xsIGtlZXAg
c2VhcmNoIHBhdGggY2FjaGUgaGFzaHRhYmxlIGluICovCi0JCVNlYXJjaFBhdGhDYWNoZUNvbnRl
eHQgPSBBbGxvY1NldENvbnRleHRDcmVhdGUoVG9wTWVtb3J5Q29udGV4dCwKLQkJCQkJCQkJCQkJ
CQkgICAic2VhcmNoX3BhdGggcHJvY2Vzc2luZyBjYWNoZSIsCi0JCQkJCQkJCQkJCQkJICAgQUxM
T0NTRVRfREVGQVVMVF9TSVpFUyk7Ci0KIAkJLyoKIAkJICogSW4gbm9ybWFsIG1vZGUsIGFycmFu
Z2UgZm9yIGEgY2FsbGJhY2sgb24gYW55IHN5c2NhY2hlIGludmFsaWRhdGlvbgogCQkgKiB0aGF0
IHdpbGwgYWZmZWN0IHRoZSBzZWFyY2hfcGF0aCBjYWNoZS4KLS0gCjIuMzQuMQoK


--=-JOcYR3QE2Omcu11YJX72--