Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sNPpz-008VkE-BA for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Jun 2024 04:37:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sNPpx-0082Ug-Go for pgsql-bugs@arkaria.postgresql.org; Sat, 29 Jun 2024 04:37:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sNPpx-0082UX-8P for pgsql-bugs@lists.postgresql.org; Sat, 29 Jun 2024 04:37:21 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sNPpu-003enG-Kr for pgsql-bugs@lists.postgresql.org; Sat, 29 Jun 2024 04:37:20 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a729da840a8so385116166b.1 for ; Fri, 28 Jun 2024 21:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20230601.gappssmtp.com; s=20230601; t=1719635836; x=1720240636; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=WH5wYrpWFjyFhNy6jKf0Dpeqg3lBD2uWgc+9Uv1P9m0=; b=NTVin+FCedFzPXJQT9bUnwJuQ4CxL+Tvxdikro1B2WcLbElnVmkyLTGy/NHLF73JQZ odEqDn1QUNAFxJklF8fYAcUZX1fQjUuzxS5DjJcUSDqgqcQoNt6ENa+f258la9LD5ZHL JqiDTFjncut9XiftMTHBmRMzlT8tM09K94/riJcuWm9UZx0zH71H2EcV+8jg//475J81 gvHBUt6ZJBp6LMha6gSx2k1RLk59gZO7pF5czipFPPjnkPUnl19lMXr+8fxrAaOuZoQo lpPh3FDXYKnGDXQgnWyVovrkGvp277KBkEVTzE+6v5JE7CkFUhGa1y8v1FqMSxk926yr rwyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719635836; x=1720240636; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WH5wYrpWFjyFhNy6jKf0Dpeqg3lBD2uWgc+9Uv1P9m0=; b=GtaV+QE13gjc1ruakorIMG4fzAzbJaFBvRbk3NXNXWQ6sBG4ba22ZPTek0PeTioB2w 6ZUIOEbbZjzYeppqkJQ8eKmsM9FM5eLSbMFn3XNxcBTpV5HcIzBO4oVgpckdhf7PrH6s YcY8Nj0H+D5JQTW5cggRqXe2NXDnEFc+EQz3NBoc8+4SS4Zr2q1FAYcJwGZ18B3iXICK dAAJBJHKjKnQDxgs0vHW0tPrgv+D0sacVcFzuoaXBfYHMDtKfSJU9/mmekgZ5UZW+zBY v6eqqpV+zszRmYZQpymkZsV7PMcRRKMVNabVxOW9vWvKFiRzirRRJBcvfyLTUtFy/i4X JETA== X-Forwarded-Encrypted: i=1; AJvYcCVGVDhQx6dhcBdCXqUqcg75Gi18aTLTFO5YnQe3AGZ0pz0qXeWYVYXNfidYdAgN7nlhu9WnikONiBYbPQycKN9BhVylgnsHQzONjhHHXxqD X-Gm-Message-State: AOJu0Yxi+lrx1y1hSEf5Mjn3ISDZZ5gG6MbnzxZVMYs03D92++2lw3tJ 2bEvWFgNxQHxDvyYE8Zde/c8xGAQQ3FvLnYdZiTaaTBieWphxity0qggCgnmmug= X-Google-Smtp-Source: AGHT+IEhSCVoTSHuuIyHZsoCRIYsGKNnEry0MSR0frB2aWe4JED7YyCG8PtDViiEpwrukHFhkHNW+g== X-Received: by 2002:a17:906:da85:b0:a6f:6337:1ad5 with SMTP id a640c23a62f3a-a7513935c1amr20671766b.27.1719635835263; Fri, 28 Jun 2024 21:37:15 -0700 (PDT) Received: from localhost.localdomain ([41.66.99.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab065292sm132280366b.122.2024.06.28.21.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 21:37:14 -0700 (PDT) Message-ID: Subject: Re: BUG #18500: Detaching a partition with an index manually attached to the parent's index triggers Assert From: Laurenz Albe To: Michael Paquier , Alvaro Herrera Cc: Tender Wang , exclusion@gmail.com, pgsql-bugs@lists.postgresql.org Date: Sat, 29 Jun 2024 06:37:12 +0200 In-Reply-To: References: <202406281127.piekjwgnulgf@alvherre.pgsql> Autocrypt: addr=laurenz.albe@cybertec.at; prefer-encrypt=mutual; keydata=mQINBGGDwAQBEADgbWy5cKXQld3N2mF+DFyiNFbi2oBl2T+XgxpPF8wTRw2D/u4bBKXP0SYSE/lA86jIVNWWU0gf1KODIkVvgJm2w4vH2VBV1b7ddVViGl1Iu+9zaRnv9wulhnH42KefepXnoean6UT1EzLM0opF/Ik0j+40TxdRtobkBprkQUyHDXWlHc2ffPs3SipyFEP9AVLf7ejRC46CXWDnsqjOBSMEW8Z4HiK/8RrPZBsKLts8dJxKF4pygOdJb0CWk8k/X1jbcfdxo+zOLjOMvJcSJ2pFdJmQHU+JufB3rePziqQ2S9Ur6sccr9XnTC1GVBWN4Lf5VHq+vf+bFJjVwg+2hrySZnAVfcOrxoqFLErr7ug1zN2nM1kcpgA4VWn4gxlJtYNYYq+9WxX5dtvnNANlG3ZCrRKQzl8lxtzoF6Zo7LUhEqPaHDwn7Rvs+IdbOn41lF5UDTJGqmC4gS/bZydW2Fy3YWm4aSaN9fgFf8D+PVkrlKAZB7gBLz1TyHjbcRf85cYF+GKKrDld5SzMB/V60VX3oP/Eo8ikFpyWaqiz1f9X7MBot3/PjJkY+wDzp3nmb19QEcOBuQiSQ4xds2r0HewbuHTAR68u8jNNMGmpm2j4x+g09Jd/WQDjqlTBZ/jEltH41fYCCPWMfljXTOOXu2eLNGdfi7ETZogtwjM9oTtSPQARAQABtCdMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5hdD6JAk4EEwEIADgWIQR0CqhbZGGABqoaSbdi8bhXA2EdmAUCYYPABAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBi8bhXA2EdmM/6EADK232JCwmBzhlj8h7U9CjG6kx0JHP3uJGv+XfsHtHAlmY/RCwF1BHMEsRlk bT5UrLvJ2jb99bA9QARzhFaxzyn0F/BUKzuIjRGNs/n6d5dNUFA0kOt8sX+TacmC GEyjEBCrVCm4ranBiUyePn9NhHNWnaex7pJyqvMLLdwW9BEMJx0Fqo+DN8ukbXmYRsmhEtd3ue+x/luYmOmJnaGtzInaY5aOJYbW9XqoRIZkZvOCgbi1FfvNmoqWa+3oVxTOgw9RafjJDyW0lTHzKGjbGI5ofMU98l+/hKJFYJqWUF6VpFJY5YIcN/1lf4ZICMwDl+MPIVo/tpq8L10seJL28nLlvw3K+cI+TVW8IW/qL/LyVoDofI3USeOORuYmhpWRhik8JXX6xf3v6GrRilJIPWNFIJbxm1ZblQiQnOw3IOW7T+8nAmPin1HKqM3VrOrJQ2VtShsefNBibNAsr1oFaqcDBkn3yGG8i6CTW+FyO4PZ+/EwNxMVgktxbYdy5AT1/lpXr5tB+phhLIyVfiBvrWs5EThxYMQ/L8Y85c3GMsAy1l/x4h3jqySIYy3SCU9+jc5UVuNnXljbvkEzJ+NLWJ6C1rACFWrMszgPdh5tCrlRY9PpmYll4JbCgb8BtxEIUmR+xr50/ZElEK5iml7Q00KUekCcDt+36PsyGFTXBzNOrkCDQRhg8AEARAAzOZ2tLHlI4rrhG411h6cdCFjBZxuljaFCxFyHn3m6wbGLqwBUWC5k8UrRqjHMz88KcTSaNO7XGAmCqPdWd2SeflPZRnNTbjsVpw7mLdffsBm4JX7kki2Pvk5h0NtYeidXT1PSpc2ri4DutYXuT9uD8RAm1wUDCE5HQNUihT/WH6opt+hskHW21uHao0+y822tG0QQcGMqdQR5Vxdxj89wiEPdqW+HpU/oOZIhrf2E7prduAppxixjHy/o1rcnoznnJvc8D3+YgI9O0LrBMij89dM55pRGbLovTR1oGR3U74sX774+0xmSzeIKwZfiMUz7Atlvfk5SHOsRUFPN2Ux9kaXiiBibQpHFxt7b lDrT4wxdLJ/XCdbPPAyl+lZtOLsaHEEZvYNyTXwZc35dVf3R4/oz20HoG6s7ct8e1 AQygj43XAERzty9SkWgxs8+grp1PrGx6FHVSYRqBM8dS/ZR6yRVwOwJXPyaSSqfIF21DkE4j1y4n+ItSewPGoRp8K/yWCikt6qlkVkO2ASNIiX04fAbtzwVOaNn8ZMRNqyvLc1fED4sr49onE4cAIcBLjcC3KL+w9DUGRQCdziROj5H2Yl/sXGPdMciUHo/Uz2rggc+2th3bQiMhrHWSsBpUkDQp0yWewemstPpPgBL3h2fHKaX8B9oH5Qu/H1IgrOuX8AEQEAAYkCNgQYAQgAIBYhBHQKqFtkYYAGqhpJt2LxuFcDYR2YBQJhg8AEAhsMAAoJEGLxuFcDYR2YuPwQAMkpGtR80pQ1gVsONhdkqj0H2eU66efP/gO3CoyaoIcvrpKYj7C2HipVSmkt1gpByL0X4AMQ/vKuknUz3wd28Ba+G1dCfbVs/Xiusq+SmpUj5rTwmYqdSjWMuCo1R6oS5hdJMdUUJYGMT0QkVlm1KnW8jkmCTl9GzjDxOAsN9O6/6lPzaGFtk9XF+34Bry/N4HKiJkqpC4+UTd0AprPfzJ2jdT64e1F0+W88X8y1bTTgNrHwK4mDiLnlE4SKRuEm54lNhJz//ar86Or5BErzNpM6TL7lk44QS06hwsMrEdKIy8J/SYJPjfzR8tIUnKscclVpOgjKaBqC+0iFiVaRqAgfOlIEiezX6kMh5Q2FIUfqs46qWhhXjRrdKOEoStYAaikdLu5ZXr7vfb0ZaDh+ZwTQtbSMFolyOkecwI81MCdbMfT/1TqIGTOdAj5as9fAakk0jb2pXgUYQ8X1DVTR8ahSDVEaw9VTmWiSvTxvguVJ1Mb7gG4Gmh6aviDTJhfXtH4rPUNXhDLqrTH8JkJjyKROOMakIF68Hjse5vUfUxreBEOtb5r1Coa2Fe7ncJayaSE7ryrDbFqpZ 36UMAx4ulWMyqJajLNGY0DdG8qIsR5nxRhrnK/mrCidZ8F9/D3bWAl4rjtHlsztN59 +AnW5l0HsQcY9ntFL/zEBOaonjdJf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, 2024-06-29 at 09:15 +0900, Michael Paquier wrote: > > Here's a proposed patch for master only.=C2=A0 It turns all three situa= tions > > being reported into ereport(ERROR); in one case I have an XXX comment, > > because we have an alternative when attaching a partition that already > > has a PK to a partitioned table that has a non-PK index: just create a > > separate index in the partition.=C2=A0 But that would cause slowness, w= hich > > is probably undesirable.=C2=A0 I'm inclined to just remove the XXX comm= ent, > > but if anyone has other thoughts, they are welcome. >=20 > An error sounds saner here in the long term. >=20 > Tests for all of the code paths involved, perhaps?=C2=A0 ;) My example that triggered this assert runs just fine on v16. So while an error is clearly better than a crash, that would constitute a regression. Is that really unavoidable? It would be very unfortunate if the only way to detach a partition would be to drop some indexes first..= . Yours, Laurenz Albe