Feedback-ID: ie0a040ee:Fastmail
Message-ID: <dec2bd5b-66e3-4750-83ef-e597d539c2f4@eisentraut.org>
Date: Wed, 20 Nov 2024 09:35:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
To: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sam James <sam@gentoo.org>, pgsql-bugs@lists.postgresql.org
References: <87o72eo9iu.fsf@gentoo.org> <3073930.1731867112@sss.pgh.pa.us>
 <CA+hUKGJsuBiBcYnmJhGUNEg6Ud3n+C3K8c6em6RTOgu1E-dbwg@mail.gmail.com>
 <3160019.1731875201@sss.pgh.pa.us>
 <CA+hUKGLJnhpJBrsutH2aK91ARMS+XCez5P8XrR-kwdfSyLXGiQ@mail.gmail.com>
 <3169079.1731880169@sss.pgh.pa.us>
 <CA+hUKGJEnmapE7YYEfdJYZ-yGmcDpVGRrQ_eEVdcux26ZNJq_g@mail.gmail.com>
 <3175762.1731883847@sss.pgh.pa.us>
 <CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/dec2bd5b-66e3-4750-83ef-e597d539c2f4%40eisentraut.org>
Precedence: bulk

On 18.11.24 02:30, Thomas Munro wrote:
> On Mon, Nov 18, 2024 at 11:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Thomas Munro <thomas.munro@gmail.com> writes:
>>> It sounds like we should stop using the old and broken
>>> AC_CHECK_HEADER_STDBOOL macro.
>>
>> Yeah, that's what I was imagining: assume that <stdbool.h> exists
>> and works, and check only to see if sizeof(bool) is acceptable.
> 
> I think this is the minimal change, which I'd push back to 13 post-freeze.

Note that if we backpatch C23 support, we also need to backpatch at 
least commits a67a49648d9 and d2b4b4c2259.