Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uP9tO-001Y5r-RF for pgsql-bugs@arkaria.postgresql.org; Wed, 11 Jun 2025 01:04:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uP9tL-00CnNF-D2 for pgsql-bugs@arkaria.postgresql.org; Wed, 11 Jun 2025 01:04:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uP9tL-00CnN7-4M for pgsql-bugs@lists.postgresql.org; Wed, 11 Jun 2025 01:04:35 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uP9tI-001Kel-28 for pgsql-bugs@lists.postgresql.org; Wed, 11 Jun 2025 01:04:35 +0000 Received: from [192.168.11.2] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133]) by oss.nttdata.com (Postfix) with ESMTPSA id 8E00560716; Wed, 11 Jun 2025 10:04:25 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------q92tCXj7kFKgTh0Hp40reqY4" Message-ID: Date: Wed, 11 Jun 2025 10:04:24 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #18952: pg_restore --help and document have strange description: Dump something Content-Language: en-US To: harukat@sraoss.co.jp, pgsql-bugs@lists.postgresql.org References: <18952-be40a620f8b1e755@postgresql.org> From: Fujii Masao In-Reply-To: <18952-be40a620f8b1e755@postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------q92tCXj7kFKgTh0Hp40reqY4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/06/10 16:35, PG Bug reporting form wrote: > The following bug has been logged on the website: > > Bug reference: 18952 > Logged by: TAKATSUKA Haruka > Email address: harukat@sraoss.co.jp > PostgreSQL version: 18beta1 > Operating system: any > Description: > > pg_restore --help has strange description like "Dump .....": > [dbhost]$ LANG=C pg_restore --help > pg_restore restores PostgreSQL databases from archives created by pg_dump or > pg_dumpall. > Usage: > pg_restore [OPTION]... [FILE] > (snip) > --with-data dump the data > --with-schema dump the schema > --with-statistics dump the statistics > Connection options: > -h, --host=HOSTNAME database server host or socket directory > (snip) > https://www.postgresql.org/docs/18/app-pgrestore.html also have the > following description. > --with-data > Dump data. This is the default. > --with-schema > Dump schema (data definitions). This is the default. > --with-statistics > Dump statistics. This is the default. Thanks for the report! Are you suggesting that "dump" in the help message and docs should be "restore"? If so, does the attached patch address that correctly? Regards, -- Fujii Masao NTT DATA Japan Corporation --------------q92tCXj7kFKgTh0Hp40reqY4 Content-Type: text/plain; charset=UTF-8; name="v1-0001-pg_restore-Fix-wrong-descriptions-of-with-schema-.patch" Content-Disposition: attachment; filename*0="v1-0001-pg_restore-Fix-wrong-descriptions-of-with-schema-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0MmQ3OTZiMmRmYTA5YzRmNDU1MDJjODA0Zjc5MzkzMzFkMjg1YWY4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IFdlZCwgMTEgSnVuIDIwMjUgMDk6NTM6MTQgKzA5MDAKU3ViamVjdDogW1BB VENIIHYxXSBwZ19yZXN0b3JlOiBGaXggd3JvbmcgZGVzY3JpcHRpb25zIG9mCiAtLXdpdGgt e3NjaGVtYSxkYXRhLHN0YXRpc3RpY3N9IG9wdGlvbnMuCgpDb21taXQgYmRlMmZiNzk3YWEg YWRkZWQgdGhlIC0td2l0aC1zY2hlbWEsIC0td2l0aC1kYXRhLCBhbmQgLS13aXRoLXN0YXRp c3RpY3MKb3B0aW9ucyB0byBwZ19yZXN0b3JlLiBUaGVzZSBvcHRpb25zIGNvbnRyb2wgd2hl dGhlciB0byByZXN0b3JlIHNjaGVtYSwgZGF0YSwKb3Igc3RhdGlzdGljcyBpZiBwcmVzZW50 IGluIHRoZSBhcmNoaXZlLiBIb3dldmVyLCB0aGUgaGVscCBtZXNzYWdlIGFuZApkb2N1bWVu dGF0aW9uIGluY29ycmVjdGx5IGRlc2NyaWJlZCB0aGVtIGFzIGFmZmVjdGluZyB3aGF0IGdl dHMgZHVtcGVkLgoKVGhpcyBjb21taXQgY29ycmVjdHMgdGhvc2UgZGVzY3JpcHRpb25zIHRv IGNsYXJpZnkgdGhhdCB0aGUgb3B0aW9ucyBjb250cm9sCnJlc3RvcmF0aW9uLCBub3QgZHVt cGluZy4KLS0tCiBkb2Mvc3JjL3NnbWwvcmVmL3BnX3Jlc3RvcmUuc2dtbCB8IDkgKysrKysr LS0tCiBzcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jICAgICB8IDYgKysrLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9kb2Mvc3JjL3NnbWwvcmVmL3BnX3Jlc3RvcmUuc2dtbCBiL2RvYy9zcmMvc2dtbC9y ZWYvcGdfcmVzdG9yZS5zZ21sCmluZGV4IDIyOTVkZjYyZDAzLi44Yzg4YjA3ZGNjOCAxMDA2 NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKKysrIGIvZG9jL3Ny Yy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKQEAgLTkyMyw3ICs5MjMsOCBAQCBQb3N0Z3Jl U1FMIGRvY3VtZW50YXRpb24KICAgICAgIDx0ZXJtPjxvcHRpb24+LS13aXRoLWRhdGE8L29w dGlvbj48L3Rlcm0+CiAgICAgICA8bGlzdGl0ZW0+CiAgICAgICAgPHBhcmE+Ci0gICAgICAg IER1bXAgZGF0YS4gVGhpcyBpcyB0aGUgZGVmYXVsdC4KKyAgICAgICAgT3V0cHV0IGNvbW1h bmRzIHRvIHJlc3RvcmUgZGF0YSwgaWYgdGhlIGFyY2hpdmUgY29udGFpbnMgdGhlbS4KKyAg ICAgICAgVGhpcyBpcyB0aGUgZGVmYXVsdC4KICAgICAgICA8L3BhcmE+CiAgICAgICA8L2xp c3RpdGVtPgogICAgICA8L3Zhcmxpc3RlbnRyeT4KQEAgLTkzMiw3ICs5MzMsOCBAQCBQb3N0 Z3JlU1FMIGRvY3VtZW50YXRpb24KICAgICAgIDx0ZXJtPjxvcHRpb24+LS13aXRoLXNjaGVt YTwvb3B0aW9uPjwvdGVybT4KICAgICAgIDxsaXN0aXRlbT4KICAgICAgICA8cGFyYT4KLSAg ICAgICAgRHVtcCBzY2hlbWEgKGRhdGEgZGVmaW5pdGlvbnMpLiBUaGlzIGlzIHRoZSBkZWZh dWx0LgorICAgICAgICBPdXRwdXQgY29tbWFuZHMgdG8gcmVzdG9yZSBzY2hlbWEgKGRhdGEg ZGVmaW5pdGlvbnMpLCBpZiB0aGUgYXJjaGl2ZQorICAgICAgICBjb250YWlucyB0aGVtLiBU aGlzIGlzIHRoZSBkZWZhdWx0LgogICAgICAgIDwvcGFyYT4KICAgICAgIDwvbGlzdGl0ZW0+ CiAgICAgIDwvdmFybGlzdGVudHJ5PgpAQCAtOTQxLDcgKzk0Myw4IEBAIFBvc3RncmVTUUwg ZG9jdW1lbnRhdGlvbgogICAgICAgPHRlcm0+PG9wdGlvbj4tLXdpdGgtc3RhdGlzdGljczwv b3B0aW9uPjwvdGVybT4KICAgICAgIDxsaXN0aXRlbT4KICAgICAgICA8cGFyYT4KLSAgICAg ICAgRHVtcCBzdGF0aXN0aWNzLiBUaGlzIGlzIHRoZSBkZWZhdWx0LgorICAgICAgICBPdXRw dXQgY29tbWFuZHMgdG8gcmVzdG9yZSBzdGF0aXN0aWNzLCBpZiB0aGUgYXJjaGl2ZSBjb250 YWlucyB0aGVtLgorICAgICAgICBUaGlzIGlzIHRoZSBkZWZhdWx0LgogICAgICAgIDwvcGFy YT4KICAgICAgIDwvbGlzdGl0ZW0+CiAgICAgIDwvdmFybGlzdGVudHJ5PgpkaWZmIC0tZ2l0 IGEvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYyBiL3NyYy9iaW4vcGdfZHVtcC9wZ19y ZXN0b3JlLmMKaW5kZXggZjIxODJlOTE4MjUuLmM0YjYyMTRkNjE4IDEwMDY0NAotLS0gYS9z cmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCisrKyBiL3NyYy9iaW4vcGdfZHVtcC9wZ19y ZXN0b3JlLmMKQEAgLTcxMiw5ICs3MTIsOSBAQCB1c2FnZShjb25zdCBjaGFyICpwcm9nbmFt ZSkKIAlwcmludGYoXygiICAtLXVzZS1zZXQtc2Vzc2lvbi1hdXRob3JpemF0aW9uXG4iCiAJ CQkgIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1c2UgU0VUIFNFU1NJT04gQVVU SE9SSVpBVElPTiBjb21tYW5kcyBpbnN0ZWFkIG9mXG4iCiAJCQkgIiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBBTFRFUiBPV05FUiBjb21tYW5kcyB0byBzZXQgb3duZXJzaGlw XG4iKSk7Ci0JcHJpbnRmKF8oIiAgLS13aXRoLWRhdGEgICAgICAgICAgICAgICAgICBkdW1w IHRoZSBkYXRhXG4iKSk7Ci0JcHJpbnRmKF8oIiAgLS13aXRoLXNjaGVtYSAgICAgICAgICAg ICAgICBkdW1wIHRoZSBzY2hlbWFcbiIpKTsKLQlwcmludGYoXygiICAtLXdpdGgtc3RhdGlz dGljcyAgICAgICAgICAgIGR1bXAgdGhlIHN0YXRpc3RpY3NcbiIpKTsKKwlwcmludGYoXygi ICAtLXdpdGgtZGF0YSAgICAgICAgICAgICAgICAgIHJlc3RvcmUgdGhlIGRhdGFcbiIpKTsK KwlwcmludGYoXygiICAtLXdpdGgtc2NoZW1hICAgICAgICAgICAgICAgIHJlc3RvcmUgdGhl IHNjaGVtYVxuIikpOworCXByaW50ZihfKCIgIC0td2l0aC1zdGF0aXN0aWNzICAgICAgICAg ICAgcmVzdG9yZSB0aGUgc3RhdGlzdGljc1xuIikpOwogCiAJcHJpbnRmKF8oIlxuQ29ubmVj dGlvbiBvcHRpb25zOlxuIikpOwogCXByaW50ZihfKCIgIC1oLCAtLWhvc3Q9SE9TVE5BTUUg ICAgICBkYXRhYmFzZSBzZXJ2ZXIgaG9zdCBvciBzb2NrZXQgZGlyZWN0b3J5XG4iKSk7Ci0t IAoyLjQ5LjAKCg== --------------q92tCXj7kFKgTh0Hp40reqY4--