Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMYU5-0004jc-62 for pgsql-bugs@arkaria.postgresql.org; Thu, 09 Apr 2020 14:48:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMYU3-0007pq-P8 for pgsql-bugs@arkaria.postgresql.org; Thu, 09 Apr 2020 14:48:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMYU2-0007hC-Kx for pgsql-bugs@lists.postgresql.org; Thu, 09 Apr 2020 14:48:47 +0000 Received: from [66.111.4.25] (helo=out1-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMYTz-00035u-KE for pgsql-bugs@lists.postgresql.org; Thu, 09 Apr 2020 14:48:45 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A76815C2BDC; Thu, 9 Apr 2020 10:48:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 Apr 2020 10:48:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=58pliReRdV0frWAm1k/m9uqi19BF4kcQc9RpMh/2F ls=; b=A/GTx0xcBJitJ9PtlSk9b5tsBbH0w+N7rjosv1R538Yh5WmnCxZNB8tSE ZSWXxZtVdQv/YT/U6mlxg2uIwlX/Ko4UzURmWKCHhiJefIEZ+HuM/ePCTGyzZDiJ J8+fV82iVcpx7bshZqPkpHoB/+VLO3oAm3H1Vk7ytFGxe9KFXc3ungikN38C8JVX nah9fbiS4aCKeF1dMQJPqagDKAPy/DGb21niuvzdy7vEuVoFwX1OQgSw37WpvUi9 oxMZuTjYcTPelXOypGp4aDB99Q5y8il1ELZDMNRp+XS4eySyMS+hjaweJXOP2Cvp SZrVge/iRl8B4KCPcYQkLnuUOPj5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhohfkffgfgggjtgfgsehtje ertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghr rdgvihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtghomheqnecuffhomhgrih hnpedvnhguqhhurggurhgrnhhtrdgtohhmnecukfhppeelfedrvdegvddrvddufedrvdeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvg htvghrrdgvihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtghomh X-ME-Proxy: Received: from april.pezone.net (p5df2d5f1.dip0.t-ipconnect.de [93.242.213.241]) by mail.messagingengine.com (Postfix) with ESMTPA id B25DC3060060; Thu, 9 Apr 2020 10:48:30 -0400 (EDT) Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue To: Tom Lane References: <16342-50008a509308f4ca@postgresql.org> <10837.1586100396@sss.pgh.pa.us> Cc: ewaldo@healthetechs.com, pgsql-bugs@lists.postgresql.org From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Thu, 9 Apr 2020 16:48:29 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <10837.1586100396@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.25 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-04-05 17:26, Tom Lane wrote: > Peter Eisentraut writes: >> Confirmed. Attached is a patch to fix it. Thanks for the report! > > LGTM. Perhaps extend the comment block just above, adding something > like "We must fill the attmap now so it can be used to process > GENERATED default expressions in the per-column loop." Committed with that. Ethan, this will be in the next minor release of PostgreSQL 12. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services