Message-ID: <e0789f10-5b48-4d6b-a32c-0f4426d254df@oss.nttdata.com>
Date: Sat, 5 Jul 2025 01:24:06 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Content-Language: en-US
To: Laurenz Albe <laurenz.albe@cybertec.at>,
 Nisha Moond <nisha.moond412@gmail.com>,
 Gunnar Morling <gunnar.morling@googlemail.com>
Cc: pgsql-bugs@lists.postgresql.org
References: 
 <CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com>
 <CABdArM76e8-XChodqKxEiRK3tR_Yv3cymn_AWfP4bOsLDscZAg@mail.gmail.com>
 <30e91649-06dd-453e-8658-5f4acd03a3bd@oss.nttdata.com>
 <b26f13d7-769a-4b64-8bed-cb3a833c0604@oss.nttdata.com>
 <686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e0789f10-5b48-4d6b-a32c-0f4426d254df%40oss.nttdata.com>
Precedence: bulk


On 2025/07/05 1:07, Laurenz Albe wrote:
> On Sat, 2025-07-05 at 00:22 +0900, Fujii Masao wrote:
>> On 2025/07/04 23:12, Fujii Masao wrote:
>>> But I wonder why the current unit of this GUC is minutes (GUC_UNIT_MIN).
>>> Since at least two users (including myself) tried to set it to a value
>>> less than 1 minute, it might worth considering changing the unit to seconds
>>> (GUC_UNIT_S). Also which would reduces the chance of the reported trouble.
>>
>> Attached patch changes unit of idle_replication_slot_timeout to seconds.
> 
> -1
> 
> I think that the reason that several users tried to set it it less than a minute
> is that they were trying to test the feature and didn't want to wait long.
> I cannot imagine that anybody will want to abandon a standby server just
> because it is idle for more than 30 seconds.

Maybe. But changing the unit to seconds doesn't make things worse, does it?
It still allows users to set values greater than 1 minute, and also less than
1 minute for debugging or testing purposes, if needed.

Or are you suggesting we should disallow values below 1 minute?

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation