Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCjpa-0002xv-Ux for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Feb 2021 13:58:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lCjpZ-0004kq-TS for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Feb 2021 13:58:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCjpZ-0004ki-NC for pgsql-bugs@lists.postgresql.org; Thu, 18 Feb 2021 13:58:57 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCjpW-0001S9-GT for pgsql-bugs@lists.postgresql.org; Thu, 18 Feb 2021 13:58:57 +0000 Received: from hnk.local (p2710230-ipbf1703funabasi.chiba.ocn.ne.jp [123.216.93.230]) by oss.nttdata.com (Postfix) with ESMTPSA id F2A4B62730; Thu, 18 Feb 2021 22:58:48 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: BUG #16867: savepoints vs. commit and chain To: Arthur Nascimento Cc: pgsql-bugs@lists.postgresql.org References: <16867-3475744069228158@postgresql.org> <473dba6b-dfb3-b5a8-93c6-af3787893728@oss.nttdata.com> From: Fujii Masao Message-ID: Date: Thu, 18 Feb 2021 22:58:48 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021/02/17 3:03, Arthur Nascimento wrote: > Hi, Fujii-san, > > On Tue, 16 Feb 2021 at 01:49, Fujii Masao wrote: >> In the server side, ISTM that CommitTransactionCommand() needs to handle >> the COMMIT AND CHAIN in TBLOCK_SUBCOMMIT case, but it forgot to do that. >> Patch attached. I'm not sure if this is a bug or an intentional behavior. >> Probably we need to look at the past discussion about AND CHAIN feature. > > I can confirm that your patch solved it for me. Thanks for looking into it. Thanks for testing the patch! As far as I read the past discussion about chain transaction, I could not find any mention that current behavior that you reported is intentional. Barring any objection, I will commit the patch that you wrote for psql and the patch I wrote. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION