Message-ID: <e60b2021-054e-49d7-8a31-c2b18a1e1e6e@oss.nttdata.com>
Date: Thu, 3 Jul 2025 23:42:16 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #16931: source code problem about commit_ts
To: Andy Fan <zhihuifan1213@163.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, zoulx1982@163.com,
 pgsql-bugs@lists.postgresql.org
References: <20210409224241.GA32072@alvherre.pgsql>
 <a92a5d4f-4167-22fd-2aa4-3642df5cf978@oss.nttdata.com>
 <87ecuzmkqf.fsf@163.com>
 <873d332a-9609-4a1a-bb01-0344e2542575@oss.nttdata.com>
 <87jz4p9z6g.fsf@163.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <87jz4p9z6g.fsf@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e60b2021-054e-49d7-8a31-c2b18a1e1e6e%40oss.nttdata.com>
Precedence: bulk


On 2025/07/03 22:33, Andy Fan wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> 
>>>>
>>>> Thanks for the ping! Pushed!
>>> Did this commit(08aa89b326261b669648df97d4f2a6edba22d26a) forget to
>>> remove struct xl_commit_ts_set?
>>
>> You're right. I seem to have overlooked that.
>>
>>> After it, there is no reference to
>>> xl_commit_ts_set. So Is it better clean them as well?
>>
>> Agreed, the patch looks good to me. Unless there are objections,
>> I'll go ahead and commit it.
> 
> Thank you Fujii!
> 
>> While this could be considered an oversight in the original commit,
>> it's not a bug fix, so I plan to apply it only to the master branch.
> 
> That makes sense to me.

I've pushed the patch. Thanks!

Regards,


-- 
Fujii Masao
NTT DATA Japan Corporation