Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oai5I-0005D6-8I for pgsql-bugs@arkaria.postgresql.org; Tue, 20 Sep 2022 18:35:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oai5H-0003cy-4P for pgsql-bugs@arkaria.postgresql.org; Tue, 20 Sep 2022 18:35:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oai2U-00088u-L9 for pgsql-bugs@lists.postgresql.org; Tue, 20 Sep 2022 18:32:10 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oai2S-0003Yj-DZ for pgsql-bugs@postgresql.org; Tue, 20 Sep 2022 18:32:10 +0000 Received: by mail-pj1-x1034.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso3305909pjd.4 for ; Tue, 20 Sep 2022 11:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date; bh=7/5wjOC9YgJvci9V3LmAJag5hrzH1ahdAOyWQ3vCPIA=; b=3RUZDsnZC9CWVKV1FBnQt4HtsLXtNrzYL/sS17+dEMcwa6/LX04cacDXMfUIdUTpZR fk+D36pvc4kfxIbWyF8dPkVBjuJ0rdor2HAaRa8OHFF482KVMkgfLvwu6WZmqJ6o4Z5I IasS3P9iqgJgEiDmONTqcDo0thvSY7RQo58IPz8BaANRGV7473dksgwei9ZYnH/xhV44 tZWjpzvViflhbEQocsM9r64PGdgz9r+IweCC49q0y62Rt6Z9FhDngsOTLGhDcB/Plqpc IFeMyWfFMkXz6VfyJ7Fv259DCJRvtM9CxtXxaTyqKXXMZuSKGpRUCkoL8D3eOVajGllL GZ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date; bh=7/5wjOC9YgJvci9V3LmAJag5hrzH1ahdAOyWQ3vCPIA=; b=dP8hBD0X43f3bgkjS0Pu6VuKn5Ru909DUvy7Gv2zGxPmJm4bqbOgrYdV1vnYRRrOMf IgZe4M2kFynX/9jex/M1IYnNGPGTIjaK30J536IPWQ9nTRC8R/MP2DWrAhir35wLyHKT wEU4hUitA0EVgSrfgpSNZuFKhjuygQsVonRgkpim73be5ZUbUc1vW2cjv24brd/xcVMJ bt7nrbPEnNFG6WLVDhtDl+NgvCJNOGdm1Q85LLrCuIXIGOOgqraLi/FKI1Mwp3JJ04sk QUA05eNGO0L+QdBmmIWeVrspy8SeB9cRyEJAsLY2+zGHhnbZDC3cShgMykE3ECnTHn3F nswg== X-Gm-Message-State: ACrzQf13ervJVbO1tUQX18PeHDsxGNO6lR8MeDKhJWBPC6IjZHHgv+x/ xUMAJKG/Qt30Go0mlHPUGR0CqdOg+LjAu9YV X-Google-Smtp-Source: AMsMyM4+nno9r7aHL9B+uz/PVTf7Q+lAZyKYjULTAk/3x2OZTfB5y7a1BEQue5kBR4hpMakS1h/EZQ== X-Received: by 2002:a17:903:32cf:b0:178:3d49:45b0 with SMTP id i15-20020a17090332cf00b001783d4945b0mr925087plr.5.1663698726677; Tue, 20 Sep 2022 11:32:06 -0700 (PDT) Received: from jeff-laptop.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id b7-20020a170903228700b001780a528540sm234247plh.93.2022.09.20.11.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 11:32:06 -0700 (PDT) Message-ID: Subject: Re: PANIC in heap_delete during ALTER TABLE From: Jeff Davis To: Robins Tharakan , pgsql-bugs@postgresql.org Date: Tue, 20 Sep 2022 11:32:05 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2022-09-07 at 14:53 -0700, Jeff Davis wrote: > I attached a hasty patch that seems to fix it. I'll need to look more > closely later, and I'll also need some review because there have been > multiple bugs in this area. I plan to commit something close to this patch in about 48 hours and backport to 12, like 5f12bc94dc was. I would prefer if I was able to repro on 13 first, and some review would be nice given the area involved and how close we are to release. But it seems like fixing a bug is better than not. If someone thinks this is the wrong time to commit and wants me to hold off, please let me know. Regards, Jeff Davis