Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZ8cu-00057F-QB for pgsql-bugs@arkaria.postgresql.org; Tue, 18 Dec 2018 06:13:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZ8ct-0006lL-57 for pgsql-bugs@arkaria.postgresql.org; Tue, 18 Dec 2018 06:13:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZ8cs-0006lE-S8 for pgsql-bugs@lists.postgresql.org; Tue, 18 Dec 2018 06:13:07 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZ8cp-0002Xm-Af for pgsql-bugs@lists.postgresql.org; Tue, 18 Dec 2018 06:13:05 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wBI6D2ik012350; Tue, 18 Dec 2018 15:13:02 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 67EF9638ACE; Tue, 18 Dec 2018 15:13:02 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 5CE4B638B52; Tue, 18 Dec 2018 15:13:02 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.61]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 57E8B400B71; Tue, 18 Dec 2018 15:13:02 +0900 (JST) Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction References: <15552-c64aa14c5c22f63c@postgresql.org> <8e82d10d-cc16-eed4-7634-3654f59d8053@lab.ntt.co.jp> <30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp> <20181218050419.GJ1532@paquier.xyz> <20181218060243.GK1532@paquier.xyz> From: Amit Langote Message-ID: Date: Tue, 18 Dec 2018 15:12:53 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181218060243.GK1532@paquier.xyz> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Michael Paquier Cc: Luis Carril , "pgsql-bugs@lists.postgresql.org" , PG Bug reporting form X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2018/12/18 15:02, Michael Paquier wrote: > On Tue, Dec 18, 2018 at 02:51:10PM +0900, Amit Langote wrote: >> The link you shared is broken, so I couldn't read that email to understand >> the relation of relfilenode removal optimization to the bug here or how a >> TAP test was deployed for it. > > Oops. And here you go: > https://www.postgresql.org/message-id/20181114.124736.206988673.horiguchi.kyotaro@lab.ntt.co.jp Thanks. I looked at: https://www.postgresql.org/message-id/attachment/65997/v4-0001-TAP-test-for-copy-truncation-optimization.patch and I now get it. Adding a TAP test to src/test/recovery might make sense, but I'm not completely sure. In this case, we don't really want to see if the WAL-skipping optimization works correctly but that it's correctly *disabled* for foreign tables. Thanks, Amit