Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jR5t4-0007BP-91 for pgsql-bugs@arkaria.postgresql.org; Wed, 22 Apr 2020 03:17:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jR5t1-0008VX-EC for pgsql-bugs@arkaria.postgresql.org; Wed, 22 Apr 2020 03:17:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jR5t1-0008VN-7k for pgsql-bugs@lists.postgresql.org; Wed, 22 Apr 2020 03:17:19 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jR5sy-0003Xo-IA for pgsql-bugs@postgresql.org; Wed, 22 Apr 2020 03:17:18 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id ACECD6029A; Wed, 22 Apr 2020 12:17:12 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: pg_stat_statements: rows not updated for CREATE TABLE AS SELECT statements To: legrand legrand , pgsql-bugs@postgresql.org References: <1584293755198-0.post@n3.nabble.com> <1585330995153-0.post@n3.nabble.com> <54fa2fec-b133-0fc0-4227-3e308ba68812@oss.nttdata.com> <1587469032291-0.post@n3.nabble.com> From: Fujii Masao Message-ID: Date: Wed, 22 Apr 2020 12:17:11 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1587469032291-0.post@n3.nabble.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/04/21 20:37, legrand legrand wrote: > Fujii Masao-4 wrote >> Attached is the patch that makes pgss track the total number of rows >> retrieved or affected by CREATE TABLE AS, SELECT INTO, >> CREATE MATERIALIZED VIEW and FETCH. I think this is new feature >> rather than bug fix, so am planning to add this patch into next CommitFest >> for v14. Thought? > > Thanks ! > maybe v13, if this was considered as a bug that don't need backport ? Yeah, if many people think this is a bug, we can get it into v13. But at least for me it looks like an improvement of the capability of pgss rather than a bug fix. If the document of pgss clearly explained "pgss tracks the total number of rows affect by even utility command ...", I think that we can treat this as a bug. But... Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION