Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHnHE-0000ha-U9 for pgsql-bugs@arkaria.postgresql.org; Thu, 04 Mar 2021 12:40:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lHnHD-00017m-SK for pgsql-bugs@arkaria.postgresql.org; Thu, 04 Mar 2021 12:40:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHnHD-00017e-1s for pgsql-bugs@lists.postgresql.org; Thu, 04 Mar 2021 12:40:23 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHnH9-00045Y-Rh for pgsql-bugs@lists.postgresql.org; Thu, 04 Mar 2021 12:40:22 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 4042014E6; Thu, 4 Mar 2021 07:40:15 -0500 (EST) Received: from imap21 ([10.202.2.71]) by compute2.internal (MEProxy); Thu, 04 Mar 2021 07:40:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm1; bh=PXtz7S6cCjenYKAaNgW7g03tD+eyEo9 21wV0N1LMiDk=; b=1mUjS7yuGNMM70MzIFGTqqETjEWnfXfx7J9OOEYDyadlqK/ 3dB7WdBxOq9tAbEeCKKOQX5NYzBFN3BRGgEdNkmm5UijkxjUd+FVk5RdycnIqK2s Fb4CUCC9wW0nuNsG7j8FVIHjFTRLdLBpO9KTp13ptVs1zNhdNm4AMqp6I7wUcPN3 gDBgxFWC18RpmfCTWfKTsPuQjGyDrU0FCUjGEGGbujQ7pwvdks+3qhfoFD2NXuRw ulu9nxSZ22F1YxyFNnrN6Om2OLwUY7ktQESzjN0KXYo59WeCe1/rnemh+Fvj67JY 3qfYrS8qC1lXqxiRMQxHChM8jUDaQvk6tB1fnIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=PXtz7S 6cCjenYKAaNgW7g03tD+eyEo921wV0N1LMiDk=; b=WljMT0WiyBogZmZekCucN/ 1FBEWzDW+JQnQHwfDhmdqsa+Jz9pstHaafz63N2Kkzr80eGVx7NxBXj8iq3UyIxO /ZDOCTc5UCzIuei/G70CEKtXSXPB+IzA8BP6cdQ1JUFuKovB0rx5nNnQ1hTGLdjZ UgcpjdYxgVHPAj0P7qFnF7Tkv1gdDBuC8FqhfZttMcIr0rTVtcXciu29v9UZ1xY7 0lB4KkAZor2Wr8pDyQQI5/Udj9wr0Kw3MPwbv4FObACuNU8WJ5UP3OX2JI++PFLp 70CbOOjEW31Oj+dLVF2CpJMz/L2DObKIQ65mE4HWEmLFphm6NmsiCy4A8rPH8lRw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsegrtd erreerreejnecuhfhrohhmpedfgfhulhgvrhcuvfgrvhgvihhrrgdfuceovghulhgvrhes vghulhgvrhhtohdrtghomheqnecuggftrfgrthhtvghrnhepiefftdfgvdeghfeggfdtje dtffefvdfgueffgedtffefudeiuedvhefggeevleeknecuffhomhgrihhnpegvnhhtvghr phhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegvuhhlvghrsegvuhhlvghrthhordgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3FBF551C005D; Thu, 4 Mar 2021 07:40:14 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-206-g078a48fda5-fm-20210226.001-g078a48fd Mime-Version: 1.0 Message-Id: In-Reply-To: <16912-32693c592e24e8e8@postgresql.org> References: <16912-32693c592e24e8e8@postgresql.org> Date: Thu, 04 Mar 2021 09:39:53 -0300 From: "Euler Taveira" To: brandon.m.simmons@gmail.com, pgsql-bugs@lists.postgresql.org Subject: =?UTF-8?Q?Re:_BUG_#16912:_pg=5Fdump_11_does_not_respect_--quote-all-iden?= =?UTF-8?Q?tifiers_within_function_bodies?= Content-Type: multipart/alternative; boundary=a98daf4f9ac74524a99d2868610903e8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --a98daf4f9ac74524a99d2868610903e8 Content-Type: text/plain On Wed, Mar 3, 2021, at 8:39 PM, PG Bug reporting form wrote: > I'm using regex to rewrite identifiers in a SQL dump and rely on the > double-quotes. > Within plpgsql `CREATE FUNCTION` statements in the resulting dump, > identifiers are not quoted as I would expect. IIUC this is not a bug. You don't provide enough detail to show the issue. Are you generating dynamic commands inside your PL/pgSQL function? If so, Postgres doesn't manipulate function body. You should use quote_ident (that adds quotes if necessary) or a similar user-defined function. -- Euler Taveira EDB https://www.enterprisedb.com/ --a98daf4f9ac74524a99d2868610903e8 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Wed, Mar 3, = 2021, at 8:39 PM, PG Bug reporting form wrote:
I'm using regex to rewrite identifie= rs in a SQL dump and rely on the
double-quotes.
<= div>Within plpgsql `CREATE FUNCTION` statements in the resulting dump,
identifiers are not quoted as I would expect.
IIUC this is not a bug. You don't provide enough detail to= show the issue. Are 
you generating dynamic command= s inside your PL/pgSQL function? If so, Postgres 
doe= sn't manipulate function body. You should use quote_ident (that adds quo= tes 
if necessary) or a similar user-defined function= .


--
Euler Taveira
=
--a98daf4f9ac74524a99d2868610903e8--