Content-Type: multipart/mixed; boundary="------------8smtouUUA1FwROR6GJslcnzx"
Message-ID: <f1856a5d-3703-66ff-e7c7-01d2489315c1@joeconway.com>
Date: Sat, 10 Jun 2023 12:12:36 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Content-Language: en-US
From: Joe Conway <mail@joeconway.com>
To: Tristan Partin <tristan@neon.tech>, Heikki Linnakangas <hlinnaka@iki.fi>,
 Tom Lane <tgl@sss.pgh.pa.us>, gdo@leader.it
Cc: pgsql-bugs@lists.postgresql.org
References: <17946-3e84cb577e9551c3@postgresql.org>
 <1564676.1685043220@sss.pgh.pa.us>
 <555bb26e-c27c-ab65-028f-3fd5b82df9de@iki.fi>
 <CT887GSPI31W.BQCSW35JL67L@gonk>
 <ca35e375-be82-322d-8c81-78127d8fb33f@joeconway.com>
 <5676b739-0854-f924-4b97-466e3504c692@joeconway.com>
Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
In-Reply-To: <5676b739-0854-f924-4b97-466e3504c692@joeconway.com>
Archived-At: 
 <https://www.postgresql.org/message-id/f1856a5d-3703-66ff-e7c7-01d2489315c1%40joeconway.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------8smtouUUA1FwROR6GJslcnzx
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/9/23 22:10, Joe Conway wrote:
> On 6/9/23 15:05, Joe Conway wrote:
>> I wonder if it isn't a behavior change in libperl itself. It seems
>> that merely doing "load 'plperl';" is enough to cause the issue
> I can reproduce with a simple test program by linking libperl:
> 
> 8<-------- test.c ----------------

A bit more spelunking leads me to the following observations and 
conclusions:

1/ On RHEL7 with perl v5.16.3 the problem does not occur

2/ On RHEL9 with perl v5.32.1 the problem does occur

3/ The difference in behavior is triggered by the newer perl doing a 
bunch of newlocale/uselocale calls not done by the older perl, combined 
with a glibc behavior which seems surprising at best.

 From localeinfo.h in glibc source tree:
8<------------------------
/* This fetches the thread-local locale_t pointer, either one set with
    uselocale or &_nl_global_locale.  */
#define _NL_CURRENT_LOCALE      (__libc_tsd_get (locale_t, LOCALE))
8<------------------------

4/ I successfully tested a fix in the simplified reproducer program sent 
earlier. It amounts to adding:

8<------------------------
   uselocale(LC_GLOBAL_LOCALE);
8<------------------------

prior to calling

8<------------------------
   extlconv = localeconv();
8<------------------------

5/ The attached fixes the issue for me on pg10 and passes check-world.

Comments?

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--------------8smtouUUA1FwROR6GJslcnzx
Content-Type: text/x-patch; charset=UTF-8;
 name="20230610-plperl_locale_issue-000.patch"
Content-Disposition: attachment;
 filename="20230610-plperl_locale_issue-000.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUuYyBiL3NyYy9i
YWNrZW5kL3V0aWxzL2FkdC9wZ19sb2NhbGUuYwppbmRleCBiYmYxMDBlLi41NjBhMzI0IDEw
MDY0NAoqKiogYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdfbG9jYWxlLmMKLS0tIGIvc3Jj
L2JhY2tlbmQvdXRpbHMvYWR0L3BnX2xvY2FsZS5jCioqKioqKioqKioqKioqKiBQR0xDX2xv
Y2FsZWNvbnYodm9pZCkKKioqIDU2Miw1NjcgKioqKgotLS0gNTYyLDU3NCAtLS0tCiAgCXNl
dGxvY2FsZShMQ19DVFlQRSwgbG9jYWxlX251bWVyaWMpOwogICNlbmRpZgogIAorICAgICAg
ICAgLyoKKyAgICAgICAgICAqIEVuc3VyZSB0aGUgZ2xvYmFsIGxvY2FsZSBpcyBiZWluZyB1
c2VkLiBUaGlzIGlzCisgICAgICAgICAgKiBuZWNlc3NhcnksIGZvciBleGFtcGxlLCBpZiBh
bm90aGVyIGxvYWRlZCBsaWJyYXJ5CisgICAgICAgICAgKiBzdWNoIGFzIGxpYnBlcmwgaGFz
IGRvbmUgdXNlbG9jYWxlKCkgdW5kZXJuZWF0aCB1cy4KKyAgICAgICAgICAqICovCisgICAg
ICAgICB1c2Vsb2NhbGUoTENfR0xPQkFMX0xPQ0FMRSk7CisgCiAgCS8qIEdldCBmb3JtYXR0
aW5nIGluZm9ybWF0aW9uIGZvciBudW1lcmljICovCiAgCXNldGxvY2FsZShMQ19OVU1FUklD
LCBsb2NhbGVfbnVtZXJpYyk7CiAgCWV4dGxjb252ID0gbG9jYWxlY29udigpOwpkaWZmIC0t
Z2l0IGEvc3JjL2ZlX3V0aWxzL3ByaW50LmMgYi9zcmMvZmVfdXRpbHMvcHJpbnQuYwppbmRl
eCBlN2YzMWYyLi4wM2Q2NjIzIDEwMDY0NAoqKiogYS9zcmMvZmVfdXRpbHMvcHJpbnQuYwot
LS0gYi9zcmMvZmVfdXRpbHMvcHJpbnQuYwoqKioqKioqKioqKioqKiogc2V0RGVjaW1hbExv
Y2FsZSh2b2lkKQoqKiogMzQwMiwzNDA3ICoqKioKLS0tIDM0MDIsMzQxMyAtLS0tCiAgewog
IAlzdHJ1Y3QgbGNvbnYgKmV4dGxjb252OwogIAorICAgICAgICAgLyoKKyAgICAgICAgICAq
IEVuc3VyZSB0aGUgZ2xvYmFsIGxvY2FsZSBpcyBiZWluZyB1c2VkLiBUaGlzIGlzCisgICAg
ICAgICAgKiBuZWNlc3NhcnksIGZvciBleGFtcGxlLCBpZiBhbm90aGVyIGxvYWRlZCBsaWJy
YXJ5CisgICAgICAgICAgKiBzdWNoIGFzIGxpYnBlcmwgaGFzIGRvbmUgdXNlbG9jYWxlKCkg
dW5kZXJuZWF0aCB1cy4KKyAgICAgICAgICAqICovCisgICAgICAgICB1c2Vsb2NhbGUoTENf
R0xPQkFMX0xPQ0FMRSk7CiAgCWV4dGxjb252ID0gbG9jYWxlY29udigpOwogIAogIAkvKiBE
b24ndCBhY2NlcHQgYW4gZW1wdHkgZGVjaW1hbF9wb2ludCBzdHJpbmcgKi8K

--------------8smtouUUA1FwROR6GJslcnzx--