pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
38+ messages / 8 participants
[nested] [flat]
Commits from this thread:
2017-03-17 ff30aec759 38bdba54a6 96fd76dd28 6b584c36a4 3ebcc2498d 9c52ddfcee Fix and simplify check for whether we're running as Windows service.
* BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
@ 2015-11-04 06:23 breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: breen@rtda.com @ 2015-11-04 06:23 UTC (permalink / raw)
To: pgsql-bugs
The following bug has been logged on the website:
Bug reference: 13755
Logged by: Breen Hagan
Email address: breen@rtda.com
PostgreSQL version: 9.4.4
Operating system: Windows 8.1
Description:
Short version: pgwin32_is_service checks the process token for
SECURITY_SERVICE_RID by doing an EqualSid check. This will match against a
SECURITY_SERVICE_RID that has been disabled ("use_for_deny_only"), causing
PG to think it's a service when it is not. This causes it to attempt to log
to the event log, but this doesn't work, and so there is no logging at all.
Long version: We ship PG with our own product, which may or may not be
installed as a service. When running PG, we run postgres.exe directly via a
Tcl-based wrapper script so that we can monitor the output in real time.
This works as expected when our product is not being run as a service.
When our product is installed as a service, we use CreateRestrictedToken to
disable all admin rights as well as the SECURITY_SERVICE_RID, and use the
returned token with CreateProcessAsUser, for which we also specify
CREATE_NEW_CONSOLE. This process then calls our wrapper script. Inside
this wrapper, I can call GetStdHandle (via Twapi) and get valid handles for
all 3: in, out, and err. Yet when the script calls postgres.exe, nothing is
received on the output. As mentioned above, nothing is logged in the event
log, either.
If you look at
https://msdn.microsoft.com/en-us/library/windows/desktop/aa379554(v=vs.85).aspx,
this code is very similar to pgwin32_is_service (except that it looks for
Admins), but also checks the attributes on the SID to see if it is enabled,
or used for deny only. I believe this check needs to be added to
pgwin32_is_service.
Thanks!
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
@ 2015-11-05 15:39 ` Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2015-11-05 15:39 UTC (permalink / raw)
To: breen@rtda.com; +Cc: pgsql-bugs
On Wed, Nov 4, 2015 at 3:23 PM, <breen@rtda.com> wrote:
> Short version: pgwin32_is_service checks the process token for
> SECURITY_SERVICE_RID by doing an EqualSid check. This will match against a
> SECURITY_SERVICE_RID that has been disabled ("use_for_deny_only"), causing
> PG to think it's a service when it is not. This causes it to attempt to log
> to the event log, but this doesn't work, and so there is no logging at all.
OK. So if I am following correctly... If Postgres process uses a
SECURITY_SERVICE_RID SID that has SE_GROUP_USE_FOR_DENY_ONLY enabled
it will try to access to the event logs but will be denied as all
accesses are denied with this attribute, right?
What do you think about the patch attached then?
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Attachments:
20151105_windows_sid_deny.patch (application/x-patch, 918B) download
diff --git a/src/backend/port/win32/security.c b/src/backend/port/win32/security.c
index e9cfe15..92dbc9a 100644
--- a/src/backend/port/win32/security.c
+++ b/src/backend/port/win32/security.c
@@ -98,7 +98,9 @@ pgwin32_is_admin(void)
*
* 1) We are running as Local System (only used by services)
* 2) Our token contains SECURITY_SERVICE_RID (automatically added to the
- * process token by the SCM when starting a service)
+ * process token by the SCM when starting a service) without
+ * SE_GROUP_USE_FOR_DENY_ONLY enabled as this would prevent access
+ * to the event logs forcibly.
*
* Return values:
* 0 = Not service
@@ -190,7 +192,10 @@ pgwin32_is_service(void)
{
if (EqualSid(ServiceSid, Groups->Groups[x].Sid))
{
- _is_service = 1;
+ if ((Groups->Groups[x].Attributes & SE_GROUP_USE_FOR_DENY_ONLY) != 0)
+ _is_service = 0;
+ else
+ _is_service = 1;
break;
}
}
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2015-11-05 16:00 ` Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Breen Hagan @ 2015-11-05 16:00 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: pgsql-bugs
Michael,
I'm pretty sure your patch will fix my issue, but perhaps it should be a
positive check for SE_GROUP_ENABLED? I say "perhaps" because the last time
I did any serious Windows coding was 2005.
Thanks for the quick response!
Breen
On Thu, Nov 5, 2015 at 9:39 AM, Michael Paquier <michael.paquier@gmail.com>
wrote:
> On Wed, Nov 4, 2015 at 3:23 PM, <breen@rtda.com> wrote:
> > Short version: pgwin32_is_service checks the process token for
> > SECURITY_SERVICE_RID by doing an EqualSid check. This will match
> against a
> > SECURITY_SERVICE_RID that has been disabled ("use_for_deny_only"),
> causing
> > PG to think it's a service when it is not. This causes it to attempt to
> log
> > to the event log, but this doesn't work, and so there is no logging at
> all.
>
> OK. So if I am following correctly... If Postgres process uses a
> SECURITY_SERVICE_RID SID that has SE_GROUP_USE_FOR_DENY_ONLY enabled
> it will try to access to the event logs but will be denied as all
> accesses are denied with this attribute, right?
>
> What do you think about the patch attached then?
> --
> Michael
>
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
@ 2015-11-07 07:09 ` Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2015-11-07 07:09 UTC (permalink / raw)
To: Breen Hagan <breen@rtda.com>; +Cc: pgsql-bugs
On Fri, Nov 6, 2015 at 1:00 AM, Breen Hagan <breen@rtda.com> wrote:
> Michael,
(You should avoid top-posting, this breaks the logic of a thread).
> I'm pretty sure your patch will fix my issue, but perhaps it should be a
> positive check for SE_GROUP_ENABLED?
If we want to be completely consistent with pgwin32_is_admin, that
would be actually the opposite: Postgres should not start with an SID
that has administrator's rights for security reasons.
Btw, I think that you would be interested in this patch as well:
http://www.postgresql.org/message-id/CAB7nPqR=FsgqOsQL6qUC04XWbZ93Q9BC-qEmHu2Cvh8uMRNrNQ@mail.gmail....
This makes pgwin32_is_service available for frontend applications as
well, hence you would not need to duplicate any upstream code and just
reuse it for your scripts. That's material for 9.6~ though. I am
actually planning to fix an old bug in pg_ctl handling of a service
using that.
> I say "perhaps" because the last time
> I did any serious Windows coding was 2005.
That's short considering these day's life average expectancy.
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2015-11-07 07:36 ` Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2015-11-07 07:36 UTC (permalink / raw)
To: Breen Hagan <breen@rtda.com>; +Cc: pgsql-bugs
On Sat, Nov 7, 2015 at 4:09 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Nov 6, 2015 at 1:00 AM, Breen Hagan <breen@rtda.com> wrote:
>> Michael,
>
> (You should avoid top-posting, this breaks the logic of a thread).
>
>> I'm pretty sure your patch will fix my issue, but perhaps it should be a
>> positive check for SE_GROUP_ENABLED?
>
> If we want to be completely consistent with pgwin32_is_admin, that
> would be actually the opposite: Postgres should not start with an SID
> that has administrator's rights for security reasons.
SECURITY_SERVICE_RID and SECURITY_BUILTIN_DOMAIN_RID are completely
separated concepts... Please ignore that. Still, yeah, it seems that
you are right, we would want SE_GROUP_ENABLED to be enabled to check
if process can access the event logs. Thoughts from any Windows ninja
in the surroundings?
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-03-09 22:44 ` Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Breen Hagan @ 2016-03-09 22:44 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: pgsql-bugs
On Sat, Nov 7, 2015 at 1:36 AM, Michael Paquier <michael.paquier@gmail.com>
wrote:
> On Sat, Nov 7, 2015 at 4:09 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> > On Fri, Nov 6, 2015 at 1:00 AM, Breen Hagan <breen@rtda.com> wrote:
> >> Michael,
> >
> > (You should avoid top-posting, this breaks the logic of a thread).
> >
> >> I'm pretty sure your patch will fix my issue, but perhaps it should be a
> >> positive check for SE_GROUP_ENABLED?
> >
> > If we want to be completely consistent with pgwin32_is_admin, that
> > would be actually the opposite: Postgres should not start with an SID
> > that has administrator's rights for security reasons.
>
> SECURITY_SERVICE_RID and SECURITY_BUILTIN_DOMAIN_RID are completely
> separated concepts... Please ignore that. Still, yeah, it seems that
> you are right, we would want SE_GROUP_ENABLED to be enabled to check
> if process can access the event logs. Thoughts from any Windows ninja
> in the surroundings?
--
> Michael
>
Sorry to bring back a very old thread, but I was wondering if this was ever
resolved? I saw
an item in the 9.4.6 release notes that seemed similar, but upon checking
the code, I see
that pgwin32_is_service() still checks just for the existence of these RIDs
without checking
to see if they are enabled.
Thanks,
Breen
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
@ 2016-03-10 06:24 ` Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-03-10 06:24 UTC (permalink / raw)
To: Breen Hagan <breen@rtda.com>; +Cc: pgsql-bugs
On Wed, Mar 9, 2016 at 11:44 PM, Breen Hagan <breen@rtda.com> wrote:
>
>
> On Sat, Nov 7, 2015 at 1:36 AM, Michael Paquier <michael.paquier@gmail.com>
> wrote:
>>
>> On Sat, Nov 7, 2015 at 4:09 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>> > On Fri, Nov 6, 2015 at 1:00 AM, Breen Hagan <breen@rtda.com> wrote:
>> >> Michael,
>> >
>> > (You should avoid top-posting, this breaks the logic of a thread).
>> >
>> >> I'm pretty sure your patch will fix my issue, but perhaps it should be
>> >> a
>> >> positive check for SE_GROUP_ENABLED?
>> >
>> > If we want to be completely consistent with pgwin32_is_admin, that
>> > would be actually the opposite: Postgres should not start with an SID
>> > that has administrator's rights for security reasons.
>>
>> SECURITY_SERVICE_RID and SECURITY_BUILTIN_DOMAIN_RID are completely
>> separated concepts... Please ignore that. Still, yeah, it seems that
>> you are right, we would want SE_GROUP_ENABLED to be enabled to check
>> if process can access the event logs. Thoughts from any Windows ninja
>> in the surroundings?
>>
>> --
>> Michael
>
>
> Sorry to bring back a very old thread, but I was wondering if this was ever
> resolved? I saw
> an item in the 9.4.6 release notes that seemed similar, but upon checking
> the code, I see
> that pgwin32_is_service() still checks just for the existence of these RIDs
> without checking
> to see if they are enabled.
This is not resolved yet, this just fell from my radar and I recall
that I spent some time thinking about the consequences and whereabouts
of using either SE_GROUP_ENABLED or SE_GROUP_USE_FOR_DENY_ONLY,
without actually reaching a conclusion. I think that the patch would
be straight-forward. But it needs a bit of review from the author
(Hi!) and some extra input would be welcome. I guess I could try to
look at that again.. That won't be this week for sure though.
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-04-04 16:08 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Alvaro Herrera @ 2016-04-04 16:08 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: Breen Hagan <breen@rtda.com>; pgsql-bugs
Michael Paquier wrote:
> This is not resolved yet, this just fell from my radar and I recall
> that I spent some time thinking about the consequences and whereabouts
> of using either SE_GROUP_ENABLED or SE_GROUP_USE_FOR_DENY_ONLY,
> without actually reaching a conclusion. I think that the patch would
> be straight-forward. But it needs a bit of review from the author
> (Hi!) and some extra input would be welcome. I guess I could try to
> look at that again.. That won't be this week for sure though.
Bump.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
@ 2016-04-05 03:58 ` Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-04-05 03:58 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: Breen Hagan <breen@rtda.com>; pgsql-bugs
On Tue, Apr 5, 2016 at 1:08 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Michael Paquier wrote:
>> This is not resolved yet, this just fell from my radar and I recall
>> that I spent some time thinking about the consequences and whereabouts
>> of using either SE_GROUP_ENABLED or SE_GROUP_USE_FOR_DENY_ONLY,
>> without actually reaching a conclusion. I think that the patch would
>> be straight-forward. But it needs a bit of review from the author
>> (Hi!) and some extra input would be welcome. I guess I could try to
>> look at that again.. That won't be this week for sure though.
>
> Bump.
Don't worry. This has not fallen from my radar yet..
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-04-08 06:48 ` Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-04-08 06:48 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: Breen Hagan <breen@rtda.com>; pgsql-bugs
On Tue, Apr 5, 2016 at 12:58 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Apr 5, 2016 at 1:08 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> Michael Paquier wrote:
>>> This is not resolved yet, this just fell from my radar and I recall
>>> that I spent some time thinking about the consequences and whereabouts
>>> of using either SE_GROUP_ENABLED or SE_GROUP_USE_FOR_DENY_ONLY,
>>> without actually reaching a conclusion. I think that the patch would
>>> be straight-forward. But it needs a bit of review from the author
>>> (Hi!) and some extra input would be welcome. I guess I could try to
>>> look at that again.. That won't be this week for sure though.
>>
>> Bump.
>
> Don't worry. This has not fallen from my radar yet..
So I have been looking at this issue again and finished with the patch
attached. I think that it makes the most sense to browse the whole
list of groups, and choose if Postgres is running as a service if
service SID matches with one of the group SIDs listed, on top of which
this group SID should be enabled via SE_GROUP_ENABLED. Checking for
SE_GROUP_USE_FOR_DENY_ONLY would not make much sense, because it would
mean that SE_GROUP_ENABLED is not set, and that's what we are
interested in. That was in short the point of Breen, and it looks to
be the saner way to go.
What do others think?
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Attachments:
win32-security-service-v2.patch (invalid/octet-stream, 466B) download
diff --git a/src/port/win32security.c b/src/port/win32security.c
index ab9cd67..cfa0aec 100644
--- a/src/port/win32security.c
+++ b/src/port/win32security.c
@@ -218,7 +218,8 @@ pgwin32_is_service(void)
_is_service = 0;
for (x = 0; x < Groups->GroupCount; x++)
{
- if (EqualSid(ServiceSid, Groups->Groups[x].Sid))
+ if (EqualSid(ServiceSid, Groups->Groups[x].Sid) &&
+ (Groups->Groups[x].Attributes & SE_GROUP_ENABLED))
{
_is_service = 1;
break;
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-09-21 12:50 ` Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
0 siblings, 1 reply; 38+ messages in thread
From: Heikki Linnakangas @ 2016-09-21 12:50 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Breen Hagan <breen@rtda.com>; +Cc: Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-bugs
On 04/08/2016 09:48 AM, Michael Paquier wrote:
> So I have been looking at this issue again and finished with the patch
> attached. I think that it makes the most sense to browse the whole
> list of groups, and choose if Postgres is running as a service if
> service SID matches with one of the group SIDs listed, on top of which
> this group SID should be enabled via SE_GROUP_ENABLED. Checking for
> SE_GROUP_USE_FOR_DENY_ONLY would not make much sense, because it would
> mean that SE_GROUP_ENABLED is not set, and that's what we are
> interested in. That was in short the point of Breen, and it looks to
> be the saner way to go.
Yeah, seems like the right way. pgwin32_is_admin() also checks for
SE_GROUP_ENABLED.
I think this is ready to be committed, except that I don't have an easy
way to reproduce the original problem to test this. I suppose I could
write a test program to call CreateRestrictedToken() and
CreateProcessAsUser(), but would rather avoid the work. Breen, if I push
a fix for this, can you build from sources and verify that it fixes your
original problem? Or alternatively, can you provide a test program that
I can use to verify it?
- Heikki
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
@ 2016-09-23 17:55 ` Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Breen Hagan @ 2016-09-23 17:55 UTC (permalink / raw)
To: Heikki Linnakangas <hlinnaka@iki.fi>; +Cc: Michael Paquier <michael.paquier@gmail.com>; Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-bugs
Hi,
Sorry for the delay in response. We don't presently build postgres for
Windows (we do for linux and macos), but I'm willing to give it a shot if
there is a solid doc on setting up the build. That would probably be
easier than doing a test program.
Breen
On Wed, Sep 21, 2016 at 7:50 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> On 04/08/2016 09:48 AM, Michael Paquier wrote:
>
>> So I have been looking at this issue again and finished with the patch
>> attached. I think that it makes the most sense to browse the whole
>> list of groups, and choose if Postgres is running as a service if
>> service SID matches with one of the group SIDs listed, on top of which
>> this group SID should be enabled via SE_GROUP_ENABLED. Checking for
>> SE_GROUP_USE_FOR_DENY_ONLY would not make much sense, because it would
>> mean that SE_GROUP_ENABLED is not set, and that's what we are
>> interested in. That was in short the point of Breen, and it looks to
>> be the saner way to go.
>>
>
> Yeah, seems like the right way. pgwin32_is_admin() also checks for
> SE_GROUP_ENABLED.
>
> I think this is ready to be committed, except that I don't have an easy
> way to reproduce the original problem to test this. I suppose I could write
> a test program to call CreateRestrictedToken() and CreateProcessAsUser(),
> but would rather avoid the work. Breen, if I push a fix for this, can you
> build from sources and verify that it fixes your original problem? Or
> alternatively, can you provide a test program that I can use to verify it?
>
> - Heikki
>
>
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
@ 2016-09-23 23:52 ` Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-09-23 23:52 UTC (permalink / raw)
To: Breen Hagan <breen@rtda.com>; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-bugs
On Sat, Sep 24, 2016 at 2:55 AM, Breen Hagan <breen@rtda.com> wrote:
> Sorry for the delay in response. We don't presently build postgres for
> Windows (we do for linux and macos), but I'm willing to give it a shot if
> there is a solid doc on setting up the build. That would probably be easier
> than doing a test program.
There is a whole chapter in the docs in the matter:
https://www.postgresql.org/docs/9.0/static/install-windows.html
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-10-02 12:47 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:11 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
0 siblings, 2 replies; 38+ messages in thread
From: Michael Paquier @ 2016-10-02 12:47 UTC (permalink / raw)
To: Breen Hagan <breen@rtda.com>; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-bugs
On Sat, Sep 24, 2016 at 8:52 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Sat, Sep 24, 2016 at 2:55 AM, Breen Hagan <breen@rtda.com> wrote:
>> Sorry for the delay in response. We don't presently build postgres for
>> Windows (we do for linux and macos), but I'm willing to give it a shot if
>> there is a solid doc on setting up the build. That would probably be easier
>> than doing a test program.
>
> There is a whole chapter in the docs in the matter:
> https://www.postgresql.org/docs/9.0/static/install-windows.html
(Moved to next CF, with same status "Ready for committer").
--
Michael
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-06 09:11 ` MauMau <maumau307@gmail.com>
1 sibling, 0 replies; 38+ messages in thread
From: MauMau @ 2016-11-06 09:11 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Breen Hagan <breen@rtda.com>; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-bugs
Hello,
From: Michael Paquier
(Moved to next CF, with same status "Ready for committer").
I reviewed and tested this patch after simplifying it like the
attached one. The file could be reduced by about 110 lines. Please
review and/or test it. Though I kept the status "ready for
committer", feel free to change it back based on the result.
I tested as follows. First, I confirmed that pg_is_admin() still
works by running postgres.exe from the Administrator command line:
--------------------------------------------------
G:\>postgres
Execution of PostgreSQL by a user with administrative permissions is
not
permitted.
The server must be started under an unprivileged user ID to prevent
possible system security compromises. See the documentation for
more information on how to properly start the server.
G:\>
--------------------------------------------------
Then, I added the following two elog() calls in postmaster.c so that
pg_is_admin() and pg_is_service() works fine.
--------------------------------------------------
maybe_start_bgworker();
elog(LOG, "pgwin32_is_admin = %d", pgwin32_is_admin());
elog(LOG, "pgwin32_is_service = %d", pgwin32_is_service());
status = ServerLoop();
--------------------------------------------------
To reproduce the OP's problem, I modified pg_ctl.c to disable
SECURITY_SERVICE_RID when spawning postgres.exe. Without the patch,
starting the Windows service emit the following log, showing that
pg_is_service() misjudged that postgres is running as a Windows
service:
LOG: pgwin32_is_admin = 0
LOG: pgwin32_is_service = 1
With the patch, the log became correct:
LOG: pgwin32_is_admin = 0
LOG: pgwin32_is_service = 0
Regards
Takayuki Tsunakawa
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Attachments:
win32-security_service-v3.patch (application/octet-stream, 12.7K) download
ÿþd i f f - - g i t a / s r c / p o r t / w i n 3 2 s e c u r i t y . c b / s r c / p o r t / w i n 3 2 s e c u r i t y . c
i n d e x 2 c 9 c a 1 5 . . 3 b 2 2 f 1 6 1 0 0 6 4 4
- - - a / s r c / p o r t / w i n 3 2 s e c u r i t y . c
+ + + b / s r c / p o r t / w i n 3 2 s e c u r i t y . c
@ @ - 1 8 , 1 1 + 1 8 , 6 @ @
# e n d i f
- s t a t i c B O O L p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( H A N D L E t o k e n ,
- T O K E N _ I N F O R M A T I O N _ C L A S S c l a s s ,
- c h a r * * I n f o B u f f e r , c h a r * e r r b u f , i n t e r r s i z e ) ;
-
-
/ *
* U t i l i t y w r a p p e r f o r f r o n t e n d a n d b a c k e n d w h e n r e p o r t i n g a n e r r o r
* m e s s a g e .
@ @ - 5 3 , 3 3 + 4 8 , 1 1 @ @ l o g _ e r r o r ( c o n s t c h a r * f m t , . . . )
i n t
p g w i n 3 2 _ i s _ a d m i n ( v o i d )
{
- H A N D L E A c c e s s T o k e n ;
- c h a r * I n f o B u f f e r = N U L L ;
- c h a r e r r b u f [ 2 5 6 ] ;
- P T O K E N _ G R O U P S G r o u p s ;
P S I D A d m i n i s t r a t o r s S i d ;
P S I D P o w e r U s e r s S i d ;
S I D _ I D E N T I F I E R _ A U T H O R I T Y N t A u t h o r i t y = { S E C U R I T Y _ N T _ A U T H O R I T Y } ;
- U I N T x ;
- B O O L s u c c e s s ;
-
- i f ( ! O p e n P r o c e s s T o k e n ( G e t C u r r e n t P r o c e s s ( ) , T O K E N _ R E A D , & A c c e s s T o k e n ) )
- {
- l o g _ e r r o r ( _ ( " c o u l d n o t o p e n p r o c e s s t o k e n : e r r o r c o d e % l u \ n " ) ,
- G e t L a s t E r r o r ( ) ) ;
- e x i t ( 1 ) ;
- }
-
- i f ( ! p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( A c c e s s T o k e n , T o k e n G r o u p s ,
- & I n f o B u f f e r , e r r b u f , s i z e o f ( e r r b u f ) ) )
- {
- l o g _ e r r o r ( " % s " , e r r b u f ) ;
- e x i t ( 1 ) ;
- }
-
- G r o u p s = ( P T O K E N _ G R O U P S ) I n f o B u f f e r ;
-
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ B O O L I s A d m i n i s t r a t o r s ;
+ B O O L I s P o w e r U s e r s ;
i f ( ! A l l o c a t e A n d I n i t i a l i z e S i d ( & N t A u t h o r i t y , 2 ,
S E C U R I T Y _ B U I L T I N _ D O M A I N _ R I D ,
@ @ - 1 0 1 , 2 4 + 7 4 , 2 1 @ @ p g w i n 3 2 _ i s _ a d m i n ( v o i d )
e x i t ( 1 ) ;
}
- s u c c e s s = F A L S E ;
-
- f o r ( x = 0 ; x < G r o u p s - > G r o u p C o u n t ; x + + )
+ i f ( ! C h e c k T o k e n M e m b e r s h i p ( N U L L , A d m i n i s t r a t o r s S i d , & I s A d m i n i s t r a t o r s ) | |
+ ! C h e c k T o k e n M e m b e r s h i p ( N U L L , P o w e r U s e r s S i d , & I s P o w e r U s e r s ) )
{
- i f ( ( E q u a l S i d ( A d m i n i s t r a t o r s S i d , G r o u p s - > G r o u p s [ x ] . S i d ) & &
- ( G r o u p s - > G r o u p s [ x ] . A t t r i b u t e s & S E _ G R O U P _ E N A B L E D ) ) | |
- ( E q u a l S i d ( P o w e r U s e r s S i d , G r o u p s - > G r o u p s [ x ] . S i d ) & &
- ( G r o u p s - > G r o u p s [ x ] . A t t r i b u t e s & S E _ G R O U P _ E N A B L E D ) ) )
- {
- s u c c e s s = T R U E ;
- b r e a k ;
- }
+ l o g _ e r r o r ( " c o u l d n o t c h e c k a c c e s s t o k e n m e m b e r s h i p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
+ e x i t ( 1 ) ;
}
- f r e e ( I n f o B u f f e r ) ;
F r e e S i d ( A d m i n i s t r a t o r s S i d ) ;
F r e e S i d ( P o w e r U s e r s S i d ) ;
- r e t u r n s u c c e s s ;
+
+ i f ( I s A d m i n i s t r a t o r s | | I s P o w e r U s e r s )
+ r e t u r n 1 ;
+ e l s e
+ r e t u r n 0 ;
}
/ *
@ @ - 1 4 3 , 1 4 0 + 1 1 3 , 6 3 @ @ i n t
p g w i n 3 2 _ i s _ s e r v i c e ( v o i d )
{
s t a t i c i n t _ i s _ s e r v i c e = - 1 ;
- H A N D L E A c c e s s T o k e n ;
- c h a r * I n f o B u f f e r = N U L L ;
- c h a r e r r b u f [ 2 5 6 ] ;
- P T O K E N _ G R O U P S G r o u p s ;
- P T O K E N _ U S E R U s e r ;
+ B O O L I s M e m b e r ;
P S I D S e r v i c e S i d ;
P S I D L o c a l S y s t e m S i d ;
S I D _ I D E N T I F I E R _ A U T H O R I T Y N t A u t h o r i t y = { S E C U R I T Y _ N T _ A U T H O R I T Y } ;
- U I N T x ;
/ * O n l y c h e c k t h e f i r s t t i m e * /
i f ( _ i s _ s e r v i c e ! = - 1 )
r e t u r n _ i s _ s e r v i c e ;
- i f ( ! O p e n P r o c e s s T o k e n ( G e t C u r r e n t P r o c e s s ( ) , T O K E N _ R E A D , & A c c e s s T o k e n ) )
- {
- f p r i n t f ( s t d e r r , " c o u l d n o t o p e n p r o c e s s t o k e n : e r r o r c o d e % l u \ n " ,
- G e t L a s t E r r o r ( ) ) ;
- r e t u r n - 1 ;
- }
-
- / * F i r s t c h e c k f o r l o c a l s y s t e m * /
- i f ( ! p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( A c c e s s T o k e n , T o k e n U s e r , & I n f o B u f f e r ,
- e r r b u f , s i z e o f ( e r r b u f ) ) )
- {
- f p r i n t f ( s t d e r r , " % s " , e r r b u f ) ;
- r e t u r n - 1 ;
- }
-
- U s e r = ( P T O K E N _ U S E R ) I n f o B u f f e r ;
-
+ / * F i r s t c h e c k f o r L o c a l S y s t e m * /
i f ( ! A l l o c a t e A n d I n i t i a l i z e S i d ( & N t A u t h o r i t y , 1 ,
S E C U R I T Y _ L O C A L _ S Y S T E M _ R I D , 0 , 0 , 0 , 0 , 0 , 0 , 0 ,
& L o c a l S y s t e m S i d ) )
{
- f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r l o c a l s y s t e m a c c o u n t \ n " ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r L o c a l S y s t e m a c c o u n t : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
r e t u r n - 1 ;
}
- i f ( E q u a l S i d ( L o c a l S y s t e m S i d , U s e r - > U s e r . S i d ) )
+ i f ( ! C h e c k T o k e n M e m b e r s h i p ( N U L L , L o c a l S y s t e m S i d , & I s M e m b e r ) )
{
+ f p r i n t f ( s t d e r r , " c o u l d n o t c h e c k a c c e s s t o k e n m e m b e r s h i p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
F r e e S i d ( L o c a l S y s t e m S i d ) ;
- f r e e ( I n f o B u f f e r ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
- _ i s _ s e r v i c e = 1 ;
- r e t u r n _ i s _ s e r v i c e ;
+ r e t u r n - 1 ;
}
-
F r e e S i d ( L o c a l S y s t e m S i d ) ;
- f r e e ( I n f o B u f f e r ) ;
- / * N o w c h e c k f o r g r o u p S I D * /
- i f ( ! p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( A c c e s s T o k e n , T o k e n G r o u p s , & I n f o B u f f e r ,
- e r r b u f , s i z e o f ( e r r b u f ) ) )
+ i f ( I s M e m b e r )
{
- f p r i n t f ( s t d e r r , " % s " , e r r b u f ) ;
- r e t u r n - 1 ;
+ _ i s _ s e r v i c e = 1 ;
+ r e t u r n _ i s _ s e r v i c e ;
}
- G r o u p s = ( P T O K E N _ G R O U P S ) I n f o B u f f e r ;
-
+ / * N e x t c h e c k f o r s e r v i c e g r o u p * /
i f ( ! A l l o c a t e A n d I n i t i a l i z e S i d ( & N t A u t h o r i t y , 1 ,
S E C U R I T Y _ S E R V I C E _ R I D , 0 , 0 , 0 , 0 , 0 , 0 , 0 ,
& S e r v i c e S i d ) )
{
- f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r s e r v i c e g r o u p \ n " ) ;
- f r e e ( I n f o B u f f e r ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r s e r v i c e g r o u p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
r e t u r n - 1 ;
}
- _ i s _ s e r v i c e = 0 ;
- f o r ( x = 0 ; x < G r o u p s - > G r o u p C o u n t ; x + + )
+ i f ( ! C h e c k T o k e n M e m b e r s h i p ( N U L L , S e r v i c e S i d , & I s M e m b e r ) )
{
- i f ( E q u a l S i d ( S e r v i c e S i d , G r o u p s - > G r o u p s [ x ] . S i d ) )
- {
- _ i s _ s e r v i c e = 1 ;
- b r e a k ;
- }
+ f p r i n t f ( s t d e r r , " c o u l d n o t c h e c k a c c e s s t o k e n m e m b e r s h i p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
+ F r e e S i d ( S e r v i c e S i d ) ;
+ r e t u r n - 1 ;
}
-
- f r e e ( I n f o B u f f e r ) ;
F r e e S i d ( S e r v i c e S i d ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ i f ( I s M e m b e r )
+ _ i s _ s e r v i c e = 1 ;
+ e l s e
+ _ i s _ s e r v i c e = 0 ;
r e t u r n _ i s _ s e r v i c e ;
}
-
-
- / *
- * C a l l G e t T o k e n I n f o r m a t i o n ( ) o n a t o k e n a n d r e t u r n a d y n a m i c a l l y s i z e d
- * b u f f e r w i t h t h e i n f o r m a t i o n i n i t . T h i s b u f f e r m u s t b e f r e e ( ) : d b y
- * t h e c a l l i n g f u n c t i o n !
- * /
- s t a t i c B O O L
- p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( H A N D L E t o k e n , T O K E N _ I N F O R M A T I O N _ C L A S S c l a s s ,
- c h a r * * I n f o B u f f e r , c h a r * e r r b u f , i n t e r r s i z e )
- {
- D W O R D I n f o B u f f e r S i z e ;
-
- i f ( G e t T o k e n I n f o r m a t i o n ( t o k e n , c l a s s , N U L L , 0 , & I n f o B u f f e r S i z e ) )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t g e t t o k e n i n f o r m a t i o n b u f f e r s i z e : g o t z e r o s i z e \ n " ) ;
- r e t u r n F A L S E ;
- }
-
- i f ( G e t L a s t E r r o r ( ) ! = E R R O R _ I N S U F F I C I E N T _ B U F F E R )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t g e t t o k e n i n f o r m a t i o n b u f f e r s i z e : e r r o r c o d e % l u \ n " ,
- G e t L a s t E r r o r ( ) ) ;
- r e t u r n F A L S E ;
- }
-
- * I n f o B u f f e r = m a l l o c ( I n f o B u f f e r S i z e ) ;
- i f ( * I n f o B u f f e r = = N U L L )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t a l l o c a t e % d b y t e s f o r t o k e n i n f o r m a t i o n \ n " ,
- ( i n t ) I n f o B u f f e r S i z e ) ;
- r e t u r n F A L S E ;
- }
-
- i f ( ! G e t T o k e n I n f o r m a t i o n ( t o k e n , c l a s s , * I n f o B u f f e r ,
- I n f o B u f f e r S i z e , & I n f o B u f f e r S i z e ) )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t g e t t o k e n i n f o r m a t i o n : e r r o r c o d e % l u \ n " ,
- G e t L a s t E r r o r ( ) ) ;
- r e t u r n F A L S E ;
- }
-
- r e t u r n T R U E ;
- }
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-06 09:30 ` MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
1 sibling, 1 reply; 38+ messages in thread
From: MauMau @ 2016-11-06 09:30 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Breen Hagan <breen@rtda.com>; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Hello,
Sorry, I may have had to send this to pgsql-hackers. I just replied
to all, which did not include pgsql-hackers but pgsql-bugs because
this discussion was on pgsql-bugs. CommitFest app doesn't seem to
reflect the mails on pgsql-bugs, so I'm re-submitting this here on
pgsql-hackers.
From: Michael Paquier
(Moved to next CF, with same status "Ready for committer").
I reviewed and tested this patch after simplifying it like the
attached one. The file could be reduced by about 110 lines. Please
review and/or test it. Though I kept the status "ready for
committer", feel free to change it back based on the result.
I tested as follows. First, I confirmed that pg_is_admin() still
works by running postgres.exe from the Administrator command line:
--------------------------------------------------
G:\>postgres
Execution of PostgreSQL by a user with administrative permissions is
not
permitted.
The server must be started under an unprivileged user ID to prevent
possible system security compromises. See the documentation for
more information on how to properly start the server.
G:\>
--------------------------------------------------
Then, I added the following two elog() calls in postmaster.c so that
pg_is_admin() and pg_is_service() works fine.
--------------------------------------------------
maybe_start_bgworker();
elog(LOG, "pgwin32_is_admin = %d", pgwin32_is_admin());
elog(LOG, "pgwin32_is_service = %d", pgwin32_is_service());
status = ServerLoop();
--------------------------------------------------
To reproduce the OP's problem, I modified pg_ctl.c to disable
SECURITY_SERVICE_RID when spawning postgres.exe. Without the patch,
starting the Windows service emit the following log, showing that
pg_is_service() misjudged that postgres is running as a Windows
service:
LOG: pgwin32_is_admin = 0
LOG: pgwin32_is_service = 1
With the patch, the log became correct:
LOG: pgwin32_is_admin = 0
LOG: pgwin32_is_service = 0
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
win32-security_service-v3.patch (application/octet-stream, 12.7K) download
ÿþd i f f - - g i t a / s r c / p o r t / w i n 3 2 s e c u r i t y . c b / s r c / p o r t / w i n 3 2 s e c u r i t y . c
i n d e x 2 c 9 c a 1 5 . . 3 b 2 2 f 1 6 1 0 0 6 4 4
- - - a / s r c / p o r t / w i n 3 2 s e c u r i t y . c
+ + + b / s r c / p o r t / w i n 3 2 s e c u r i t y . c
@ @ - 1 8 , 1 1 + 1 8 , 6 @ @
# e n d i f
- s t a t i c B O O L p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( H A N D L E t o k e n ,
- T O K E N _ I N F O R M A T I O N _ C L A S S c l a s s ,
- c h a r * * I n f o B u f f e r , c h a r * e r r b u f , i n t e r r s i z e ) ;
-
-
/ *
* U t i l i t y w r a p p e r f o r f r o n t e n d a n d b a c k e n d w h e n r e p o r t i n g a n e r r o r
* m e s s a g e .
@ @ - 5 3 , 3 3 + 4 8 , 1 1 @ @ l o g _ e r r o r ( c o n s t c h a r * f m t , . . . )
i n t
p g w i n 3 2 _ i s _ a d m i n ( v o i d )
{
- H A N D L E A c c e s s T o k e n ;
- c h a r * I n f o B u f f e r = N U L L ;
- c h a r e r r b u f [ 2 5 6 ] ;
- P T O K E N _ G R O U P S G r o u p s ;
P S I D A d m i n i s t r a t o r s S i d ;
P S I D P o w e r U s e r s S i d ;
S I D _ I D E N T I F I E R _ A U T H O R I T Y N t A u t h o r i t y = { S E C U R I T Y _ N T _ A U T H O R I T Y } ;
- U I N T x ;
- B O O L s u c c e s s ;
-
- i f ( ! O p e n P r o c e s s T o k e n ( G e t C u r r e n t P r o c e s s ( ) , T O K E N _ R E A D , & A c c e s s T o k e n ) )
- {
- l o g _ e r r o r ( _ ( " c o u l d n o t o p e n p r o c e s s t o k e n : e r r o r c o d e % l u \ n " ) ,
- G e t L a s t E r r o r ( ) ) ;
- e x i t ( 1 ) ;
- }
-
- i f ( ! p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( A c c e s s T o k e n , T o k e n G r o u p s ,
- & I n f o B u f f e r , e r r b u f , s i z e o f ( e r r b u f ) ) )
- {
- l o g _ e r r o r ( " % s " , e r r b u f ) ;
- e x i t ( 1 ) ;
- }
-
- G r o u p s = ( P T O K E N _ G R O U P S ) I n f o B u f f e r ;
-
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ B O O L I s A d m i n i s t r a t o r s ;
+ B O O L I s P o w e r U s e r s ;
i f ( ! A l l o c a t e A n d I n i t i a l i z e S i d ( & N t A u t h o r i t y , 2 ,
S E C U R I T Y _ B U I L T I N _ D O M A I N _ R I D ,
@ @ - 1 0 1 , 2 4 + 7 4 , 2 1 @ @ p g w i n 3 2 _ i s _ a d m i n ( v o i d )
e x i t ( 1 ) ;
}
- s u c c e s s = F A L S E ;
-
- f o r ( x = 0 ; x < G r o u p s - > G r o u p C o u n t ; x + + )
+ i f ( ! C h e c k T o k e n M e m b e r s h i p ( N U L L , A d m i n i s t r a t o r s S i d , & I s A d m i n i s t r a t o r s ) | |
+ ! C h e c k T o k e n M e m b e r s h i p ( N U L L , P o w e r U s e r s S i d , & I s P o w e r U s e r s ) )
{
- i f ( ( E q u a l S i d ( A d m i n i s t r a t o r s S i d , G r o u p s - > G r o u p s [ x ] . S i d ) & &
- ( G r o u p s - > G r o u p s [ x ] . A t t r i b u t e s & S E _ G R O U P _ E N A B L E D ) ) | |
- ( E q u a l S i d ( P o w e r U s e r s S i d , G r o u p s - > G r o u p s [ x ] . S i d ) & &
- ( G r o u p s - > G r o u p s [ x ] . A t t r i b u t e s & S E _ G R O U P _ E N A B L E D ) ) )
- {
- s u c c e s s = T R U E ;
- b r e a k ;
- }
+ l o g _ e r r o r ( " c o u l d n o t c h e c k a c c e s s t o k e n m e m b e r s h i p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
+ e x i t ( 1 ) ;
}
- f r e e ( I n f o B u f f e r ) ;
F r e e S i d ( A d m i n i s t r a t o r s S i d ) ;
F r e e S i d ( P o w e r U s e r s S i d ) ;
- r e t u r n s u c c e s s ;
+
+ i f ( I s A d m i n i s t r a t o r s | | I s P o w e r U s e r s )
+ r e t u r n 1 ;
+ e l s e
+ r e t u r n 0 ;
}
/ *
@ @ - 1 4 3 , 1 4 0 + 1 1 3 , 6 3 @ @ i n t
p g w i n 3 2 _ i s _ s e r v i c e ( v o i d )
{
s t a t i c i n t _ i s _ s e r v i c e = - 1 ;
- H A N D L E A c c e s s T o k e n ;
- c h a r * I n f o B u f f e r = N U L L ;
- c h a r e r r b u f [ 2 5 6 ] ;
- P T O K E N _ G R O U P S G r o u p s ;
- P T O K E N _ U S E R U s e r ;
+ B O O L I s M e m b e r ;
P S I D S e r v i c e S i d ;
P S I D L o c a l S y s t e m S i d ;
S I D _ I D E N T I F I E R _ A U T H O R I T Y N t A u t h o r i t y = { S E C U R I T Y _ N T _ A U T H O R I T Y } ;
- U I N T x ;
/ * O n l y c h e c k t h e f i r s t t i m e * /
i f ( _ i s _ s e r v i c e ! = - 1 )
r e t u r n _ i s _ s e r v i c e ;
- i f ( ! O p e n P r o c e s s T o k e n ( G e t C u r r e n t P r o c e s s ( ) , T O K E N _ R E A D , & A c c e s s T o k e n ) )
- {
- f p r i n t f ( s t d e r r , " c o u l d n o t o p e n p r o c e s s t o k e n : e r r o r c o d e % l u \ n " ,
- G e t L a s t E r r o r ( ) ) ;
- r e t u r n - 1 ;
- }
-
- / * F i r s t c h e c k f o r l o c a l s y s t e m * /
- i f ( ! p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( A c c e s s T o k e n , T o k e n U s e r , & I n f o B u f f e r ,
- e r r b u f , s i z e o f ( e r r b u f ) ) )
- {
- f p r i n t f ( s t d e r r , " % s " , e r r b u f ) ;
- r e t u r n - 1 ;
- }
-
- U s e r = ( P T O K E N _ U S E R ) I n f o B u f f e r ;
-
+ / * F i r s t c h e c k f o r L o c a l S y s t e m * /
i f ( ! A l l o c a t e A n d I n i t i a l i z e S i d ( & N t A u t h o r i t y , 1 ,
S E C U R I T Y _ L O C A L _ S Y S T E M _ R I D , 0 , 0 , 0 , 0 , 0 , 0 , 0 ,
& L o c a l S y s t e m S i d ) )
{
- f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r l o c a l s y s t e m a c c o u n t \ n " ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r L o c a l S y s t e m a c c o u n t : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
r e t u r n - 1 ;
}
- i f ( E q u a l S i d ( L o c a l S y s t e m S i d , U s e r - > U s e r . S i d ) )
+ i f ( ! C h e c k T o k e n M e m b e r s h i p ( N U L L , L o c a l S y s t e m S i d , & I s M e m b e r ) )
{
+ f p r i n t f ( s t d e r r , " c o u l d n o t c h e c k a c c e s s t o k e n m e m b e r s h i p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
F r e e S i d ( L o c a l S y s t e m S i d ) ;
- f r e e ( I n f o B u f f e r ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
- _ i s _ s e r v i c e = 1 ;
- r e t u r n _ i s _ s e r v i c e ;
+ r e t u r n - 1 ;
}
-
F r e e S i d ( L o c a l S y s t e m S i d ) ;
- f r e e ( I n f o B u f f e r ) ;
- / * N o w c h e c k f o r g r o u p S I D * /
- i f ( ! p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( A c c e s s T o k e n , T o k e n G r o u p s , & I n f o B u f f e r ,
- e r r b u f , s i z e o f ( e r r b u f ) ) )
+ i f ( I s M e m b e r )
{
- f p r i n t f ( s t d e r r , " % s " , e r r b u f ) ;
- r e t u r n - 1 ;
+ _ i s _ s e r v i c e = 1 ;
+ r e t u r n _ i s _ s e r v i c e ;
}
- G r o u p s = ( P T O K E N _ G R O U P S ) I n f o B u f f e r ;
-
+ / * N e x t c h e c k f o r s e r v i c e g r o u p * /
i f ( ! A l l o c a t e A n d I n i t i a l i z e S i d ( & N t A u t h o r i t y , 1 ,
S E C U R I T Y _ S E R V I C E _ R I D , 0 , 0 , 0 , 0 , 0 , 0 , 0 ,
& S e r v i c e S i d ) )
{
- f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r s e r v i c e g r o u p \ n " ) ;
- f r e e ( I n f o B u f f e r ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ f p r i n t f ( s t d e r r , " c o u l d n o t g e t S I D f o r s e r v i c e g r o u p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
r e t u r n - 1 ;
}
- _ i s _ s e r v i c e = 0 ;
- f o r ( x = 0 ; x < G r o u p s - > G r o u p C o u n t ; x + + )
+ i f ( ! C h e c k T o k e n M e m b e r s h i p ( N U L L , S e r v i c e S i d , & I s M e m b e r ) )
{
- i f ( E q u a l S i d ( S e r v i c e S i d , G r o u p s - > G r o u p s [ x ] . S i d ) )
- {
- _ i s _ s e r v i c e = 1 ;
- b r e a k ;
- }
+ f p r i n t f ( s t d e r r , " c o u l d n o t c h e c k a c c e s s t o k e n m e m b e r s h i p : e r r o r c o d e % l u \ n " ,
+ G e t L a s t E r r o r ( ) ) ;
+ F r e e S i d ( S e r v i c e S i d ) ;
+ r e t u r n - 1 ;
}
-
- f r e e ( I n f o B u f f e r ) ;
F r e e S i d ( S e r v i c e S i d ) ;
- C l o s e H a n d l e ( A c c e s s T o k e n ) ;
+ i f ( I s M e m b e r )
+ _ i s _ s e r v i c e = 1 ;
+ e l s e
+ _ i s _ s e r v i c e = 0 ;
r e t u r n _ i s _ s e r v i c e ;
}
-
-
- / *
- * C a l l G e t T o k e n I n f o r m a t i o n ( ) o n a t o k e n a n d r e t u r n a d y n a m i c a l l y s i z e d
- * b u f f e r w i t h t h e i n f o r m a t i o n i n i t . T h i s b u f f e r m u s t b e f r e e ( ) : d b y
- * t h e c a l l i n g f u n c t i o n !
- * /
- s t a t i c B O O L
- p g w i n 3 2 _ g e t _ d y n a m i c _ t o k e n i n f o ( H A N D L E t o k e n , T O K E N _ I N F O R M A T I O N _ C L A S S c l a s s ,
- c h a r * * I n f o B u f f e r , c h a r * e r r b u f , i n t e r r s i z e )
- {
- D W O R D I n f o B u f f e r S i z e ;
-
- i f ( G e t T o k e n I n f o r m a t i o n ( t o k e n , c l a s s , N U L L , 0 , & I n f o B u f f e r S i z e ) )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t g e t t o k e n i n f o r m a t i o n b u f f e r s i z e : g o t z e r o s i z e \ n " ) ;
- r e t u r n F A L S E ;
- }
-
- i f ( G e t L a s t E r r o r ( ) ! = E R R O R _ I N S U F F I C I E N T _ B U F F E R )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t g e t t o k e n i n f o r m a t i o n b u f f e r s i z e : e r r o r c o d e % l u \ n " ,
- G e t L a s t E r r o r ( ) ) ;
- r e t u r n F A L S E ;
- }
-
- * I n f o B u f f e r = m a l l o c ( I n f o B u f f e r S i z e ) ;
- i f ( * I n f o B u f f e r = = N U L L )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t a l l o c a t e % d b y t e s f o r t o k e n i n f o r m a t i o n \ n " ,
- ( i n t ) I n f o B u f f e r S i z e ) ;
- r e t u r n F A L S E ;
- }
-
- i f ( ! G e t T o k e n I n f o r m a t i o n ( t o k e n , c l a s s , * I n f o B u f f e r ,
- I n f o B u f f e r S i z e , & I n f o B u f f e r S i z e ) )
- {
- s n p r i n t f ( e r r b u f , e r r s i z e ,
- " c o u l d n o t g e t t o k e n i n f o r m a t i o n : e r r o r c o d e % l u \ n " ,
- G e t L a s t E r r o r ( ) ) ;
- r e t u r n F A L S E ;
- }
-
- r e t u r n T R U E ;
- }
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
@ 2016-11-06 12:12 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-11-06 12:12 UTC (permalink / raw)
To: MauMau <maumau307@gmail.com>; +Cc: Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Sun, Nov 6, 2016 at 6:30 PM, MauMau <maumau307@gmail.com> wrote:
> Sorry, I may have had to send this to pgsql-hackers. I just replied
> to all, which did not include pgsql-hackers but pgsql-bugs because
> this discussion was on pgsql-bugs. CommitFest app doesn't seem to
> reflect the mails on pgsql-bugs, so I'm re-submitting this here on
> pgsql-hackers.
No problem, I still see a unique thread so that's not an issue seen from here.
> I reviewed and tested this patch after simplifying it like the
> attached one. The file could be reduced by about 110 lines. Please
> review and/or test it. Though I kept the status "ready for
> committer", feel free to change it back based on the result.
So you see the same behavior with the patch I sent and your
refactoring, right? If yes, backpatching the one-liner is the safest
bet to me. We could keep the refactoring for HEAD if it makes sense.
Something is wrong with the format of your patch by the way. My
Windows and even OSX environments recognize it as a binary file,
though I can read it in any editor and I cannot apply it cleanly with
a simple patch command. Could you send it again and double-check?
> To reproduce the OP's problem, I modified pg_ctl.c to disable
> SECURITY_SERVICE_RID when spawning postgres.exe.
So basically you allocated a SID to drop via AllocateAndInitializeSid,
called _CreateRestrictedToken and let the process being spawned? I
think that this is the patch attached
(win32-disable-service-rid.patch). Could you confirm? I want to be
sure that we are testing the same things.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
win32-disable-service-rid.patch (text/x-patch, 1.3K) download
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 4b47602..56c7f2e 100644
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -1738,7 +1738,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, bool as_ser
HANDLE origToken;
HANDLE restrictedToken;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- SID_AND_ATTRIBUTES dropSids[2];
+ SID_AND_ATTRIBUTES dropSids[3];
/* Functions loaded dynamically */
__CreateRestrictedToken _CreateRestrictedToken = NULL;
@@ -1790,7 +1790,10 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, bool as_ser
0, &dropSids[0].Sid) ||
!AllocateAndInitializeSid(&NtAuthority, 2,
SECURITY_BUILTIN_DOMAIN_RID, DOMAIN_ALIAS_RID_POWER_USERS, 0, 0, 0, 0, 0,
- 0, &dropSids[1].Sid))
+ 0, &dropSids[1].Sid) ||
+ !AllocateAndInitializeSid(&NtAuthority, 1,
+ SECURITY_SERVICE_RID, 0, 0, 0, 0, 0, 0,
+ 0, &dropSids[2].Sid))
{
write_stderr(_("%s: could not allocate SIDs: error code %lu\n"),
progname, (unsigned long) GetLastError());
@@ -1805,6 +1808,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, bool as_ser
0, NULL,
&restrictedToken);
+ FreeSid(dropSids[2].Sid);
FreeSid(dropSids[1].Sid);
FreeSid(dropSids[0].Sid);
CloseHandle(origToken);
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-07 00:49 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-07 00:49 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; MauMau <maumau307@gmail.com>; +Cc: Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
> On Sun, Nov 6, 2016 at 6:30 PM, MauMau <maumau307@gmail.com> wrote:
> > Sorry, I may have had to send this to pgsql-hackers. I just replied
> > to all, which did not include pgsql-hackers but pgsql-bugs because
> > this discussion was on pgsql-bugs. CommitFest app doesn't seem to
> > reflect the mails on pgsql-bugs, so I'm re-submitting this here on
> > pgsql-hackers.
>
> No problem, I still see a unique thread so that's not an issue seen from
> here.
You are right. A while after I sent the second mail, I noticed the CommitFest app collected both of my mails. I was just impatient.
> So you see the same behavior with the patch I sent and your refactoring,
> right? If yes, backpatching the one-liner is the safest bet to me. We could
> keep the refactoring for HEAD if it makes sense.
Yes. And It's fine to me that your patch will be applied to previous releases and my patch to HEAD only. This is a good (rare?) chance to reduce the Windows-specific code, so I want to take advantage of it.
> Something is wrong with the format of your patch by the way. My Windows
> and even OSX environments recognize it as a binary file, though I can read
> it in any editor and I cannot apply it cleanly with a simple patch command.
> Could you send it again and double-check?
Ouch, the Git shell included in GitHub Desktop for Windows produced the diff in UTF-16 and CR/LF line terminators. I haven't found how to fix it, so I generated the attached patch on Linux. Please check it.
> > To reproduce the OP's problem, I modified pg_ctl.c to disable
> > SECURITY_SERVICE_RID when spawning postgres.exe.
>
> So basically you allocated a SID to drop via AllocateAndInitializeSid,
> called _CreateRestrictedToken and let the process being spawned? I think
> that this is the patch attached (win32-disable-service-rid.patch). Could
> you confirm? I want to be sure that we are testing the same things.
Yes, I did the same.
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
win32-security-service-v4.patch (application/octet-stream, 6.1K) download
diff --git a/src/port/win32security.c b/src/port/win32security.c
index 2c9ca15..3b22f16 100644
--- a/src/port/win32security.c
+++ b/src/port/win32security.c
@@ -18,11 +18,6 @@
#endif
-static BOOL pgwin32_get_dynamic_tokeninfo(HANDLE token,
- TOKEN_INFORMATION_CLASS class,
- char **InfoBuffer, char *errbuf, int errsize);
-
-
/*
* Utility wrapper for frontend and backend when reporting an error
* message.
@@ -53,33 +48,11 @@ log_error(const char *fmt,...)
int
pgwin32_is_admin(void)
{
- HANDLE AccessToken;
- char *InfoBuffer = NULL;
- char errbuf[256];
- PTOKEN_GROUPS Groups;
PSID AdministratorsSid;
PSID PowerUsersSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- UINT x;
- BOOL success;
-
- if (!OpenProcessToken(GetCurrentProcess(), TOKEN_READ, &AccessToken))
- {
- log_error(_("could not open process token: error code %lu\n"),
- GetLastError());
- exit(1);
- }
-
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups,
- &InfoBuffer, errbuf, sizeof(errbuf)))
- {
- log_error("%s", errbuf);
- exit(1);
- }
-
- Groups = (PTOKEN_GROUPS) InfoBuffer;
-
- CloseHandle(AccessToken);
+ BOOL IsAdministrators;
+ BOOL IsPowerUsers;
if (!AllocateAndInitializeSid(&NtAuthority, 2,
SECURITY_BUILTIN_DOMAIN_RID,
@@ -101,24 +74,21 @@ pgwin32_is_admin(void)
exit(1);
}
- success = FALSE;
-
- for (x = 0; x < Groups->GroupCount; x++)
+ if (!CheckTokenMembership(NULL, AdministratorsSid, &IsAdministrators) ||
+ !CheckTokenMembership(NULL, PowerUsersSid, &IsPowerUsers))
{
- if ((EqualSid(AdministratorsSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)) ||
- (EqualSid(PowerUsersSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)))
- {
- success = TRUE;
- break;
- }
+ log_error("could not check access token membership: error code %lu\n",
+ GetLastError());
+ exit(1);
}
- free(InfoBuffer);
FreeSid(AdministratorsSid);
FreeSid(PowerUsersSid);
- return success;
+
+ if (IsAdministrators || IsPowerUsers)
+ return 1;
+ else
+ return 0;
}
/*
@@ -143,140 +113,63 @@ int
pgwin32_is_service(void)
{
static int _is_service = -1;
- HANDLE AccessToken;
- char *InfoBuffer = NULL;
- char errbuf[256];
- PTOKEN_GROUPS Groups;
- PTOKEN_USER User;
+ BOOL IsMember;
PSID ServiceSid;
PSID LocalSystemSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- UINT x;
/* Only check the first time */
if (_is_service != -1)
return _is_service;
- if (!OpenProcessToken(GetCurrentProcess(), TOKEN_READ, &AccessToken))
- {
- fprintf(stderr, "could not open process token: error code %lu\n",
- GetLastError());
- return -1;
- }
-
- /* First check for local system */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenUser, &InfoBuffer,
- errbuf, sizeof(errbuf)))
- {
- fprintf(stderr, "%s", errbuf);
- return -1;
- }
-
- User = (PTOKEN_USER) InfoBuffer;
-
+ /* First check for Local System */
if (!AllocateAndInitializeSid(&NtAuthority, 1,
SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0,
&LocalSystemSid))
{
- fprintf(stderr, "could not get SID for local system account\n");
- CloseHandle(AccessToken);
+ fprintf(stderr, "could not get SID for Local System account: error code %lu\n",
+ GetLastError());
return -1;
}
- if (EqualSid(LocalSystemSid, User->User.Sid))
+ if (!CheckTokenMembership(NULL, LocalSystemSid, &IsMember))
{
+ fprintf(stderr, "could not check access token membership: error code %lu\n",
+ GetLastError());
FreeSid(LocalSystemSid);
- free(InfoBuffer);
- CloseHandle(AccessToken);
- _is_service = 1;
- return _is_service;
+ return -1;
}
-
FreeSid(LocalSystemSid);
- free(InfoBuffer);
- /* Now check for group SID */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups, &InfoBuffer,
- errbuf, sizeof(errbuf)))
+ if (IsMember)
{
- fprintf(stderr, "%s", errbuf);
- return -1;
+ _is_service = 1;
+ return _is_service;
}
- Groups = (PTOKEN_GROUPS) InfoBuffer;
-
+ /* Next check for service group */
if (!AllocateAndInitializeSid(&NtAuthority, 1,
SECURITY_SERVICE_RID, 0, 0, 0, 0, 0, 0, 0,
&ServiceSid))
{
- fprintf(stderr, "could not get SID for service group\n");
- free(InfoBuffer);
- CloseHandle(AccessToken);
+ fprintf(stderr, "could not get SID for service group: error code %lu\n",
+ GetLastError());
return -1;
}
- _is_service = 0;
- for (x = 0; x < Groups->GroupCount; x++)
+ if (!CheckTokenMembership(NULL, ServiceSid, &IsMember))
{
- if (EqualSid(ServiceSid, Groups->Groups[x].Sid))
- {
- _is_service = 1;
- break;
- }
+ fprintf(stderr, "could not check access token membership: error code %lu\n",
+ GetLastError());
+ FreeSid(ServiceSid);
+ return -1;
}
-
- free(InfoBuffer);
FreeSid(ServiceSid);
- CloseHandle(AccessToken);
+ if (IsMember)
+ _is_service = 1;
+ else
+ _is_service = 0;
return _is_service;
}
-
-
-/*
- * Call GetTokenInformation() on a token and return a dynamically sized
- * buffer with the information in it. This buffer must be free():d by
- * the calling function!
- */
-static BOOL
-pgwin32_get_dynamic_tokeninfo(HANDLE token, TOKEN_INFORMATION_CLASS class,
- char **InfoBuffer, char *errbuf, int errsize)
-{
- DWORD InfoBufferSize;
-
- if (GetTokenInformation(token, class, NULL, 0, &InfoBufferSize))
- {
- snprintf(errbuf, errsize,
- "could not get token information buffer size: got zero size\n");
- return FALSE;
- }
-
- if (GetLastError() != ERROR_INSUFFICIENT_BUFFER)
- {
- snprintf(errbuf, errsize,
- "could not get token information buffer size: error code %lu\n",
- GetLastError());
- return FALSE;
- }
-
- *InfoBuffer = malloc(InfoBufferSize);
- if (*InfoBuffer == NULL)
- {
- snprintf(errbuf, errsize,
- "could not allocate %d bytes for token information\n",
- (int) InfoBufferSize);
- return FALSE;
- }
-
- if (!GetTokenInformation(token, class, *InfoBuffer,
- InfoBufferSize, &InfoBufferSize))
- {
- snprintf(errbuf, errsize,
- "could not get token information: error code %lu\n",
- GetLastError());
- return FALSE;
- }
-
- return TRUE;
-}
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-07 08:05 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-07 13:31 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
0 siblings, 2 replies; 38+ messages in thread
From: Michael Paquier @ 2016-11-07 08:05 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Mon, Nov 7, 2016 at 9:49 AM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: pgsql-hackers-owner@postgresql.org
>> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
>> On Sun, Nov 6, 2016 at 6:30 PM, MauMau <maumau307@gmail.com> wrote:
>> So you see the same behavior with the patch I sent and your refactoring,
>> right? If yes, backpatching the one-liner is the safest bet to me. We could
>> keep the refactoring for HEAD if it makes sense.
>
> Yes. And It's fine to me that your patch will be applied to previous releases and my patch to HEAD only. This is a good (rare?) chance to reduce the Windows-specific code, so I want to take advantage of it.
Yes, I can follow that argument.
>> Something is wrong with the format of your patch by the way. My Windows
>> and even OSX environments recognize it as a binary file, though I can read
>> it in any editor and I cannot apply it cleanly with a simple patch command.
>> Could you send it again and double-check?
>
> Ouch, the Git shell included in GitHub Desktop for Windows produced the diff in UTF-16 and CR/LF line terminators. I haven't found how to fix it, so I generated the attached patch on Linux. Please check it.
And the patch got twice smaller in size. Thanks.
>> > To reproduce the OP's problem, I modified pg_ctl.c to disable
>> > SECURITY_SERVICE_RID when spawning postgres.exe.
>>
>> So basically you allocated a SID to drop via AllocateAndInitializeSid,
>> called _CreateRestrictedToken and let the process being spawned? I think
>> that this is the patch attached (win32-disable-service-rid.patch). Could
>> you confirm? I want to be sure that we are testing the same things.
>
> Yes, I did the same.
Hm.. I have just tested HEAD, my patch and your patch using my patch
test on pg_ctl.c, but I am always getting pgwin32_is_service set to 0
when running pg_ctl start from a terminal, and set it to 1 when
running pg_ctl service to register the service startup. Could you
precise in which ways you started the Postgres instance and could you
post the patch of pg_ctl you used? I am afraid that I am taking it
incorrectly because I am not able to see any differences.
Also, did you test the patch I posted and were you able to see the
same differences as with your patch? I still think that my short patch
is logically correct but if the tests are not we are in a no-go
position for any fix posted on this thread.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-07 13:31 ` MauMau <maumau307@gmail.com>
2016-11-08 01:33 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
1 sibling, 1 reply; 38+ messages in thread
From: MauMau @ 2016-11-07 13:31 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Michael Paquier
Hm.. I have just tested HEAD, my patch and your patch using my patch
test on pg_ctl.c, but I am always getting pgwin32_is_service set to 0
when running pg_ctl start from a terminal, and set it to 1 when
running pg_ctl service to register the service startup. Could you
precise in which ways you started the Postgres instance and could you
post the patch of pg_ctl you used? I am afraid that I am taking it
incorrectly because I am not able to see any differences.
Also, did you test the patch I posted and were you able to see the
same differences as with your patch? I still think that my short patch
is logically correct but if the tests are not we are in a no-go
position for any fix posted on this thread.
Yes, I tested both your patch and mine. I used the attached pg_ctl.c.
It adds -z option which disables SECURITY_SERVICE_RID.
I registered the service with "pg_ctl register -N pg -D
datadir -w -z -S demand -U myuser -P mypass", then started the service
with "net start pg". The following messages were output in the server
log:
LOG: pgwin32_is_admin = 0
LOG: pgwin32_is_service = 0
LOG: database system was shut down at 2016-11-07 22:04:46 JST
LOG: MultiXact member wraparound protections are now enabled
LOG: database system is ready to accept connections
LOG: autovacuum launcher started
Without -z, the message becomes "pgwin32_is_service = 1". And without
the win32security.c patch, "pgwin32_is_service = 1" is output.
I guess you registered the service without specifying the service
account with -U. Then the service runs as the Local System account,
whence pgwin32_is_service() returns 1.
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
pg_ctl.c (text/plain, 62.5K) download
/*--------------------------------------------------------------------
-----
*
* pg_ctl --- start/stops/restarts the PostgreSQL server
*
* Portions Copyright (c) 1996-2016, PostgreSQL Global Development
Group
*
* src/bin/pg_ctl/pg_ctl.c
*
*--------------------------------------------------------------------
-----
*/
#ifdef WIN32
/*
* Need this to get defines for restricted tokens and jobs. And it
* has to be set before any header from the Win32 API is loaded.
*/
#define _WIN32_WINNT 0x0501
#endif
#include "postgres_fe.h"
#include "libpq-fe.h"
#include "pqexpbuffer.h"
#include <fcntl.h>
#include <locale.h>
#include <signal.h>
#include <time.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/wait.h>
#include <unistd.h>
#ifdef HAVE_SYS_RESOURCE_H
#include <sys/time.h>
#include <sys/resource.h>
#endif
#include "getopt_long.h"
#include "miscadmin.h"
/* PID can be negative for standalone backend */
typedef long pgpid_t;
typedef enum
{
SMART_MODE,
FAST_MODE,
IMMEDIATE_MODE
} ShutdownMode;
typedef enum
{
NO_COMMAND = 0,
INIT_COMMAND,
START_COMMAND,
STOP_COMMAND,
RESTART_COMMAND,
RELOAD_COMMAND,
STATUS_COMMAND,
PROMOTE_COMMAND,
KILL_COMMAND,
REGISTER_COMMAND,
UNREGISTER_COMMAND,
RUN_AS_SERVICE_COMMAND
} CtlCommand;
#define DEFAULT_WAIT 60
static bool do_wait = false;
static bool del_service_rid = false;
static bool wait_set = false;
static int wait_seconds = DEFAULT_WAIT;
static bool wait_seconds_arg = false;
static bool silent_mode = false;
static ShutdownMode shutdown_mode = FAST_MODE;
static int sig = SIGINT; /* default */
static CtlCommand ctl_command = NO_COMMAND;
static char *pg_data = NULL;
static char *pg_config = NULL;
static char *pgdata_opt = NULL;
static char *post_opts = NULL;
static const char *progname;
static char *log_file = NULL;
static char *exec_path = NULL;
static char *event_source = NULL;
static char *register_servicename = "PostgreSQL"; /* FIXME: +
version ID? */
static char *register_username = NULL;
static char *register_password = NULL;
static char *argv0 = NULL;
static bool allow_core_files = false;
static time_t start_time;
static char postopts_file[MAXPGPATH];
static char version_file[MAXPGPATH];
static char pid_file[MAXPGPATH];
static char backup_file[MAXPGPATH];
static char recovery_file[MAXPGPATH];
static char promote_file[MAXPGPATH];
#ifdef WIN32
static DWORD pgctl_start_type = SERVICE_AUTO_START;
static SERVICE_STATUS status;
static SERVICE_STATUS_HANDLE hStatus = (SERVICE_STATUS_HANDLE) 0;
static HANDLE shutdownHandles[2];
static pid_t postmasterPID = -1;
#define shutdownEvent shutdownHandles[0]
#define postmasterProcess shutdownHandles[1]
#endif
static void write_stderr(const char *fmt,...) pg_attribute_printf(1,
2);
static void do_advice(void);
static void do_help(void);
static void set_mode(char *modeopt);
static void set_sig(char *signame);
static void do_init(void);
static void do_start(void);
static void do_stop(void);
static void do_restart(void);
static void do_reload(void);
static void do_status(void);
static void do_promote(void);
static void do_kill(pgpid_t pid);
static void print_msg(const char *msg);
static void adjust_data_dir(void);
#ifdef WIN32
#if (_MSC_VER >= 1800)
#include <versionhelpers.h>
#else
static bool IsWindowsXPOrGreater(void);
static bool IsWindows7OrGreater(void);
#endif
static bool pgwin32_IsInstalled(SC_HANDLE);
static char *pgwin32_CommandLine(bool);
static void pgwin32_doRegister(void);
static void pgwin32_doUnregister(void);
static void pgwin32_SetServiceStatus(DWORD);
static void WINAPI pgwin32_ServiceHandler(DWORD);
static void WINAPI pgwin32_ServiceMain(DWORD, LPTSTR *);
static void pgwin32_doRunAsService(void);
static int CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION
*processInfo, bool as_service);
#endif
static pgpid_t get_pgpid(bool is_status_request);
static char **readfile(const char *path);
static void free_readfile(char **optlines);
static pgpid_t start_postmaster(void);
static void read_post_opts(void);
static PGPing test_postmaster_connection(pgpid_t pm_pid, bool
do_checkpoint);
static bool postmaster_is_alive(pid_t pid);
#if defined(HAVE_GETRLIMIT) && defined(RLIMIT_CORE)
static void unlimit_core_size(void);
#endif
#ifdef WIN32
static void
write_eventlog(int level, const char *line)
{
static HANDLE evtHandle = INVALID_HANDLE_VALUE;
if (silent_mode && level == EVENTLOG_INFORMATION_TYPE)
return;
if (evtHandle == INVALID_HANDLE_VALUE)
{
evtHandle = RegisterEventSource(NULL,
event_source ? event_source : DEFAULT_EVENT_SOURCE);
if (evtHandle == NULL)
{
evtHandle = INVALID_HANDLE_VALUE;
return;
}
}
ReportEvent(evtHandle,
level,
0,
0, /* All events are Id 0 */
NULL,
1,
0,
&line,
NULL);
}
#endif
/*
* Write errors to stderr (or by equal means when stderr is
* not available).
*/
static void
write_stderr(const char *fmt,...)
{
va_list ap;
va_start(ap, fmt);
#ifndef WIN32
/* On Unix, we just fprintf to stderr */
vfprintf(stderr, fmt, ap);
#else
/*
* On Win32, we print to stderr if running on a console, or write to
* eventlog if running as a service
*/
if (pgwin32_is_service()) /* Running as a service */
{
char errbuf[2048]; /* Arbitrary size? */
vsnprintf(errbuf, sizeof(errbuf), fmt, ap);
write_eventlog(EVENTLOG_ERROR_TYPE, errbuf);
}
else
/* Not running as service, write to stderr */
vfprintf(stderr, fmt, ap);
#endif
va_end(ap);
}
/*
* Given an already-localized string, print it to stdout unless the
* user has specified that no messages should be printed.
*/
static void
print_msg(const char *msg)
{
if (!silent_mode)
{
fputs(msg, stdout);
fflush(stdout);
}
}
static pgpid_t
get_pgpid(bool is_status_request)
{
FILE *pidf;
long pid;
struct stat statbuf;
if (stat(pg_data, &statbuf) != 0)
{
if (errno == ENOENT)
write_stderr(_("%s: directory \"%s\" does not exist\n"),
progname,
pg_data);
else
write_stderr(_("%s: could not access directory \"%s\": %s\n"),
progname,
pg_data, strerror(errno));
/*
* The Linux Standard Base Core Specification 3.1 says this should
* return '4, program or service status is unknown'
*
https://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-g
* eneric/iniscrptact.html
*/
exit(is_status_request ? 4 : 1);
}
if (stat(version_file, &statbuf) != 0 && errno == ENOENT)
{
write_stderr(_("%s: directory \"%s\" is not a database cluster
directory\n"),
progname, pg_data);
exit(is_status_request ? 4 : 1);
}
pidf = fopen(pid_file, "r");
if (pidf == NULL)
{
/* No pid file, not an error on startup */
if (errno == ENOENT)
return 0;
else
{
write_stderr(_("%s: could not open PID file \"%s\": %s\n"),
progname, pid_file, strerror(errno));
exit(1);
}
}
if (fscanf(pidf, "%ld", &pid) != 1)
{
/* Is the file empty? */
if (ftell(pidf) == 0 && feof(pidf))
write_stderr(_("%s: the PID file \"%s\" is empty\n"),
progname, pid_file);
else
write_stderr(_("%s: invalid data in PID file \"%s\"\n"),
progname, pid_file);
exit(1);
}
fclose(pidf);
return (pgpid_t) pid;
}
/*
* get the lines from a text file - return NULL if file can't be
opened
*/
static char **
readfile(const char *path)
{
int fd;
int nlines;
char **result;
char *buffer;
char *linebegin;
int i;
int n;
int len;
struct stat statbuf;
/*
* Slurp the file into memory.
*
* The file can change concurrently, so we read the whole file into
memory
* with a single read() call. That's not guaranteed to get an atomic
* snapshot, but in practice, for a small file, it's close enough
for the
* current use.
*/
fd = open(path, O_RDONLY | PG_BINARY, 0);
if (fd < 0)
return NULL;
if (fstat(fd, &statbuf) < 0)
{
close(fd);
return NULL;
}
if (statbuf.st_size == 0)
{
/* empty file */
close(fd);
result = (char **) pg_malloc(sizeof(char *));
*result = NULL;
return result;
}
buffer = pg_malloc(statbuf.st_size + 1);
len = read(fd, buffer, statbuf.st_size + 1);
close(fd);
if (len != statbuf.st_size)
{
/* oops, the file size changed between fstat and read */
free(buffer);
return NULL;
}
/*
* Count newlines. We expect there to be a newline after each full
line,
* including one at the end of file. If there isn't a newline at the
end,
* any characters after the last newline will be ignored.
*/
nlines = 0;
for (i = 0; i < len; i++)
{
if (buffer[i] == '\n')
nlines++;
}
/* set up the result buffer */
result = (char **) pg_malloc((nlines + 1) * sizeof(char *));
/* now split the buffer into lines */
linebegin = buffer;
n = 0;
for (i = 0; i < len; i++)
{
if (buffer[i] == '\n')
{
int slen = &buffer[i] - linebegin + 1;
char *linebuf = pg_malloc(slen + 1);
memcpy(linebuf, linebegin, slen);
linebuf[slen] = '\0';
result[n++] = linebuf;
linebegin = &buffer[i + 1];
}
}
result[n] = NULL;
free(buffer);
return result;
}
/*
* Free memory allocated for optlines through readfile()
*/
static void
free_readfile(char **optlines)
{
char *curr_line = NULL;
int i = 0;
if (!optlines)
return;
while ((curr_line = optlines[i++]))
free(curr_line);
free(optlines);
return;
}
/*
* start/test/stop routines
*/
/*
* Start the postmaster and return its PID.
*
* Currently, on Windows what we return is the PID of the shell
process
* that launched the postmaster (and, we trust, is waiting for it to
exit).
* So the PID is usable for "is the postmaster still running" checks,
* but cannot be compared directly to postmaster.pid.
*
* On Windows, we also save aside a handle to the shell process in
* "postmasterProcess", which the caller should close when done with
it.
*/
static pgpid_t
start_postmaster(void)
{
char cmd[MAXPGPATH];
#ifndef WIN32
pgpid_t pm_pid;
/* Flush stdio channels just before fork, to avoid double-output
problems */
fflush(stdout);
fflush(stderr);
pm_pid = fork();
if (pm_pid < 0)
{
/* fork failed */
write_stderr(_("%s: could not start server: %s\n"),
progname, strerror(errno));
exit(1);
}
if (pm_pid > 0)
{
/* fork succeeded, in parent */
return pm_pid;
}
/* fork succeeded, in child */
/*
* Since there might be quotes to handle here, it is easier simply
to pass
* everything to a shell to process them. Use exec so that the
postmaster
* has the same PID as the current child process.
*/
if (log_file != NULL)
snprintf(cmd, MAXPGPATH, "exec \"%s\" %s%s < \"%s\" >> \"%s\"
2>&1",
exec_path, pgdata_opt, post_opts,
DEVNULL, log_file);
else
snprintf(cmd, MAXPGPATH, "exec \"%s\" %s%s < \"%s\" 2>&1",
exec_path, pgdata_opt, post_opts, DEVNULL);
(void) execl("/bin/sh", "/bin/sh", "-c", cmd, (char *) NULL);
/* exec failed */
write_stderr(_("%s: could not start server: %s\n"),
progname, strerror(errno));
exit(1);
return 0; /* keep dumb compilers quiet */
#else /* WIN32 */
/*
* As with the Unix case, it's easiest to use the shell (CMD.EXE) to
* handle redirection etc. Unfortunately CMD.EXE lacks any
equivalent of
* "exec", so we don't get to find out the postmaster's PID
immediately.
*/
PROCESS_INFORMATION pi;
if (log_file != NULL)
snprintf(cmd, MAXPGPATH, "CMD /C \"\"%s\" %s%s < \"%s\" >> \"%s\"
2>&1\"",
exec_path, pgdata_opt, post_opts, DEVNULL, log_file);
else
snprintf(cmd, MAXPGPATH, "CMD /C \"\"%s\" %s%s < \"%s\" 2>&1\"",
exec_path, pgdata_opt, post_opts, DEVNULL);
if (!CreateRestrictedProcess(cmd, &pi, false))
{
write_stderr(_("%s: could not start server: error code %lu\n"),
progname, (unsigned long) GetLastError());
exit(1);
}
/* Don't close command process handle here; caller must do so */
postmasterProcess = pi.hProcess;
CloseHandle(pi.hThread);
return pi.dwProcessId; /* Shell's PID, not postmaster's! */
#endif /* WIN32 */
}
/*
* Find the pgport and try a connection
*
* On Unix, pm_pid is the PID of the just-launched postmaster. On
Windows,
* it may be the PID of an ancestor shell process, so we can't check
the
* contents of postmaster.pid quite as carefully.
*
* On Windows, the static variable postmasterProcess is an implicit
argument
* to this routine; it contains a handle to the postmaster process or
an
* ancestor shell process thereof.
*
* Note that the checkpoint parameter enables a Windows service
control
* manager checkpoint, it's got nothing to do with database
checkpoints!!
*/
static PGPing
test_postmaster_connection(pgpid_t pm_pid, bool do_checkpoint)
{
PGPing ret = PQPING_NO_RESPONSE;
char connstr[MAXPGPATH * 2 + 256];
int i;
/* if requested wait time is zero, return "still starting up" code
*/
if (wait_seconds <= 0)
return PQPING_REJECT;
connstr[0] = '\0';
for (i = 0; i < wait_seconds; i++)
{
/* Do we need a connection string? */
if (connstr[0] == '\0')
{
/*----------
* The number of lines in postmaster.pid tells us several
things:
*
* # of lines
* 0 lock file created but status not written
* 2 pre-9.1 server, shared memory not created
* 3 pre-9.1 server, shared memory created
* 5 9.1+ server, ports not opened
* 6 9.1+ server, shared memory not created
* 7 9.1+ server, shared memory created
*
* This code does not support pre-9.1 servers. On Unix machines
* we could consider extracting the port number from the shmem
* key, but that (a) is not robust, and (b) doesn't help with
* finding out the socket directory. And it wouldn't work
anyway
* on Windows.
*
* If we see less than 6 lines in postmaster.pid, just keep
* waiting.
*----------
*/
char **optlines;
/* Try to read the postmaster.pid file */
if ((optlines = readfile(pid_file)) != NULL &&
optlines[0] != NULL &&
optlines[1] != NULL &&
optlines[2] != NULL)
{
if (optlines[3] == NULL)
{
/* File is exactly three lines, must be pre-9.1 */
write_stderr(_("\n%s: -w option is not supported when
starting a pre-9.1 server\n"),
progname);
return PQPING_NO_ATTEMPT;
}
else if (optlines[4] != NULL &&
optlines[5] != NULL)
{
/* File is complete enough for us, parse it */
pgpid_t pmpid;
time_t pmstart;
/*
* Make sanity checks. If it's for the wrong PID, or the
* recorded start time is before pg_ctl started, then
* either we are looking at the wrong data directory, or
* this is a pre-existing pidfile that hasn't (yet?) been
* overwritten by our child postmaster. Allow 2 seconds
* slop for possible cross-process clock skew.
*/
pmpid = atol(optlines[LOCK_FILE_LINE_PID - 1]);
pmstart = atol(optlines[LOCK_FILE_LINE_START_TIME - 1]);
if (pmstart >= start_time - 2 &&
#ifndef WIN32
pmpid == pm_pid
#else
/* Windows can only reject standalone-backend PIDs */
pmpid > 0
#endif
)
{
/*
* OK, seems to be a valid pidfile from our child.
*/
int portnum;
char *sockdir;
char *hostaddr;
char host_str[MAXPGPATH];
/*
* Extract port number and host string to use. Prefer
* using Unix socket if available.
*/
portnum = atoi(optlines[LOCK_FILE_LINE_PORT - 1]);
sockdir = optlines[LOCK_FILE_LINE_SOCKET_DIR - 1];
hostaddr = optlines[LOCK_FILE_LINE_LISTEN_ADDR - 1];
/*
* While unix_socket_directories can accept relative
* directories, libpq's host parameter must have a
* leading slash to indicate a socket directory. So,
* ignore sockdir if it's relative, and try to use TCP
* instead.
*/
if (sockdir[0] == '/')
strlcpy(host_str, sockdir, sizeof(host_str));
else
strlcpy(host_str, hostaddr, sizeof(host_str));
/* remove trailing newline */
if (strchr(host_str, '\n') != NULL)
*strchr(host_str, '\n') = '\0';
/* Fail if couldn't get either sockdir or host addr */
if (host_str[0] == '\0')
{
write_stderr(_("\n%s: -w option cannot use a relative
socket directory specification\n"),
progname);
return PQPING_NO_ATTEMPT;
}
/*
* Map listen-only addresses to counterparts usable
* for establishing a connection. connect() to "::"
* or "0.0.0.0" is not portable to OpenBSD 5.0 or to
* Windows Server 2008, and connect() to "::" is
* additionally not portable to NetBSD 6.0. (Cygwin
* does handle both addresses, though.)
*/
if (strcmp(host_str, "*") == 0)
strcpy(host_str, "localhost");
else if (strcmp(host_str, "0.0.0.0") == 0)
strcpy(host_str, "127.0.0.1");
else if (strcmp(host_str, "::") == 0)
strcpy(host_str, "::1");
/*
* We need to set connect_timeout otherwise on Windows
* the Service Control Manager (SCM) will probably
* timeout first.
*/
snprintf(connstr, sizeof(connstr),
"dbname=postgres port=%d host='%s' connect_timeout=5",
portnum, host_str);
}
}
}
/*
* Free the results of readfile.
*
* This is safe to call even if optlines is NULL.
*/
free_readfile(optlines);
}
/* If we have a connection string, ping the server */
if (connstr[0] != '\0')
{
ret = PQping(connstr);
if (ret == PQPING_OK || ret == PQPING_NO_ATTEMPT)
break;
}
/*
* Check whether the child postmaster process is still alive.
This
* lets us exit early if the postmaster fails during startup.
*
* On Windows, we may be checking the postmaster's parent shell,
but
* that's fine for this purpose.
*/
#ifndef WIN32
{
int exitstatus;
if (waitpid((pid_t) pm_pid, &exitstatus, WNOHANG) == (pid_t)
pm_pid)
return PQPING_NO_RESPONSE;
}
#else
if (WaitForSingleObject(postmasterProcess, 0) == WAIT_OBJECT_0)
return PQPING_NO_RESPONSE;
#endif
/* No response, or startup still in process; wait */
#ifdef WIN32
if (do_checkpoint)
{
/*
* Increment the wait hint by 6 secs (connection timeout +
sleep)
* We must do this to indicate to the SCM that our startup time
is
* changing, otherwise it'll usually send a stop signal after 20
* seconds, despite incrementing the checkpoint counter.
*/
status.dwWaitHint += 6000;
status.dwCheckPoint++;
SetServiceStatus(hStatus, (LPSERVICE_STATUS) &status);
}
else
#endif
print_msg(".");
pg_usleep(1000000); /* 1 sec */
}
/* return result of last call to PQping */
return ret;
}
#if defined(HAVE_GETRLIMIT) && defined(RLIMIT_CORE)
static void
unlimit_core_size(void)
{
struct rlimit lim;
getrlimit(RLIMIT_CORE, &lim);
if (lim.rlim_max == 0)
{
write_stderr(_("%s: cannot set core file size limit; disallowed by
hard limit\n"),
progname);
return;
}
else if (lim.rlim_max == RLIM_INFINITY || lim.rlim_cur <
lim.rlim_max)
{
lim.rlim_cur = lim.rlim_max;
setrlimit(RLIMIT_CORE, &lim);
}
}
#endif
static void
read_post_opts(void)
{
if (post_opts == NULL)
{
post_opts = ""; /* default */
if (ctl_command == RESTART_COMMAND)
{
char **optlines;
optlines = readfile(postopts_file);
if (optlines == NULL)
{
write_stderr(_("%s: could not read file \"%s\"\n"), progname,
postopts_file);
exit(1);
}
else if (optlines[0] == NULL || optlines[1] != NULL)
{
write_stderr(_("%s: option file \"%s\" must have exactly one
line\n"),
progname, postopts_file);
exit(1);
}
else
{
int len;
char *optline;
char *arg1;
optline = optlines[0];
/* trim off line endings */
len = strcspn(optline, "\r\n");
optline[len] = '\0';
/*
* Are we at the first option, as defined by space and
* double-quote?
*/
if ((arg1 = strstr(optline, " \"")) != NULL)
{
*arg1 = '\0'; /* terminate so we get only program
* name */
post_opts = pg_strdup(arg1 + 1); /* point past whitespace
*/
}
if (exec_path == NULL)
exec_path = pg_strdup(optline);
}
/* Free the results of readfile. */
free_readfile(optlines);
}
}
}
static char *
find_other_exec_or_die(const char *argv0, const char *target, const
char *versionstr)
{
int ret;
char *found_path;
found_path = pg_malloc(MAXPGPATH);
if ((ret = find_other_exec(argv0, target, versionstr, found_path)) <
0)
{
char full_path[MAXPGPATH];
if (find_my_exec(argv0, full_path) < 0)
strlcpy(full_path, progname, sizeof(full_path));
if (ret == -1)
write_stderr(_("The program \"%s\" is needed by %s "
"but was not found in the\n"
"same directory as \"%s\".\n"
"Check your installation.\n"),
target, progname, full_path);
else
write_stderr(_("The program \"%s\" was found by \"%s\"\n"
"but was not the same version as %s.\n"
"Check your installation.\n"),
target, full_path, progname);
exit(1);
}
return found_path;
}
static void
do_init(void)
{
char cmd[MAXPGPATH];
if (exec_path == NULL)
exec_path = find_other_exec_or_die(argv0, "initdb", "initdb
(PostgreSQL) " PG_VERSION "\n");
if (pgdata_opt == NULL)
pgdata_opt = "";
if (post_opts == NULL)
post_opts = "";
if (!silent_mode)
snprintf(cmd, MAXPGPATH, "\"%s\" %s%s",
exec_path, pgdata_opt, post_opts);
else
snprintf(cmd, MAXPGPATH, "\"%s\" %s%s > \"%s\"",
exec_path, pgdata_opt, post_opts, DEVNULL);
if (system(cmd) != 0)
{
write_stderr(_("%s: database system initialization failed\n"),
progname);
exit(1);
}
}
static void
do_start(void)
{
pgpid_t old_pid = 0;
pgpid_t pm_pid;
if (ctl_command != RESTART_COMMAND)
{
old_pid = get_pgpid(false);
if (old_pid != 0)
write_stderr(_("%s: another server might be running; "
"trying to start server anyway\n"),
progname);
}
read_post_opts();
/* No -D or -D already added during server start */
if (ctl_command == RESTART_COMMAND || pgdata_opt == NULL)
pgdata_opt = "";
if (exec_path == NULL)
exec_path = find_other_exec_or_die(argv0, "postgres",
PG_BACKEND_VERSIONSTR);
#if defined(HAVE_GETRLIMIT) && defined(RLIMIT_CORE)
if (allow_core_files)
unlimit_core_size();
#endif
/*
* If possible, tell the postmaster our parent shell's PID (see the
* comments in CreateLockFile() for motivation). Windows hasn't got
* getppid() unfortunately.
*/
#ifndef WIN32
{
static char env_var[32];
snprintf(env_var, sizeof(env_var), "PG_GRANDPARENT_PID=%d",
(int) getppid());
putenv(env_var);
}
#endif
pm_pid = start_postmaster();
if (do_wait)
{
print_msg(_("waiting for server to start..."));
switch (test_postmaster_connection(pm_pid, false))
{
case PQPING_OK:
print_msg(_(" done\n"));
print_msg(_("server started\n"));
break;
case PQPING_REJECT:
print_msg(_(" stopped waiting\n"));
print_msg(_("server is still starting up\n"));
break;
case PQPING_NO_RESPONSE:
print_msg(_(" stopped waiting\n"));
write_stderr(_("%s: could not start server\n"
"Examine the log output.\n"),
progname);
exit(1);
break;
case PQPING_NO_ATTEMPT:
print_msg(_(" failed\n"));
write_stderr(_("%s: could not wait for server because of
misconfiguration\n"),
progname);
exit(1);
}
}
else
print_msg(_("server starting\n"));
#ifdef WIN32
/* Now we don't need the handle to the shell process anymore */
CloseHandle(postmasterProcess);
postmasterProcess = INVALID_HANDLE_VALUE;
#endif
}
static void
do_stop(void)
{
int cnt;
pgpid_t pid;
struct stat statbuf;
pid = get_pgpid(false);
if (pid == 0) /* no pid file */
{
write_stderr(_("%s: PID file \"%s\" does not exist\n"), progname,
pid_file);
write_stderr(_("Is server running?\n"));
exit(1);
}
else if (pid < 0) /* standalone backend, not postmaster */
{
pid = -pid;
write_stderr(_("%s: cannot stop server; "
"single-user server is running (PID: %ld)\n"),
progname, pid);
exit(1);
}
if (kill((pid_t) pid, sig) != 0)
{
write_stderr(_("%s: could not send stop signal (PID: %ld): %s\n"),
progname, pid,
strerror(errno));
exit(1);
}
if (!do_wait)
{
print_msg(_("server shutting down\n"));
return;
}
else
{
/*
* If backup_label exists, an online backup is running. Warn the
user
* that smart shutdown will wait for it to finish. However, if
* recovery.conf is also present, we're recovering from an online
* backup instead of performing one.
*/
if (shutdown_mode == SMART_MODE &&
stat(backup_file, &statbuf) == 0 &&
stat(recovery_file, &statbuf) != 0)
{
print_msg(_("WARNING: online backup mode is active\n"
"Shutdown will not complete until pg_stop_backup() is
called.\n\n"));
}
print_msg(_("waiting for server to shut down..."));
for (cnt = 0; cnt < wait_seconds; cnt++)
{
if ((pid = get_pgpid(false)) != 0)
{
print_msg(".");
pg_usleep(1000000); /* 1 sec */
}
else
break;
}
if (pid != 0) /* pid file still exists */
{
print_msg(_(" failed\n"));
write_stderr(_("%s: server does not shut down\n"), progname);
if (shutdown_mode == SMART_MODE)
write_stderr(_("HINT: The \"-m fast\" option immediately
disconnects sessions rather than\n"
"waiting for session-initiated disconnection.\n"));
exit(1);
}
print_msg(_(" done\n"));
print_msg(_("server stopped\n"));
}
}
/*
* restart/reload routines
*/
static void
do_restart(void)
{
int cnt;
pgpid_t pid;
struct stat statbuf;
pid = get_pgpid(false);
if (pid == 0) /* no pid file */
{
write_stderr(_("%s: PID file \"%s\" does not exist\n"),
progname, pid_file);
write_stderr(_("Is server running?\n"));
write_stderr(_("starting server anyway\n"));
do_start();
return;
}
else if (pid < 0) /* standalone backend, not postmaster */
{
pid = -pid;
if (postmaster_is_alive((pid_t) pid))
{
write_stderr(_("%s: cannot restart server; "
"single-user server is running (PID: %ld)\n"),
progname, pid);
write_stderr(_("Please terminate the single-user server and try
again.\n"));
exit(1);
}
}
if (postmaster_is_alive((pid_t) pid))
{
if (kill((pid_t) pid, sig) != 0)
{
write_stderr(_("%s: could not send stop signal (PID: %ld):
%s\n"), progname, pid,
strerror(errno));
exit(1);
}
/*
* If backup_label exists, an online backup is running. Warn the
user
* that smart shutdown will wait for it to finish. However, if
* recovery.conf is also present, we're recovering from an online
* backup instead of performing one.
*/
if (shutdown_mode == SMART_MODE &&
stat(backup_file, &statbuf) == 0 &&
stat(recovery_file, &statbuf) != 0)
{
print_msg(_("WARNING: online backup mode is active\n"
"Shutdown will not complete until pg_stop_backup() is
called.\n\n"));
}
print_msg(_("waiting for server to shut down..."));
/* always wait for restart */
for (cnt = 0; cnt < wait_seconds; cnt++)
{
if ((pid = get_pgpid(false)) != 0)
{
print_msg(".");
pg_usleep(1000000); /* 1 sec */
}
else
break;
}
if (pid != 0) /* pid file still exists */
{
print_msg(_(" failed\n"));
write_stderr(_("%s: server does not shut down\n"), progname);
if (shutdown_mode == SMART_MODE)
write_stderr(_("HINT: The \"-m fast\" option immediately
disconnects sessions rather than\n"
"waiting for session-initiated disconnection.\n"));
exit(1);
}
print_msg(_(" done\n"));
print_msg(_("server stopped\n"));
}
else
{
write_stderr(_("%s: old server process (PID: %ld) seems to be
gone\n"),
progname, pid);
write_stderr(_("starting server anyway\n"));
}
do_start();
}
static void
do_reload(void)
{
pgpid_t pid;
pid = get_pgpid(false);
if (pid == 0) /* no pid file */
{
write_stderr(_("%s: PID file \"%s\" does not exist\n"), progname,
pid_file);
write_stderr(_("Is server running?\n"));
exit(1);
}
else if (pid < 0) /* standalone backend, not postmaster */
{
pid = -pid;
write_stderr(_("%s: cannot reload server; "
"single-user server is running (PID: %ld)\n"),
progname, pid);
write_stderr(_("Please terminate the single-user server and try
again.\n"));
exit(1);
}
if (kill((pid_t) pid, sig) != 0)
{
write_stderr(_("%s: could not send reload signal (PID: %ld):
%s\n"),
progname, pid, strerror(errno));
exit(1);
}
print_msg(_("server signaled\n"));
}
/*
* promote
*/
static void
do_promote(void)
{
FILE *prmfile;
pgpid_t pid;
struct stat statbuf;
pid = get_pgpid(false);
if (pid == 0) /* no pid file */
{
write_stderr(_("%s: PID file \"%s\" does not exist\n"), progname,
pid_file);
write_stderr(_("Is server running?\n"));
exit(1);
}
else if (pid < 0) /* standalone backend, not postmaster */
{
pid = -pid;
write_stderr(_("%s: cannot promote server; "
"single-user server is running (PID: %ld)\n"),
progname, pid);
exit(1);
}
/* If recovery.conf doesn't exist, the server is not in standby mode
*/
if (stat(recovery_file, &statbuf) != 0)
{
write_stderr(_("%s: cannot promote server; "
"server is not in standby mode\n"),
progname);
exit(1);
}
/*
* For 9.3 onwards, "fast" promotion is performed. Promotion with a
full
* checkpoint is still possible by writing a file called
* "fallback_promote" instead of "promote"
*/
snprintf(promote_file, MAXPGPATH, "%s/promote", pg_data);
if ((prmfile = fopen(promote_file, "w")) == NULL)
{
write_stderr(_("%s: could not create promote signal file \"%s\":
%s\n"),
progname, promote_file, strerror(errno));
exit(1);
}
if (fclose(prmfile))
{
write_stderr(_("%s: could not write promote signal file \"%s\":
%s\n"),
progname, promote_file, strerror(errno));
exit(1);
}
sig = SIGUSR1;
if (kill((pid_t) pid, sig) != 0)
{
write_stderr(_("%s: could not send promote signal (PID: %ld):
%s\n"),
progname, pid, strerror(errno));
if (unlink(promote_file) != 0)
write_stderr(_("%s: could not remove promote signal file \"%s\":
%s\n"),
progname, promote_file, strerror(errno));
exit(1);
}
print_msg(_("server promoting\n"));
}
/*
* utility routines
*/
static bool
postmaster_is_alive(pid_t pid)
{
/*
* Test to see if the process is still there. Note that we do not
* consider an EPERM failure to mean that the process is still
there;
* EPERM must mean that the given PID belongs to some other userid,
and
* considering the permissions on $PGDATA, that means it's not the
* postmaster we are after.
*
* Don't believe that our own PID or parent shell's PID is the
postmaster,
* either. (Windows hasn't got getppid(), though.)
*/
if (pid == getpid())
return false;
#ifndef WIN32
if (pid == getppid())
return false;
#endif
if (kill(pid, 0) == 0)
return true;
return false;
}
static void
do_status(void)
{
pgpid_t pid;
pid = get_pgpid(true);
/* Is there a pid file? */
if (pid != 0)
{
/* standalone backend? */
if (pid < 0)
{
pid = -pid;
if (postmaster_is_alive((pid_t) pid))
{
printf(_("%s: single-user server is running (PID: %ld)\n"),
progname, pid);
return;
}
}
else
/* must be a postmaster */
{
if (postmaster_is_alive((pid_t) pid))
{
char **optlines;
char **curr_line;
printf(_("%s: server is running (PID: %ld)\n"),
progname, pid);
optlines = readfile(postopts_file);
if (optlines != NULL)
{
for (curr_line = optlines; *curr_line != NULL; curr_line++)
fputs(*curr_line, stdout);
/* Free the results of readfile */
free_readfile(optlines);
}
return;
}
}
}
printf(_("%s: no server running\n"), progname);
/*
* The Linux Standard Base Core Specification 3.1 says this should
return
* '3, program is not running'
*
https://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-gen
er
* ic/iniscrptact.html
*/
exit(3);
}
static void
do_kill(pgpid_t pid)
{
if (kill((pid_t) pid, sig) != 0)
{
write_stderr(_("%s: could not send signal %d (PID: %ld): %s\n"),
progname, sig, pid, strerror(errno));
exit(1);
}
}
#ifdef WIN32
#if (_MSC_VER < 1800)
static bool
IsWindowsXPOrGreater(void)
{
OSVERSIONINFO osv;
osv.dwOSVersionInfoSize = sizeof(osv);
/* Windows XP = Version 5.1 */
return (!GetVersionEx(&osv) || /* could not get version */
osv.dwMajorVersion > 5 || (osv.dwMajorVersion == 5 &&
osv.dwMinorVersion >= 1));
}
static bool
IsWindows7OrGreater(void)
{
OSVERSIONINFO osv;
osv.dwOSVersionInfoSize = sizeof(osv);
/* Windows 7 = Version 6.0 */
return (!GetVersionEx(&osv) || /* could not get version */
osv.dwMajorVersion > 6 || (osv.dwMajorVersion == 6 &&
osv.dwMinorVersion >= 0));
}
#endif
static bool
pgwin32_IsInstalled(SC_HANDLE hSCM)
{
SC_HANDLE hService = OpenService(hSCM, register_servicename,
SERVICE_QUERY_CONFIG);
bool bResult = (hService != NULL);
if (bResult)
CloseServiceHandle(hService);
return bResult;
}
static char *
pgwin32_CommandLine(bool registration)
{
PQExpBuffer cmdLine = createPQExpBuffer();
char cmdPath[MAXPGPATH];
int ret;
if (registration)
{
ret = find_my_exec(argv0, cmdPath);
if (ret != 0)
{
write_stderr(_("%s: could not find own program executable\n"),
progname);
exit(1);
}
}
else
{
ret = find_other_exec(argv0, "postgres", PG_BACKEND_VERSIONSTR,
cmdPath);
if (ret != 0)
{
write_stderr(_("%s: could not find postgres program
executable\n"), progname);
exit(1);
}
}
/* if path does not end in .exe, append it */
if (strlen(cmdPath) < 4 ||
pg_strcasecmp(cmdPath + strlen(cmdPath) - 4, ".exe") != 0)
snprintf(cmdPath + strlen(cmdPath), sizeof(cmdPath) -
strlen(cmdPath),
".exe");
/* use backslashes in path to avoid problems with some third-party
tools */
make_native_path(cmdPath);
/* be sure to double-quote the executable's name in the command */
appendPQExpBuffer(cmdLine, "\"%s\"", cmdPath);
/* append assorted switches to the command line, as needed */
if (registration)
appendPQExpBuffer(cmdLine, " runservice -N \"%s\"",
register_servicename);
if (pg_config)
{
/* We need the -D path to be absolute */
char *dataDir;
if ((dataDir = make_absolute_path(pg_config)) == NULL)
{
/* make_absolute_path already reported the error */
exit(1);
}
make_native_path(dataDir);
appendPQExpBuffer(cmdLine, " -D \"%s\"", dataDir);
free(dataDir);
}
if (registration && event_source != NULL)
appendPQExpBuffer(cmdLine, " -e \"%s\"", event_source);
if (registration && do_wait)
appendPQExpBuffer(cmdLine, " -w");
if (registration && del_service_rid)
appendPQExpBuffer(cmdLine, " -z");
/* Don't propagate a value from an environment variable. */
if (registration && wait_seconds_arg && wait_seconds !=
DEFAULT_WAIT)
appendPQExpBuffer(cmdLine, " -t %d", wait_seconds);
if (registration && silent_mode)
appendPQExpBuffer(cmdLine, " -s");
if (post_opts)
{
if (registration)
appendPQExpBuffer(cmdLine, " -o \"%s\"", post_opts);
else
appendPQExpBuffer(cmdLine, " %s", post_opts);
}
return cmdLine->data;
}
static void
pgwin32_doRegister(void)
{
SC_HANDLE hService;
SC_HANDLE hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
if (hSCM == NULL)
{
write_stderr(_("%s: could not open service manager\n"), progname);
exit(1);
}
if (pgwin32_IsInstalled(hSCM))
{
CloseServiceHandle(hSCM);
write_stderr(_("%s: service \"%s\" already registered\n"),
progname, register_servicename);
exit(1);
}
if ((hService = CreateService(hSCM, register_servicename,
register_servicename,
SERVICE_ALL_ACCESS, SERVICE_WIN32_OWN_PROCESS,
pgctl_start_type, SERVICE_ERROR_NORMAL,
pgwin32_CommandLine(true),
NULL, NULL, "RPCSS\0", register_username, register_password)) ==
NULL)
{
CloseServiceHandle(hSCM);
write_stderr(_("%s: could not register service \"%s\": error code
%lu\n"),
progname, register_servicename,
(unsigned long) GetLastError());
exit(1);
}
CloseServiceHandle(hService);
CloseServiceHandle(hSCM);
}
static void
pgwin32_doUnregister(void)
{
SC_HANDLE hService;
SC_HANDLE hSCM = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
if (hSCM == NULL)
{
write_stderr(_("%s: could not open service manager\n"), progname);
exit(1);
}
if (!pgwin32_IsInstalled(hSCM))
{
CloseServiceHandle(hSCM);
write_stderr(_("%s: service \"%s\" not registered\n"), progname,
register_servicename);
exit(1);
}
if ((hService = OpenService(hSCM, register_servicename, DELETE)) ==
NULL)
{
CloseServiceHandle(hSCM);
write_stderr(_("%s: could not open service \"%s\": error code
%lu\n"),
progname, register_servicename,
(unsigned long) GetLastError());
exit(1);
}
if (!DeleteService(hService))
{
CloseServiceHandle(hService);
CloseServiceHandle(hSCM);
write_stderr(_("%s: could not unregister service \"%s\": error
code %lu\n"),
progname, register_servicename,
(unsigned long) GetLastError());
exit(1);
}
CloseServiceHandle(hService);
CloseServiceHandle(hSCM);
}
static void
pgwin32_SetServiceStatus(DWORD currentState)
{
status.dwCurrentState = currentState;
SetServiceStatus(hStatus, (LPSERVICE_STATUS) &status);
}
static void WINAPI
pgwin32_ServiceHandler(DWORD request)
{
switch (request)
{
case SERVICE_CONTROL_STOP:
case SERVICE_CONTROL_SHUTDOWN:
/*
* We only need a short wait hint here as it just needs to wait
* for the next checkpoint. They occur every 5 seconds during
* shutdown
*/
status.dwWaitHint = 10000;
pgwin32_SetServiceStatus(SERVICE_STOP_PENDING);
SetEvent(shutdownEvent);
return;
case SERVICE_CONTROL_PAUSE:
/* Win32 config reloading */
status.dwWaitHint = 5000;
kill(postmasterPID, SIGHUP);
return;
/* FIXME: These could be used to replace other signals etc */
case SERVICE_CONTROL_CONTINUE:
case SERVICE_CONTROL_INTERROGATE:
default:
break;
}
}
static void WINAPI
pgwin32_ServiceMain(DWORD argc, LPTSTR *argv)
{
PROCESS_INFORMATION pi;
DWORD ret;
/* Initialize variables */
status.dwWin32ExitCode = S_OK;
status.dwCheckPoint = 0;
status.dwWaitHint = 60000;
status.dwServiceType = SERVICE_WIN32_OWN_PROCESS;
status.dwControlsAccepted = SERVICE_ACCEPT_STOP |
SERVICE_ACCEPT_SHUTDOWN | SERVICE_ACCEPT_PAUSE_CONTINUE;
status.dwServiceSpecificExitCode = 0;
status.dwCurrentState = SERVICE_START_PENDING;
memset(&pi, 0, sizeof(pi));
read_post_opts();
/* Register the control request handler */
if ((hStatus = RegisterServiceCtrlHandler(register_servicename,
pgwin32_ServiceHandler)) == (SERVICE_STATUS_HANDLE) 0)
return;
if ((shutdownEvent = CreateEvent(NULL, true, false, NULL)) == NULL)
return;
/* Start the postmaster */
pgwin32_SetServiceStatus(SERVICE_START_PENDING);
if (!CreateRestrictedProcess(pgwin32_CommandLine(false), &pi, true))
{
pgwin32_SetServiceStatus(SERVICE_STOPPED);
return;
}
postmasterPID = pi.dwProcessId;
postmasterProcess = pi.hProcess;
CloseHandle(pi.hThread);
if (do_wait)
{
write_eventlog(EVENTLOG_INFORMATION_TYPE, _("Waiting for server
startup...\n"));
if (test_postmaster_connection(postmasterPID, true) != PQPING_OK)
{
write_eventlog(EVENTLOG_ERROR_TYPE, _("Timed out waiting for
server startup\n"));
pgwin32_SetServiceStatus(SERVICE_STOPPED);
return;
}
write_eventlog(EVENTLOG_INFORMATION_TYPE, _("Server started and
accepting connections\n"));
}
pgwin32_SetServiceStatus(SERVICE_RUNNING);
/* Wait for quit... */
ret = WaitForMultipleObjects(2, shutdownHandles, FALSE, INFINITE);
pgwin32_SetServiceStatus(SERVICE_STOP_PENDING);
switch (ret)
{
case WAIT_OBJECT_0: /* shutdown event */
{
/*
* status.dwCheckPoint can be incremented by
* test_postmaster_connection(), so it might not start from 0.
*/
int maxShutdownCheckPoint = status.dwCheckPoint + 12;
kill(postmasterPID, SIGINT);
/*
* Increment the checkpoint and try again. Abort after 12
* checkpoints as the postmaster has probably hung.
*/
while (WaitForSingleObject(postmasterProcess, 5000) ==
WAIT_TIMEOUT && status.dwCheckPoint < maxShutdownCheckPoint)
{
status.dwCheckPoint++;
SetServiceStatus(hStatus, (LPSERVICE_STATUS) &status);
}
break;
}
case (WAIT_OBJECT_0 + 1): /* postmaster went down */
break;
default:
/* shouldn't get here? */
break;
}
CloseHandle(shutdownEvent);
CloseHandle(postmasterProcess);
pgwin32_SetServiceStatus(SERVICE_STOPPED);
}
static void
pgwin32_doRunAsService(void)
{
SERVICE_TABLE_ENTRY st[] = {{register_servicename,
pgwin32_ServiceMain},
{NULL, NULL}};
if (StartServiceCtrlDispatcher(st) == 0)
{
write_stderr(_("%s: could not start service \"%s\": error code
%lu\n"),
progname, register_servicename,
(unsigned long) GetLastError());
exit(1);
}
}
/*
* Mingw headers are incomplete, and so are the libraries. So we have
to load
* a whole lot of API functions dynamically. Since we have to do this
anyway,
* also load the couple of functions that *do* exist in minwg headers
but not
* on NT4. That way, we don't break on NT4.
*/
typedef BOOL (WINAPI * __CreateRestrictedToken) (HANDLE, DWORD, DWORD,
PSID_AND_ATTRIBUTES, DWORD, PLUID_AND_ATTRIBUTES, DWORD,
PSID_AND_ATTRIBUTES, PHANDLE);
typedef BOOL (WINAPI * __IsProcessInJob) (HANDLE, HANDLE, PBOOL);
typedef HANDLE (WINAPI * __CreateJobObject) (LPSECURITY_ATTRIBUTES,
LPCTSTR);
typedef BOOL (WINAPI * __SetInformationJobObject) (HANDLE,
JOBOBJECTINFOCLASS, LPVOID, DWORD);
typedef BOOL (WINAPI * __AssignProcessToJobObject) (HANDLE, HANDLE);
typedef BOOL (WINAPI * __QueryInformationJobObject) (HANDLE,
JOBOBJECTINFOCLASS, LPVOID, DWORD, LPDWORD);
/* Windows API define missing from some versions of MingW headers */
#ifndef DISABLE_MAX_PRIVILEGE
#define DISABLE_MAX_PRIVILEGE 0x1
#endif
/*
* Create a restricted token, a job object sandbox, and execute the
specified
* process with it.
*
* Returns 0 on success, non-zero on failure, same as CreateProcess().
*
* On NT4, or any other system not containing the required functions,
will
* launch the process under the current token without doing any
modifications.
*
* NOTE! Job object will only work when running as a service, because
it's
* automatically destroyed when pg_ctl exits.
*/
static int
CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo,
bool as_service)
{
int r;
BOOL b;
STARTUPINFO si;
HANDLE origToken;
HANDLE restrictedToken;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
SID_AND_ATTRIBUTES dropSids[3];
/* Functions loaded dynamically */
__CreateRestrictedToken _CreateRestrictedToken = NULL;
__IsProcessInJob _IsProcessInJob = NULL;
__CreateJobObject _CreateJobObject = NULL;
__SetInformationJobObject _SetInformationJobObject = NULL;
__AssignProcessToJobObject _AssignProcessToJobObject = NULL;
__QueryInformationJobObject _QueryInformationJobObject = NULL;
HANDLE Kernel32Handle;
HANDLE Advapi32Handle;
ZeroMemory(&si, sizeof(si));
si.cb = sizeof(si);
Advapi32Handle = LoadLibrary("ADVAPI32.DLL");
if (Advapi32Handle != NULL)
{
_CreateRestrictedToken = (__CreateRestrictedToken)
GetProcAddress(Advapi32Handle, "CreateRestrictedToken");
}
if (_CreateRestrictedToken == NULL)
{
/*
* NT4 doesn't have CreateRestrictedToken, so just call ordinary
* CreateProcess
*/
write_stderr(_("%s: WARNING: cannot create restricted tokens on
this platform\n"), progname);
if (Advapi32Handle != NULL)
FreeLibrary(Advapi32Handle);
return CreateProcess(NULL, cmd, NULL, NULL, FALSE, 0, NULL, NULL,
&si, processInfo);
}
/* Open the current token to use as a base for the restricted one */
if (!OpenProcessToken(GetCurrentProcess(), TOKEN_ALL_ACCESS,
&origToken))
{
/*
* Most Windows targets make DWORD a 32-bit unsigned long, but in
case
* it doesn't cast DWORD before printing.
*/
write_stderr(_("%s: could not open process token: error code
%lu\n"),
progname, (unsigned long) GetLastError());
return 0;
}
/* Allocate list of SIDs to remove */
ZeroMemory(&dropSids, sizeof(dropSids));
if (!AllocateAndInitializeSid(&NtAuthority, 2,
SECURITY_BUILTIN_DOMAIN_RID, DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0,
0,
0, &dropSids[0].Sid) ||
!AllocateAndInitializeSid(&NtAuthority, 2,
SECURITY_BUILTIN_DOMAIN_RID, DOMAIN_ALIAS_RID_POWER_USERS, 0, 0, 0,
0, 0,
0, &dropSids[1].Sid) ||
!AllocateAndInitializeSid(&NtAuthority, 1,
SECURITY_SERVICE_RID, 0, 0, 0, 0, 0, 0,
0, &dropSids[2].Sid))
{
write_stderr(_("%s: could not allocate SIDs: error code %lu\n"),
progname, (unsigned long) GetLastError());
return 0;
}
b = _CreateRestrictedToken(origToken,
0,
del_service_rid ?
(sizeof(dropSids) / sizeof(dropSids[0])) :
(sizeof(dropSids) / sizeof(dropSids[0]) - 1),
dropSids,
0, NULL,
0, NULL,
&restrictedToken);
FreeSid(dropSids[1].Sid);
FreeSid(dropSids[0].Sid);
CloseHandle(origToken);
FreeLibrary(Advapi32Handle);
if (!b)
{
write_stderr(_("%s: could not create restricted token: error code
%lu\n"),
progname, (unsigned long) GetLastError());
return 0;
}
AddUserToTokenDacl(restrictedToken);
r = CreateProcessAsUser(restrictedToken, NULL, cmd, NULL, NULL,
TRUE, CREATE_SUSPENDED, NULL, NULL, &si, processInfo);
Kernel32Handle = LoadLibrary("KERNEL32.DLL");
if (Kernel32Handle != NULL)
{
_IsProcessInJob = (__IsProcessInJob)
GetProcAddress(Kernel32Handle, "IsProcessInJob");
_CreateJobObject = (__CreateJobObject)
GetProcAddress(Kernel32Handle, "CreateJobObjectA");
_SetInformationJobObject = (__SetInformationJobObject)
GetProcAddress(Kernel32Handle, "SetInformationJobObject");
_AssignProcessToJobObject = (__AssignProcessToJobObject)
GetProcAddress(Kernel32Handle, "AssignProcessToJobObject");
_QueryInformationJobObject = (__QueryInformationJobObject)
GetProcAddress(Kernel32Handle, "QueryInformationJobObject");
}
/* Verify that we found all functions */
if (_IsProcessInJob == NULL || _CreateJobObject == NULL ||
_SetInformationJobObject == NULL || _AssignProcessToJobObject == NULL
|| _QueryInformationJobObject == NULL)
{
/*
* IsProcessInJob() is not available on < WinXP, so there is no
need
* to log the error every time in that case
*/
if (IsWindowsXPOrGreater())
/*
* Log error if we can't get version, or if we're on WinXP/2003
or
* newer
*/
write_stderr(_("%s: WARNING: could not locate all job object
functions in system API\n"), progname);
}
else
{
BOOL inJob;
if (_IsProcessInJob(processInfo->hProcess, NULL, &inJob))
{
if (!inJob)
{
/*
* Job objects are working, and the new process isn't in one,
* so we can create one safely. If any problems show up when
* setting it, we're going to ignore them.
*/
HANDLE job;
char jobname[128];
sprintf(jobname, "PostgreSQL_%lu",
(unsigned long) processInfo->dwProcessId);
job = _CreateJobObject(NULL, jobname);
if (job)
{
JOBOBJECT_BASIC_LIMIT_INFORMATION basicLimit;
JOBOBJECT_BASIC_UI_RESTRICTIONS uiRestrictions;
JOBOBJECT_SECURITY_LIMIT_INFORMATION securityLimit;
ZeroMemory(&basicLimit, sizeof(basicLimit));
ZeroMemory(&uiRestrictions, sizeof(uiRestrictions));
ZeroMemory(&securityLimit, sizeof(securityLimit));
basicLimit.LimitFlags =
JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION |
JOB_OBJECT_LIMIT_PRIORITY_CLASS;
basicLimit.PriorityClass = NORMAL_PRIORITY_CLASS;
_SetInformationJobObject(job,
JobObjectBasicLimitInformation, &basicLimit, sizeof(basicLimit));
uiRestrictions.UIRestrictionsClass =
JOB_OBJECT_UILIMIT_DESKTOP | JOB_OBJECT_UILIMIT_DISPLAYSETTINGS |
JOB_OBJECT_UILIMIT_EXITWINDOWS |
JOB_OBJECT_UILIMIT_READCLIPBOARD |
JOB_OBJECT_UILIMIT_SYSTEMPARAMETERS |
JOB_OBJECT_UILIMIT_WRITECLIPBOARD;
if (as_service)
{
if (!IsWindows7OrGreater())
{
/*
* On Windows 7 (and presumably later),
* JOB_OBJECT_UILIMIT_HANDLES prevents us from
* starting as a service. So we only enable it on
* Vista and earlier (version <= 6.0)
*/
uiRestrictions.UIRestrictionsClass |=
JOB_OBJECT_UILIMIT_HANDLES;
}
}
_SetInformationJobObject(job, JobObjectBasicUIRestrictions,
&uiRestrictions, sizeof(uiRestrictions));
securityLimit.SecurityLimitFlags =
JOB_OBJECT_SECURITY_NO_ADMIN | JOB_OBJECT_SECURITY_ONLY_TOKEN;
securityLimit.JobToken = restrictedToken;
_SetInformationJobObject(job,
JobObjectSecurityLimitInformation, &securityLimit,
sizeof(securityLimit));
_AssignProcessToJobObject(job, processInfo->hProcess);
}
}
}
}
CloseHandle(restrictedToken);
ResumeThread(processInfo->hThread);
FreeLibrary(Kernel32Handle);
/*
* We intentionally don't close the job object handle, because we
want the
* object to live on until pg_ctl shuts down.
*/
return r;
}
#endif /* WIN32 */
static void
do_advice(void)
{
write_stderr(_("Try \"%s --help\" for more information.\n"),
progname);
}
static void
do_help(void)
{
printf(_("%s is a utility to initialize, start, stop, or control a
PostgreSQL server.\n\n"), progname);
printf(_("Usage:\n"));
printf(_(" %s init[db] [-D DATADIR] [-s] [-o
\"OPTIONS\"]\n"), progname);
printf(_(" %s start [-w] [-t SECS] [-D DATADIR] [-s] [-l
FILENAME] [-o \"OPTIONS\"]\n"), progname);
printf(_(" %s stop [-W] [-t SECS] [-D DATADIR] [-s] [-m
SHUTDOWN-MODE]\n"), progname);
printf(_(" %s restart [-w] [-t SECS] [-D DATADIR] [-s] [-m
SHUTDOWN-MODE]\n"
" [-o \"OPTIONS\"]\n"), progname);
printf(_(" %s reload [-D DATADIR] [-s]\n"), progname);
printf(_(" %s status [-D DATADIR]\n"), progname);
printf(_(" %s promote [-D DATADIR] [-s]\n"), progname);
printf(_(" %s kill SIGNALNAME PID\n"), progname);
#ifdef WIN32
printf(_(" %s register [-N SERVICENAME] [-U USERNAME] [-P
PASSWORD] [-D DATADIR]\n"
" [-S START-TYPE] [-w] [-t SECS] [-o
\"OPTIONS\"]\n"), progname);
printf(_(" %s unregister [-N SERVICENAME]\n"), progname);
#endif
printf(_("\nCommon options:\n"));
printf(_(" -D, --pgdata=DATADIR location of the database storage
area\n"));
#ifdef WIN32
printf(_(" -e SOURCE event source for logging when
running as a service\n"));
#endif
printf(_(" -s, --silent only print errors, no
informational messages\n"));
printf(_(" -t, --timeout=SECS seconds to wait when using -w
option\n"));
printf(_(" -V, --version output version information, then
exit\n"));
printf(_(" -w wait until operation
completes\n"));
printf(_(" -W do not wait until operation
completes\n"));
printf(_(" -?, --help show this help, then exit\n"));
printf(_("(The default is to wait for shutdown, but not for start or
restart.)\n\n"));
printf(_("If the -D option is omitted, the environment variable
PGDATA is used.\n"));
printf(_("\nOptions for start or restart:\n"));
#if defined(HAVE_GETRLIMIT) && defined(RLIMIT_CORE)
printf(_(" -c, --core-files allow postgres to produce core
files\n"));
#else
printf(_(" -c, --core-files not applicable on this
platform\n"));
#endif
printf(_(" -l, --log=FILENAME write (or append) server log to
FILENAME\n"));
printf(_(" -o OPTIONS command line options to pass to
postgres\n"
" (PostgreSQL server executable) or
initdb\n"));
printf(_(" -p PATH-TO-POSTGRES normally not necessary\n"));
printf(_("\nOptions for stop or restart:\n"));
printf(_(" -m, --mode=MODE MODE can be \"smart\", \"fast\",
or \"immediate\"\n"));
printf(_("\nShutdown modes are:\n"));
printf(_(" smart quit after all clients have
disconnected\n"));
printf(_(" fast quit directly, with proper shutdown\n"));
printf(_(" immediate quit without complete shutdown; will lead to
recovery on restart\n"));
printf(_("\nAllowed signal names for kill:\n"));
printf(" ABRT HUP INT QUIT TERM USR1 USR2\n");
#ifdef WIN32
printf(_("\nOptions for register and unregister:\n"));
printf(_(" -N SERVICENAME service name with which to register
PostgreSQL server\n"));
printf(_(" -P PASSWORD password of account to register
PostgreSQL server\n"));
printf(_(" -U USERNAME user name of account to register
PostgreSQL server\n"));
printf(_(" -S START-TYPE service start type to register
PostgreSQL server\n"));
printf(_("\nStart types are:\n"));
printf(_(" auto start service automatically during system
startup (default)\n"));
printf(_(" demand start service on demand\n"));
#endif
printf(_("\nReport bugs to <pgsql-bugs@postgresql.org>.\n"));
}
static void
set_mode(char *modeopt)
{
if (strcmp(modeopt, "s") == 0 || strcmp(modeopt, "smart") == 0)
{
shutdown_mode = SMART_MODE;
sig = SIGTERM;
}
else if (strcmp(modeopt, "f") == 0 || strcmp(modeopt, "fast") == 0)
{
shutdown_mode = FAST_MODE;
sig = SIGINT;
}
else if (strcmp(modeopt, "i") == 0 || strcmp(modeopt, "immediate")
== 0)
{
shutdown_mode = IMMEDIATE_MODE;
sig = SIGQUIT;
}
else
{
write_stderr(_("%s: unrecognized shutdown mode \"%s\"\n"),
progname, modeopt);
do_advice();
exit(1);
}
}
static void
set_sig(char *signame)
{
if (strcmp(signame, "HUP") == 0)
sig = SIGHUP;
else if (strcmp(signame, "INT") == 0)
sig = SIGINT;
else if (strcmp(signame, "QUIT") == 0)
sig = SIGQUIT;
else if (strcmp(signame, "ABRT") == 0)
sig = SIGABRT;
#if 0
/* probably should NOT provide SIGKILL */
else if (strcmp(signame, "KILL") == 0)
sig = SIGKILL;
#endif
else if (strcmp(signame, "TERM") == 0)
sig = SIGTERM;
else if (strcmp(signame, "USR1") == 0)
sig = SIGUSR1;
else if (strcmp(signame, "USR2") == 0)
sig = SIGUSR2;
else
{
write_stderr(_("%s: unrecognized signal name \"%s\"\n"), progname,
signame);
do_advice();
exit(1);
}
}
#ifdef WIN32
static void
set_starttype(char *starttypeopt)
{
if (strcmp(starttypeopt, "a") == 0 || strcmp(starttypeopt, "auto")
== 0)
pgctl_start_type = SERVICE_AUTO_START;
else if (strcmp(starttypeopt, "d") == 0 || strcmp(starttypeopt,
"demand") == 0)
pgctl_start_type = SERVICE_DEMAND_START;
else
{
write_stderr(_("%s: unrecognized start type \"%s\"\n"), progname,
starttypeopt);
do_advice();
exit(1);
}
}
#endif
/*
* adjust_data_dir
*
* If a configuration-only directory was specified, find the real data
dir.
*/
static void
adjust_data_dir(void)
{
char cmd[MAXPGPATH],
filename[MAXPGPATH],
*my_exec_path;
FILE *fd;
/* do nothing if we're working without knowledge of data dir */
if (pg_config == NULL)
return;
/* If there is no postgresql.conf, it can't be a config-only dir */
snprintf(filename, sizeof(filename), "%s/postgresql.conf",
pg_config);
if ((fd = fopen(filename, "r")) == NULL)
return;
fclose(fd);
/* If PG_VERSION exists, it can't be a config-only dir */
snprintf(filename, sizeof(filename), "%s/PG_VERSION", pg_config);
if ((fd = fopen(filename, "r")) != NULL)
{
fclose(fd);
return;
}
/* Must be a configuration directory, so find the data directory */
/* we use a private my_exec_path to avoid interfering with later
uses */
if (exec_path == NULL)
my_exec_path = find_other_exec_or_die(argv0, "postgres",
PG_BACKEND_VERSIONSTR);
else
my_exec_path = pg_strdup(exec_path);
/* it's important for -C to be the first option, see main.c */
snprintf(cmd, MAXPGPATH, "\"%s\" -C data_directory %s%s",
my_exec_path,
pgdata_opt ? pgdata_opt : "",
post_opts ? post_opts : "");
fd = popen(cmd, "r");
if (fd == NULL || fgets(filename, sizeof(filename), fd) == NULL)
{
write_stderr(_("%s: could not determine the data directory using
command \"%s\"\n"), progname, cmd);
exit(1);
}
pclose(fd);
free(my_exec_path);
/* Remove trailing newline */
if (strchr(filename, '\n') != NULL)
*strchr(filename, '\n') = '\0';
free(pg_data);
pg_data = pg_strdup(filename);
canonicalize_path(pg_data);
}
int
main(int argc, char **argv)
{
static struct option long_options[] = {
{"help", no_argument, NULL, '?'},
{"version", no_argument, NULL, 'V'},
{"log", required_argument, NULL, 'l'},
{"mode", required_argument, NULL, 'm'},
{"pgdata", required_argument, NULL, 'D'},
{"silent", no_argument, NULL, 's'},
{"timeout", required_argument, NULL, 't'},
{"core-files", no_argument, NULL, 'c'},
{NULL, 0, NULL, 0}
};
char *env_wait;
int option_index;
int c;
pgpid_t killproc = 0;
#ifdef WIN32
setvbuf(stderr, NULL, _IONBF, 0);
#endif
progname = get_progname(argv[0]);
set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_ctl"));
start_time = time(NULL);
/*
* save argv[0] so do_start() can look for the postmaster if
necessary. we
* don't look for postmaster here because in many cases we won't
need it.
*/
argv0 = argv[0];
umask(S_IRWXG | S_IRWXO);
/* support --help and --version even if invoked as root */
if (argc > 1)
{
if (strcmp(argv[1], "--help") == 0 || strcmp(argv[1], "-?") == 0)
{
do_help();
exit(0);
}
else if (strcmp(argv[1], "--version") == 0 || strcmp(argv[1],
"-V") == 0)
{
puts("pg_ctl (PostgreSQL) " PG_VERSION);
exit(0);
}
}
/*
* Disallow running as root, to forestall any possible security
holes.
*/
#ifndef WIN32
if (geteuid() == 0)
{
write_stderr(_("%s: cannot be run as root\n"
"Please log in (using, e.g., \"su\") as the "
"(unprivileged) user that will\n"
"own the server process.\n"),
progname);
exit(1);
}
#endif
env_wait = getenv("PGCTLTIMEOUT");
if (env_wait != NULL)
wait_seconds = atoi(env_wait);
/*
* 'Action' can be before or after args so loop over both. Some
* getopt_long() implementations will reorder argv[] to place all
flags
* first (GNU?), but we don't rely on it. Our /port version doesn't
do
* that.
*/
optind = 1;
/* process command-line options */
while (optind < argc)
{
while ((c = getopt_long(argc, argv, "cD:e:l:m:N:o:p:P:sS:t:U:wWz",
long_options, &option_index)) != -1)
{
switch (c)
{
case 'D':
{
char *pgdata_D;
char *env_var;
pgdata_D = pg_strdup(optarg);
canonicalize_path(pgdata_D);
env_var = psprintf("PGDATA=%s", pgdata_D);
putenv(env_var);
/*
* We could pass PGDATA just in an environment
* variable but we do -D too for clearer postmaster
* 'ps' display
*/
pgdata_opt = psprintf("-D \"%s\" ", pgdata_D);
break;
}
case 'e':
event_source = pg_strdup(optarg);
break;
case 'l':
log_file = pg_strdup(optarg);
break;
case 'm':
set_mode(optarg);
break;
case 'N':
register_servicename = pg_strdup(optarg);
break;
case 'o':
/* append option? */
if (!post_opts)
post_opts = pg_strdup(optarg);
else
{
char *old_post_opts = post_opts;
post_opts = psprintf("%s %s", old_post_opts, optarg);
free(old_post_opts);
}
break;
case 'p':
exec_path = pg_strdup(optarg);
break;
case 'P':
register_password = pg_strdup(optarg);
break;
case 's':
silent_mode = true;
break;
case 'S':
#ifdef WIN32
set_starttype(optarg);
#else
write_stderr(_("%s: -S option not supported on this
platform\n"),
progname);
exit(1);
#endif
break;
case 't':
wait_seconds = atoi(optarg);
wait_seconds_arg = true;
break;
case 'U':
if (strchr(optarg, '\\'))
register_username = pg_strdup(optarg);
else
/* Prepend .\ for local accounts */
register_username = psprintf(".\\%s", optarg);
break;
case 'w':
do_wait = true;
wait_set = true;
break;
case 'z':
del_service_rid = true;
break;
case 'W':
do_wait = false;
wait_set = true;
break;
case 'c':
allow_core_files = true;
break;
default:
/* getopt_long already issued a suitable error message */
do_advice();
exit(1);
}
}
/* Process an action */
if (optind < argc)
{
if (ctl_command != NO_COMMAND)
{
write_stderr(_("%s: too many command-line arguments (first is
\"%s\")\n"), progname, argv[optind]);
do_advice();
exit(1);
}
if (strcmp(argv[optind], "init") == 0
|| strcmp(argv[optind], "initdb") == 0)
ctl_command = INIT_COMMAND;
else if (strcmp(argv[optind], "start") == 0)
ctl_command = START_COMMAND;
else if (strcmp(argv[optind], "stop") == 0)
ctl_command = STOP_COMMAND;
else if (strcmp(argv[optind], "restart") == 0)
ctl_command = RESTART_COMMAND;
else if (strcmp(argv[optind], "reload") == 0)
ctl_command = RELOAD_COMMAND;
else if (strcmp(argv[optind], "status") == 0)
ctl_command = STATUS_COMMAND;
else if (strcmp(argv[optind], "promote") == 0)
ctl_command = PROMOTE_COMMAND;
else if (strcmp(argv[optind], "kill") == 0)
{
if (argc - optind < 3)
{
write_stderr(_("%s: missing arguments for kill mode\n"),
progname);
do_advice();
exit(1);
}
ctl_command = KILL_COMMAND;
set_sig(argv[++optind]);
killproc = atol(argv[++optind]);
}
#ifdef WIN32
else if (strcmp(argv[optind], "register") == 0)
ctl_command = REGISTER_COMMAND;
else if (strcmp(argv[optind], "unregister") == 0)
ctl_command = UNREGISTER_COMMAND;
else if (strcmp(argv[optind], "runservice") == 0)
ctl_command = RUN_AS_SERVICE_COMMAND;
#endif
else
{
write_stderr(_("%s: unrecognized operation mode \"%s\"\n"),
progname, argv[optind]);
do_advice();
exit(1);
}
optind++;
}
}
if (ctl_command == NO_COMMAND)
{
write_stderr(_("%s: no operation specified\n"), progname);
do_advice();
exit(1);
}
/* Note we put any -D switch into the env var above */
pg_config = getenv("PGDATA");
if (pg_config)
{
pg_config = pg_strdup(pg_config);
canonicalize_path(pg_config);
pg_data = pg_strdup(pg_config);
}
/* -D might point at config-only directory; if so find the real
PGDATA */
adjust_data_dir();
/* Complain if -D needed and not provided */
if (pg_config == NULL &&
ctl_command != KILL_COMMAND && ctl_command != UNREGISTER_COMMAND)
{
write_stderr(_("%s: no database directory specified and
environment variable PGDATA unset\n"),
progname);
do_advice();
exit(1);
}
if (!wait_set)
{
switch (ctl_command)
{
case RESTART_COMMAND:
case START_COMMAND:
do_wait = false;
break;
case STOP_COMMAND:
do_wait = true;
break;
default:
break;
}
}
if (ctl_command == RELOAD_COMMAND)
{
sig = SIGHUP;
do_wait = false;
}
if (pg_data)
{
snprintf(postopts_file, MAXPGPATH, "%s/postmaster.opts", pg_data);
snprintf(version_file, MAXPGPATH, "%s/PG_VERSION", pg_data);
snprintf(pid_file, MAXPGPATH, "%s/postmaster.pid", pg_data);
snprintf(backup_file, MAXPGPATH, "%s/backup_label", pg_data);
snprintf(recovery_file, MAXPGPATH, "%s/recovery.conf", pg_data);
}
switch (ctl_command)
{
case INIT_COMMAND:
do_init();
break;
case STATUS_COMMAND:
do_status();
break;
case START_COMMAND:
do_start();
break;
case STOP_COMMAND:
do_stop();
break;
case RESTART_COMMAND:
do_restart();
break;
case RELOAD_COMMAND:
do_reload();
break;
case PROMOTE_COMMAND:
do_promote();
break;
case KILL_COMMAND:
do_kill(killproc);
break;
#ifdef WIN32
case REGISTER_COMMAND:
pgwin32_doRegister();
break;
case UNREGISTER_COMMAND:
pgwin32_doUnregister();
break;
case RUN_AS_SERVICE_COMMAND:
pgwin32_doRunAsService();
break;
#endif
default:
break;
}
exit(0);
}
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 13:31 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
@ 2016-11-08 01:33 ` Michael Paquier <michael.paquier@gmail.com>
0 siblings, 0 replies; 38+ messages in thread
From: Michael Paquier @ 2016-11-08 01:33 UTC (permalink / raw)
To: MauMau <maumau307@gmail.com>; +Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Mon, Nov 7, 2016 at 10:31 PM, MauMau <maumau307@gmail.com> wrote:
> Yes, I tested both your patch and mine. I used the attached pg_ctl.c.
> It adds -z option which disables SECURITY_SERVICE_RID.
Okay, so you did exactly what I did except that you wrapped with an option...
> I guess you registered the service without specifying the service
> account with -U. Then the service runs as the Local System account,
> whence pgwin32_is_service() returns 1.
Thank you, that's as you said. I was just using the local user account
which is why I did not see the difference. And now I can. I finished
by not using your version of pg_ctl but mine still the result is the
same. Hm, now that we are two folks able to test the difference, I'd
suggest that a committer pops up and pushes the one-liner patch I sent
upthread and back-patches it.
For the refactoring, I guess that we could sort that later on, and I
promise to look at soon. The issue reported on this thread has been
here for 1 year, I am glad that someone finally came up an easy way to
test things.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-07 21:47 ` MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
1 sibling, 1 reply; 38+ messages in thread
From: MauMau @ 2016-11-07 21:47 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Hi, Michael
As I guessed in the previous mail, both our patches cause
pgwin32_is_service() to return 1 even when SECURITY_SERVICE_RID is
disabled, if the service is running as a Local System. The existing
logic of checking for Local System should be removed. The attached
patch fixes this problem.
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
win32-security-service-v5.patch (application/octet-stream, 6.2K) download
diff --git a/src/port/win32security.c b/src/port/win32security.c
index 2c9ca15..9e65e60 100644
--- a/src/port/win32security.c
+++ b/src/port/win32security.c
@@ -18,11 +18,6 @@
#endif
-static BOOL pgwin32_get_dynamic_tokeninfo(HANDLE token,
- TOKEN_INFORMATION_CLASS class,
- char **InfoBuffer, char *errbuf, int errsize);
-
-
/*
* Utility wrapper for frontend and backend when reporting an error
* message.
@@ -53,33 +48,11 @@ log_error(const char *fmt,...)
int
pgwin32_is_admin(void)
{
- HANDLE AccessToken;
- char *InfoBuffer = NULL;
- char errbuf[256];
- PTOKEN_GROUPS Groups;
PSID AdministratorsSid;
PSID PowerUsersSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- UINT x;
- BOOL success;
-
- if (!OpenProcessToken(GetCurrentProcess(), TOKEN_READ, &AccessToken))
- {
- log_error(_("could not open process token: error code %lu\n"),
- GetLastError());
- exit(1);
- }
-
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups,
- &InfoBuffer, errbuf, sizeof(errbuf)))
- {
- log_error("%s", errbuf);
- exit(1);
- }
-
- Groups = (PTOKEN_GROUPS) InfoBuffer;
-
- CloseHandle(AccessToken);
+ BOOL IsAdministrators;
+ BOOL IsPowerUsers;
if (!AllocateAndInitializeSid(&NtAuthority, 2,
SECURITY_BUILTIN_DOMAIN_RID,
@@ -101,32 +74,26 @@ pgwin32_is_admin(void)
exit(1);
}
- success = FALSE;
-
- for (x = 0; x < Groups->GroupCount; x++)
+ if (!CheckTokenMembership(NULL, AdministratorsSid, &IsAdministrators) ||
+ !CheckTokenMembership(NULL, PowerUsersSid, &IsPowerUsers))
{
- if ((EqualSid(AdministratorsSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)) ||
- (EqualSid(PowerUsersSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)))
- {
- success = TRUE;
- break;
- }
+ log_error("could not check access token membership: error code %lu\n",
+ GetLastError());
+ exit(1);
}
- free(InfoBuffer);
FreeSid(AdministratorsSid);
FreeSid(PowerUsersSid);
- return success;
+
+ if (IsAdministrators || IsPowerUsers)
+ return 1;
+ else
+ return 0;
}
/*
- * We consider ourselves running as a service if one of the following is
- * true:
- *
- * 1) We are running as Local System (only used by services)
- * 2) Our token contains SECURITY_SERVICE_RID (automatically added to the
+ * We consider ourselves running as a service if
+ * our token contains SECURITY_SERVICE_RID (automatically added to the
* process token by the SCM when starting a service)
*
* Return values:
@@ -143,140 +110,37 @@ int
pgwin32_is_service(void)
{
static int _is_service = -1;
- HANDLE AccessToken;
- char *InfoBuffer = NULL;
- char errbuf[256];
- PTOKEN_GROUPS Groups;
- PTOKEN_USER User;
+ BOOL IsMember;
PSID ServiceSid;
- PSID LocalSystemSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- UINT x;
/* Only check the first time */
if (_is_service != -1)
return _is_service;
- if (!OpenProcessToken(GetCurrentProcess(), TOKEN_READ, &AccessToken))
- {
- fprintf(stderr, "could not open process token: error code %lu\n",
- GetLastError());
- return -1;
- }
-
- /* First check for local system */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenUser, &InfoBuffer,
- errbuf, sizeof(errbuf)))
- {
- fprintf(stderr, "%s", errbuf);
- return -1;
- }
-
- User = (PTOKEN_USER) InfoBuffer;
-
- if (!AllocateAndInitializeSid(&NtAuthority, 1,
- SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0,
- &LocalSystemSid))
- {
- fprintf(stderr, "could not get SID for local system account\n");
- CloseHandle(AccessToken);
- return -1;
- }
-
- if (EqualSid(LocalSystemSid, User->User.Sid))
- {
- FreeSid(LocalSystemSid);
- free(InfoBuffer);
- CloseHandle(AccessToken);
- _is_service = 1;
- return _is_service;
- }
-
- FreeSid(LocalSystemSid);
- free(InfoBuffer);
-
- /* Now check for group SID */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups, &InfoBuffer,
- errbuf, sizeof(errbuf)))
- {
- fprintf(stderr, "%s", errbuf);
- return -1;
- }
-
- Groups = (PTOKEN_GROUPS) InfoBuffer;
-
+ /* Check for service group membership */
if (!AllocateAndInitializeSid(&NtAuthority, 1,
SECURITY_SERVICE_RID, 0, 0, 0, 0, 0, 0, 0,
&ServiceSid))
{
- fprintf(stderr, "could not get SID for service group\n");
- free(InfoBuffer);
- CloseHandle(AccessToken);
+ fprintf(stderr, "could not get SID for service group: error code %lu\n",
+ GetLastError());
return -1;
}
- _is_service = 0;
- for (x = 0; x < Groups->GroupCount; x++)
+ if (!CheckTokenMembership(NULL, ServiceSid, &IsMember))
{
- if (EqualSid(ServiceSid, Groups->Groups[x].Sid))
- {
- _is_service = 1;
- break;
- }
+ fprintf(stderr, "could not check access token membership: error code %lu\n",
+ GetLastError());
+ FreeSid(ServiceSid);
+ return -1;
}
-
- free(InfoBuffer);
FreeSid(ServiceSid);
- CloseHandle(AccessToken);
+ if (IsMember)
+ _is_service = 1;
+ else
+ _is_service = 0;
return _is_service;
}
-
-
-/*
- * Call GetTokenInformation() on a token and return a dynamically sized
- * buffer with the information in it. This buffer must be free():d by
- * the calling function!
- */
-static BOOL
-pgwin32_get_dynamic_tokeninfo(HANDLE token, TOKEN_INFORMATION_CLASS class,
- char **InfoBuffer, char *errbuf, int errsize)
-{
- DWORD InfoBufferSize;
-
- if (GetTokenInformation(token, class, NULL, 0, &InfoBufferSize))
- {
- snprintf(errbuf, errsize,
- "could not get token information buffer size: got zero size\n");
- return FALSE;
- }
-
- if (GetLastError() != ERROR_INSUFFICIENT_BUFFER)
- {
- snprintf(errbuf, errsize,
- "could not get token information buffer size: error code %lu\n",
- GetLastError());
- return FALSE;
- }
-
- *InfoBuffer = malloc(InfoBufferSize);
- if (*InfoBuffer == NULL)
- {
- snprintf(errbuf, errsize,
- "could not allocate %d bytes for token information\n",
- (int) InfoBufferSize);
- return FALSE;
- }
-
- if (!GetTokenInformation(token, class, *InfoBuffer,
- InfoBufferSize, &InfoBufferSize))
- {
- snprintf(errbuf, errsize,
- "could not get token information: error code %lu\n",
- GetLastError());
- return FALSE;
- }
-
- return TRUE;
-}
=
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
@ 2016-11-08 01:37 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-11-08 01:37 UTC (permalink / raw)
To: MauMau <maumau307@gmail.com>; +Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Tue, Nov 8, 2016 at 6:47 AM, MauMau <maumau307@gmail.com> wrote:
> As I guessed in the previous mail, both our patches cause
> pgwin32_is_service() to return 1 even when SECURITY_SERVICE_RID is
> disabled, if the service is running as a Local System. The existing
> logic of checking for Local System should be removed. The attached
> patch fixes this problem.
Meh. Local System accounts are used only by services (see comments of
pgwin32_is_service), so I'd expect pgwin32_is_service() to return true
in this case, contrary to what your v5 is doing. v4 is doing it better
I think at quick glance.
Here are the diffs between your v4 and v5 of this refactoring btw for
people wondering:
/*
- * We consider ourselves running as a service if one of the following is
- * true:
- *
- * 1) We are running as Local System (only used by services)
- * 2) Our token contains SECURITY_SERVICE_RID (automatically added to the
+ * We consider ourselves running as a service if
+ * our token contains SECURITY_SERVICE_RID (automatically added to the
* process token by the SCM when starting a service)
*
* Return values:
@@ -115,39 +112,13 @@ pgwin32_is_service(void)
static int _is_service = -1;
BOOL IsMember;
PSID ServiceSid;
- PSID LocalSystemSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
/* Only check the first time */
if (_is_service != -1)
return _is_service;
- /* First check for Local System */
- if (!AllocateAndInitializeSid(&NtAuthority, 1,
- SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0,
- &LocalSystemSid))
- {
- fprintf(stderr, "could not get SID for Local System account:
error code %lu\n",
- GetLastError());
- return -1;
- }
-
- if (!CheckTokenMembership(NULL, LocalSystemSid, &IsMember))
- {
- fprintf(stderr, "could not check access token membership:
error code %lu\n",
- GetLastError());
- FreeSid(LocalSystemSid);
- return -1;
- }
- FreeSid(LocalSystemSid);
-
- if (IsMember)
- {
- _is_service = 1;
- return _is_service;
- }
-
- /* Next check for service group */
+ /* Check for service group membership */
Not relying on the fact that local system accounts are only used by
services looks bad to me.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-08 02:36 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-08 02:36 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; MauMau <maumau307@gmail.com>; +Cc: Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
> Meh. Local System accounts are used only by services (see comments of
> pgwin32_is_service), so I'd expect pgwin32_is_service() to return true in
> this case, contrary to what your v5 is doing. v4 is doing it better I think
> at quick glance.
> Not relying on the fact that local system accounts are only used by services
> looks bad to me.
I believe v5 is correct for two reasons:
(1)
SECURITY_SERVICE_RID is enough to check, because the process gets SECURITY_SERVICE_RID when it runs as a service.
https://msdn.microsoft.com/ja-jp/library/windows/desktop/aa379649(v=vs.85).aspx
SECURITY_SERVICE_RID
Accounts authorized to log on as a service. This is a group identifier added to the token of a process when it was logged as a service. The corresponding logon type is LOGON32_LOGON_SERVICE.
I saw descriptions that LocalSystem is used by the SCM, but didn't find a statement that LocalSystem is used only by SCM and services. In addition, if the check for LocalSystem is really necessary, LocalService and NetworkService also need to be checked.
https://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684190(v=vs.85).aspx
(Japanese article)
http://www.atmarkit.co.jp/ait/articles/0905/08/news095.html
(2)
The OP wants to explicitly run postgres.exe outside the service even when his app runs as a service, so that the app can read postgres's messages from its stdout/stderr. So, he disabled SECURITY_SERVICE_RID when starting postgres.exe. His users may run his app as a service under LocalSystem.
[Excerpt]
--------------------------------------------------
We ship PG with our own product, which may or may not be
installed as a service. When running PG, we run postgres.exe directly via a
Tcl-based wrapper script so that we can monitor the output in real time.
When our product is installed as a service, we use CreateRestrictedToken to
disable all admin rights as well as the SECURITY_SERVICE_RID, and use the
returned token with CreateProcessAsUser, for which we also specify
CREATE_NEW_CONSOLE. This process then calls our wrapper script. Inside
this wrapper, I can call GetStdHandle (via Twapi) and get valid handles for
all 3: in, out, and err. Yet when the script calls postgres.exe, nothing is
received on the output. As mentioned above, nothing is logged in the event
log, either.
--------------------------------------------------
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-08 02:57 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-11-08 02:57 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Tue, Nov 8, 2016 at 11:36 AM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> SECURITY_SERVICE_RID
> Accounts authorized to log on as a service. This is a group identifier added to the token of a process when it was logged as a service. The corresponding logon type is LOGON32_LOGON_SERVICE.
>
> I saw descriptions that LocalSystem is used by the SCM, but didn't find a statement that LocalSystem is used only by SCM and services. In addition, if the check for LocalSystem is really necessary, LocalService and NetworkService also need to be checked.
>
> https://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684190(v=vs.85).aspx
That's what I looked at as well :) And this part is what caught my
attention, meaning that it is not used by anything else than the SCM:
"The LocalSystem account is a predefined local account used by the
service control manager."
And this implies, at least it seems to me, that trying to run Postgres
as this user is actually not something you'd want to do.
> (2)
> The OP wants to explicitly run postgres.exe outside the service even when his app runs as a service, so that the app can read postgres's messages from its stdout/stderr. So, he disabled SECURITY_SERVICE_RID when starting postgres.exe. His users may run his app as a service under LocalSystem.
Good question, and I don't know how this is used.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-08 03:16 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-08 03:16 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
> https://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684190(v=vs
> > .85).aspx
>
> That's what I looked at as well :) And this part is what caught my attention,
> meaning that it is not used by anything else than the SCM:
> "The LocalSystem account is a predefined local account used by the service
> control manager."
The same thing is said about other two special accounts, so they need to be checked if we really believe we need to check for LocalSystem.
"The LocalService account is a predefined local account used by the service control manager."
"The NetworkService account is a predefined local account used by the service control manager."
But, in practice, SECURITY_SERVICE_RID has turned out to be enough.
> And this implies, at least it seems to me, that trying to run Postgres as
> this user is actually not something you'd want to do.
Yes, I think people should avoid using LocalSystem for user services like PostgreSQL for security reasons. But the Services applet in the Control Panel allows to select LocalSystem, and pg_ctl register creates a service with LocalSystem account when -U is omitted.
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-08 03:20 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-11-08 03:20 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Tue, Nov 8, 2016 at 12:16 PM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: pgsql-hackers-owner@postgresql.org
>> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
>> https://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684190(v=vs
>> > .85).aspx
>>
>> That's what I looked at as well :) And this part is what caught my attention,
>> meaning that it is not used by anything else than the SCM:
>> "The LocalSystem account is a predefined local account used by the service
>> control manager."
>
> The same thing is said about other two special accounts, so they need to be checked if we really believe we need to check for LocalSystem.
>
> "The LocalService account is a predefined local account used by the service control manager."
> "The NetworkService account is a predefined local account used by the service control manager."
>
> But, in practice, SECURITY_SERVICE_RID has turned out to be enough.
Hm... See here:
http://stackoverflow.com/questions/6084547/how-to-check-whether-a-process-is-running-as-a-windows-se...
And particularly this quote:
"No, that is not reliable because if a service is started from command
line for example it will not have this token. "
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-08 04:36 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-08 04:36 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
> Hm... See here:
> http://stackoverflow.com/questions/6084547/how-to-check-whether-a-proc
> ess-is-running-as-a-windows-service
> And particularly this quote:
> "No, that is not reliable because if a service is started from command line
> for example it will not have this token. "
Is there any Microsoft document that states this? I don't think the above comment is correct, because SECURITY_SERVICE_RID was present when I started the service from command line with "net start".
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-08 05:11 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
0 siblings, 1 reply; 38+ messages in thread
From: Michael Paquier @ 2016-11-08 05:11 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Tue, Nov 8, 2016 at 1:36 PM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: pgsql-hackers-owner@postgresql.org
>> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
>> Hm... See here:
>> http://stackoverflow.com/questions/6084547/how-to-check-whether-a-proc
>> ess-is-running-as-a-windows-service
>> And particularly this quote:
>> "No, that is not reliable because if a service is started from command line
>> for example it will not have this token. "
>
> Is there any Microsoft document that states this? I don't think the above comment is correct, because SECURITY_SERVICE_RID was present when I started the service from command line with "net start".
Not that I can see of... So maybe I'm just confused by this comment as
it is added by the SCM itself, right?
Things are this way since b15f9b08 that introduced
pgwin32_is_service(). Still, by considering what you say, you
definitely have a point that if postgres is started by another service
running as Local System logs are going where they should not. Let's
remove the check for LocalSystem but still check for SE_GROUP_ENABLED.
So, without any refactoring work, isn't the attached patch just but
fine? That seems to work properly for me.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
win32-security-service-v6.patch (text/x-patch, 2.2K) download
diff --git a/src/port/win32security.c b/src/port/win32security.c
index 2c9ca15..e329eb0 100644
--- a/src/port/win32security.c
+++ b/src/port/win32security.c
@@ -122,12 +122,9 @@ pgwin32_is_admin(void)
}
/*
- * We consider ourselves running as a service if one of the following is
- * true:
- *
- * 1) We are running as Local System (only used by services)
- * 2) Our token contains SECURITY_SERVICE_RID (automatically added to the
- * process token by the SCM when starting a service)
+ * We consider ourselves running as a service if our token contains
+ * SECURITY_SERVICE_RID, which is automatically added to the process token
+ * by the SCM when starting a service.
*
* Return values:
* 0 = Not service
@@ -147,9 +144,7 @@ pgwin32_is_service(void)
char *InfoBuffer = NULL;
char errbuf[256];
PTOKEN_GROUPS Groups;
- PTOKEN_USER User;
PSID ServiceSid;
- PSID LocalSystemSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
UINT x;
@@ -164,37 +159,6 @@ pgwin32_is_service(void)
return -1;
}
- /* First check for local system */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenUser, &InfoBuffer,
- errbuf, sizeof(errbuf)))
- {
- fprintf(stderr, "%s", errbuf);
- return -1;
- }
-
- User = (PTOKEN_USER) InfoBuffer;
-
- if (!AllocateAndInitializeSid(&NtAuthority, 1,
- SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0,
- &LocalSystemSid))
- {
- fprintf(stderr, "could not get SID for local system account\n");
- CloseHandle(AccessToken);
- return -1;
- }
-
- if (EqualSid(LocalSystemSid, User->User.Sid))
- {
- FreeSid(LocalSystemSid);
- free(InfoBuffer);
- CloseHandle(AccessToken);
- _is_service = 1;
- return _is_service;
- }
-
- FreeSid(LocalSystemSid);
- free(InfoBuffer);
-
/* Now check for group SID */
if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups, &InfoBuffer,
errbuf, sizeof(errbuf)))
@@ -218,7 +182,8 @@ pgwin32_is_service(void)
_is_service = 0;
for (x = 0; x < Groups->GroupCount; x++)
{
- if (EqualSid(ServiceSid, Groups->Groups[x].Sid))
+ if (EqualSid(ServiceSid, Groups->Groups[x].Sid) &&
+ (Groups->Groups[x].Attributes & SE_GROUP_ENABLED))
{
_is_service = 1;
break;
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-08 05:25 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-08 05:25 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
> Things are this way since b15f9b08 that introduced pgwin32_is_service().
> Still, by considering what you say, you definitely have a point that if
> postgres is started by another service running as Local System logs are
> going where they should not. Let's remove the check for LocalSystem but
> still check for SE_GROUP_ENABLED.
> So, without any refactoring work, isn't the attached patch just but fine?
> That seems to work properly for me.
Just taking a look at the patch, I'm sure it will work.
Committer (Heikki?),
v5 is refactored for HEAD, and v6 is for previous releases without refactoring. I'd like v5 to be applied to at least HEAD, as it removes a lot of unnecessary code.
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-08 05:56 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 06:31 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2017-03-16 08:40 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 2 replies; 38+ messages in thread
From: Michael Paquier @ 2016-11-08 05:56 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Tue, Nov 8, 2016 at 2:25 PM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: pgsql-hackers-owner@postgresql.org
>> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
>> Things are this way since b15f9b08 that introduced pgwin32_is_service().
>> Still, by considering what you say, you definitely have a point that if
>> postgres is started by another service running as Local System logs are
>> going where they should not. Let's remove the check for LocalSystem but
>> still check for SE_GROUP_ENABLED.
>> So, without any refactoring work, isn't the attached patch just but fine?
>> That seems to work properly for me.
>
> Just taking a look at the patch, I'm sure it will work.
>
> Committer (Heikki?),
> v5 is refactored for HEAD, and v6 is for previous releases without refactoring. I'd like v5 to be applied to at least HEAD, as it removes a lot of unnecessary code.
+ if (!CheckTokenMembership(NULL, AdministratorsSid, &IsAdministrators) ||
+ !CheckTokenMembership(NULL, PowerUsersSid, &IsPowerUsers))
{
- if ((EqualSid(AdministratorsSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)) ||
- (EqualSid(PowerUsersSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)))
- {
- success = TRUE;
- break;
- }
+ log_error("could not check access token membership: error code %lu\n",
+ GetLastError());
+ exit(1);
}
I just looked more deeply at your refactoring patch, and I didn't know
about CheckTokenMembership()... The whole logic of your patch depends
on it. That's quite a cleanup that you have here. It looks that the
former implementation just had no knowledge of this routine or it
would just have been used.
+ if (IsAdministrators || IsPowerUsers)
+ return 1;
+ else
+ return 0;
I would remove the else here.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2016-11-08 06:31 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-21 08:33 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Craig Ringer <craig@2ndquadrant.com>
1 sibling, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-08 06:31 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Michael Paquier [mailto:michael.paquier@gmail.com]
> I just looked more deeply at your refactoring patch, and I didn't know about
> CheckTokenMembership()... The whole logic of your patch depends on it.
> That's quite a cleanup that you have here. It looks that the former
> implementation just had no knowledge of this routine or it would just have
> been used.
Yes, Microsoft recommends GetTokenMembership() because it's simpler.
> + if (IsAdministrators || IsPowerUsers)
> + return 1;
> + else
> + return 0;
> I would remove the else here.
IIRC, I sometimes saw this style of code in PostgreSQL (or in psqlODBC possibly...) I'd like to leave the style choice to the committer.
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 06:31 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-21 08:33 ` Craig Ringer <craig@2ndquadrant.com>
2016-11-22 04:58 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
0 siblings, 1 reply; 38+ messages in thread
From: Craig Ringer @ 2016-11-21 08:33 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: Michael Paquier <michael.paquier@gmail.com>; MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On 8 November 2016 at 14:31, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: Michael Paquier [mailto:michael.paquier@gmail.com]
>> I just looked more deeply at your refactoring patch, and I didn't know about
>> CheckTokenMembership()... The whole logic of your patch depends on it.
>> That's quite a cleanup that you have here. It looks that the former
>> implementation just had no knowledge of this routine or it would just have
>> been used.
>
> Yes, Microsoft recommends GetTokenMembership() because it's simpler.
You meant CheckTokenMembership().
Relevant references:
* https://msdn.microsoft.com/en-us/library/windows/desktop/aa376389(v=vs.85).aspx
* https://blogs.msdn.microsoft.com/junfeng/2007/01/26/how-to-tell-if-the-current-user-is-in-administra...
The docs say it's supported in WinXP and Win2k3, so it's fine to use.
The blog above notes that it "won't work" on Vista+, but if you read
it you'll notice that what it means is that you can't tell if the
running user has the right to elevate to Administrator rights. I don't
think PostgreSQL cares about that, it only cares if it has admin
rights *right now*, not whether the running user can gain such rights
using a UAC elevation prompt. In fact it'd be super-annoying if you
couldn't run postgres as a user with admin elevation rights so this
behaviour seems to be what we want.
The proposed patch does need to be checked with:
* WinXP, non-admin
* WinXP, admin, should refuse to run
* WinVista / Win7, local admin, UAC on => should run
* WinVista / Win7, local admin, UAC off => should refuse to run
* WinVista / Win7, run cmd.exe using "run as admin" => should refuse to run
* WinVista / Win7, not local admin => should run
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 06:31 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-21 08:33 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Craig Ringer <craig@2ndquadrant.com>
@ 2016-11-22 04:58 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-29 04:24 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 38+ messages in thread
From: Tsunakawa, Takayuki @ 2016-11-22 04:58 UTC (permalink / raw)
To: Craig Ringer <craig@2ndquadrant.com>; +Cc: Michael Paquier <michael.paquier@gmail.com>; MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Craig Ringer [mailto:craig@2ndquadrant.com]
> You meant CheckTokenMembership().
Yes, my typo in the mail.
> The proposed patch does need to be checked with:
I understood you meant by "refuse to run" that postgres.exe fails to start below. Yes, I checked it on Win10. I don't have access to WinXP/2003 - Microsoft ended their support.
if (pgwin32_is_admin())
{
write_stderr("Execution of PostgreSQL by a user with administrative permissions is not\n"
"permitted.\n"
"The server must be started under an unprivileged user ID to prevent\n"
"possible system security compromises. See the documentation for\n"
"more information on how to properly start the server.\n");
exit(1);
}
Regards
Takayuki Tsunakawa
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 06:31 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-21 08:33 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Craig Ringer <craig@2ndquadrant.com>
2016-11-22 04:58 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
@ 2016-11-29 04:24 ` Michael Paquier <michael.paquier@gmail.com>
0 siblings, 0 replies; 38+ messages in thread
From: Michael Paquier @ 2016-11-29 04:24 UTC (permalink / raw)
To: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: Craig Ringer <craig@2ndquadrant.com>; MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On Tue, Nov 22, 2016 at 1:58 PM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: Craig Ringer [mailto:craig@2ndquadrant.com]
>> You meant CheckTokenMembership().
>
> Yes, my typo in the mail.
>
>> The proposed patch does need to be checked with:
>
> I understood you meant by "refuse to run" that postgres.exe fails to start below. Yes, I checked it on Win10. I don't have access to WinXP/2003 - Microsoft ended their support.
>
> if (pgwin32_is_admin())
> {
> write_stderr("Execution of PostgreSQL by a user with administrative permissions is not\n"
> "permitted.\n"
> "The server must be started under an unprivileged user ID to prevent\n"
> "possible system security compromises. See the documentation for\n"
> "more information on how to properly start the server.\n");
> exit(1);
> }
I have moved that to next CF. The refactoring patch needs more testing
but the basic fix patch could be applied.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
@ 2017-03-16 08:40 ` Heikki Linnakangas <hlinnaka@iki.fi>
2017-03-16 22:21 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
1 sibling, 1 reply; 38+ messages in thread
From: Heikki Linnakangas @ 2017-03-16 08:40 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: MauMau <maumau307@gmail.com>; Breen Hagan <breen@rtda.com>; Heikki Linnakangas <hlinnaka@iki.fi>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On 11/08/2016 07:56 AM, Michael Paquier wrote:
> On Tue, Nov 8, 2016 at 2:25 PM, Tsunakawa, Takayuki
> <tsunakawa.takay@jp.fujitsu.com> wrote:
>> From: pgsql-hackers-owner@postgresql.org
>>> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Michael Paquier
>>> Things are this way since b15f9b08 that introduced pgwin32_is_service().
>>> Still, by considering what you say, you definitely have a point that if
>>> postgres is started by another service running as Local System logs are
>>> going where they should not. Let's remove the check for LocalSystem but
>>> still check for SE_GROUP_ENABLED.
I did some testing on patch v5, on my Windows 8 VM. I launched cmd as
Administrator, and registered the service with:
pg_ctl register -D data
I.e. without specifying a user. When I start the service with "net
start", it refuses to start, and there are no messages in the event log.
It refuses to start because "data" is not a valid directory, so that's
correct. But the error message about that is lost.
Added some debugging messages to win32_is_service(), and it confirms
that with this patch (v5), win32_is_service() incorrectly returns false,
while unmodified git master returns true, and writes the error message
to the event log.
So, I think we still need the check for Local System.
>>> So, without any refactoring work, isn't the attached patch just but fine?
>>> That seems to work properly for me.
>>
>> Just taking a look at the patch, I'm sure it will work.
>>
>> Committer (Heikki?),
>> v5 is refactored for HEAD, and v6 is for previous releases without refactoring. I'd like v5 to be applied to at least HEAD, as it removes a lot of unnecessary code.
>
> + if (!CheckTokenMembership(NULL, AdministratorsSid, &IsAdministrators) ||
> + !CheckTokenMembership(NULL, PowerUsersSid, &IsPowerUsers))
> {
> - if ((EqualSid(AdministratorsSid, Groups->Groups[x].Sid) &&
> - (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)) ||
> - (EqualSid(PowerUsersSid, Groups->Groups[x].Sid) &&
> - (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)))
> - {
> - success = TRUE;
> - break;
> - }
> + log_error("could not check access token membership: error code %lu\n",
> + GetLastError());
> + exit(1);
> }
> I just looked more deeply at your refactoring patch, and I didn't know
> about CheckTokenMembership()... The whole logic of your patch depends
> on it. That's quite a cleanup that you have here. It looks that the
> former implementation just had no knowledge of this routine or it
> would just have been used.
Yeah, CheckTokenMembership() seems really handy. Let's switch to that,
but without removing the checks for Local System.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2017-03-16 08:40 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
@ 2017-03-16 22:21 ` MauMau <maumau307@gmail.com>
2017-03-17 09:19 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 1 reply; 38+ messages in thread
From: MauMau @ 2017-03-16 22:21 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; Heikki Linnakangas <hlinnaka@iki.fi>; +Cc: Breen Hagan <breen@rtda.com>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Heikki Linnakangas
So, I think we still need the check for Local System.
Thanks, fixed and confirmed that the error message is output in the
event log.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
win32-security-service-v7.patch (application/octet-stream, 6.4K) download
diff --git a/src/port/win32security.c b/src/port/win32security.c
index 777a2e5b99..ca0fa35299 100644
--- a/src/port/win32security.c
+++ b/src/port/win32security.c
@@ -18,11 +18,6 @@
#endif
-static BOOL pgwin32_get_dynamic_tokeninfo(HANDLE token,
- TOKEN_INFORMATION_CLASS class,
- char **InfoBuffer, char *errbuf, int errsize);
-
-
/*
* Utility wrapper for frontend and backend when reporting an error
* message.
@@ -53,33 +48,11 @@ log_error(const char *fmt,...)
int
pgwin32_is_admin(void)
{
- HANDLE AccessToken;
- char *InfoBuffer = NULL;
- char errbuf[256];
- PTOKEN_GROUPS Groups;
PSID AdministratorsSid;
PSID PowerUsersSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- UINT x;
- BOOL success;
-
- if (!OpenProcessToken(GetCurrentProcess(), TOKEN_READ, &AccessToken))
- {
- log_error(_("could not open process token: error code %lu\n"),
- GetLastError());
- exit(1);
- }
-
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups,
- &InfoBuffer, errbuf, sizeof(errbuf)))
- {
- log_error("%s", errbuf);
- exit(1);
- }
-
- Groups = (PTOKEN_GROUPS) InfoBuffer;
-
- CloseHandle(AccessToken);
+ BOOL IsAdministrators;
+ BOOL IsPowerUsers;
if (!AllocateAndInitializeSid(&NtAuthority, 2,
SECURITY_BUILTIN_DOMAIN_RID,
@@ -101,32 +74,26 @@ pgwin32_is_admin(void)
exit(1);
}
- success = FALSE;
-
- for (x = 0; x < Groups->GroupCount; x++)
+ if (!CheckTokenMembership(NULL, AdministratorsSid, &IsAdministrators) ||
+ !CheckTokenMembership(NULL, PowerUsersSid, &IsPowerUsers))
{
- if ((EqualSid(AdministratorsSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)) ||
- (EqualSid(PowerUsersSid, Groups->Groups[x].Sid) &&
- (Groups->Groups[x].Attributes & SE_GROUP_ENABLED)))
- {
- success = TRUE;
- break;
- }
+ log_error("could not check access token membership: error code %lu\n",
+ GetLastError());
+ exit(1);
}
- free(InfoBuffer);
FreeSid(AdministratorsSid);
FreeSid(PowerUsersSid);
- return success;
+
+ if (IsAdministrators || IsPowerUsers)
+ return 1;
+ else
+ return 0;
}
/*
- * We consider ourselves running as a service if one of the following is
- * true:
- *
- * 1) We are running as Local System (only used by services)
- * 2) Our token contains SECURITY_SERVICE_RID (automatically added to the
+ * We consider ourselves running as a service if
+ * our token contains SECURITY_SERVICE_RID (automatically added to the
* process token by the SCM when starting a service)
*
* Return values:
@@ -143,140 +110,62 @@ int
pgwin32_is_service(void)
{
static int _is_service = -1;
- HANDLE AccessToken;
- char *InfoBuffer = NULL;
- char errbuf[256];
- PTOKEN_GROUPS Groups;
- PTOKEN_USER User;
+ BOOL IsMember;
PSID ServiceSid;
PSID LocalSystemSid;
SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY};
- UINT x;
/* Only check the first time */
if (_is_service != -1)
return _is_service;
- if (!OpenProcessToken(GetCurrentProcess(), TOKEN_READ, &AccessToken))
- {
- fprintf(stderr, "could not open process token: error code %lu\n",
- GetLastError());
- return -1;
- }
-
/* First check for local system */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenUser, &InfoBuffer,
- errbuf, sizeof(errbuf)))
- {
- fprintf(stderr, "%s", errbuf);
- return -1;
- }
-
- User = (PTOKEN_USER) InfoBuffer;
-
if (!AllocateAndInitializeSid(&NtAuthority, 1,
SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0,
&LocalSystemSid))
{
fprintf(stderr, "could not get SID for local system account\n");
- CloseHandle(AccessToken);
return -1;
}
- if (EqualSid(LocalSystemSid, User->User.Sid))
+ if (!CheckTokenMembership(NULL, LocalSystemSid, &IsMember))
{
+ fprintf(stderr, "could not check access token membership: error code %lu\n",
+ GetLastError());
FreeSid(LocalSystemSid);
- free(InfoBuffer);
- CloseHandle(AccessToken);
- _is_service = 1;
- return _is_service;
+ return -1;
}
-
FreeSid(LocalSystemSid);
- free(InfoBuffer);
- /* Now check for group SID */
- if (!pgwin32_get_dynamic_tokeninfo(AccessToken, TokenGroups, &InfoBuffer,
- errbuf, sizeof(errbuf)))
+ if (IsMember)
{
- fprintf(stderr, "%s", errbuf);
- return -1;
+ _is_service = 1;
+ return _is_service;
}
- Groups = (PTOKEN_GROUPS) InfoBuffer;
-
+ /* Check for service group membership */
if (!AllocateAndInitializeSid(&NtAuthority, 1,
SECURITY_SERVICE_RID, 0, 0, 0, 0, 0, 0, 0,
&ServiceSid))
{
- fprintf(stderr, "could not get SID for service group\n");
- free(InfoBuffer);
- CloseHandle(AccessToken);
+ fprintf(stderr, "could not get SID for service group: error code %lu\n",
+ GetLastError());
return -1;
}
- _is_service = 0;
- for (x = 0; x < Groups->GroupCount; x++)
+ if (!CheckTokenMembership(NULL, ServiceSid, &IsMember))
{
- if (EqualSid(ServiceSid, Groups->Groups[x].Sid))
- {
- _is_service = 1;
- break;
- }
+ fprintf(stderr, "could not check access token membership: error code %lu\n",
+ GetLastError());
+ FreeSid(ServiceSid);
+ return -1;
}
-
- free(InfoBuffer);
FreeSid(ServiceSid);
- CloseHandle(AccessToken);
+ if (IsMember)
+ _is_service = 1;
+ else
+ _is_service = 0;
return _is_service;
}
-
-
-/*
- * Call GetTokenInformation() on a token and return a dynamically sized
- * buffer with the information in it. This buffer must be free():d by
- * the calling function!
- */
-static BOOL
-pgwin32_get_dynamic_tokeninfo(HANDLE token, TOKEN_INFORMATION_CLASS class,
- char **InfoBuffer, char *errbuf, int errsize)
-{
- DWORD InfoBufferSize;
-
- if (GetTokenInformation(token, class, NULL, 0, &InfoBufferSize))
- {
- snprintf(errbuf, errsize,
- "could not get token information buffer size: got zero size\n");
- return FALSE;
- }
-
- if (GetLastError() != ERROR_INSUFFICIENT_BUFFER)
- {
- snprintf(errbuf, errsize,
- "could not get token information buffer size: error code %lu\n",
- GetLastError());
- return FALSE;
- }
-
- *InfoBuffer = malloc(InfoBufferSize);
- if (*InfoBuffer == NULL)
- {
- snprintf(errbuf, errsize,
- "could not allocate %d bytes for token information\n",
- (int) InfoBufferSize);
- return FALSE;
- }
-
- if (!GetTokenInformation(token, class, *InfoBuffer,
- InfoBufferSize, &InfoBufferSize))
- {
- snprintf(errbuf, errsize,
- "could not get token information: error code %lu\n",
- GetLastError());
- return FALSE;
- }
-
- return TRUE;
-}
=
* Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:30 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Michael Paquier <michael.paquier@gmail.com>
2017-03-16 08:40 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled Heikki Linnakangas <hlinnaka@iki.fi>
2017-03-16 22:21 ` Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled MauMau <maumau307@gmail.com>
@ 2017-03-17 09:19 ` Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 0 replies; 38+ messages in thread
From: Heikki Linnakangas @ 2017-03-17 09:19 UTC (permalink / raw)
To: MauMau <maumau307@gmail.com>; Michael Paquier <michael.paquier@gmail.com>; Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>; +Cc: Breen Hagan <breen@rtda.com>; Alvaro Herrera <alvherre@2ndquadrant.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
On 03/17/2017 12:21 AM, MauMau wrote:
> From: Heikki Linnakangas
> So, I think we still need the check for Local System.
>
> Thanks, fixed and confirmed that the error message is output in the
> event log.
Committed, thanks!
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 38+ messages in thread
end of thread, other threads:[~2017-03-17 09:19 UTC | newest]
Thread overview: 38+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-11-04 06:23 BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled breen@rtda.com
2015-11-05 15:39 ` Michael Paquier <michael.paquier@gmail.com>
2015-11-05 16:00 ` Breen Hagan <breen@rtda.com>
2015-11-07 07:09 ` Michael Paquier <michael.paquier@gmail.com>
2015-11-07 07:36 ` Michael Paquier <michael.paquier@gmail.com>
2016-03-09 22:44 ` Breen Hagan <breen@rtda.com>
2016-03-10 06:24 ` Michael Paquier <michael.paquier@gmail.com>
2016-04-04 16:08 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2016-04-05 03:58 ` Michael Paquier <michael.paquier@gmail.com>
2016-04-08 06:48 ` Michael Paquier <michael.paquier@gmail.com>
2016-09-21 12:50 ` Heikki Linnakangas <hlinnaka@iki.fi>
2016-09-23 17:55 ` Breen Hagan <breen@rtda.com>
2016-09-23 23:52 ` Michael Paquier <michael.paquier@gmail.com>
2016-10-02 12:47 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-06 09:11 ` MauMau <maumau307@gmail.com>
2016-11-06 09:30 ` MauMau <maumau307@gmail.com>
2016-11-06 12:12 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-07 00:49 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-07 08:05 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-07 13:31 ` MauMau <maumau307@gmail.com>
2016-11-08 01:33 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-07 21:47 ` MauMau <maumau307@gmail.com>
2016-11-08 01:37 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 02:36 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 02:57 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 03:16 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 03:20 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 04:36 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:11 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 05:25 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-08 05:56 ` Michael Paquier <michael.paquier@gmail.com>
2016-11-08 06:31 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-21 08:33 ` Craig Ringer <craig@2ndquadrant.com>
2016-11-22 04:58 ` Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
2016-11-29 04:24 ` Michael Paquier <michael.paquier@gmail.com>
2017-03-16 08:40 ` Heikki Linnakangas <hlinnaka@iki.fi>
2017-03-16 22:21 ` MauMau <maumau307@gmail.com>
2017-03-17 09:19 ` Heikki Linnakangas <hlinnaka@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox