Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDBdF-001By4-Sz for pgsql-bugs@arkaria.postgresql.org; Tue, 12 Dec 2023 22:53:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rDBdE-0091ZW-HI for pgsql-bugs@arkaria.postgresql.org; Tue, 12 Dec 2023 22:53:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rDBdE-0091ZN-8g for pgsql-bugs@lists.postgresql.org; Tue, 12 Dec 2023 22:53:40 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rDBdB-00A6IP-DK for pgsql-bugs@lists.postgresql.org; Tue, 12 Dec 2023 22:53:38 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a22eba5a290so144490566b.3 for ; Tue, 12 Dec 2023 14:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20230601.gappssmtp.com; s=20230601; t=1702421616; x=1703026416; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to; bh=551UBavCyvynG/NuNy5gB/dYeBnxZZcoK9qsetjuB/g=; b=oQqLiln3tpLphhqRH1p3EpCrFWd+74h67bg+2rBK0fnh9dvR97BQWrcxPGDROwkQ4W zOjubzMrH0Ttzx7KirqXj5mBSyDsjcMuTj2xXjfeQBa4NxQQFJ8q8uAW4zWelsK7LoW7 HTF9X1ikE1Kvx7MV2BRWvN9lviouoMg94lyzxCCXEtnO14OHK3kgTkUC86MzKhef1uNi xAoD8hviYJ383pXPxC7aNjPZX8jemG7CU43g5Q0k7H91PkauJUwdLkd1eeOcGzCUghA+ 6FOm5lnejA6waqBldbDLoIKaAXqDJFwLWwZ+9IGuF7LjTZYSCqSj4uVK0xOcWVV677gM iALA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702421616; x=1703026416; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=551UBavCyvynG/NuNy5gB/dYeBnxZZcoK9qsetjuB/g=; b=abEsxL7o+USqXa/lP0sTcNdGkdN0e1Ahdl8l7gU2BWA1Omorytc2Utmgnj0D69mqip Aa4FHe4E6427qJTQOEd2Rcqq0G+AHDdZWvt7EsBdmziznXNy6f2j/lRDE+0FEk1/UZjd h7KA7EJLz4mu8VLnnoEaRe7bumhn60R5gKGeKv10i/sSzUngLr9ufiHo2cQ74649BouK k2O1+sVuK4qb140uaIirijXnyojC+BClMjgRFEDTi5aytg3/J2AhadOkFn+dFoeMyI2+ zqzmfUlnDpR1fAC6nEYWfj6cp5REFX3BOaSSanDTDo/6OoZJhWp4Ju8Srdu4w9TUfr4b ygLw== X-Gm-Message-State: AOJu0Yx3UZamFIL2iaqAYU3ERJytYHzkLRnZB/5rYVfpFeixk0+M/lpB 8EUIie/jBQR0lbOm6qP8dVqPq2yzuo88N1FeRpCy1Q== X-Google-Smtp-Source: AGHT+IEILBktRAL0h1OzpoGZAVfX3r+/lrvEzPdKzuDc5Toof0BhxeV+mzBsHcl6anYOb24UbuK7qA== X-Received: by 2002:a17:907:2d11:b0:a1f:60d2:f0af with SMTP id gs17-20020a1709072d1100b00a1f60d2f0afmr4633548ejc.70.1702421615836; Tue, 12 Dec 2023 14:53:35 -0800 (PST) Received: from localhost.localdomain ([82.142.85.165]) by smtp.gmail.com with ESMTPSA id tk10-20020a170907c28a00b00a1cfa7e0d40sm6820029ejc.61.2023.12.12.14.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 14:53:35 -0800 (PST) Message-ID: Subject: Re: BUG #18244: Corruption in indexes involving whole-row expressions From: Laurenz Albe To: nik@postgres.ai, pgsql-bugs@lists.postgresql.org Date: Tue, 12 Dec 2023 23:53:35 +0100 In-Reply-To: <18244-8a7897de2acd5a08@postgresql.org> References: <18244-8a7897de2acd5a08@postgresql.org> Autocrypt: addr=laurenz.albe@cybertec.at; prefer-encrypt=mutual; keydata=mQINBGGDwAQBEADgbWy5cKXQld3N2mF+DFyiNFbi2oBl2T+XgxpPF8wTRw2D/u4bBKXP0SYSE/lA86jIVNWWU0gf1KODIkVvgJm2w4vH2VBV1b7ddVViGl1Iu+9zaRnv9wulhnH42KefepXnoean6UT1EzLM0opF/Ik0j+40TxdRtobkBprkQUyHDXWlHc2ffPs3SipyFEP9AVLf7ejRC46CXWDnsqjOBSMEW8Z4HiK/8RrPZBsKLts8dJxKF4pygOdJb0CWk8k/X1jbcfdxo+zOLjOMvJcSJ2pFdJmQHU+JufB3rePziqQ2S9Ur6sccr9XnTC1GVBWN4Lf5VHq+vf+bFJjVwg+2hrySZnAVfcOrxoqFLErr7ug1zN2nM1kcpgA4VWn4gxlJtYNYYq+9WxX5dtvnNANlG3ZCrRKQzl8lxtzoF6Zo7LUhEqPaHDwn7Rvs+IdbOn41lF5UDTJGqmC4gS/bZydW2Fy3YWm4aSaN9fgFf8D+PVkrlKAZB7gBLz1TyHjbcRf85cYF+GKKrDld5SzMB/V60VX3oP/Eo8ikFpyWaqiz1f9X7MBot3/PjJkY+wDzp3nmb19QEcOBuQiSQ4xds2r0HewbuHTAR68u8jNNMGmpm2j4x+g09Jd/WQDjqlTBZ/jEltH41fYCCPWMfljXTOOXu2eLNGdfi7ETZogtwjM9oTtSPQARAQABtCdMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5hdD6JAk4EEwEIADgWIQR0CqhbZGGABqoaSbdi8bhXA2EdmAUCYYPABAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBi8bhXA2EdmM/6EADK232JCwmBzhlj8h7U9CjG6kx0JHP3uJGv+XfsHtHAlmY/RCwF1BHMEsRlk bT5UrLvJ2jb99bA9QARzhFaxzyn0F/BUKzuIjRGNs/n6d5dNUFA0kOt8sX+TacmC GEyjEBCrVCm4ranBiUyePn9NhHNWnaex7pJyqvMLLdwW9BEMJx0Fqo+DN8ukbXmYRsmhEtd3ue+x/luYmOmJnaGtzInaY5aOJYbW9XqoRIZkZvOCgbi1FfvNmoqWa+3oVxTOgw9RafjJDyW0lTHzKGjbGI5ofMU98l+/hKJFYJqWUF6VpFJY5YIcN/1lf4ZICMwDl+MPIVo/tpq8L10seJL28nLlvw3K+cI+TVW8IW/qL/LyVoDofI3USeOORuYmhpWRhik8JXX6xf3v6GrRilJIPWNFIJbxm1ZblQiQnOw3IOW7T+8nAmPin1HKqM3VrOrJQ2VtShsefNBibNAsr1oFaqcDBkn3yGG8i6CTW+FyO4PZ+/EwNxMVgktxbYdy5AT1/lpXr5tB+phhLIyVfiBvrWs5EThxYMQ/L8Y85c3GMsAy1l/x4h3jqySIYy3SCU9+jc5UVuNnXljbvkEzJ+NLWJ6C1rACFWrMszgPdh5tCrlRY9PpmYll4JbCgb8BtxEIUmR+xr50/ZElEK5iml7Q00KUekCcDt+36PsyGFTXBzNOrkCDQRhg8AEARAAzOZ2tLHlI4rrhG411h6cdCFjBZxuljaFCxFyHn3m6wbGLqwBUWC5k8UrRqjHMz88KcTSaNO7XGAmCqPdWd2SeflPZRnNTbjsVpw7mLdffsBm4JX7kki2Pvk5h0NtYeidXT1PSpc2ri4DutYXuT9uD8RAm1wUDCE5HQNUihT/WH6opt+hskHW21uHao0+y822tG0QQcGMqdQR5Vxdxj89wiEPdqW+HpU/oOZIhrf2E7prduAppxixjHy/o1rcnoznnJvc8D3+YgI9O0LrBMij89dM55pRGbLovTR1oGR3U74sX774+0xmSzeIKwZfiMUz7Atlvfk5SHOsRUFPN2Ux9kaXiiBibQpHFxt7b lDrT4wxdLJ/XCdbPPAyl+lZtOLsaHEEZvYNyTXwZc35dVf3R4/oz20HoG6s7ct8e1 AQygj43XAERzty9SkWgxs8+grp1PrGx6FHVSYRqBM8dS/ZR6yRVwOwJXPyaSSqfIF21DkE4j1y4n+ItSewPGoRp8K/yWCikt6qlkVkO2ASNIiX04fAbtzwVOaNn8ZMRNqyvLc1fED4sr49onE4cAIcBLjcC3KL+w9DUGRQCdziROj5H2Yl/sXGPdMciUHo/Uz2rggc+2th3bQiMhrHWSsBpUkDQp0yWewemstPpPgBL3h2fHKaX8B9oH5Qu/H1IgrOuX8AEQEAAYkCNgQYAQgAIBYhBHQKqFtkYYAGqhpJt2LxuFcDYR2YBQJhg8AEAhsMAAoJEGLxuFcDYR2YuPwQAMkpGtR80pQ1gVsONhdkqj0H2eU66efP/gO3CoyaoIcvrpKYj7C2HipVSmkt1gpByL0X4AMQ/vKuknUz3wd28Ba+G1dCfbVs/Xiusq+SmpUj5rTwmYqdSjWMuCo1R6oS5hdJMdUUJYGMT0QkVlm1KnW8jkmCTl9GzjDxOAsN9O6/6lPzaGFtk9XF+34Bry/N4HKiJkqpC4+UTd0AprPfzJ2jdT64e1F0+W88X8y1bTTgNrHwK4mDiLnlE4SKRuEm54lNhJz//ar86Or5BErzNpM6TL7lk44QS06hwsMrEdKIy8J/SYJPjfzR8tIUnKscclVpOgjKaBqC+0iFiVaRqAgfOlIEiezX6kMh5Q2FIUfqs46qWhhXjRrdKOEoStYAaikdLu5ZXr7vfb0ZaDh+ZwTQtbSMFolyOkecwI81MCdbMfT/1TqIGTOdAj5as9fAakk0jb2pXgUYQ8X1DVTR8ahSDVEaw9VTmWiSvTxvguVJ1Mb7gG4Gmh6aviDTJhfXtH4rPUNXhDLqrTH8JkJjyKROOMakIF68Hjse5vUfUxreBEOtb5r1Coa2Fe7ncJayaSE7ryrDbFqpZ 36UMAx4ulWMyqJajLNGY0DdG8qIsR5nxRhrnK/mrCidZ8F9/D3bWAl4rjtHlsztN59 +AnW5l0HsQcY9ntFL/zEBOaonjdJf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 2023-12-12 at 19:28 +0000, PG Bug reporting form wrote: > nik=3D# create index on t1 (hash_record(t1)); >=20 > Such an index can easily be corrupted, e.g.: >=20 > nik=3D# alter table t1 add column yo int default -1; > > Proposal: prohibit the use of whole-row expression =E2=80=93 as it is alr= eady done > for generated columns and produce a similar error ("cannot use whole-row > variable in column generation expression") I reported that bug before: https://www.postgresql.org/message-id/flat/e48a5d9a2d3d72985d61ee254314f5f5= f5444a55.camel%40cybertec.at I think that your proposal is good, it seems that nobody cared enough to implement it. If we forbid that, one thing to consider is pg_upgrade: it needs a new check. Yours, Laurenz Albe