Subject: Re: BUG #17197: Assert failed on inserting index tuples after VACUUM
To: Peter Geoghegan <pg@bowt.ie>,
 PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
References: <17197-9438f31f46705182@postgresql.org>
 <CAH2-Wz=37_B-QwOrm1huKF0Dce=7y8kjSq2QhMePLVxaqB+EZQ@mail.gmail.com>
 <CAH2-WzkKtu=o=H_xFD1NS1pp-KDUq_akMVnLuYOAN+z4=sZTxA@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <f76a292c-9170-1aef-91a0-59d9443b99a3@gmail.com>
Date: Tue, 21 Sep 2021 08:00:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: 
 <CAH2-WzkKtu=o=H_xFD1NS1pp-KDUq_akMVnLuYOAN+z4=sZTxA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: ru-RU
Archived-At: 
 <https://www.postgresql.org/message-id/f76a292c-9170-1aef-91a0-59d9443b99a3%40gmail.com>
Precedence: bulk

Hello Peter,

21.09.2021 00:03, Peter Geoghegan wrote:
> On Mon, Sep 20, 2021 at 1:35 PM Peter Geoghegan <pg@bowt.ie> wrote:
> Before commit 3c3b8a4b our failing offset number would have at least
> found an LP_UNUSED item -- so no assertion failure. After that commit
> the offset's line pointer might actually be positioned "past the end
> of the line pointer array". But that is a valid state for a heap
> page/HOT chain to have -- so the assertion has it wrong.
>
> I'll push a fix soon. Thanks for the report!
Thanks for the fix!
But if that is a valid (or sane) state, then shouldn't the comment "Some
sanity checks" be removed (or updated) too?

Best regards,
Alexander