Message-ID: <f97d670d-2b03-9d47-6b64-09e6ed2f4d84@postgrespro.ru>
Date: Sun, 6 Feb 2022 10:37:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable
 transaction causes Assert at the transaction end
Content-Language: en-US
To: Dilip Kumar <dilipbalaut@gmail.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>
Cc: andrewbille@gmail.com,
 PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
References: <17385-9ee529fb091f0ce5@postgresql.org>
 <b22395d2-d432-f211-0bed-1f466df75152@postgrespro.ru>
 <CAD21AoCkwsb_Hz6JYbG0X8Jf_VEMheiib0FXpR2kc3UATVCPNQ@mail.gmail.com>
 <CAFiTN-sYZ0Cuyeygp7z8xfoFPhqTAbtnV+k2W9OHp8s0xus5vw@mail.gmail.com>
From: Dmitry Koval <d.koval@postgrespro.ru>
In-Reply-To: 
 <CAFiTN-sYZ0Cuyeygp7z8xfoFPhqTAbtnV+k2W9OHp8s0xus5vw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f97d670d-2b03-9d47-6b64-09e6ed2f4d84%40postgrespro.ru>
Precedence: bulk

> In  if (source != PGC_S_DEFAULT) we are overwriting newval with
> conf->reset_val so I think we should free the newval or can we even
> avoid guc_strdup in case of (source != PGC_S_DEFAULT)?

I think we can not avoid guc_strdup in case of (source != PGC_S_DEFAULT) 
because function call_string_check_hook() contains "free(*newval);" in 
PG_CATCH-section.
Probably we should free the newval in block

+                    if (source != PGC_S_DEFAULT)
+                    {
+                        /* Release newextra as we use reset_extra */
+                        if (newextra)
+                            free(newextra);

With best regards,
Dmitry Koval.