Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Wed, 17 Sep 2025 19:34:56 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Nathan Bossart" <nathandbossart@gmail.com>,
 "Masahiko Sawada" <sawada.mshk@gmail.com>
Cc: "Nazneen Jafri" <jafrinazneen@gmail.com>, pgsql-bugs@lists.postgresql.org
Message-Id: <fb6cbb5a-43e0-4da0-9008-3e583b41a230@app.fastmail.com>
In-Reply-To: <aMo3tsESKXh6MCVp@nathan>
References: 
 <CA+m5N8uciiyzVOBb+ncadQutLoMOFaqN13Phq+r_neZm2vd5gQ@mail.gmail.com>
 <CAD21AoAWGp5q9w7bN024NGT7QL=1Vw3PcqGBLbE35XGnT_JzpQ@mail.gmail.com>
 <aMog06qbmvLLcFSw@nathan>
 <CAD21AoB3kcrVnTxHX+F=MOt_DWHdKFBLKaBBeOcsUyW6jWEMfQ@mail.gmail.com>
 <aMo3tsESKXh6MCVp@nathan>
Subject: Re: Read Replica termination occurs when its
 max_active_replication_origins
 setting is lower than the primary
Content-Type: multipart/mixed;
 boundary=34139aed6c064976a16f7812efd323df
Archived-At: 
 <https://www.postgresql.org/message-id/fb6cbb5a-43e0-4da0-9008-3e583b41a230%40app.fastmail.com>
Precedence: bulk

--34139aed6c064976a16f7812efd323df
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Wed, Sep 17, 2025, at 1:23 AM, Nathan Bossart wrote:
> I drafted up what that would look like.  One very small nitpick is that it
> messes up the alignment of the pg_controldata output.  Otherwise, it seems
> pretty straightforward.
>

As Masahiko said this behavior is not new in v18 so I wouldn't consider fix it
to v18.

I don't think your patch works for one detail: StartupReplicationOrigin() is
called earlier than CheckRequiredParameterValues(). The
StartupReplicationOrigin() uses max_active_replication_origins to emit the
PANIC message. I didn't check the implications to postpone the
StartupReplicationOrigin(). Maybe an ugly solution is to check the
max_active_replication_origins inside or even before calling
StartupReplicationOrigin().

I'm attaching a script that I used to simulate the issue. Change the GUC name
to simulate the issue in a pre v18.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/
--34139aed6c064976a16f7812efd323df
Content-Disposition: attachment; filename="test-maro.sh"
Content-Type: application/x-shellscript; name="test-maro.sh"
Content-Transfer-Encoding: base64

IyEvYmluL2Jhc2gKCnNldCAteAoKUEdQQVRIPSR7UEdQQVRIOi0iJEhPTUUvcGcxOC9iaW4i
fQpQR0RBVEExPS9jL3BnZGF0YTEKUEdEQVRBMj0vYy9wZ2RhdGEyClBHREFUQTM9L2MvcGdk
YXRhMwpQR1BPUlQxPTk5OTEKUEdQT1JUMj05OTkyClBHUE9SVDM9OTk5MwpQR0RBVEFCQVNF
PXBvc3RncmVzClBBR0VSPSIiCgpQR1NDQUxFRkFDVE9SPTEKUEdDTElFTlRTPTEKUEdURVNU
RFVSQVRJT049MgoKZXhwb3J0IExBTkc9QwpleHBvcnQgUEFHRVIKdWxpbWl0IC1jIHVubGlt
aXRlZAoKaWYgWyAtZiAkUEdEQVRBMS9wb3N0bWFzdGVyLnBpZCBdOyB0aGVuCgkkUEdQQVRI
L3BnX2N0bCBzdG9wIC1EICRQR0RBVEExCmZpCgppZiBbIC1mICRQR0RBVEEyL3Bvc3RtYXN0
ZXIucGlkIF07IHRoZW4KCSRQR1BBVEgvcGdfY3RsIHN0b3AgLUQgJFBHREFUQTIKZmkKCmlm
IFsgLWYgJFBHREFUQTMvcG9zdG1hc3Rlci5waWQgXTsgdGhlbgoJJFBHUEFUSC9wZ19jdGwg
c3RvcCAtRCAkUEdEQVRBMwpmaQoKaWYgWyAtZCAkUEdEQVRBMSBdOyB0aGVuCglybSAtcmYg
JFBHREFUQTEKZmkKaWYgWyAtZCAkUEdEQVRBMiBdOyB0aGVuCglybSAtcmYgJFBHREFUQTIK
ZmkKaWYgWyAtZCAkUEdEQVRBMyBdOyB0aGVuCglybSAtcmYgJFBHREFUQTMKZmkKCiRQR1BB
VEgvaW5pdGRiIC1EICRQR0RBVEExCiRQR1BBVEgvaW5pdGRiIC1EICRQR0RBVEEyCgplY2hv
ICJ3YWxfbGV2ZWwgPSBsb2dpY2FsIiA+PiAkUEdEQVRBMS9wb3N0Z3Jlc3FsLmNvbmYKZWNo
byAibG9nZ2luZ19jb2xsZWN0b3IgPSBvbiIgPj4gJFBHREFUQTEvcG9zdGdyZXNxbC5jb25m
CmVjaG8gImxvZ19maWxlbmFtZSA9ICdwb3N0Z3Jlc3FsLmxvZyciID4+ICRQR0RBVEExL3Bv
c3RncmVzcWwuY29uZgplY2hvICJwb3J0ID0gJFBHUE9SVDEiID4+ICRQR0RBVEExL3Bvc3Rn
cmVzcWwuY29uZgojZWNobyAibG9nX21pbl9tZXNzYWdlcyA9IGRlYnVnMiIgPj4gJFBHREFU
QTEvcG9zdGdyZXNxbC5jb25mCgplY2hvICJ3YWxfbGV2ZWwgPSBsb2dpY2FsIiA+PiAkUEdE
QVRBMi9wb3N0Z3Jlc3FsLmNvbmYKZWNobyAibG9nZ2luZ19jb2xsZWN0b3IgPSBvbiIgPj4g
JFBHREFUQTIvcG9zdGdyZXNxbC5jb25mCmVjaG8gImxvZ19maWxlbmFtZSA9ICdwb3N0Z3Jl
c3FsLmxvZyciID4+ICRQR0RBVEEyL3Bvc3RncmVzcWwuY29uZgojZWNobyAibG9nX21pbl9t
ZXNzYWdlcyA9IGRlYnVnMiIgPj4gJFBHREFUQTIvcG9zdGdyZXNxbC5jb25mCmVjaG8gInBv
cnQgPSAkUEdQT1JUMiIgPj4gJFBHREFUQTIvcG9zdGdyZXNxbC5jb25mCgokUEdQQVRIL3Bn
X2N0bCBzdGFydCAtdyAtRCAkUEdEQVRBMQokUEdQQVRIL3BnX2N0bCBzdGFydCAtdyAtRCAk
UEdEQVRBMgoKJFBHUEFUSC9wZ2JlbmNoIC1pIC1zICRQR1NDQUxFRkFDVE9SIC1wICRQR1BP
UlQxICRQR0RBVEFCQVNFCgojIGFkZCBwcmltYXJ5IGtleSB0byBwZ2JlbmNoX2hpc3RvcnkK
JFBHUEFUSC9wc3FsIC1YIC1jICJCRUdJTjsgQUxURVIgVEFCTEUgcGdiZW5jaF9oaXN0b3J5
IFJFUExJQ0EgSURFTlRJVFkgRlVMTDsgQ09NTUlUOyIgLXAgJFBHUE9SVDEgJFBHREFUQUJB
U0UKCiMgY29weSBzY2hlbWEgdG8gc3Vic2NyaWJlcgokUEdQQVRIL3BnX2R1bXAgLXMgLXAg
JFBHUE9SVDEgJFBHREFUQUJBU0UgfCAkUEdQQVRIL3BzcWwgLWYgLSAtcCAkUEdQT1JUMiAk
UEdEQVRBQkFTRQoKIyBjcmVhdGUgcHVibGljYXRpb24gb24gcHVibGlzaGVyCiRQR1BBVEgv
cHNxbCAtWCAtYyAiQ1JFQVRFIFBVQkxJQ0FUSU9OIHB1YjEgRk9SIFRBQkxFIHBnYmVuY2hf
YWNjb3VudHMiIC1wICRQR1BPUlQxICRQR0RBVEFCQVNFCiRQR1BBVEgvcHNxbCAtWCAtYyAi
Q1JFQVRFIFBVQkxJQ0FUSU9OIHB1YjIgRk9SIFRBQkxFIHBnYmVuY2hfdGVsbGVycywgcGdi
ZW5jaF9icmFuY2hlcyIgLXAgJFBHUE9SVDEgJFBHREFUQUJBU0UKJFBHUEFUSC9wc3FsIC1Y
IC1jICJDUkVBVEUgUFVCTElDQVRJT04gcHViMyBGT1IgVEFCTEUgcGdiZW5jaF9oaXN0b3J5
IiAtcCAkUEdQT1JUMSAkUEdEQVRBQkFTRQoKIyBjcmVhdGUgc3Vic2NyaXB0aW9uIG9uIHN1
YnNjcmliZXIKJFBHUEFUSC9wc3FsIC1YIC1jICJDUkVBVEUgU1VCU0NSSVBUSU9OIHN1YjEg
Q09OTkVDVElPTiAncG9ydD0kUEdQT1JUMSBkYm5hbWU9JFBHREFUQUJBU0UnIFBVQkxJQ0FU
SU9OIHB1YjEiIC1wICRQR1BPUlQyICRQR0RBVEFCQVNFCiRQR1BBVEgvcHNxbCAtWCAtYyAi
Q1JFQVRFIFNVQlNDUklQVElPTiBzdWIyIENPTk5FQ1RJT04gJ3BvcnQ9JFBHUE9SVDEgZGJu
YW1lPSRQR0RBVEFCQVNFJyBQVUJMSUNBVElPTiBwdWIyIiAtcCAkUEdQT1JUMiAkUEdEQVRB
QkFTRQokUEdQQVRIL3BzcWwgLVggLWMgIkNSRUFURSBTVUJTQ1JJUFRJT04gc3ViMyBDT05O
RUNUSU9OICdwb3J0PSRQR1BPUlQxIGRibmFtZT0kUEdEQVRBQkFTRScgUFVCTElDQVRJT04g
cHViMyIgLXAgJFBHUE9SVDIgJFBHREFUQUJBU0UKCiMgZXhlY3V0ZSBzb21lIHRyYW5zYWN0
aW9ucwokUEdQQVRIL3BnYmVuY2ggLVQgJFBHVEVTVERVUkFUSU9OIC1jICRQR0NMSUVOVFMg
LXAgJFBHUE9SVDEgJFBHREFUQUJBU0UKCiMgY2hlY2sgcmVwbGljYXRpb24gbW9uaXRvcmlu
ZwokUEdQQVRIL3BzcWwgLVggLWMgIlNFTEVDVCBwZ19jdXJyZW50X3dhbF9sc24oKSA8PSB3
cml0ZV9sc24gQU5EIHN0YXRlID0gJ3N0cmVhbWluZycgRlJPTSBwZ19jYXRhbG9nLnBnX3N0
YXRfcmVwbGljYXRpb24gV0hFUkUgYXBwbGljYXRpb25fbmFtZSA9ICdzdWIxJyIgLXAgJFBH
UE9SVDEgJFBHREFUQUJBU0UKIyRQR1BBVEgvcHNxbCAtWCAtYyAiU0VMRUNUICogRlJPTSBw
Z19jYXRhbG9nLnBnX3JlcGxpY2F0aW9uX3Nsb3RzIiAtcCAkUEdQT1JUMSAkUEdEQVRBQkFT
RQojJFBHUEFUSC9wc3FsIC1YIC1jICJTRUxFQ1QgKiBGUk9NIHBnX2NhdGFsb2cucGdfc3Rh
dF9yZXBsaWNhdGlvbl9zbG90cyIgLXAgJFBHUE9SVDEgJFBHREFUQUJBU0UKIyRQR1BBVEgv
cHNxbCAtWCAtYyAiU0VMRUNUICogRlJPTSBwZ19jYXRhbG9nLnBnX3N0YXRfcmVwbGljYXRp
b24iIC1wICRQR1BPUlQxICRQR0RBVEFCQVNFCiMkUEdQQVRIL3BzcWwgLVggLWMgIlNFTEVD
VCAqIEZST00gcGdfY2F0YWxvZy5wZ19zdGF0X2FjdGl2aXR5IHdoZXJlIGJhY2tlbmRfdHlw
ZSA9ICd3YWxzZW5kZXInIiAtcCAkUEdQT1JUMSAkUEdEQVRBQkFTRQojJFBHUEFUSC9wc3Fs
IC1YIC1jICJTRUxFQ1QgKiBGUk9NIHBnX2NhdGFsb2cucGdfc3Vic2NyaXB0aW9uX3JlbCIg
LXAgJFBHUE9SVDIgJFBHREFUQUJBU0UKCiMgY3JlYXRlIHBoeXNpY2FsIHJlcGxpY2EgZnJv
bSBzdWJzY3JpYmVyCiRQR1BBVEgvcGdfYmFzZWJhY2t1cCAtRCAkUEdEQVRBMyAtUiAtWCBz
dHJlYW0gLWMgZmFzdCAtUCAtdiAtcCAkUEdQT1JUMiAtQyAtUyBwcmltYXJ5c2xvdApzZWQg
LWkgInMvcG9ydCA9ICRQR1BPUlQyL3BvcnQgPSAkUEdQT1JUMy8iICRQR0RBVEEzL3Bvc3Rn
cmVzcWwuY29uZgpybSAtcmYgJFBHREFUQTMvbG9nLyoubG9nCgojIHN0YXJ0IHN0YW5kYnkK
JFBHUEFUSC9wZ19jdGwgc3RhcnQgLXcgLUQgJFBHREFUQTMKCiMgcmVkdWNlIEdVQwplY2hv
ICJtYXhfYWN0aXZlX3JlcGxpY2F0aW9uX29yaWdpbnMgPSAxIiA+PiAkUEdEQVRBMy9wb3N0
Z3Jlc3FsLmNvbmYKI2VjaG8gIm1heF9yZXBsaWNhdGlvbl9zbG90cyA9IDEiID4+ICRQR0RB
VEEzL3Bvc3RncmVzcWwuY29uZgoKIyBzdGFydCBzdGFuZGJ5CiRQR1BBVEgvcGdfY3RsIHJl
c3RhcnQgLXcgLUQgJFBHREFUQTMKCiNncmVwIC1FICdQQU5JQ3xGQVRBTHxFUlJPUicgJFBH
REFUQTMvbG9nL3Bvc3RncmVzcWwubG9nCgokUEdQQVRIL3BnX2N0bCBzdG9wIC1EICRQR0RB
VEExCiRQR1BBVEgvcGdfY3RsIHN0b3AgLUQgJFBHREFUQTIKJFBHUEFUSC9wZ19jdGwgc3Rv
cCAtRCAkUEdEQVRBMwoKdGFpbCAtbiAxNSAkUEdEQVRBMy9sb2cvcG9zdGdyZXNxbC5sb2cK

--34139aed6c064976a16f7812efd323df--