Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppdjF-0000e8-UP for pgsql-bugs@arkaria.postgresql.org; Thu, 20 Apr 2023 23:30:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ppdjC-000676-2y for pgsql-bugs@arkaria.postgresql.org; Thu, 20 Apr 2023 23:30:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppdjB-00066w-Mt for pgsql-bugs@lists.postgresql.org; Thu, 20 Apr 2023 23:30:13 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ppdj8-000xe6-It for pgsql-bugs@lists.postgresql.org; Thu, 20 Apr 2023 23:30:12 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1a6bc48aec8so13829925ad.2 for ; Thu, 20 Apr 2023 16:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20221208.gappssmtp.com; s=20221208; t=1682033409; x=1684625409; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=IDTGJaHmnVtJINZS+ciEGv348r3ZIxUfJ12+RzoI8X0=; b=33SByxeCRkbIkIU0ppL9GRf1Hkd2JxVZL+++VLyjXFPXKbQukBQvNbe30pOnsLF9fE lPvYO2nW793htLbEE6eDjPvT5rvrg6q39CaWAFFimRiZE23hAZwBT3K5QlNlcy/IkUcE Fp0c6o8Gsuqdw7yHBDY8WUHWraTOs7IlbQO9YGHqbJM6lt00Vr5AAlv7tSCetCB0VB2d bFWp97sI+qiuh4GD3jVr8GTYn8f9nOjvf7Cl3F940jnT5SEnktYxYdr4asv1Zpn8IRJx hc4Eaq/QX1Q87AT3TFKZULjKMkTkCAk+6CAHVb3PLZRsgM64Akd65ekpAkbH11nKsVRU ImkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682033409; x=1684625409; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IDTGJaHmnVtJINZS+ciEGv348r3ZIxUfJ12+RzoI8X0=; b=WTQ6EGsXr8RosR7hxyYE2tMoABNA+uIbYIPzx0cXIg9jPMIrDXZemV3JoH/Pjx6Tyd Eyc4XJ4AEKoGNeyNydbt1RuXgKLnAbLzP5Tle2yDhYMCXnC1/DrpT45wghSxT4YL++sq ro9FtGw9aRGzs0kjBMIp6PP6KqRRaB9ZkNDUgXbn1QYKICrnK56qZZ31MVTreajA5dL8 cMZxmeP2T49YTAeGORL+MkVM7wTYVW8bPzP5CAxbN2zRQe2cHChSpyjlpo0/YpE8hZ7/ DWVbgh4RzwQXOM9rWiM9R8MMqAHDTdYRtNQ4RGexaJ2Q8/aSfAqDdTYJvHhnl3CftCqr XkuA== X-Gm-Message-State: AAQBX9dQ4mBdR7uwuHKVa93BJUV9gQXQ4hTe5MbCCgfBPxd1piZotpYW hclj+3UO1AZ6h3JWu9+3Aww1NA== X-Google-Smtp-Source: AKy350a4RFVshL+jOHbHmqbSutHodDFwXUujTJiVu+TiR58xopOWsDl3f+HIjnfrw+NUTNxlF4Fqkw== X-Received: by 2002:a17:902:64d7:b0:1a5:2371:a64f with SMTP id y23-20020a17090264d700b001a52371a64fmr2555144pli.12.1682033409417; Thu, 20 Apr 2023 16:30:09 -0700 (PDT) Received: from jeff-laptop.lan (c-73-170-46-202.hsd1.ca.comcast.net. [73.170.46.202]) by smtp.gmail.com with ESMTPSA id d4-20020a170902b70400b001a681d123a0sm1596811pls.297.2023.04.20.16.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 16:30:08 -0700 (PDT) Message-ID: Subject: Re: Assert failure with ICU support From: Jeff Davis To: Tom Lane Cc: Richard Guo , PostgreSQL mailing lists Date: Thu, 20 Apr 2023 16:30:07 -0700 In-Reply-To: <3170490.1682020381@sss.pgh.pa.us> References: <3017542.1681937148@sss.pgh.pa.us> <3170490.1682020381@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="=-uBcGx+c7455eg/Q7tHTx" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-uBcGx+c7455eg/Q7tHTx Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2023-04-20 at 15:53 -0400, Tom Lane wrote: > As I read it, it's meant to leave room for defining more escapes. > If we allowed \x for any non-currently-defined "x" to just be "x", > then there would be a compatibility problem if we wanted to make > it mean something else.=C2=A0 But I think it's sufficient to reserve > the ASCII letters for that purpose. Sounds good, patch attached. Regards, Jeff Davis --=-uBcGx+c7455eg/Q7tHTx Content-Disposition: attachment; filename*0=0001-Avoid-character-classification-in-regex-escape-parsi.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Avoid-character-classification-in-regex-escape-parsi.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBiOTMzYjA0ZDY4Y2RhYzA5OGM3ZWViMzJiODg3MDdmM2JlMzg1ZmU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU aHUsIDIwIEFwciAyMDIzIDEzOjE3OjA5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQXZvaWQgY2hh cmFjdGVyIGNsYXNzaWZpY2F0aW9uIGluIHJlZ2V4IGVzY2FwZSBwYXJzaW5nLgpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1U cmFuc2Zlci1FbmNvZGluZzogOGJpdAoKRm9yIHJlZ2V4IGVzY2FwZSBzZXF1ZW5jZXMsIGp1c3Qg dGVzdCBkaXJlY3RseSBmb3IgdGhlIHJlbGV2YW50IEFTQ0lJCmNoYXJhY3RlcnMgcmF0aGVyIHRo YW4gdXNpbmcgbG9jYWxlLXNlbnNpdGl2ZSBjaGFyYWN0ZXIKY2xhc3NpZmljYXRpb24uCgpUaGlz IGZpeGVzIGFuIGFzc2VydGlvbiBmYWlsdXJlIHdoZW4gYSBsb2NhbGUgY29uc2lkZXJzIGEgbm9u LUFTQ0lJCmNoYXJhY3Rlciwgc3VjaCBhcyAi4LWnIiwgdG8gYmUgYSBkaWdpdC4KClJlcG9ydGVk LWJ5OiBSaWNoYXJkIEd1bwpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL0NBTWJXczQ5 UTZVb0tHZVQ4cEJrTXRKR0pkKzE2Q0JGWmFhV1VrOUR1KzJFUkU1Z19ZQUBtYWlsLmdtYWlsLmNv bQotLS0KIHNyYy9iYWNrZW5kL3JlZ2V4L3JlZ2NfbGV4LmMgfCAxMyArKysrKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9zcmMvYmFja2VuZC9yZWdleC9yZWdjX2xleC5jIGIvc3JjL2JhY2tlbmQvcmVnZXgvcmVn Y19sZXguYwppbmRleCA0NzgwZDc5ZjA5Li4zOGMwOWIxMTIzIDEwMDY0NAotLS0gYS9zcmMvYmFj a2VuZC9yZWdleC9yZWdjX2xleC5jCisrKyBiL3NyYy9iYWNrZW5kL3JlZ2V4L3JlZ2NfbGV4LmMK QEAgLTYxMyw3ICs2MTMsMTEgQEAgbGV4ZXNjYXBlKHN0cnVjdCB2YXJzICp2KQogCiAJYXNzZXJ0 KCFBVEVPUygpKTsKIAljID0gKnYtPm5vdysrOwotCWlmICghaXNjYWxudW0oYykpCisKKwkvKiBp ZiBpdCdzIG5vdCBhbHBoYW51bWVyaWMgQVNDSUksIHRyZWF0IGl0IGFzIGEgcGxhaW4gY2hhcmFj dGVyICovCisJaWYgKCEoJ2EnIDw9IGMgJiYgYyA8PSAneicpICYmCisJCSEoJ0EnIDw9IGMgJiYg YyA8PSAnWicpICYmCisJCSEoJzAnIDw9IGMgJiYgYyA8PSAnOScpKQogCQlSRVRWKFBMQUlOLCBj KTsKIAogCU5PVEUoUkVHX1VOT05QT1NJWCk7CkBAIC03NTUsOCArNzU5LDExIEBAIGxleGVzY2Fw ZShzdHJ1Y3QgdmFycyAqdikKIAkJCVJFVFYoUExBSU4sIGMpOwogCQkJYnJlYWs7CiAJCWRlZmF1 bHQ6Ci0JCQlhc3NlcnQoaXNjYWxwaGEoYykpOwotCQkJRkFJTFcoUkVHX0VFU0NBUEUpOyAvKiB1 bmtub3duIGFscGhhYmV0aWMgZXNjYXBlICovCisJCQkvKgorCQkJICogVGhyb3cgYW4gZXJyb3Ig Zm9yIHVucmVjb2duaXplZCBBU0NJSSBhbHBoYSBlc2NhcGUgc2VxdWVuY2VzLAorCQkJICogd2hp Y2ggcmVzZXJ2ZXMgdGhlbSBmb3IgZnV0dXJlIHVzZSBpZiBuZWVkZWQuCisJCQkgKi8KKwkJCUZB SUxXKFJFR19FRVNDQVBFKTsKIAkJCWJyZWFrOwogCX0KIAlhc3NlcnQoTk9UUkVBQ0hFRCk7Ci0t IAoyLjM0LjEKCg== --=-uBcGx+c7455eg/Q7tHTx--