Feedback-ID: ie0a040ee:Fastmail
Message-ID: <fed622f0-b7bb-4294-a91b-02ccdd2bf54f@eisentraut.org>
Date: Wed, 15 May 2024 08:45:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #18362: unaccent rules and Old Greek text
To: Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Cc: Cees van Zeeland <cees.van.zeeland@freedom.nl>,
 Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-bugs@lists.postgresql.org
References: <18362-be6d0cfe122b6354@postgresql.org>
 <CA+hUKGLpoxTRryM1MxaHMpC1c5cxoKDm0iXfogQR9KGVUG=w9w@mail.gmail.com>
 <ZdvLGeJ1BsXRkrdQ@paquier.xyz>
 <d9875ca6-6438-4c52-adc1-5bc2ed28c362@freedom.nl>
 <CA+hUKGK7OKZcCpvD92RyJtu6m_b6XRuZRNqSu_5Y3vHDn7KDpA@mail.gmail.com>
 <CA+TgmobZvFiTHhnO=jBqffMY=5OTB7R=jAkVRRR13yQG11UnvQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CA+TgmobZvFiTHhnO=jBqffMY=5OTB7R=jAkVRRR13yQG11UnvQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/fed622f0-b7bb-4294-a91b-02ccdd2bf54f%40eisentraut.org>
Precedence: bulk

On 14.05.24 16:51, Robert Haas wrote:
> 1. The question of rule file load times seems like something that
> anyone who could compile PostgreSQL with and without a patch applied
> could test in under an hour. They could then report the results that
> they got, and people here could judge whether the resulting numbers
> are totally cool or very sad or something in between. Anyone willing
> to do that?

The rules are only loaded once on first use, right?  I tested with

date; for x in $(seq 1 1000); do psql -X -c "select unaccent('foobar')" 
-o /dev/null; done; date

and this had the same runtime (about 8 seconds here) with and without 
the patch.

Btw., with the patch I get

WARNING:  duplicate source strings, first one will be used

so it will need to adjustments in how the rules are produced.