Message-ID: <ffefcf03-41fe-400b-929b-90692eb70e44@oss.nttdata.com>
Date: Tue, 24 Sep 2024 23:49:12 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 Christophe Pettus <xof@thebuild.com>,
 vaibhave postgres <postgresvaibhave@gmail.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
 pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
References: <Zu3iMzfiGBTbg3iy@nathan> <20240920215030.8d.nmisch@google.com>
 <2603142.1726873660@sss.pgh.pa.us>
 <5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
 <2649165.1726898595@sss.pgh.pa.us>
 <CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
 <ZvGye19tHrhLCpFl@nathan> <E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
 <ZvIRG6282T33q3Ku@paquier.xyz>
 <00d98a9f-bec1-4cd0-b59e-1043ae04c8bc@oss.nttdata.com>
 <ZvLMDXv1XrxuJfT3@nathan>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <ZvLMDXv1XrxuJfT3@nathan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ffefcf03-41fe-400b-929b-90692eb70e44%40oss.nttdata.com>
Precedence: bulk


On 2024/09/24 23:26, Nathan Bossart wrote:
> Yeah, this is what I mentioned upthread [0].  If the user doesn't specify
> anything in --table or --schema, then it's probably fine to silently skip
> objects for which they lack privileges.  But if they do explicitly specify
> a table or schema that they cannot vacuum, then IMHO it'd be better to
> fail.

This could be debatable. To be honest, if I run something like vacuumdb mydb,
*I* expect all eligible tables in that database to be vacuumed. If I forget to
grant the necessary privileges to the role, I’d prefer to see errors from
vacuumdb so I can fix the permissions.

If we decide to skip tables without enough privilege, I’d prefer adding
an option like --skip-unprivileged-tables rather than changing the default behavior.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION