pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
[PATCH] Reject MERGE in CTE
1+ messages / 1 participants
[nested] [flat]

* [PATCH] Reject MERGE in CTE
@ 2022-08-11 11:17 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 1+ messages in thread

From: Alvaro Herrera @ 2022-08-11 11:17 UTC (permalink / raw)

---
 src/backend/parser/parse_cte.c      | 7 +++++++
 src/test/regress/expected/merge.out | 8 ++++++++
 src/test/regress/sql/merge.sql      | 5 +++++
 3 files changed, 20 insertions(+)

inline patch 1: src/backend/parser/parse_cte.c, src/test/regress/expected/merge.out, src/test/regress/sql/merge.sql (+20/-0 lines) download inline-1.patchdiff --git a/src/backend/parser/parse_cte.c b/src/backend/parser/parse_cte.c index efb4af706e..8fc8658608 100644 --- a/src/backend/parser/parse_cte.c +++ b/src/backend/parser/parse_cte.c @@ -126,6 +126,13 @@ transformWithClause(ParseState *pstate, WithClause *withClause) CommonTableExpr *cte = (CommonTableExpr *) lfirst(lc); ListCell *rest; + /* MERGE is allowed by parser, but unimplemented. Reject for now */ + if (IsA(cte->ctequery, MergeStmt)) + ereport(ERROR, + errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("MERGE not supported in WITH query"), + parser_errposition(pstate, cte->location)); + for_each_cell(rest, withClause->ctes, lnext(withClause->ctes, lc)) { CommonTableExpr *cte2 = (CommonTableExpr *) lfirst(rest); diff --git a/src/test/regress/expected/merge.out b/src/test/regress/expected/merge.out index af670e28e7..21609eba63 100644 --- a/src/test/regress/expected/merge.out +++ b/src/test/regress/expected/merge.out @@ -123,6 +123,14 @@ ON tid = tid WHEN MATCHED THEN DO NOTHING; ERROR: name "target" specified more than once DETAIL: The name is used both as MERGE target table and data source. +-- used in a CTE +WITH foo AS ( + MERGE INTO target USING source ON (true) +WHEN MATCHED THEN DELETE +) SELECT * FROM foo; +ERROR: MERGE not supported in WITH query +LINE 1: WITH foo AS ( + ^ -- unsupported relation types -- view CREATE VIEW tv AS SELECT * FROM target; diff --git a/src/test/regress/sql/merge.sql b/src/test/regress/sql/merge.sql index afeb212f3c..a3e9d36fe3 100644 --- a/src/test/regress/sql/merge.sql +++ b/src/test/regress/sql/merge.sql @@ -88,6 +88,11 @@ MERGE INTO target USING target ON tid = tid WHEN MATCHED THEN DO NOTHING; +-- used in a CTE +WITH foo AS ( + MERGE INTO target USING source ON (true) +WHEN MATCHED THEN DELETE +) SELECT * FROM foo; -- unsupported relation types -- view -- 2.30.2
--54exrjnke3mqqaau-- ^ permalink raw reply [nested|flat] 1+ messages in thread


only message in thread

Thread overview: 1+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 11:17 [PATCH] Reject MERGE in CTE Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox