Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uz7w7-00H1kF-Vc for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Sep 2025 06:16:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uz7w6-00E3h1-J3 for pgsql-bugs@arkaria.postgresql.org; Thu, 18 Sep 2025 06:16:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with utf8esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uz7w5-00E3gt-SS for pgsql-bugs@lists.postgresql.org; Thu, 18 Sep 2025 06:16:06 +0000 Received: from out203-205-221-164.mail.qq.com ([203.205.221.164]) by magus.postgresql.org with utf8esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uz7vw-001SCN-1f for pgsql-bugs@lists.postgresql.org; Thu, 18 Sep 2025 06:16:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1758176127; bh=yktOflsel1dj4njcuQ7YUTgZZNZtXqrpmi8FuKrcQIE=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=zY9Cyz70vKMLipwTmVQzUaYmOztdRF/bqk/91MLHTrju/op4bTin0fDcE9N5dqvRK k0dCKifZj9P3hfuH53EAsuQUtnE9JcRCNeR1/g6FgOEBSWX4RoGcLqUUAwContzJks zAt2l2mBq0rH3YIdoqJ/l+rh0zih3zF5erMhubNQ= Received: from smtpclient.apple ([140.205.11.23]) by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP id 3D9874D7; Thu, 18 Sep 2025 14:15:25 +0800 X-QQ-mid: xmsmtpt1758176125tzp466q10 Message-ID: X-QQ-XMAILINFO: NkHKfw09D6j8cv3gtALgbvfhYva38Z7SFtGgpGEMUV2mw3q69RnR2g1WqYxf8K GG0uBe+3XUW9bDj9NUY0S5msoIcoYLCKodvKQzHLBTs8n4QFj9rkMLiGdN1N2nDPPqvz+xQ/3ZdP nyCd+9zMkJ9ia65eaiMoHPlMLri2oau+OpAolkj5P+xO4FsofkOED9YPo8RI6SD5kJFkWB2X8D1u zj5LSYLPmlBz6x80/m5C7AA9fYp+FAzdC1922SiPUKHakODvd0n8EELRbQyVuKONHdNaDCcFAQvY 3OYU8b4jcqo4hdpKMrGoChpFKSd0RN1YEmWTRHd1Cph72R3E3TYqkLi2kiuxAf34HE8AkBePfMsT axeXcyGj0H0MbGrOAIZAD86mig2iEARWYQ0NSCpxvkraItPA1+MfYX5rhWZWNAlvGL+IE7Dl2NhR I6mQ9YVUiZ7OU0mN51lnQOIr5SKl2tcZ1BlqGuWAjGqgZFaAmbGT3A7Zlucb0J7fWmjmPUUqHSKe NwD05ukPCNj5TfkcpJ33pPmOd1pQUwNL/V6Nze/D66bXey/2DnHTxF7KyVwBvUXrsMf1v4KjF3K4 ENhBADCFwrWvy/PP91/4c0gTeanw56GleoeI9IgAqKb1C1WVlHQ3WY3LvAZI5mY1rzicOFvdc+Pp t25ABRVw9dPF1Md1TslnwA1yCiRmKDWkjT9DRYU2+AeUtg4Z2qQ5JCnZw2RDGuXCLWYpwyyAzAx+ 0IZuqakZIMA3WI+9t/EpPC32Qdg0bPySfUOUwlnpJuGdH7UGDYEOxDecBkZkS2BTSJcIPtKNODU9 1EW5FOw09yiMYhQq38QbVCZU5C2nyeMt3mnkqZ1z9o9DdKBrXdVNhNg2jIKgxuF3K0fzoH5LAkTw valtoG8td+/e0J/69ygKlXnGlNHPU8icHR71BOmx99LS9UPURLRj04DicFt1sFsOyyN6T7ltFUn5 ITu5C6NNCtzqVtTJ1YQWDQggu5i3776o0hP+u3XCHAoyh4sORkhR9RDcAFgNjgN0tgrfQagUWED7 pqorLh3d9nmHWAEYnAMrDwUnSwgaqDrctlAmh8IcDKzk60lp2F X-QQ-XMRINFO: MPJ6Tf5t3I/ycC2BItcBVIA= From: feichanghong X-OQ-MSGID: <6BBBC18E-DD5E-419F-A141-450CEA670927@qq.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_1C49962E-2AA0-4EC7-8C3B-FF4A0426FBB5" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos Date: Thu, 18 Sep 2025 14:15:15 +0800 In-Reply-To: Cc: Tom Lane , David Rowley , pgsql-bugs@lists.postgresql.org To: Amit Langote References: <19056-a677cef9b54d76a0@postgresql.org> <1836971.1758168660@sss.pgh.pa.us> X-Mailer: Apple Mail (2.3826.700.81) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_1C49962E-2AA0-4EC7-8C3B-FF4A0426FBB5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 18, 2025, at 14:09, Amit Langote = wrote: >=20 > On Thu, Sep 18, 2025 at 1:56=E2=80=AFPM Amit Langote = > wrote: >> On Thu, Sep 18, 2025 at 1:11=E2=80=AFPM Tom Lane = wrote: >>>=20 >>> David Rowley writes: >>>> On Thu, 18 Sept 2025 at 15:37, Amit Langote = wrote: >>>>> +# Test that EState.es_part_prune_infos is properly set in = EvalPlanQualStart() >>>>> +# Bug #19056 >>>=20 >>>> I don't think it's that useful to note down the bug number that = caused >>>> that test to be added. >>>=20 >>> We're inconsistent about whether we do that or not, but it's >>> far from un-heard-of. I just today pushed a patch in which >>> I did mention the bug# in the test case [1], and I did so >>> mostly because the adjacent test case had a similar comment. >>> So I see no reason to object to Amit's usage. >>=20 >> I was just mimicking a few other "cf bug #" mentions in >> eval-plan-qual.spec, but I'm fine to take it out if we'd prefer to >> reduce that. Git blame is enough. >>=20 >>>> I think it'd be better to write something like: >>>> "Exercise run-time partition pruning code in an EPQ plan" >>>=20 >>> Not expressing an opinion about whether that's better or >>> worse than Amit's lede. >>=20 >> What I added is: >>=20 >> # Test that EState.es_part_prune_infos is properly set in = EvalPlanQualStart() >>=20 >> I'm fine to change the comment to David's suggestion since that makes >> the test description less narrowly tied to one fix of one specific >> issue in that path. >=20 > Patch updated. > +# EState.es_part_prune_infos bug #19056 There is still bug #19056 here. Best Regards, Fei Changhong --Apple-Mail=_1C49962E-2AA0-4EC7-8C3B-FF4A0426FBB5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On Sep 18, = 2025, at 14:09, Amit Langote <amitlangote09@gmail.com> = wrote:

On Thu, Sep 18, 2025 at = 1:56=E2=80=AFPM Amit Langote <amitlangote09@gmail.com> = wrote:
On Thu, Sep 18, 2025 at 1:11=E2=80=AFPM Tom Lane = <tgl@sss.pgh.pa.us> wrote:

David = Rowley <dgrowleyml@gmail.com> writes:
On Thu, 18 Sept 2025 at 15:37, Amit Langote = <amitlangote09@gmail.com> wrote:
+# = Test that EState.es_part_prune_infos is properly set in = EvalPlanQualStart()
+# Bug = #19056

I = don't think it's that useful to note down the bug number that = caused
that test to be added.

We're inconsistent = about whether we do that or not, but it's
far from un-heard-of. =  I just today pushed a patch in which
I did mention the bug# in = the test case [1], and I did so
mostly because the adjacent test case = had a similar comment.
So I see no reason to object to Amit's = usage.

I was just mimicking a few other "cf bug #" = mentions in
eval-plan-qual.spec, but I'm fine to take it out if we'd = prefer to
reduce that.  Git blame is enough.

I think it'd be better to write = something like:
"Exercise run-time partition pruning code in an EPQ = plan"

Not expressing an opinion about whether that's = better or
worse than Amit's lede.

What I added = is:

# Test that EState.es_part_prune_infos is properly set in = EvalPlanQualStart()

I'm fine to change the comment to David's = suggestion since that makes
the test description less narrowly tied = to one fix of one specific
issue in that path.

Patch = updated.
+# = EState.es_part_prune_infos bug = #19056

There is still bug #19056 = here.

Best Regards,
Fei Changhong

= --Apple-Mail=_1C49962E-2AA0-4EC7-8C3B-FF4A0426FBB5--