Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC08o-00033e-Sb for pgsql-committers@arkaria.postgresql.org; Thu, 14 Jul 2022 14:48:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oC08m-0004zL-S2 for pgsql-committers@arkaria.postgresql.org; Thu, 14 Jul 2022 14:48:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC08m-0004z4-Gd for pgsql-committers@lists.postgresql.org; Thu, 14 Jul 2022 14:48:32 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC08j-0001of-CB for pgsql-committers@lists.postgresql.org; Thu, 14 Jul 2022 14:48:31 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7FAAE5C01AA; Thu, 14 Jul 2022 10:48:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 14 Jul 2022 10:48:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657810107; x=1657896507; bh=AIr+lGDDqVxYf+3D3JS5/C9HVYw4 Eb7+ltdpllc2/So=; b=0QFRa4G1i/+aAAdXg22XiMOiXPq5UIl1Z9XfZVExkRW2 D7jfFbBGQ3K9M9LKbQmQazovVx07Ai3ZNoyiR60iMJ8GNiWyj4F3tGxsPs2U7rSM LPE/ungpwGqjOPJXJMFcrmgTff6mzYmQORh2zpYZMHlsq128GKq6aDB+6RGeIKVz xMKBUcsLeSSlsLOxMUDG9H/XDO/r4/H4JEty2bI1Az6VJq0+DrDxh5T4ehxv7V+q VH572ZWCgf8x5uIEVdniWKIY3lquhoTf6zSbk+y+vQgpbLlQyj8RTX/mFuBHZaaM SLIDv/nynIy04kaR1+jc6Y+LsnLEFrsTMn4VAVa9Pg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegtkfffgggfuffhvfevfhgjsehmtd erredtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghr rdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrg htthgvrhhnpeelvefgleehteektdeihfefhfffgeegtdevgfefffelfefhhedtgfdvfeel feeigfenucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhht rhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 10:48:26 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------ufXWubABWfwjgdrAOSMjLAwb" Message-ID: <01214fad-1249-183c-2161-837d8f1c1de0@enterprisedb.com> Date: Thu, 14 Jul 2022 16:48:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines. Content-Language: en-US From: Peter Eisentraut To: Tom Lane Cc: pgsql-committers@lists.postgresql.org References: <864b47bd-6e82-2d02-070d-ae5076d8c4c1@enterprisedb.com> <2431300.1657736689@sss.pgh.pa.us> <1b09ac8a-5906-3a52-3763-44a9b2115805@enterprisedb.com> In-Reply-To: <1b09ac8a-5906-3a52-3763-44a9b2115805@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------ufXWubABWfwjgdrAOSMjLAwb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14.07.22 12:05, Peter Eisentraut wrote: > On 13.07.22 20:24, Tom Lane wrote: >> Peter Eisentraut writes: >>> What platforms did this fail on?  How can one observe the failure >>> locally? >> >> wrasse at least: >> >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17 >> >> >> I think possibly you could duplicate the problem with gcc >> by using -fkeep-inline-functions, but I've not tried. > > Confirmed, -fkeep-inline-functions will catch it.  Good to know. It seems that -fkeep-inline-functions is more demanding than what wrasse is running on. I need the attached patch to get it to build cleanly. (The first hunk undoes some parts of 2cd2569c72b8920048e35c31c9be30a6170e1410, but the others are unrelated and old.) I think this would be good to apply so that this method of checking inline functions is available in the future. --------------ufXWubABWfwjgdrAOSMjLAwb Content-Type: text/plain; charset=UTF-8; name="0001-WIP-Support-gcc-fkeep-inline-functions.patch" Content-Disposition: attachment; filename="0001-WIP-Support-gcc-fkeep-inline-functions.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZTU3ZDFkNDI0OTBhYzM3ZThiZDI3ODA0YTYxODBkZGVlMGZiZjUzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogVGh1LCAxNCBKdWwgMjAyMiAxNTo1NDo0MCArMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIFdJUDogU3VwcG9ydCBnY2MgLWZrZWVwLWlubGluZS1mdW5jdGlvbnMKCi0t LQogc3JjL2luY2x1ZGUvc3RvcmFnZS9idWZwYWdlLmggfCAyNCArKysrKysrKystLS0tLS0t LS0tLS0tLS0KIHNyYy9pbmNsdWRlL3V0aWxzL3JlbC5oICAgICAgIHwgIDIgKysKIHNyYy9p bmNsdWRlL3V0aWxzL3NuYXBtZ3IuaCAgIHwgIDIgKysKIDMgZmlsZXMgY2hhbmdlZCwgMTMg aW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1 ZGUvc3RvcmFnZS9idWZwYWdlLmggYi9zcmMvaW5jbHVkZS9zdG9yYWdlL2J1ZnBhZ2UuaApp bmRleCBmYzY3ZDM5NmI2Li42YTk0NzAyMWFjIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9z dG9yYWdlL2J1ZnBhZ2UuaAorKysgYi9zcmMvaW5jbHVkZS9zdG9yYWdlL2J1ZnBhZ2UuaApA QCAtNDY2LDYgKzQ2NiwxNSBAQCBkbyB7IFwKICNkZWZpbmUgUElWX0xPR19XQVJOSU5HCQkJ KDEgPDwgMCkKICNkZWZpbmUgUElWX1JFUE9SVF9TVEFUCQkJKDEgPDwgMSkKIAorI2RlZmlu ZSBQYWdlQWRkSXRlbShwYWdlLCBpdGVtLCBzaXplLCBvZmZzZXROdW1iZXIsIG92ZXJ3cml0 ZSwgaXNfaGVhcCkgXAorCVBhZ2VBZGRJdGVtRXh0ZW5kZWQocGFnZSwgaXRlbSwgc2l6ZSwg b2Zmc2V0TnVtYmVyLCBcCisJCQkJCQkoKG92ZXJ3cml0ZSkgPyBQQUlfT1ZFUldSSVRFIDog MCkgfCBcCisJCQkJCQkoKGlzX2hlYXApID8gUEFJX0lTX0hFQVAgOiAwKSkKKworI2RlZmlu ZSBQYWdlSXNWZXJpZmllZChwYWdlLCBibGtubykgXAorCVBhZ2VJc1ZlcmlmaWVkRXh0ZW5k ZWQocGFnZSwgYmxrbm8sIFwKKwkJCQkJCSAgIFBJVl9MT0dfV0FSTklORyB8IFBJVl9SRVBP UlRfU1RBVCkKKwogLyoKICAqIENoZWNrIHRoYXQgQkxDS1NaIGlzIGEgbXVsdGlwbGUgb2Yg c2l6ZW9mKHNpemVfdCkuICBJbgogICogUGFnZUlzVmVyaWZpZWRFeHRlbmRlZCgpLCBpdCBp cyBtdWNoIGZhc3RlciB0byBjaGVjayBpZiBhIHBhZ2UgaXMKQEAgLTQ4MCwyMSArNDg5LDYg QEAgZXh0ZXJuIHZvaWQgUGFnZUluaXQoUGFnZSBwYWdlLCBTaXplIHBhZ2VTaXplLCBTaXpl IHNwZWNpYWxTaXplKTsKIGV4dGVybiBib29sIFBhZ2VJc1ZlcmlmaWVkRXh0ZW5kZWQoUGFn ZSBwYWdlLCBCbG9ja051bWJlciBibGtubywgaW50IGZsYWdzKTsKIGV4dGVybiBPZmZzZXRO dW1iZXIgUGFnZUFkZEl0ZW1FeHRlbmRlZChQYWdlIHBhZ2UsIEl0ZW0gaXRlbSwgU2l6ZSBz aXplLAogCQkJCQkJCQkJCU9mZnNldE51bWJlciBvZmZzZXROdW1iZXIsIGludCBmbGFncyk7 Ci0KLXN0YXRpYyBpbmxpbmUgT2Zmc2V0TnVtYmVyCi1QYWdlQWRkSXRlbShQYWdlIHBhZ2Us IEl0ZW0gaXRlbSwgU2l6ZSBzaXplLCBPZmZzZXROdW1iZXIgb2Zmc2V0TnVtYmVyLCBib29s IG92ZXJ3cml0ZSwgYm9vbCBpc19oZWFwKQotewotCXJldHVybiBQYWdlQWRkSXRlbUV4dGVu ZGVkKHBhZ2UsIGl0ZW0sIHNpemUsIG9mZnNldE51bWJlciwKLQkJCQkJCQkgICAob3Zlcndy aXRlID8gUEFJX09WRVJXUklURSA6IDApIHwKLQkJCQkJCQkgICAoaXNfaGVhcCA/IFBBSV9J U19IRUFQIDogMCkpOwotfQotCi1zdGF0aWMgaW5saW5lIGJvb2wKLVBhZ2VJc1ZlcmlmaWVk KFBhZ2UgcGFnZSwgQmxvY2tOdW1iZXIgYmxrbm8pCi17Ci0JcmV0dXJuIFBhZ2VJc1Zlcmlm aWVkRXh0ZW5kZWQocGFnZSwgYmxrbm8sIFBJVl9MT0dfV0FSTklORyB8IFBJVl9SRVBPUlRf U1RBVCk7Ci19Ci0KIGV4dGVybiBQYWdlIFBhZ2VHZXRUZW1wUGFnZShQYWdlIHBhZ2UpOwog ZXh0ZXJuIFBhZ2UgUGFnZUdldFRlbXBQYWdlQ29weShQYWdlIHBhZ2UpOwogZXh0ZXJuIFBh Z2UgUGFnZUdldFRlbXBQYWdlQ29weVNwZWNpYWwoUGFnZSBwYWdlKTsKZGlmZiAtLWdpdCBh L3NyYy9pbmNsdWRlL3V0aWxzL3JlbC5oIGIvc3JjL2luY2x1ZGUvdXRpbHMvcmVsLmgKaW5k ZXggMjg1NDgzOWVjMi4uMDBiODNiODkyNCAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvdXRp bHMvcmVsLmgKKysrIGIvc3JjL2luY2x1ZGUvdXRpbHMvcmVsLmgKQEAgLTU2NCw2ICs1NjQs NyBAQCB0eXBlZGVmIHN0cnVjdCBWaWV3T3B0aW9ucwogICogZWFjaCB0aW1lIHlvdSBuZWVk IHRvIGFjY2VzcyB0aGUgU01nclJlbGF0aW9uLiAgSXQncyBxdWl0ZSBjaGVhcCBpbgogICog Y29tcGFyaXNvbiB0byB3aGF0ZXZlciBhbiBzbWdyIGZ1bmN0aW9uIGlzIGdvaW5nIHRvIGRv LgogICovCisjaWZuZGVmIEZST05URU5ECiBzdGF0aWMgaW5saW5lIFNNZ3JSZWxhdGlvbgog UmVsYXRpb25HZXRTbWdyKFJlbGF0aW9uIHJlbCkKIHsKQEAgLTU3MSw2ICs1NzIsNyBAQCBS ZWxhdGlvbkdldFNtZ3IoUmVsYXRpb24gcmVsKQogCQlzbWdyc2V0b3duZXIoJihyZWwtPnJk X3NtZ3IpLCBzbWdyb3BlbihyZWwtPnJkX2xvY2F0b3IsIHJlbC0+cmRfYmFja2VuZCkpOwog CXJldHVybiByZWwtPnJkX3NtZ3I7CiB9CisjZW5kaWYKIAogLyoKICAqIFJlbGF0aW9uQ2xv c2VTbWdyCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS91dGlscy9zbmFwbWdyLmggYi9zcmMv aW5jbHVkZS91dGlscy9zbmFwbWdyLmgKaW5kZXggNjdiMjE3YjFjMS4uMDZlYWZkZjExOCAx MDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvdXRpbHMvc25hcG1nci5oCisrKyBiL3NyYy9pbmNs dWRlL3V0aWxzL3NuYXBtZ3IuaApAQCAtOTcsMTEgKzk3LDEzIEBAIGV4dGVybiBQR0RMTElN UE9SVCBTbmFwc2hvdERhdGEgQ2F0YWxvZ1NuYXBzaG90RGF0YTsKIAkoKHNuYXBzaG90KS0+ c25hcHNob3RfdHlwZSA9PSBTTkFQU0hPVF9NVkNDIHx8IFwKIAkgKHNuYXBzaG90KS0+c25h cHNob3RfdHlwZSA9PSBTTkFQU0hPVF9ISVNUT1JJQ19NVkNDKQogCisjaWZuZGVmIEZST05U RU5ECiBzdGF0aWMgaW5saW5lIGJvb2wKIE9sZFNuYXBzaG90VGhyZXNob2xkQWN0aXZlKHZv aWQpCiB7CiAJcmV0dXJuIG9sZF9zbmFwc2hvdF90aHJlc2hvbGQgPj0gMDsKIH0KKyNlbmRp ZgogCiBleHRlcm4gU25hcHNob3QgR2V0VHJhbnNhY3Rpb25TbmFwc2hvdCh2b2lkKTsKIGV4 dGVybiBTbmFwc2hvdCBHZXRMYXRlc3RTbmFwc2hvdCh2b2lkKTsKLS0gCjIuMzcuMAoK --------------ufXWubABWfwjgdrAOSMjLAwb--