Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oygvU-0003tz-6v for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 22:12:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oygvR-0002GY-FY for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 22:12:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oygvR-0002DF-8c for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 22:12:01 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oygvN-0000eH-Dv for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 22:12:00 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 92220240004 for ; Fri, 25 Nov 2022 22:11:52 +0000 (UTC) Message-ID: <02b5e6c8-a062-94f0-1add-db1fd1db5f0b@dunslane.net> Date: Fri, 25 Nov 2022 17:11:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Allow building with MSVC and Strawberry perl Content-Language: en-US From: Andrew Dunstan To: pgsql-committers@lists.postgresql.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-11-25 Fr 15:38, Andrew Dunstan wrote: > Allow building with MSVC and Strawberry perl > > Strawberry uses __builtin_expect which Visual C doesn't have. For this > case define it as a noop. Solution taken from vim sources. Argh! drongo doesn't seem to like this. I thought I'd tested it. A little further googling suggests that instead of #define __builtin_expect(expr, val) (expr) we should probably have something like #define __builtin_expect(expr, val) ((expr) == (val)) I'll try that. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com