Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYkr7-0004ko-8J for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 08:03:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYkr5-0000tA-Up for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 08:03:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYkr5-0000t2-NG for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 08:03:47 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYkr3-0003uT-5t for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 08:03:47 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 129B02EB6E80 for ; Fri, 8 Oct 2021 10:03:44 +0200 (CEST) Received: from s645.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 024122E28919; Fri, 8 Oct 2021 10:03:44 +0200 (CEST) Received: from s474.loopia.se (unknown [172.22.191.6]) by s645.loopia.se (Postfix) with ESMTP id A6AC0157A302; Fri, 8 Oct 2021 10:03:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.5]) by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024) with UTF8LMTP id BOeThDHbIJMB; Fri, 8 Oct 2021 10:03:43 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id 159767CEBF8; Fri, 8 Oct 2021 10:03:43 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. From: Daniel Gustafsson In-Reply-To: <20211008042454.GB398563@rfd.leadboat.com> Date: Fri, 8 Oct 2021 10:03:42 +0200 Cc: Tom Lane , Postgres hackers , Craig Ringer Content-Transfer-Encoding: quoted-printable Message-Id: <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> To: Noah Misch X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 8 Oct 2021, at 06:24, Noah Misch wrote: >=20 > On Thu, Oct 07, 2021 at 11:39:11PM -0400, Tom Lane wrote: >> Noah Misch writes: >>> On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote: >>>>> (1) I'm distrustful of the idea that perl 5.8.x will compile >>>>> cleanly, or at all, on modern platforms. Certainly Postgres >>>>> releases of similar vintage won't. >>=20 >>> perlbrew uses the patchperl system to build old Perl in modern = environments. >>> This year, I used it to get 5.8.0. Building unpatched 5.8.0 does = fail. >>=20 >> Oh, cool. >>=20 >>>> I propose that what might be more useful than the existing last >>>> section of src/test/perl/README is something along the lines of: >>=20 >>> -1. This would replace a useful recipe with, essentially, a = restatement of >>> that recipe in English words. That just leaves the user to = rediscover the >>> actual recipe. >>=20 >> Well, I think the existing text does the reader a disservice >> by stating a specific recipe without any context. Notably, >> it says nothing about restricting which Perl modules you use. >=20 > That's obvious from "cpanm install IPC::Run". Surely if any other = non-core > module were allowed, the recipe would list it in a similar way. The proposed changes talks about with core modules are allowed to use, I = think that's a different thing. The distinction between core and non-core = modules may not be known/clear to people who haven't used Perl in the past. > This is a source tree README; it shouldn't try to hold the reader's = hand like > the user-facing docs do. We've not had commits add usage of other = modules, so > there's no evidence of actual doubt on this point. This README isn't primarily targeting committers though IMO, but new = developers onboarding onto postgres who are trying to learn the dev environment. >> What do you think of using my proposed text followed by >>=20 >> One way to test against an old Perl version is to use >> perlbrew. >> << more or less the existing text here >> >> Bear in mind that you will still need to install IPC::Run, >> and what you will get is a current version not the one >> distributed with Perl 5.8.3. You will also need to update >> Test::More because the version distributed with Perl 5.8.3 >> is too old to run our TAP tests. So this recipe does not create >> a perfect reproduction of a back-in-the-day Perl installation, >> but it will probably catch any problems that might surface in >> the buildfarm. >=20 > I don't see an improvement in there. I respectfully disagree, the current text reads as if 5.8.0 is required = for running the test, not that using perlbrew is a great way to verify that = your tests pass in all supported Perl versions. > If there's something to change, it's improving the actual recipe: That we should do as well. -- Daniel Gustafsson https://vmware.com/