Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUxP7-000783-N1 for pgsql-committers@arkaria.postgresql.org; Thu, 17 Mar 2022 21:11:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUxP6-00046B-AA for pgsql-committers@arkaria.postgresql.org; Thu, 17 Mar 2022 21:11:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUxP5-000462-Q1 for pgsql-committers@lists.postgresql.org; Thu, 17 Mar 2022 21:11:28 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nUxP2-0004BK-3s for pgsql-committers@lists.postgresql.org; Thu, 17 Mar 2022 21:11:26 +0000 Received: by mail-lj1-x234.google.com with SMTP id 17so8942115lji.1 for ; Thu, 17 Mar 2022 14:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=mEJdJ5jORrTYpvzA8qPeSwRk34bRMVeYlgE+nxqLu8k=; b=la/7x2gqm1WCMwEV2wEeiSO+tkX91lHwhfcsQCmJZonICdwxPZy7AyNgCwhqWfjFxP VN192HRNM8m9p0JZc/9eZDVgKU3IUo4V0OmyXL5HxRVStbPoXpmm+NDF0q4HeYZ8JoCS 4VsBoMnyzfXcstkLQAgi25hf9MdnuIXc4mTDK/4ltRoVH8QQ+JOo/ZNzN+XQKZDmkZTz TLK3SWkOw+NIILbSgEvMXK28EgX2ifR89tPDyr+Ri1H5hSOMMI7Bax7Th9rnps7JCUSC PNi5EBMn4LtifF9audVF36XCtZ7MhmHxYRYbZxXLZc9ibjd9cF3Y2EozfzZomEDXLXqY M/Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=mEJdJ5jORrTYpvzA8qPeSwRk34bRMVeYlgE+nxqLu8k=; b=q0arOIQt450sQUyxO9ixGv0mzG4P/9ctnkQ2kCYt+oqVZQyvdH9JhM+rNHo2dPqPLy eJ/pS0zHWZ36T+ZAKdm7ua+RXNumnTrUwqA9l5nCbHhAnI1j2jM+16iOdEjHE5eNDijd L7gs7V3tVnCSFutWqA5QNkrLXdSZVbsxM4YdzCEozvSelBsUXIDWbpa3bwTr68ZdP0on rvPZQHTePo/vuof2sVflWj3pc56k5/F2+AmKnYuNd5QxKwtR8n8k8taa2x/2/p/dzheh 8kwVR2eIrR+FmAkW8NPVzUDaayTfvejKTzauXEtKLt159kevikYuowv9IJddZz6sZ5Kv lgKg== X-Gm-Message-State: AOAM533d/vvXfWVKogC5IQ9Rum6yGOZPjU4xhQEG7ALYXh4QKcCYy9kE B/OChr7uq6L+CVd30ZQ6WBBzP/KXEo0koGaYJ5+ktTegVxKOT+5A5CZjdOHwghFmT3ZG3jxhity S6Qgpw6Re5snopxlREFNwb3tREcfd3sbuyai1K6njflETMEru2UyrahypInNoLjbj+3NV5PG1Dr y8lYGRLbu3Fh5PiKnAcCnF2x8ev3RETIbPhU62Un/P3k+bgqNEouo/gDVez1S1 X-Google-Smtp-Source: ABdhPJzsRyGRw4fcZSyoK7rTcFhW7tRSyzTtP6fhLs6wrRJEXkhjkt1Pt6zY6FnTvMWgTB7hsZ6n1A== X-Received: by 2002:a2e:910e:0:b0:247:e33b:cbee with SMTP id m14-20020a2e910e000000b00247e33bcbeemr4164986ljg.256.1647551481801; Thu, 17 Mar 2022 14:11:21 -0700 (PDT) Received: from [10.137.0.17] (37-247-27-82.customers.ownit.se. [37.247.27.82]) by smtp.gmail.com with ESMTPSA id o17-20020ac24351000000b004437b082fc6sm538096lfl.229.2022.03.17.14.11.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Mar 2022 14:11:21 -0700 (PDT) Message-ID: <03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com> Date: Thu, 17 Mar 2022 22:11:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: pgsql: Fix row filters with multiple publications Content-Language: en-US From: Tomas Vondra To: Tomas Vondra , pgsql-committers@lists.postgresql.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/17/22 20:15, Tomas Vondra wrote: > Hmm, this seems to have failed on wrasse [1], due to a timeout when > waiting for tablesync to complete: > > 2022-03-17 17:39:28.247 CET [19962:1] LOG: logical replication table > synchronization worker for subscription "sub2", table "tab1" has started > 2022-03-17 17:39:28.258 CET [19964:1] LOG: logical replication table > synchronization worker for subscription "sub2", table "tab4" has started > > In the previous runs this completed pretty much immediately (less than a > second), but this time the workers got stuck, so the script keeps > looping on the $synced_query. There's nothing in the log, so either it's > some sort of lock wait or infinite loop. > > However, this fails in 013_partition.sql, which was not modified in this > commit. And there have been multiple successful runs since it was > modified (in c91f71b9dc). So it's not clear if this is a pre-existing > issue and we just happened to hit it now, or maybe it's introduced by > either c91f71b9dc or 5a07966225. But neither of these commits touched > tablesync at all, so I'm puzzled how could it happen. > And sure enough - now it passed on wrasse, while lapwing failed with exactly the same symptoms. Clearly some sort of race condition, but I've been unable to reproduce that :-( I'll try on my rpi4 once I get back home next week, but maybe we could try reproducing this on one of the machines that triggered this so far. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company