Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sTGpp-00EbRh-Oc for pgsql-committers@arkaria.postgresql.org; Mon, 15 Jul 2024 08:13:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sTGpo-0091i8-El for pgsql-committers@arkaria.postgresql.org; Mon, 15 Jul 2024 08:13:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sTGpo-0091hs-70 for pgsql-committers@lists.postgresql.org; Mon, 15 Jul 2024 08:13:24 +0000 Received: from meesny.iki.fi ([195.140.195.201]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sTGpl-0028N5-AM for pgsql-committers@lists.postgresql.org; Mon, 15 Jul 2024 08:13:22 +0000 Received: from [192.168.27.196] (mobile-access-c1d2a2-203.dhcp.inet.fi [193.210.162.203]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by meesny.iki.fi (Postfix) with ESMTPSA id 4WMw1n1sQCzySG; Mon, 15 Jul 2024 11:13:17 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1721031197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/HlI+vQsb6oIu116ujH8Jjt+HcJZJ/uJ25zRQwKb/fE=; b=szbN0wPrXWFMA8NchbZBkaQdRaRBOukE1dKn07oqugGHJvmobZA1YW5Z0VDSTrkBMJFDWd YhGFk72GMnFtB+UW5LO5bdschzxE3Vj1ItvnlL+m/chwGneJLsD145UlfByDI0x0a76Oyr p2tZrWgw8TCCb5AuUjic+4eurs5cg3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1721031197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/HlI+vQsb6oIu116ujH8Jjt+HcJZJ/uJ25zRQwKb/fE=; b=W8K2JwlqzEPghHavR9e9nMuCY5IkrnEMQgtlrUUQVdqwSknAQtVRcgqG/MH0ZJiGo4QZf/ Jvl3l30i/fTuiZlR5RenAzqNO1Na3RrF4ivoU2JKMNY00NjOPmx966p99ZiwvuGwK7cJXO bxWd+MEh54927rWjOnphVWO9ZSwuD2o= ARC-Seal: i=1; s=meesny; d=iki.fi; t=1721031197; a=rsa-sha256; cv=none; b=QyL3QJ60z4S17Bx05aaj84Qg5TYzBvrjZuIkS5LDL8eB61e1AF9/s38XXPPz9LTMKWhX// ztsmEG3jvqOttXJx/jZP9cWiCX7gFdw1RhswSC6zQGZWOTnS5uDE8LFv6mXJZREEZK1RWc yokxi7eofIvL4KwsIYj5ztPtq0SNHfM= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi Message-ID: <03d4d128-c27d-4b78-b0c1-24a405a60bd2@iki.fi> Date: Mon, 15 Jul 2024 11:13:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Replace BackendIds with 0-based ProcNumbers To: Thomas Munro , Heikki Linnakangas Cc: pgsql-committers@lists.postgresql.org References: Content-Language: en-US From: Heikki Linnakangas In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 09/07/2024 21:10, Thomas Munro wrote: > --- a/src/backend/libpq/pqmq.c > +++ b/src/backend/libpq/pqmq.c > @@ -26,7 +26,7 @@ > static shm_mq_handle *pq_mq_handle; > static bool pq_mq_busy = false; > static pid_t pq_mq_parallel_leader_pid = 0; > -static pid_t pq_mq_parallel_leader_backend_id = InvalidBackendId; > +static pid_t pq_mq_parallel_leader_proc_number = INVALID_PROC_NUMBER; > > I guess it was a historical mistake that this variable of type pid_t > instead of BackendId, but now it should be ProcNumber? Yep, fixed thanks! -- Heikki Linnakangas Neon (https://neon.tech)