Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if
 TRUNCATE overlaps a checkpoint.]
From: Petr Jelinek <petr.jelinek@enterprisedb.com>
In-Reply-To: 
 <CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
Date: Thu, 7 Apr 2022 20:07:17 +0200
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Markus Wanner <markus.wanner@enterprisedb.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <051E2C40-14DF-4AE4-9273-A9A42CDAB5C2@enterprisedb.com>
References: <E1nXTCX-001DGF-R0@gemulon.postgresql.org>
 <a7880f4d-1d74-582a-ada7-dad168d046d1@enterprisedb.com>
 <CA+TgmoaVwQj_nG-jPB8O=t8=h-QBoF2U+tKviv8BT8unfTEZiw@mail.gmail.com>
 <2358496.1649168259@sss.pgh.pa.us>
 <CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/051E2C40-14DF-4AE4-9273-A9A42CDAB5C2%40enterprisedb.com>
Precedence: bulk


> On 7. 4. 2022, at 17:19, Robert Haas <robertmhaas@gmail.com> wrote:
>=20
> On Tue, Apr 5, 2022 at 10:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What I think you need to do is:
>>=20
>> 1. In the back branches, revert delayChkpt to its previous type and
>> semantics.  Squeeze a separate delayChkptEnd bool in somewhere
>> (you can't change the struct size either ...).
>>=20
>> 2. In HEAD, rename the field to something like delayChkptFlags,
>> to ensure that any code touching it has to be inspected and updated.
>=20
> Here are patches for master and v14 to do things this way. Comments?


Yeah I think this should do it (compilers should warn on master even =
without the rename, but who notices that right? :) )

Thanks,
Petr