Feedback-ID: ie0a040ee:Fastmail
Message-ID: <0755ae22-4e04-4c69-b344-8c4db54d6e23@eisentraut.org>
Date: Wed, 30 Apr 2025 14:44:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Add missing string terminator
To: David Rowley <dgrowleyml@gmail.com>, Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org
References: <E1uA3rI-000Ibx-19@gemulon.postgresql.org>
 <CAApHDvrg3Gz6kF76Feyc6Dyi9u7iS+vcdQw3VZgGA1+wUc=wRQ@mail.gmail.com>
 <9887D3A8-A74F-4836-BC57-74AC4AE901BB@yesql.se>
 <CAApHDvrEJeCPesmpeS24UAU8vanq9vKYZC6m1kTDFkxQQ2qTiw@mail.gmail.com>
 <CAApHDvoRKSrujq5FN8WzncVtTpVL2c_LMs-o=8fjdmqce1pmjQ@mail.gmail.com>
Content-Language: de-DE, en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAApHDvoRKSrujq5FN8WzncVtTpVL2c_LMs-o=8fjdmqce1pmjQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/0755ae22-4e04-4c69-b344-8c4db54d6e23%40eisentraut.org>
Precedence: bulk

On 30.04.25 13:56, David Rowley wrote:
> On Wed, 30 Apr 2025 at 23:43, David Rowley <dgrowleyml@gmail.com> wrote:
>> memcpy() would make more sense IMO, since the length is
>> known already. I'm fine with either, however.
> 
> In case you're looking for inspiration on a standard to follow,
> commits such as 586dd5d6a did seem to favour memcpy() when the length
> was known and only use strlcpy() when it wasn't.

It looks like the memcpy() uses in that commit are for cases where we 
don't want/need the null terminator.

I think it's best in general to use str* for strings and mem* for 
not-strings.  That's easier to read and also better for static analyzers 
etc.