pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Further cleanup of autoconf output files for GSSAPI changes.
7+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2023-04-17 38358aab9a  Update Solution.pm for HAVE_GSSAPI[_GSSAPI]_EXT_H, too.
* pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-17 15:22  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 7+ messages in thread

From: Tom Lane @ 2023-04-17 15:22 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further cleanup of autoconf output files for GSSAPI changes.

Running autoheader was missed in f7431bca8.  This is cosmetic since
we aren't using these HAVE_ symbols, but let's get everything in
sync while we're looking at this.

Discussion: https://postgr.es/m/2422362.1681741814@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d48ac0070cff197125088959e5644ed051322f5e

Modified Files
--------------
src/include/pg_config.h.in | 6 ++++++
1 file changed, 6 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-17 18:57  Andrew Dunstan <andrew@dunslane.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 7+ messages in thread

From: Andrew Dunstan @ 2023-04-17 18:57 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers@lists.postgresql.org


On 2023-04-17 Mo 11:22, Tom Lane wrote:
> Further cleanup of autoconf output files for GSSAPI changes.
>
> Running autoheader was missed in f7431bca8.  This is cosmetic since
> we aren't using these HAVE_ symbols, but let's get everything in
> sync while we're looking at this.
>
> Discussion:https://postgr.es/m/2422362.1681741814@sss.pgh.pa.us
>

I think this also needs a fix in src/tools/msvc/Solution.pm, see 
<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2023-04-17%2016%3A30%3A03;


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-17 19:53  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 1 reply; 7+ messages in thread

From: Tom Lane @ 2023-04-17 19:53 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers@lists.postgresql.org

Andrew Dunstan <andrew@dunslane.net> writes:
> I think this also needs a fix in src/tools/msvc/Solution.pm, see 
> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2023-04-17%2016%3A30%3A03;

Argh, forgot about that.  Will fix.

(This three-build-system business can't go away soon enough.)

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-17 20:22  Andrew Dunstan <andrew@dunslane.net>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 2 replies; 7+ messages in thread

From: Andrew Dunstan @ 2023-04-17 20:22 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org


On 2023-04-17 Mo 15:53, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> I think this also needs a fix in src/tools/msvc/Solution.pm, see
>> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2023-04-17%2016%3A30%3A03;
> Argh, forgot about that.  Will fix.
>
> (This three-build-system business can't go away soon enough.)
>
> 			


 From my POV we can remove it any time - I am still having Windows 
issues with meson, but only with MSYS2. The MSVC meson build on drongo 
is perfectly well behaved.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-17 20:25  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Andrew Dunstan <andrew@dunslane.net>
  1 sibling, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-04-17 20:25 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers@lists.postgresql.org

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-04-17 Mo 15:53, Tom Lane wrote:
>> (This three-build-system business can't go away soon enough.)

>  From my POV we can remove it any time - I am still having Windows 
> issues with meson, but only with MSYS2. The MSVC meson build on drongo 
> is perfectly well behaved.

I think the outcome of the discussion a week or so ago was that
we want the MSVC scripts in v16, but we can nuke them from HEAD
as soon as the branch is made.

autoconf unfortunately will have to live a good bit longer ...
I don't think we're anywhere near the point where the meson
system is mature enough to drop that.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-20 15:06  Andres Freund <andres@anarazel.de>
  parent: Andrew Dunstan <andrew@dunslane.net>
  1 sibling, 1 reply; 7+ messages in thread

From: Andres Freund @ 2023-04-20 15:06 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers@lists.postgresql.org

On 2023-04-17 16:22:30 -0400, Andrew Dunstan wrote:
> I am still having Windows issues with meson, but only with MSYS2.

Any more details on that? I might be able to help out / improve things.





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.
@ 2023-04-20 19:37  Andrew Dunstan <andrew@dunslane.net>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 7+ messages in thread

From: Andrew Dunstan @ 2023-04-20 19:37 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers@lists.postgresql.org


On 2023-04-20 Th 11:06, Andres Freund wrote:
> On 2023-04-17 16:22:30 -0400, Andrew Dunstan wrote:
>> I am still having Windows issues with meson, but only with MSYS2.
> Any more details on that? I might be able to help out / improve things.


For some reason which makes no sense to me the buildfarm animal fails at 
the first Stop-Db step. The DB is actually stopped, but pg_ctl returns a 
non-zero status. The thing that's really odd is that meson isn't at all 
involved in this step. But it's happened enough that I've had to back 
off using meson builds on fairywren - I'm going to do more testing on a 
new Windows instance.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2023-04-20 19:37 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-04-17 15:22 pgsql: Further cleanup of autoconf output files for GSSAPI changes. Tom Lane <tgl@sss.pgh.pa.us>
2023-04-17 18:57 ` Andrew Dunstan <andrew@dunslane.net>
2023-04-17 19:53   ` Tom Lane <tgl@sss.pgh.pa.us>
2023-04-17 20:22     ` Andrew Dunstan <andrew@dunslane.net>
2023-04-17 20:25       ` Tom Lane <tgl@sss.pgh.pa.us>
2023-04-20 15:06       ` Andres Freund <andres@anarazel.de>
2023-04-20 19:37         ` Andrew Dunstan <andrew@dunslane.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox