Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzGQF-00055F-Sf for pgsql-committers@arkaria.postgresql.org; Wed, 17 May 2023 12:38:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pzGQE-0007fq-Ly for pgsql-committers@arkaria.postgresql.org; Wed, 17 May 2023 12:38:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzGQE-0007fg-By for pgsql-committers@lists.postgresql.org; Wed, 17 May 2023 12:38:26 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pzGQA-000JAo-Sg for pgsql-committers@lists.postgresql.org; Wed, 17 May 2023 12:38:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=References:To:Cc:In-Reply-To:Date:Subject: Mime-Version:Content-Type:Message-Id:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fF3XOKhLYC/fFNtTO7HJJMUF2/YMqjOSnbizxaThYR0=; b=sY0YEV0IOYs6Vjl7m/KyQL0RVs 04s0cbEdGQ7ow8bu8RYWbLNKp3S+WK1A2tY+dRsY0zv6IfTbOtyTrefVfTyvRWMKlA/sBt35Snanq B6SrteGDtbclnq6aYu9ykMdQC0mRiMgKCBbatNEZuql5amOQsmj+CK9rMMjeTSiegwEVAWsXGGKO1 WIGlrwJLaoV345nJ3paY2FxAe/02THAsDOk44pqal216JO1QdnXM+ZaZuNgoPU1fKSUMYjE8MBULU A69zv6y4K00+i82yhPfgsVsdLdORDkCma6nEL7Ru+I+v7qULZSi4KLzZ60i2vdhhnHCLT/Cyw50HU 9qpAZNag==; Received: from customer-89-255-232-193.stosn.net ([89.255.232.193] helo=smtpclient.apple) by meldrar.postgresql.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pzGQ5-000jda-51; Wed, 17 May 2023 12:38:19 +0000 From: Daniel Gustafsson Message-Id: <0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_EA700C35-A2B2-4F84-8C1A-B0A98A418C3C" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: pgsql: Refactor background psql TAP functions Date: Wed, 17 May 2023 14:38:15 +0200 In-Reply-To: <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org> Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org To: Tom Lane , Damir Belyalov References: <34800305-E1E6-4194-8738-9977946DB12A@postgresql.org> <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org> X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_EA700C35-A2B2-4F84-8C1A-B0A98A418C3C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 16 May 2023, at 21:43, Daniel Gustafsson = wrote: >=20 >> On 16 May 2023, at 21:04, Damir Belyalov wrote: >=20 >> There is another perl module: AdjustUpgrade.pm that is not in = Makefile. Do we need it? >=20 > Yes, I think it should be installed too and skimming the linked thread = I see no > mention of the omission being deliberate. I will take care of it. The attached is the proposed fix, which will have to be backpatched to = v11 to match the original commit. Unless there are reasons to treat this = module differently from the others wrt installation I'll go ahead and fix it in = time for beta1. -- Daniel Gustafsson --Apple-Mail=_EA700C35-A2B2-4F84-8C1A-B0A98A418C3C Content-Disposition: attachment; filename=v1-0001-Add-installation-rules-for-AdjustUpgrade-test-mod.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v1-0001-Add-installation-rules-for-AdjustUpgrade-test-mod.patch" Content-Transfer-Encoding: quoted-printable =46rom=20118aa36deefbac4cf54871fa9be0f2e54f67e74f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20= =0ADate:=20Wed,=2017=20May=202023=2014:29:49=20= +0200=0ASubject:=20[PATCH=20v1]=20Add=20installation=20rules=20for=20= AdjustUpgrade=20test=20module=0A=0ACommit=2052585f8f07=20introduced=20a=20= new=20Perl=20test=20module=20but=20didn't=20add=0Ait=20as=20an=20= installation=20target=20like=20the=20other=20modules=20are.=0A=0A= Backpatch=20into=20all=20supported=20versions.=0A=0AReported-by:=20Damir=20= Belyalov=20=0ADiscussion:=20= https://postgr.es/m/CALH1Lgui397s_4AXWm1ZO_uCLOUVL1HAa0TO9CbdMy1kvokkzA@ma= il.gmail.com=0ABackpatch-through:=20v11=0A---=0A=20= src/test/perl/Makefile=20=20=20=20|=202=20++=0A=20= src/test/perl/meson.build=20|=201=20+=0A=202=20files=20changed,=203=20= insertions(+)=0A=0Adiff=20--git=20a/src/test/perl/Makefile=20= b/src/test/perl/Makefile=0Aindex=20435b45a6cc..716bec76be=20100644=0A---=20= a/src/test/perl/Makefile=0A+++=20b/src/test/perl/Makefile=0A@@=20-24,6=20= +24,7=20@@=20install:=20all=20installdirs=0A=20=09$(INSTALL_DATA)=20= $(srcdir)/PostgreSQL/Test/RecursiveCopy.pm=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm'=0A=20=09= $(INSTALL_DATA)=20$(srcdir)/PostgreSQL/Test/Cluster.pm=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'=0A=20=09= $(INSTALL_DATA)=20$(srcdir)/PostgreSQL/Test/BackgroundPsql.pm=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'=0A+=09= $(INSTALL_DATA)=20$(srcdir)/PostgreSQL/Test/AdjustUpgrade.pm=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'=0A=20=09= $(INSTALL_DATA)=20$(srcdir)/PostgreSQL/Version.pm=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'=0A=20=0A=20= uninstall:=0A@@=20-32,6=20+33,7=20@@=20uninstall:=0A=20=09rm=20-f=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm'=0A=20=09= rm=20-f=20'$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'=0A=20= =09rm=20-f=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'=0A+=09= rm=20-f=20= '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'=0A=20=09= rm=20-f=20'$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'=0A=20=0A= =20endif=0Adiff=20--git=20a/src/test/perl/meson.build=20= b/src/test/perl/meson.build=0Aindex=20101e8a2b8f..041e892029=20100644=0A= ---=20a/src/test/perl/meson.build=0A+++=20b/src/test/perl/meson.build=0A= @@=20-12,4=20+12,5=20@@=20install_data(=0A=20=20=20= 'PostgreSQL/Test/RecursiveCopy.pm',=0A=20=20=20= 'PostgreSQL/Test/Cluster.pm',=0A=20=20=20= 'PostgreSQL/Test/BackgroundPsql.pm',=0A+=20=20= 'PostgreSQL/Test/AdjustUpgrade.pm',=0A=20=20=20install_dir:=20dir_pgxs=20= /=20'src/test/perl/PostgreSQL/Test')=0A--=20=0A2.32.1=20(Apple=20= Git-133)=0A=0A= --Apple-Mail=_EA700C35-A2B2-4F84-8C1A-B0A98A418C3C--