Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: pgsql: Remove the adminpack contrib extension
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <E1rh6j5-0021w3-GX@gemulon.postgresql.org>
Date: Mon, 4 Mar 2024 14:01:03 +0100
Cc: pgsql-committers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0CFB76D0-0510-48B2-9916-1199F93BC28C@yesql.se>
References: <E1rh6j5-0021w3-GX@gemulon.postgresql.org>
To: Daniel Gustafsson <dgustafsson@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/0CFB76D0-0510-48B2-9916-1199F93BC28C%40yesql.se>
Precedence: bulk

> On 4 Mar 2024, at 12:43, Daniel Gustafsson =
<dgustafsson@postgresql.org> wrote:
>=20
> Remove the adminpack contrib extension

The pg_upgrade Xversion test on crake failed on this, I'm trying to =
reproduce
the cross-version test locally to verify the below diff but it's right =
now
failing on an unrelated thing.  If anyone has a working setup locally to =
test I
would love the below taken for a spin against something in 16->12.

diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm =
b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
index c0da0aaff8..8dc1a65e3d 100644
--- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
+++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
@@ -106,6 +106,16 @@ sub adjust_database_contents
 			'drop extension if exists test_ext7');
 	}
=20
+	# we removed the adminpack extension in v17
+	if ($old_version >=3D 12 && $old_version < 17)
+	{
+		_add_st($result, 'regression',
+			'drop extension if exists adminpack');
+		_add_st($result, 'postgres',
+			'drop database contrib_regression_adminpack');
+		delete($dbnames{'contrib_regression_adminpack'});
+	}
+
 	# we removed this test-support function in v17
 	if ($old_version >=3D 15 && $old_version < 17)
 	{

--
Daniel Gustafsson