Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJvRi-008Mtd-0h for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 15:10:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vJvRf-006uhm-1s for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 15:10:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJvRf-006uhd-0t for pgsql-hackers@lists.postgresql.org; Fri, 14 Nov 2025 15:10:39 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vJvRc-007jri-26 for pgsql-hackers@lists.postgresql.org; Fri, 14 Nov 2025 15:10:38 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-477563e28a3so14413785e9.1 for ; Fri, 14 Nov 2025 07:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763133035; x=1763737835; darn=lists.postgresql.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/fJWKTe5SDpZpLsF8eWcnJktK3gJlwaZBFkVjVZUoPQ=; b=fwRyjHYNOR+2QsB4B327sM5JBnHCDUeEfBSqu8qD/YbtHAQ5bEtAq7XxDICWCbK1xA mRRta5OA08tixigmNUezmBhhjnuVTNDEIHMgHT/R4R+ecLz8c0Z9exVRMbJ0Kjk8WhMU G+GEa1TAb1MbpF8gZq6uHK3tLF5oblLEg4Wkvo9su5cGfaESXssEVTUHxa/7Ido+qpBj TGN37FEaeRiQJb4oFPl9RkOLm3LAj04tDM0w1JCacbfGMal+DQfnZ6gcl20YtiU/LVN3 E19eAFV46Um/BVNI81YSe63ZT7lSanWbYc3bZQTCG2NHksxYbicex8WA5UNibiD8LsxM lcPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763133035; x=1763737835; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/fJWKTe5SDpZpLsF8eWcnJktK3gJlwaZBFkVjVZUoPQ=; b=SzZW+lHeRZsTnBOJekn8Zt1weUIvmBak1fEe6BPScGX++Sv7IP9ooHnRfOuLe5YBWo cZgsRn/LDKvhkP1NdHBJeNANcnb5vwn255fYOWkoyzq5KLrf9H5nOMTBjZZ2Fg5wOZvb BNhND2WS9qu3AlmBDVg6ENrB8rTJMwNjALzghSMZz8EyA5AzbZFZotXk5a5/rCBOaLQX QBr5hur6/KKwzO7a545V3kRUmKtIfY4CuYlUqFqsKptuG2/upKmZoOR6wMEA3AsTcUTz 87zTBgGKBife588zj29wy72YEpcdtodBUpdyYY9wrlxDUhpfnSAv+qDs3ytlJyHDWvf8 O7XQ== X-Forwarded-Encrypted: i=1; AJvYcCUbo2CXmRHMLVbM5Xc1hFCgm1MFL+2V/FjT/h5oEKW1zvROVHAxeemrXF2Iulj5i+iQMaR2P5hgvj8xwXjc@lists.postgresql.org X-Gm-Message-State: AOJu0YzoBQkKoayFdzCmUPvQjqRrZTOmDJGioL7jZTOLk1jnfqdFK0RS B/3prClaOirbgIddbGEg0BMboE9j8KgGYt2+q4eUBZQlcAZ6WCQmzqMO X-Gm-Gg: ASbGncva5h9b+HW6W+fdRdKXhu1qZvhjAVINsU+aSybO95yoyGl39QEOh3DojvwGC4u +VfhrZleDAYwhyNEKDnADApQMiYEt+mgy1B0buFZ/yIxYNd7sVPbCAt+y6Ozo20g/WjSyHw8N/N Qm7EubLtETTk18YQiJWlg9YWl0FuZMqGU7FwHpMLsz6oq2LhYdRq3C51OySRu5sVvZznMNhUD6A uBSjNpc9H3wBGKN1pKF30KL0ICW40vgyW+OqG0fu8HHxvu3ypFWF4xjG8S+LJmg+IH9PrNaUK57 RfB9Tl/8r3g8f2ap90/+GQXbBIYHKwCiVqynTeYxGy0mEmdKmQNrWGcVoDwx4V0iDBjEiJoI/78 SiF14Kz6mYg4znIHwUlfb+jW7vSeGcVwo4i4P/sjSRTo1yLecNxVW82TaUhLdEUpdo9iaunD6PD od8ELhkHSBqLwEbaOwBaKAA8ukb179H87+mQeC1AgkQVtWULAWcQlV6s/dcuxMBMmhIfYwT9bKr otIRdNN4yFrzfqC1ff5FNgzYIJV X-Google-Smtp-Source: AGHT+IF7SvmOrqp+02Ior/yTzreqRs1umpiPdcEpQtYtpWRZ4gqXNjqdGGvlPamhxYaulyYtewxM1Q== X-Received: by 2002:a05:600c:15c2:b0:477:e8c:923a with SMTP id 5b1f17b1804b1-4778be33cfdmr46621185e9.8.1763133034754; Fri, 14 Nov 2025 07:10:34 -0800 (PST) Received: from [192.168.4.121] (host-92-25-165-171.as13285.net. [92.25.165.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e43c2fsm146845905e9.6.2025.11.14.07.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 07:10:33 -0800 (PST) Content-Type: multipart/mixed; boundary="------------75hEG0tr1qrhbGHyQbmcJEsS" Message-ID: <0a666d28-9080-4239-90d6-f6345bb43468@gmail.com> Date: Fri, 14 Nov 2025 15:10:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Drop unnamed portal immediately after execution to completion Content-Language: en-GB To: Michael Paquier Cc: Sami Imseih , Robert Haas , Tom Lane , =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Yhuel?= , PostgreSQL Hackers References: <1982325.1762810082@sss.pgh.pa.us> <00d71a54-2118-4b18-87e8-33f4a99dc624@gmail.com> From: Mircea Cadariu In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------75hEG0tr1qrhbGHyQbmcJEsS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, I think I found a gap in the tests we added previously for documenting the current behaviour. See attached patch for your consideration. What's interesting about the holdable cursors scenario is that as far as I can tell the temp files are cleaned up during PersistHoldablePortal instead of PortalDrop. Kind regards, Mircea Cadariu --------------75hEG0tr1qrhbGHyQbmcJEsS Content-Type: text/plain; charset=UTF-8; name="v1-0001-add-holdable-cursors-test.patch" Content-Disposition: attachment; filename="v1-0001-add-holdable-cursors-test.patch" Content-Transfer-Encoding: base64 RnJvbSBhODFmMjMxMmI4OTU1ODI0NzVhNzMzZmFlNDk3NTk0ZGYyNzI3ZGZhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaXJjZWEgQ2FkYXJpdSA8Y2FkYXJpdS5taXJjZWFA Z21haWwuY29tPgpEYXRlOiBGcmksIDE0IE5vdiAyMDI1IDE0OjQ2OjQzICswMDAwClN1Ympl Y3Q6IFtQQVRDSCB2MV0gYWRkIGhvbGRhYmxlIGN1cnNvcnMgdGVzdAoKLS0tCiAuLi4vbW9k dWxlcy90ZXN0X21pc2MvdC8wMDlfbG9nX3RlbXBfZmlsZXMucGwgICB8IDE3ICsrKysrKysr KysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3QvMDA5X2xv Z190ZW1wX2ZpbGVzLnBsIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMDlfbG9n X3RlbXBfZmlsZXMucGwKaW5kZXggNDYyYTk0OWU0MS4uNWNhYzhmMDEyMiAxMDA2NDQKLS0t IGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMDlfbG9nX3RlbXBfZmlsZXMucGwK KysrIGIvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMDlfbG9nX3RlbXBfZmlsZXMu cGwKQEAgLTEyMywxMiArMTIzLDI3IEBAIG9rKCAkbm9kZS0+bG9nX2NvbnRhaW5zKAogCQkk bG9nX29mZnNldCksCiAJImN1cnNvciIpOwogCitub3RlICJob2xkYWJsZSBjdXJzb3I6IHRl bXBvcmFyeSBmaWxlIGRyb3BwZWQgZHVyaW5nIENPTU1JVCI7CiskbG9nX29mZnNldCA9IC1z ICRub2RlLT5sb2dmaWxlOworJG5vZGUtPnNhZmVfcHNxbCgKKwkicG9zdGdyZXMiLCBxcXsK K0JFR0lOOworREVDTEFSRSBob2xkY3VyIENVUlNPUiBXSVRIIEhPTEQgRk9SIFNFTEVDVCBh IEZST00gZm9vIE9SREVSIEJZIGEgT0ZGU0VUIDQ5OTY7CitGRVRDSCAxMCBGUk9NIGhvbGRj dXI7CitDT01NSVQ7CitDTE9TRSBob2xkY3VyOworfSk7CitvayggJG5vZGUtPmxvZ19jb250 YWlucygKKwkJcXIvTE9HOlxzK3RlbXBvcmFyeSBmaWxlOiBwYXRoLipcbi4qXCBTVEFURU1F TlQ6XHMrQ09NTUlUOy9zLAorCQkkbG9nX29mZnNldCksCisJImhvbGRhYmxlIGN1cnNvciIp OworCiBub3RlICJwcmVwYXJlL2V4ZWN1dGU6IHRlbXBvcmFyeSBmaWxlIGRyb3BwZWQgdW5k ZXIgRVhFQ1VURSI7CiAkbG9nX29mZnNldCA9IC1zICRub2RlLT5sb2dmaWxlOwogJG5vZGUt PnNhZmVfcHNxbCgKIAkicG9zdGdyZXMiLCBxcXsKIEJFR0lOOwotUFJFUEFSRSBwMSBBUyBT RUxFQ1QgYSBGUk9NIGZvbyBPUkRFUiBCWSBhIE9GRlNFVCA0OTk2OworUFJFUEFSRSBwMSBB UyBTRUxFQ1QgYSBGUk9NIGZvbyBPUkRFUiBCWSBhIE9GRlNFVCA0OTk3OwogRVhFQ1VURSBw MTsKIERFQUxMT0NBVEUgcDE7CiBFTkQ7Ci0tIAoyLjM5LjUgKEFwcGxlIEdpdC0xNTQpCgo= --------------75hEG0tr1qrhbGHyQbmcJEsS--