Message-ID: <0aac5d44-0063-458d-8792-e9bbbc37fe72@iki.fi>
Date: Thu, 12 Feb 2026 19:42:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Tomas Vondra <tomas@vondra.me>, Christoph Berg <myon@debian.org>,
 Andres Freund <andres@anarazel.de>,
 Tomas Vondra <tomas.vondra@postgresql.org>,
 pgsql-hackers@lists.postgresql.org
References: <21cc7a48-99d9-4f69-9a3f-2c2de61ac8e5@iki.fi>
 <202602121635.kdy5xdbvxaqi@alvherre.pgsql>
 <aY4MpVrK++9oXvti@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <aY4MpVrK++9oXvti@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/0aac5d44-0063-458d-8792-e9bbbc37fe72%40iki.fi>
Precedence: bulk

On 12/02/2026 19:23, Bertrand Drouvot wrote:
> Hi,
> 
> On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote:
>> On 2026-Feb-12, Heikki Linnakangas wrote:
>>
>>> I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into
>>> pg_numa_query_pages) made the function unusable in frontend programs,
>>> because CHECK_FOR_INTERRUPTS is server only.
> 
> Good catch! Out of curiosity how did you find the issue? Were you building a
> client tool making used of pg_numa_query_pages()?

I was working on my "interrupts vs signals" patch, which needed to 
change some #includes in pg_numa.c, when I spotted that it already had 
that issue.

>> It's not used in frontend
>>> programs today, but it was placed in src/port/ with the idea that it could
>>> be.
>>
>> Your patch LGTM.
> 
> +1

Pushed, thanks!

- Heikki