Message-ID: <0c6fa66f2753217d2a40480a96bd2ccf023536a1.camel@j-davis.com>
Subject: Re: pgsql: Add standard collation UNICODE
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Peter Eisentraut
	 <peter@eisentraut.org>, pgsql-committers@lists.postgresql.org
Date: Mon, 13 Mar 2023 12:40:28 -0700
In-Reply-To: <1253026.1678567661@sss.pgh.pa.us>
References: <E1pac4x-002qVH-Ce@gemulon.postgresql.org>
	 <582e43d0a814e09c62ea662dd851f43bfc137a16.camel@j-davis.com>
	 <c05d7d71-e869-f6ae-b83c-2d5cab0a0dc4@dunslane.net>
	 <231acf388c37597a9f0f8a3af9a899df99c28e1d.camel@j-davis.com>
	 <1253026.1678567661@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/0c6fa66f2753217d2a40480a96bd2ccf023536a1.camel%40j-davis.com>
Precedence: bulk

On Sat, 2023-03-11 at 15:47 -0500, Tom Lane wrote:
> In general, I see no good reason for our regression tests to be
> making
> assumptions about exactly how ICU's root locale behaves, so I'd
> suggest
> just lobotomizing this test case so it doesn't depend on upper/lower
> sort order.

[ Looks like Peter already found the answer, but I had some additional
commentary so I'll send this anyway. ]

Mystery solved: "und" was not a valid spelling of "root" until version
55. So it fell back to the default locale, which is sensitive to the
environment.

With this in mind, I think we should take the opposite lesson and keep
this test as-is. We don't have to promise the behavior in the docs, but
it did catch a real issue. In fact, it caught a dangerous issue,
because a change to lc_messages could cause a corrupt index.

I'd like to see if there's a way to reliably detect that a fallback to
the environment-sensitive default locale has happened, and throw an
error. I don't think that happens in versions 55 and later, but it
would be nice to have a test because earlier versions of ICU seem
dangerous to me.

Regards,
	Jeff Davis